190221 2018-10-02 15:20:52 -0700 Web Automation: tab default key handler should always cycle focus when page is controlled by automation 2018-10-02 16:55:47 -0700 1 1 1 Unclassified WebKit UI Events WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg cdumez joepeck rniwa thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1465775 0 bburg 2018-10-02 15:20:52 -0700 . 1465776 1 bburg 2018-10-02 15:21:04 -0700 <rdar://problem/44914534> 1465777 2 351445 bburg 2018-10-02 15:26:09 -0700 Created attachment 351445 Patch 1465788 3 351445 joepeck 2018-10-02 15:38:52 -0700 Comment on attachment 351445 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351445&action=review r=me > Source/WebCore/ChangeLog:15 > + Always cycle focus if the page is controlled by automation. If the chrome takes > + focus, then the first responder will be something other than the WebView, which > + causes subsequent WebDriver commands to hang. Hmm, this is interesting and makes sense but doesn't that mean that the test might differ from a real user behavior on the page? 1465793 4 bburg 2018-10-02 15:50:30 -0700 (In reply to Joseph Pecoraro from comment #3) > Comment on attachment 351445 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=351445&action=review > > r=me > > > Source/WebCore/ChangeLog:15 > > + Always cycle focus if the page is controlled by automation. If the chrome takes > > + focus, then the first responder will be something other than the WebView, which > > + causes subsequent WebDriver commands to hang. > > Hmm, this is interesting and makes sense but doesn't that mean that the test > might differ from a real user behavior on the page? Yes, it does, though I don't know that wraparound is in anyway specified by a standard. There are many other differences between WebDriver and normal UA behavior, the largest being how alerts are handled. 1465828 5 bburg 2018-10-02 16:55:47 -0700 Committed r236774: <https://trac.webkit.org/changeset/236774> 351445 2018-10-02 15:26:09 -0700 2018-10-02 15:38:52 -0700 Patch bug-190221-20181002152608.patch text/plain 1955 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDU0MDBkYWMyYzVhMzgx ZTkzMGYzZDZjYWUxMWMzYmM2MTA2YzYyNS4uNjM4MGQ1MjBlNzY1ZjZmYWUzZjc1ZWM0Zjc1YmI0 NmU5ODg1NmUyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTEwLTAyICBCcmlh biBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBBdXRvbWF0aW9uOiB0YWIg ZGVmYXVsdCBrZXkgaGFuZGxlciBzaG91bGQgYWx3YXlzIGN5Y2xlIGZvY3VzIHdoZW4gcGFnZSBp cyBjb250cm9sbGVkIGJ5IGF1dG9tYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5MDIyMQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDQ5MTQ1 MzQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhp cyBjaGFuZ2UgcHJvZ3Jlc3NlcyBXUFQgV2ViRHJpdmVyIHRlc3Qgc3BlY2lhbF9rZXlzLnB5Ojp0 ZXN0X3dlYmRyaXZlcl9zcGVjaWFsX2tleV9zZW5kc19rZXlkb3duW1RBQi1leHBlY3RlZDI0XS4K KworICAgICAgICAqIHBhZ2UvRm9jdXNDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkZvY3VzQ29udHJvbGxlcjo6YWR2YW5jZUZvY3VzSW5Eb2N1bWVudE9yZGVyKToKKyAgICAgICAg QWx3YXlzIGN5Y2xlIGZvY3VzIGlmIHRoZSBwYWdlIGlzIGNvbnRyb2xsZWQgYnkgYXV0b21hdGlv bi4gSWYgdGhlIGNocm9tZSB0YWtlcworICAgICAgICBmb2N1cywgdGhlbiB0aGUgZmlyc3QgcmVz cG9uZGVyIHdpbGwgYmUgc29tZXRoaW5nIG90aGVyIHRoYW4gdGhlIFdlYlZpZXcsIHdoaWNoCisg ICAgICAgIGNhdXNlcyBzdWJzZXF1ZW50IFdlYkRyaXZlciBjb21tYW5kcyB0byBoYW5nLgorCiAy MDE4LTEwLTAxICBSb2IgQnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CiAKICAgICAgICAgQWxpZ24g WE1MSHR0cFJlcXVlc3QncyBvdmVycmlkZU1pbWVUeXBlKCkgd2l0aCB0aGUgc3RhbmRhcmQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRm9jdXNDb250cm9sbGVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRm9jdXNDb250cm9sbGVyLmNwcAppbmRleCBiMjc1MmIwYTBlY2QwOGNh Zjg0YTBlMjBiZGU3NmVkNmNjMjNiZDFkLi40MzliMTkyN2M3Mzc3ZDQxNTk5Y2NiMzk4NzEwNzhm YzEzODVmODljIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZvY3VzQ29udHJvbGxl ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9Gb2N1c0NvbnRyb2xsZXIuY3BwCkBAIC00 NjUsNyArNDY1LDcgQEAgYm9vbCBGb2N1c0NvbnRyb2xsZXI6OmFkdmFuY2VGb2N1c0luRG9jdW1l bnRPcmRlcihGb2N1c0RpcmVjdGlvbiBkaXJlY3Rpb24sIEtleWIKIAogICAgIGlmICghZWxlbWVu dCkgewogICAgICAgICAvLyBXZSBkaWRuJ3QgZmluZCBhIG5vZGUgdG8gZm9jdXMsIHNvIHdlIHNo b3VsZCB0cnkgdG8gcGFzcyBmb2N1cyB0byBDaHJvbWUuCi0gICAgICAgIGlmICghaW5pdGlhbEZv Y3VzICYmIG1fcGFnZS5jaHJvbWUoKS5jYW5UYWtlRm9jdXMoZGlyZWN0aW9uKSkgeworICAgICAg ICBpZiAoIWluaXRpYWxGb2N1cyAmJiBtX3BhZ2UuY2hyb21lKCkuY2FuVGFrZUZvY3VzKGRpcmVj dGlvbikgJiYgIW1fcGFnZS5pc0NvbnRyb2xsZWRCeUF1dG9tYXRpb24oKSkgewogICAgICAgICAg ICAgZG9jdW1lbnQtPnNldEZvY3VzZWRFbGVtZW50KG51bGxwdHIpOwogICAgICAgICAgICAgc2V0 Rm9jdXNlZEZyYW1lKG51bGxwdHIpOwogICAgICAgICAgICAgbV9wYWdlLmNocm9tZSgpLnRha2VG b2N1cyhkaXJlY3Rpb24pOwo=