<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>190203</bug_id>
          
          <creation_ts>2018-10-02 08:54:18 -0700</creation_ts>
          <short_desc>Fix Disassembler-output on ARM Thumb2</short_desc>
          <delta_ts>2018-10-02 15:54:23 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dominik Inführ">dominik.infuehr</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1465573</commentid>
    <comment_count>0</comment_count>
    <who name="Dominik Inführ">dominik.infuehr</who>
    <bug_when>2018-10-02 08:54:18 -0700</bug_when>
    <thetext>Fix Disassembler-output on ARM Thumb2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1465587</commentid>
    <comment_count>1</comment_count>
      <attachid>351395</attachid>
    <who name="Dominik Inführ">dominik.infuehr</who>
    <bug_when>2018-10-02 09:11:48 -0700</bug_when>
    <thetext>Created attachment 351395
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1465594</commentid>
    <comment_count>2</comment_count>
      <attachid>351395</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2018-10-02 09:18:48 -0700</bug_when>
    <thetext>Comment on attachment 351395
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351395&amp;action=review

&gt; Source/JavaScriptCore/ChangeLog:6
&gt; +        Disassembler on ARM-Thumb2 started on wrong address.

Please describe the detail about what was wrong and what this patch fixes :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1465768</commentid>
    <comment_count>3</comment_count>
      <attachid>351444</attachid>
    <who name="Dominik Inführ">dominik.infuehr</who>
    <bug_when>2018-10-02 15:11:47 -0700</bug_when>
    <thetext>Created attachment 351444
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1465769</commentid>
    <comment_count>4</comment_count>
    <who name="Dominik Inführ">dominik.infuehr</who>
    <bug_when>2018-10-02 15:13:15 -0700</bug_when>
    <thetext>Sorry ;) Updated the ChangeLog. Thanks a lot!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1465770</commentid>
    <comment_count>5</comment_count>
      <attachid>351444</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2018-10-02 15:13:37 -0700</bug_when>
    <thetext>Comment on attachment 351444
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1465795</commentid>
    <comment_count>6</comment_count>
      <attachid>351444</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-10-02 15:53:34 -0700</bug_when>
    <thetext>Comment on attachment 351444
Patch

Clearing flags on attachment: 351444

Committed r236768: &lt;https://trac.webkit.org/changeset/236768&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1465796</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-10-02 15:53:36 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1465801</commentid>
    <comment_count>8</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-10-02 15:54:23 -0700</bug_when>
    <thetext>&lt;rdar://problem/44956795&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>351395</attachid>
            <date>2018-10-02 09:11:48 -0700</date>
            <delta_ts>2018-10-02 15:11:30 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-190203-20181002181146.patch</filename>
            <type>text/plain</type>
            <size>1678</size>
            <attacher name="Dominik Inführ">dominik.infuehr</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz
NzhjZTM0OGUzY2ZmMjMzNTRmOWRkMzYwZTk2MjQ1N2I0Y2RmMGY2Li43NTAxYzJjYmYyNGU2NWQz
YWJhYTc1MzQ1MjZlODdlYzBlMGQxYjhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNSBAQAorMjAxOC0xMC0wMiAgRG9taW5payBJbmbDvGhyICA8ZG9taW5pay5pbmZ1ZWhy
QGdtYWlsLmNvbT4KKworICAgICAgICBGaXggRGlzYXNzZW1ibGVyLW91dHB1dCBvbiBBUk0gVGh1
bWIyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTAy
MDMKKworICAgICAgICBEaXNhc3NlbWJsZXIgb24gQVJNLVRodW1iMiBzdGFydGVkIG9uIHdyb25n
IGFkZHJlc3MuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgKiBkaXNhc3NlbWJsZXIvQ2Fwc3RvbmVEaXNhc3NlbWJsZXIuY3BwOgorICAgICAgICAoSlND
Ojp0cnlUb0Rpc2Fzc2VtYmxlKToKKwogMjAxOC0xMC0wMiAgQ2FpbyBMaW1hICA8dGljYWlvbGlt
YUBnbWFpbC5jb20+CiAKICAgICAgICAgW0JpZ0ludF0gQmlnSW50LnByb3B0b3R5cGUudG9TdHJp
bmcgaXMgYnJva2VuIHdoZW4gcmFkaXggaXMgcG93ZXIgb2YgMgpkaWZmIC0tZ2l0IGEvU291cmNl
L0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci9DYXBzdG9uZURpc2Fzc2VtYmxlci5jcHAgYi9T
b3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL0NhcHN0b25lRGlzYXNzZW1ibGVyLmNw
cAppbmRleCA0N2I1NjEyZGI5OWZkYjFmODkxNWIyNzhhOTExZTVmMjEzZmEzMmVmLi5hNmZmMjI3
MTBmMDk5ZTg3ZDE5Y2ZjZDIxNTgwMjdiZmJiNWVhYTgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL0NhcHN0b25lRGlzYXNzZW1ibGVyLmNwcAorKysgYi9T
b3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL0NhcHN0b25lRGlzYXNzZW1ibGVyLmNw
cApAQCAtNjcsNyArNjcsNyBAQCBib29sIHRyeVRvRGlzYXNzZW1ibGUoY29uc3QgTWFjcm9Bc3Nl
bWJsZXJDb2RlUHRyPERpc2Fzc2VtYmx5UHRyVGFnPiYgY29kZVB0ciwgcwogICAgIH0KICNlbmRp
ZgogCi0gICAgc2l6ZV90IGNvdW50ID0gY3NfZGlzYXNtKGhhbmRsZSwgY29kZVB0ci51bnRhZ2dl
ZEV4ZWN1dGFibGVBZGRyZXNzPHVuc2lnbmVkIGNoYXIqPigpLCBzaXplLCBjb2RlUHRyLnVudGFn
Z2VkRXhlY3V0YWJsZUFkZHJlc3M8dWludHB0cl90PigpLCAwLCAmaW5zdHJ1Y3Rpb25zKTsKKyAg
ICBzaXplX3QgY291bnQgPSBjc19kaXNhc20oaGFuZGxlLCBjb2RlUHRyLmRhdGFMb2NhdGlvbjx1
bnNpZ25lZCBjaGFyKj4oKSwgc2l6ZSwgY29kZVB0ci5kYXRhTG9jYXRpb248dWludHB0cl90Pigp
LCAwLCAmaW5zdHJ1Y3Rpb25zKTsKICAgICBpZiAoY291bnQgPiAwKSB7CiAgICAgICAgIGZvciAo
c2l6ZV90IGkgPSAwOyBpIDwgY291bnQ7ICsraSkgewogICAgICAgICAgICAgYXV0byYgaW5zdHJ1
Y3Rpb24gPSBpbnN0cnVjdGlvbnNbaV07Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>351444</attachid>
            <date>2018-10-02 15:11:47 -0700</date>
            <delta_ts>2018-10-02 15:53:34 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-190203-20181003001146.patch</filename>
            <type>text/plain</type>
            <size>2053</size>
            <attacher name="Dominik Inführ">dominik.infuehr</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz
NzhjZTM0OGUzY2ZmMjMzNTRmOWRkMzYwZTk2MjQ1N2I0Y2RmMGY2Li45ZmZiNTkxYjAxMWFiN2E5
NWMxMTE1NDhkYmFjYjg1YTU3YjM5OTRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwyMCBAQAorMjAxOC0xMC0wMiAgRG9taW5payBJbmZ1ZWhyICA8ZGluZnVlaHJAaWdhbGlh
LmNvbT4KKworICAgICAgICBGaXggRGlzYXNzZW1ibGVyLW91dHB1dCBvbiBBUk0gVGh1bWIyCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTAyMDMKKwor
ICAgICAgICBPbiBBUk12NyB3aXRoIFRodW1iMiBhZGRyZXNzZXMgaGF2ZSBiaXQgMCBzZXQgdG8g
MSB0byBmb3JjZQorICAgICAgICBleGVjdXRpb24gaW4gdGh1bWIgbW9kZSBmb3IganVtcHMgYW5k
IGNhbGxzLiBUaGUgYWN0dWFsIG1hY2hpbmUKKyAgICAgICAgaW5zdHJ1Y3Rpb25zIGFyZSBzdGls
bCBhbGlnbmVkIHRvIDItYnl0ZXMgdGhvdWdoLiBVc2UgZGF0YUxvY2F0aW9uKCkgYXMKKyAgICAg
ICAgc3RhcnQgYWRkcmVzcyBmb3IgZGlzYXNzZW1ibGluZyBzaW5jZSBpdCB1bnNldHMgdGhlIHRo
dW1iIGJpdC4KKyAgICAgICAgVW50aWwgbm93IHRoZSBkaXNhc3NlbWJsZXIgd291bGQgc3RhcnQg
YXQgdGhlIHdyb25nIGFkZHJlc3MgKG9mZiBieSAxKSwKKyAgICAgICAgcmVzdWx0aW5nIGluIHRo
ZSB3cm9uZyBkaXNhc3NlbWJsZWQgbWFjaGluZSBpbnN0cnVjdGlvbnMuCisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkaXNhc3NlbWJsZXIvQ2Fwc3Rv
bmVEaXNhc3NlbWJsZXIuY3BwOgorICAgICAgICAoSlNDOjp0cnlUb0Rpc2Fzc2VtYmxlKToKKwog
MjAxOC0xMC0wMiAgQ2FpbyBMaW1hICA8dGljYWlvbGltYUBnbWFpbC5jb20+CiAKICAgICAgICAg
W0JpZ0ludF0gQmlnSW50LnByb3B0b3R5cGUudG9TdHJpbmcgaXMgYnJva2VuIHdoZW4gcmFkaXgg
aXMgcG93ZXIgb2YgMgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2Vt
Ymxlci9DYXBzdG9uZURpc2Fzc2VtYmxlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlz
YXNzZW1ibGVyL0NhcHN0b25lRGlzYXNzZW1ibGVyLmNwcAppbmRleCA0N2I1NjEyZGI5OWZkYjFm
ODkxNWIyNzhhOTExZTVmMjEzZmEzMmVmLi5hNmZmMjI3MTBmMDk5ZTg3ZDE5Y2ZjZDIxNTgwMjdi
ZmJiNWVhYTgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVy
L0NhcHN0b25lRGlzYXNzZW1ibGVyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlz
YXNzZW1ibGVyL0NhcHN0b25lRGlzYXNzZW1ibGVyLmNwcApAQCAtNjcsNyArNjcsNyBAQCBib29s
IHRyeVRvRGlzYXNzZW1ibGUoY29uc3QgTWFjcm9Bc3NlbWJsZXJDb2RlUHRyPERpc2Fzc2VtYmx5
UHRyVGFnPiYgY29kZVB0ciwgcwogICAgIH0KICNlbmRpZgogCi0gICAgc2l6ZV90IGNvdW50ID0g
Y3NfZGlzYXNtKGhhbmRsZSwgY29kZVB0ci51bnRhZ2dlZEV4ZWN1dGFibGVBZGRyZXNzPHVuc2ln
bmVkIGNoYXIqPigpLCBzaXplLCBjb2RlUHRyLnVudGFnZ2VkRXhlY3V0YWJsZUFkZHJlc3M8dWlu
dHB0cl90PigpLCAwLCAmaW5zdHJ1Y3Rpb25zKTsKKyAgICBzaXplX3QgY291bnQgPSBjc19kaXNh
c20oaGFuZGxlLCBjb2RlUHRyLmRhdGFMb2NhdGlvbjx1bnNpZ25lZCBjaGFyKj4oKSwgc2l6ZSwg
Y29kZVB0ci5kYXRhTG9jYXRpb248dWludHB0cl90PigpLCAwLCAmaW5zdHJ1Y3Rpb25zKTsKICAg
ICBpZiAoY291bnQgPiAwKSB7CiAgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgY291bnQ7
ICsraSkgewogICAgICAgICAgICAgYXV0byYgaW5zdHJ1Y3Rpb24gPSBpbnN0cnVjdGlvbnNbaV07
Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>