190202 2018-10-02 08:50:50 -0700 REGRESSION(r236154) Page loads are not drawn when loaded in shipped Safari11/12 2018-10-05 15:27:23 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=189668 InRadar P2 Normal --- 1 youennf achristensen achristensen beidson cdumez fred.wang rbuis rwlbuis webkit-bug-importer oldest_to_newest 1465570 0 youennf 2018-10-02 08:50:50 -0700 After this revision, page loads are hanging on previous Safari version. This was reported for Safari high Sierra and Safari Mojave. I bissected the issue with WebKit Nightlies to http://trac.webkit.org/r236153 1465577 1 rbuis 2018-10-02 08:55:29 -0700 I have this problem on High Sierra and I am seeing: ./Tools/Scripts/run-safari --no-saved-state Starting SafariForWebKitDevelopment with DYLD_FRAMEWORK_PATH set to point to built WebKit in /Users/rwlbuis/WebKit/WebKitBuild/Release. Failed to acquire exclusive access to AutoFill corrections SQLite store at AutoFillCorrections.db. Failed to acquire exclusive access to AutoFill corrections SQLite store at CloudAutoFillCorrections.db. Failed to acquire exclusive access to AutoFill corrections SQLite store at AutoFillCorrections.db. Failed to acquire exclusive access to AutoFill corrections SQLite store at CloudAutoFillCorrections.db. 2018-10-02 17:55:14.088 SafariForWebKitDevelopment[50142:289352] It's not legal to call -layoutSubtreeIfNeeded on a view which is already being laid out. If you are implementing the view's -layout method, you can call -[super layout] instead. Break on void _NSDetectedLayoutRecursion(void) to debug. This will be logged only once. This may break in the future. Failed to acquire exclusive access to AutoFill corrections SQLite store at AutoFillCorrections.db. Failed to acquire exclusive access to AutoFill corrections SQLite store at CloudAutoFillCorrections.db. Failed to acquire exclusive access to AutoFill corrections SQLite store at AutoFillCorrections.db. Failed to acquire exclusive access to AutoFill corrections SQLite store at CloudAutoFillCorrections.db. 2018-10-02 17:55:14.509 SafariForWebKitDevelopment[50142:289430] AOSKit ERROR: XPC CLIENT: Unauthorized client error received 1465578 2 rbuis 2018-10-02 08:57:06 -0700 Also on my system are stock Safari Version 11.1.2 (13605.3.8) and Xcode Version 9.4.1 (9F2000). 1465600 3 achristensen 2018-10-02 09:32:42 -0700 Interesting. Can this reproduce with the latest? 1465602 4 youennf 2018-10-02 09:35:32 -0700 (In reply to Alex Christensen from comment #3) > Interesting. Can this reproduce with the latest? It was reported in Mojave latest Safari. 1465603 5 achristensen 2018-10-02 09:36:32 -0700 I mean with the latest WebKit. Also, can it reproduce with local builds of WebKit? 1465605 6 cdumez 2018-10-02 09:37:35 -0700 (In reply to Alex Christensen from comment #5) > I mean with the latest WebKit. > Also, can it reproduce with local builds of WebKit? This is the bug, it happens if you use a recent locally built WebKit with the System's Safari. 1465612 7 cdumez 2018-10-02 09:46:34 -0700 Does it require building WebKit with an external SDK? 1465621 8 rbuis 2018-10-02 09:53:53 -0700 (In reply to Alex Christensen from comment #5) > I mean with the latest WebKit. > Also, can it reproduce with local builds of WebKit? Yes, I built r236716 today for my test. 1466782 9 351698 achristensen 2018-10-05 14:15:08 -0700 Created attachment 351698 Patch 1466783 10 351698 youennf 2018-10-05 14:20:10 -0700 Comment on attachment 351698 Patch Are we missing some API tests to catch these kind of regressions? 1466784 11 achristensen 2018-10-05 14:40:53 -0700 (In reply to youenn fablet from comment #10) > Comment on attachment 351698 [details] > Patch > > Are we missing some API tests to catch these kind of regressions? Technically yes, but we are in the process of removing all this SPI. http://trac.webkit.org/r236886 1466785 12 webkit-bug-importer 2018-10-05 14:41:29 -0700 <rdar://problem/45055789> 1466799 13 351698 cdumez 2018-10-05 15:27:23 -0700 Comment on attachment 351698 Patch Seems like we could have very easily written an API test for this. 351698 2018-10-05 14:15:08 -0700 2018-10-05 14:20:10 -0700 Patch bug-190202-20181005141508.patch text/plain 1800 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzY4ODQpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE4LTEwLTA1ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MjM2MTU0KSBQYWdlIGxvYWRzIGFyZSBub3QgZHJhd24gd2hlbiBsb2FkZWQgaW4gc2hpcHBlZCBT YWZhcmkxMS8xMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTkwMjAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgU2FmYXJpMTEvMTIgaGFkIGEgV0tQYWdlTG9hZGVyQ2xpZW50IGFuZCBhIFdLUGFnZU5hdmln YXRpb25DbGllbnQuCisgICAgICAgIEl0IGRpZCBub3QgYWN0dWFsbHkgZHJhdyB0aGUgcGFnZSB1 bnRpbCBpdHMgV0tQYWdlTmF2aWdhdGlvbkNsaWVudC5yZW5kZXJpbmdQcm9ncmVzc0RpZENoYW5n ZSB3YXMgY2FsbGVkLgorICAgICAgICByMjM2MTU0IG1hZGUgaXQgc28gd2Ugb25seSBjYWxsIFdL UGFnZUxvYWRlckNsaWVudC5kaWRMYXlvdXQgaWYgYW4gYXBwbGljYXRpb24gaGFzIGJvdGggY2xp ZW50cy4KKyAgICAgICAgVGhpcyBmaXhlcyBvcGVuIHNvdXJjZSBXZWJLaXQgcnVubmluZyB3aXRo IHNoaXBwZWQgU2FmYXJpLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6 CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6ZGlkUmVhY2hMYXlvdXRNaWxlc3RvbmUp OgorCiAyMDE4LTEwLTA1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAg ICAgW1BTT05dIERyb3Agc25hcHNob3R0aW5nIHdvcmthcm91bmQgaW50cm9kdWNlZCBpbiByMjM1 ODk4CkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJKHJldmlz aW9uIDIzNjg0NCkKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTM5NzMsOCArMzk3Myw3IEBAIHZvaWQgV2ViUGFnZVByb3h5Ojpk aWRSZWFjaExheW91dE1pbGVzdG8KIAogICAgIGlmIChtX2xvYWRlckNsaWVudCkKICAgICAgICAg bV9sb2FkZXJDbGllbnQtPmRpZFJlYWNoTGF5b3V0TWlsZXN0b25lKCp0aGlzLCBzdGF0aWNfY2Fz dDxMYXlvdXRNaWxlc3RvbmVzPihsYXlvdXRNaWxlc3RvbmVzKSk7Ci0gICAgZWxzZQotICAgICAg ICBtX25hdmlnYXRpb25DbGllbnQtPnJlbmRlcmluZ1Byb2dyZXNzRGlkQ2hhbmdlKCp0aGlzLCBz dGF0aWNfY2FzdDxMYXlvdXRNaWxlc3RvbmVzPihsYXlvdXRNaWxlc3RvbmVzKSk7CisgICAgbV9u YXZpZ2F0aW9uQ2xpZW50LT5yZW5kZXJpbmdQcm9ncmVzc0RpZENoYW5nZSgqdGhpcywgc3RhdGlj X2Nhc3Q8TGF5b3V0TWlsZXN0b25lcz4obGF5b3V0TWlsZXN0b25lcykpOwogfQogCiB2b2lkIFdl YlBhZ2VQcm94eTo6ZGlkRGlzcGxheUluc2VjdXJlQ29udGVudEZvckZyYW1lKHVpbnQ2NF90IGZy YW1lSUQsIGNvbnN0IFVzZXJEYXRhJiB1c2VyRGF0YSkK