190200 2018-10-02 08:46:13 -0700 -Wunused-variable in RenderLayer::updateScrollableAreaSet 2018-10-03 04:04:28 -0700 1 1 1 Unclassified WebKit WebCore Misc. Other PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=190197 InRadar P2 Normal --- 1 mcatanzaro mcatanzaro achristensen bugs-noreply commit-queue mcatanzaro webkit-bug-importer ysuzuki oldest_to_newest 1465564 0 mcatanzaro 2018-10-02 08:46:13 -0700 We have an unused variable in RenderLayer::updateScrollableAreaSet. I fixed it in r236719 but that broke a bunch of scrolling tests (bug #190197), so clearly I'm not competent enough to do this unreviewed. Let's try again. 1465586 1 351394 mcatanzaro 2018-10-02 09:10:30 -0700 Created attachment 351394 Patch 1465626 2 351394 achristensen 2018-10-02 10:02:20 -0700 Comment on attachment 351394 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351394&action=review > Source/WebCore/rendering/RenderLayer.cpp:6369 > + // Silence -Wunused-variable. The UNUSED_PARAM macro would work here, but the naming would be > + // off as it's not a parameter. This comment seems excessively verbose. Why not just use UNUSED_PARAM like we do in many other places, or make an UNUSED_VARIABLE macro? 1465647 3 mcatanzaro 2018-10-02 10:20:51 -0700 My vote is to make UNUSED_VARIABLE() in Compiler.h 1465654 4 mcatanzaro 2018-10-02 10:24:31 -0700 Did not build this yet... let's see if it passes EWS. 1465655 5 351413 mcatanzaro 2018-10-02 10:24:48 -0700 Created attachment 351413 Patch 1465951 6 mcatanzaro 2018-10-03 00:56:53 -0700 (In reply to Michael Catanzaro from comment #4) > Did not build this yet... let's see if it passes EWS. Signs point to "no." 1465952 7 351488 mcatanzaro 2018-10-03 01:06:59 -0700 Created attachment 351488 Patch 1465997 8 351488 ysuzuki 2018-10-03 03:37:46 -0700 Comment on attachment 351488 Patch r=me 1466005 9 351488 commit-queue 2018-10-03 04:03:55 -0700 Comment on attachment 351488 Patch Clearing flags on attachment: 351488 Committed r236790: <https://trac.webkit.org/changeset/236790> 1466006 10 commit-queue 2018-10-03 04:03:57 -0700 All reviewed patches have been landed. Closing bug. 1466007 11 webkit-bug-importer 2018-10-03 04:04:28 -0700 <rdar://problem/44969810> 351394 2018-10-02 09:10:30 -0700 2018-10-02 10:24:44 -0700 Patch bug-190200-20181002181029.patch text/plain 1519 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDVjNDllNzgwMTllYTli NmMwOTA5NmI1OGRlMTZmMWI1ZTVlNDJhNS4uNGQ0M2E5YjUxNjk0ZjM0NDNjZTI4NjIxYjhhNjNm ODkyMjQ5MWRmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTEwLTAyICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICAtV3VudXNl ZC12YXJpYWJsZSBpbiBSZW5kZXJMYXllcjo6dXBkYXRlU2Nyb2xsYWJsZUFyZWFTZXQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDIwMAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvdWxkIHVzZSBVTlVT RURfUEFSQU0oKSBmb3IgdGhpcywgYnV0IGl0J3Mgbm90IGEgcGFyYW1ldGVyLCBzbyB0aGF0IGRv ZXNuJ3Qgc2VlbSBxdWl0ZQorICAgICAgICByaWdodC4KKworICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6Y2FsY3VsYXRl Q2xpcFJlY3RzIGNvbnN0KTogVGhpcyBpcyBhIHByZXBhcmUtQ2hhbmdlTG9nIGJ1Zy4gSSBkb24n dAorICAgICAgICBoYXZlIGFueSBjaGFuZ2VzIGluIHRoaXMgZnVuY3Rpb24uLi4uCisKIDIwMTgt MTAtMDIgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMzY3MTkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyLmNwcAppbmRleCAxMDg2MzIxOWVkOWY4OWM0NjM1OTQ4MjkyYjFhNzk1N2Ji ZDM2YTk0Li5lZmJlMGJlNGE0YjcyMDc4YzI1YmY1ZjJiOGM5NDA3OTFkOWQzMjUxIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKQEAgLTYzNjQsNiArNjM2NCwxMCBA QCB2b2lkIFJlbmRlckxheWVyOjp1cGRhdGVTY3JvbGxhYmxlQXJlYVNldChib29sIGhhc092ZXJm bG93KQogICAgICAgICAgICAgdW5yZWdpc3RlckFzVG91Y2hFdmVudExpc3RlbmVyRm9yU2Nyb2xs aW5nKCk7CiAgICAgICAgIH0KICAgICB9CisjZWxzZQorICAgIC8vIFNpbGVuY2UgLVd1bnVzZWQt dmFyaWFibGUuIFRoZSBVTlVTRURfUEFSQU0gbWFjcm8gd291bGQgd29yayBoZXJlLCBidXQgdGhl IG5hbWluZyB3b3VsZCBiZQorICAgIC8vIG9mZiBhcyBpdCdzIG5vdCBhIHBhcmFtZXRlci4KKyAg ICAodm9pZClhZGRlZE9yUmVtb3ZlZDsKICNlbmRpZgogfQogCg== 351413 2018-10-02 10:24:48 -0700 2018-10-03 01:06:55 -0700 Patch bug-190200-20181002192447.patch text/plain 2444 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGQ4NTFhYTRlZTVkODgzZDczY2EzYjcz MjJmYjAwNjAxMWM0NzFlNDIuLjIzNWE0YmJiNGRjZDVkZjgwOThhZDJhMjZmOGUzNTMzODM4N2Yy NWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMTAtMDIgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIC1XdW51c2VkLXZhcmlhYmxlIGluIFJl bmRlckxheWVyOjp1cGRhdGVTY3JvbGxhYmxlQXJlYVNldAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMjAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgbmV3IFVOVVNFRF9WQVJJQUJMRSgpIG1h Y3JvLiBJdCdzIHRoZSBzYW1lIGFzIFVOVVNFRF9QQVJBTSgpLCBqdXN0IG5hbWVkIGRpZmZlcmVu dGx5LgorCisgICAgICAgICogd3RmL0NvbXBpbGVyLmg6CisKIDIwMTgtMTAtMDIgIENhaW8gTGlt YSAgPHRpY2Fpb2xpbWFAZ21haWwuY29tPgogCiAgICAgICAgIFtCaWdJbnRdIEJpZ0ludC5wcm9w dG90eXBlLnRvU3RyaW5nIGlzIGJyb2tlbiB3aGVuIHJhZGl4IGlzIHBvd2VyIG9mIDIKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwppbmRleCBkNWM0OWU3ODAxOWVhOWI2YzA5MDk2YjU4ZGUxNmYxYjVlNWU0MmE1Li4wZmRhZDU5 ZmNiNDU5ZTRkOWQ4MmJkMjRhZTZmMDI5NmM1Mjc4NmIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTUgQEAKKzIwMTgtMTAtMDIgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEu Y29tPgorCisgICAgICAgIC1XdW51c2VkLXZhcmlhYmxlIGluIFJlbmRlckxheWVyOjp1cGRhdGVT Y3JvbGxhYmxlQXJlYVNldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTkwMjAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUGFzcyBpdCB0aHJvdWdoIFVOVVNFRF9WQVJJQUJMRSgpLgorCisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVy OjpjYWxjdWxhdGVDbGlwUmVjdHMgY29uc3QpOgorCiAyMDE4LTEwLTAyICBDb21taXQgUXVldWUg IDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5n IG91dCByMjM2NzE5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvQ29tcGlsZXIuaCBiL1Nv dXJjZS9XVEYvd3RmL0NvbXBpbGVyLmgKaW5kZXggZmIxODk4ZDJiM2YwMzRmYzA3M2NiNjVjMjhi N2IzMzcwOWI4NGMxNC4uNzE1ZWNmN2Y0YTU0ZWFjOTgyZjBiY2U4YTc5ZDgxMTg4ZTIzZjgzNiAx MDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvQ29tcGlsZXIuaAorKysgYi9Tb3VyY2UvV1RGL3d0 Zi9Db21waWxlci5oCkBAIC0zNjcsNiArMzY3LDExIEBACiAjZGVmaW5lIFVOVVNFRF9QQVJBTSh2 YXJpYWJsZSkgKHZvaWQpdmFyaWFibGUKICNlbmRpZgogCisvKiBVTlVTRURfVkFSSUFCTEUgKi8K KyNpZiAhZGVmaW5lZChVTlVTRURfVkFSSUFCTEUpCisjZGVmaW5lIFVOVVNFRF9WQVJJQUJMRSgp IFVOVVNFRF9QQVJBTSgpCisjZW5kaWYKKwogLyogV0FSTl9VTlVTRURfUkVUVVJOICovCiAKICNp ZiAhZGVmaW5lZChXQVJOX1VOVVNFRF9SRVRVUk4pICYmIENPTVBJTEVSKEdDQ19DT01QQVRJQkxF KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKaW5kZXggMTA4NjMyMTll ZDlmODljNDYzNTk0ODI5MmIxYTc5NTdiYmQzNmE5NC4uMWQ2MzcxM2IzOTU1ZDdjNThlOWUwZWJh YjEwYzhmNmM0YjExNzczYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIu Y3BwCkBAIC02MzY0LDYgKzYzNjQsOCBAQCB2b2lkIFJlbmRlckxheWVyOjp1cGRhdGVTY3JvbGxh YmxlQXJlYVNldChib29sIGhhc092ZXJmbG93KQogICAgICAgICAgICAgdW5yZWdpc3RlckFzVG91 Y2hFdmVudExpc3RlbmVyRm9yU2Nyb2xsaW5nKCk7CiAgICAgICAgIH0KICAgICB9CisjZWxzZQor ICAgIFVOVVNFRF9WQVJJQUJMRShhZGRlZE9yUmVtb3ZlZCk7CiAjZW5kaWYKIH0KIAo= 351488 2018-10-03 01:06:59 -0700 2018-10-03 04:03:55 -0700 Patch bug-190200-20181003100657.patch text/plain 2471 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2Nzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDE2Y2I1MjQ5NmNlZGVkZGJhYjM0NDA0 Mjc5MzdlMWM4NmQ3YTg4ZjQuLjBhMzZiN2QwNGJhZmRlYmNiODAyYjYzNzE4NDZjN2MyZGNmOTc0 NzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMTAtMDMgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIC1XdW51c2VkLXZhcmlhYmxlIGluIFJl bmRlckxheWVyOjp1cGRhdGVTY3JvbGxhYmxlQXJlYVNldAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMjAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgbmV3IFVOVVNFRF9WQVJJQUJMRSgpIG1h Y3JvLiBJdCdzIHRoZSBzYW1lIGFzIFVOVVNFRF9QQVJBTSgpLCBqdXN0IG5hbWVkIGRpZmZlcmVu dGx5LgorCisgICAgICAgICogd3RmL0NvbXBpbGVyLmg6CisKIDIwMTgtMTAtMDEgIERlYW4gSmFj a3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPU10gU3dpdGNoaW5nIHRvIGRp c2NyZXRlIEdQVSBzaG91bGQgYmUgZG9uZSBpbiB0aGUgVUkgcHJvY2VzcwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4 IDk3N2ZkOTllOTk4MzNmYTkyNjJjMjIxZmM2NzI3Y2UzOTRkYmZhMDAuLjE0MDEzNmQ5YmFmYzFl N2JjM2UxMmZlMzNhYzhlYzZhNzk2ZmM0OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor MjAxOC0xMC0wMyAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CisK KyAgICAgICAgLVd1bnVzZWQtdmFyaWFibGUgaW4gUmVuZGVyTGF5ZXI6OnVwZGF0ZVNjcm9sbGFi bGVBcmVhU2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTAyMDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBQYXNzIGl0IHRocm91Z2ggVU5VU0VEX1ZBUklBQkxFKCkuCisKKyAgICAgICAgKiByZW5kZXJp bmcvUmVuZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmNhbGN1 bGF0ZUNsaXBSZWN0cyBjb25zdCk6CisKIDIwMTgtMTAtMDIgIFJ5b3N1a2UgTml3YSAgPHJuaXdh QHdlYmtpdC5vcmc+CiAKICAgICAgICAgQ29weWluZyBjb250ZW50IHdpdGggc2hhZG93IERPTSBk b2Vzbid0IGNvcHkgYW55IGNvbnRlbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9Db21w aWxlci5oIGIvU291cmNlL1dURi93dGYvQ29tcGlsZXIuaAppbmRleCBmYjE4OThkMmIzZjAzNGZj MDczY2I2NWMyOGI3YjMzNzA5Yjg0YzE0Li5hYjE5MjMyMjM0YTRiOTY0YWM5ZDljNmM3NzU4OTZh MDkyYzM5ZDVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Db21waWxlci5oCisrKyBiL1Nv dXJjZS9XVEYvd3RmL0NvbXBpbGVyLmgKQEAgLTM2Nyw2ICszNjcsMTEgQEAKICNkZWZpbmUgVU5V U0VEX1BBUkFNKHZhcmlhYmxlKSAodm9pZCl2YXJpYWJsZQogI2VuZGlmCiAKKy8qIFVOVVNFRF9W QVJJQUJMRSAqLworI2lmICFkZWZpbmVkKFVOVVNFRF9WQVJJQUJMRSkKKyNkZWZpbmUgVU5VU0VE X1ZBUklBQkxFKHZhcmlhYmxlKSBVTlVTRURfUEFSQU0odmFyaWFibGUpCisjZW5kaWYKKwogLyog V0FSTl9VTlVTRURfUkVUVVJOICovCiAKICNpZiAhZGVmaW5lZChXQVJOX1VOVVNFRF9SRVRVUk4p ICYmIENPTVBJTEVSKEdDQ19DT01QQVRJQkxFKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJMYXllci5jcHAKaW5kZXggMTA4NjMyMTllZDlmODljNDYzNTk0ODI5MmIxYTc5NTdiYmQzNmE5 NC4uMWQ2MzcxM2IzOTU1ZDdjNThlOWUwZWJhYjEwYzhmNmM0YjExNzczYyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCkBAIC02MzY0LDYgKzYzNjQsOCBAQCB2b2lk IFJlbmRlckxheWVyOjp1cGRhdGVTY3JvbGxhYmxlQXJlYVNldChib29sIGhhc092ZXJmbG93KQog ICAgICAgICAgICAgdW5yZWdpc3RlckFzVG91Y2hFdmVudExpc3RlbmVyRm9yU2Nyb2xsaW5nKCk7 CiAgICAgICAgIH0KICAgICB9CisjZWxzZQorICAgIFVOVVNFRF9WQVJJQUJMRShhZGRlZE9yUmVt b3ZlZCk7CiAjZW5kaWYKIH0KIAo=