190197 2018-10-02 07:04:10 -0700 REGRESSION(r236719): this revision caused 39 layout test failures that tested for scrolling, a bug was also not present in the commit or change log. (Requested by Truitt on #webkit). 2018-10-07 12:10:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=190200 InRadar P2 Normal --- 1 commit-queue commit-queue mcatanzaro realdawei ryanhaddad tsavell webkit-bug-importer oldest_to_newest 1465537 0 commit-queue 2018-10-02 07:04:10 -0700 https://trac.webkit.org/changeset/236719 broke the build: this revision caused 39 layout test failures that tested for scrolling, a bug was also not present in the commit or change log. (Requested by Truitt on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1465538 1 351383 commit-queue 2018-10-02 07:04:17 -0700 Created attachment 351383 ROLLOUT of r236719 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1465540 2 351383 commit-queue 2018-10-02 07:19:59 -0700 Comment on attachment 351383 ROLLOUT of r236719 Clearing flags on attachment: 351383 Committed r236741: <https://trac.webkit.org/changeset/236741> 1465541 3 commit-queue 2018-10-02 07:20:01 -0700 All reviewed patches have been landed. Closing bug. 1465542 4 webkit-bug-importer 2018-10-02 07:20:37 -0700 <rdar://problem/44937228> 1465552 5 mcatanzaro 2018-10-02 08:22:58 -0700 Ah, I see the problem: frameView.addScrollableArea and frameView.removeScrollableArea have side effects. Thanks for the speedy rollout. Note that we don't require bugs for trivial build fixes (in this case, -Wunused-variable). 1466881 6 ap 2018-10-06 10:24:02 -0700 Correct, we don’t require a bug for every commit. Mentioning that in a rollback bug seems useful anyway: 1. Maybe there was a bug, just not mentioned in ChangeLog. Not knowing about it means that the person who rolled back the change could not reopen the original. 2. It makes it more clear that some context could have been lost (maybe there was an IRC discussion that not everyone saw). 1466947 7 mcatanzaro 2018-10-07 12:10:19 -0700 Fixed properly in bug #190200 351383 2018-10-02 07:04:17 -0700 2018-10-02 07:19:59 -0700 ROLLOUT of r236719 bug-190197-20181002100416.patch text/plain 2040 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzBmZjUzMzFkOWVmZGVk Mzg0MDUyZGQ3OWUwOTk1MzE0ZTI3YTU0Ny4uZDVjNDllNzgwMTllYTliNmMwOTA5NmI1OGRlMTZm MWI1ZTVlNDJhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTEwLTAyICBDb21t aXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KKworICAgICAgICBVbnJldmlld2Vk LCByb2xsaW5nIG91dCByMjM2NzE5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTkwMTk3CisKKyAgICAgICAgdGhpcyByZXZpc2lvbiBjYXVzZWQgMzkg bGF5b3V0IHRlc3QgZmFpbHVyZXMgdGhhdCB0ZXN0ZWQgZm9yCisgICAgICAgIHNjcm9sbGluZywg YSBidWcgd2FzIGFsc28gbm90IHByZXNlbnQgaW4gdGhlIGNvbW1pdCBvciBjaGFuZ2UKKyAgICAg ICAgbG9nLiAoUmVxdWVzdGVkIGJ5IFRydWl0dCBvbiAjd2Via2l0KS4KKworICAgICAgICBSZXZl cnRlZCBjaGFuZ2VzZXQ6CisKKyAgICAgICAgIlVucmV2aWV3ZWQsIGZpeCB1bnVzZWQgdmFyaWFi bGUgaW4KKyAgICAgICAgUmVuZGVyTGF5ZXI6OnVwZGF0ZVNjcm9sbGFibGVBcmVhU2V0IgorICAg ICAgICBodHRwczovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMjM2NzE5CisKIDIwMTgtMTAt MDIgIEFsaWNpYSBCb3lhIEdhcmPDrWEgIDxhYm95YUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtN U0VdW0dTdHJlYW1lcl0gQWRkIGgyNjRwYXJzZSB0byBhY2NlcHQgTVA0IHdpdGhvdXQgc3Rzcwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKaW5kZXggMGE0MWU4OWJjNzM2 N2VkNDMxOGUyNjgzM2NiZjY4ZGQxMzBhNTJiZS4uMTA4NjMyMTllZDlmODljNDYzNTk0ODI5MmIx YTc5NTdiYmQzNmE5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3Bw CkBAIC02MzQwLDI0ICs2MzQwLDE3IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnVwZGF0ZVNjcm9sbGFi bGVBcmVhU2V0KGJvb2wgaGFzT3ZlcmZsb3cpCiAgICAgICAgIGlzVmlzaWJsZVRvSGl0VGVzdCAm PSBvd25lci0+cmVuZGVyZXIoKSAmJiBvd25lci0+cmVuZGVyZXIoKS0+dmlzaWJsZVRvSGl0VGVz dGluZygpOwogCiAgICAgYm9vbCBpc1Njcm9sbGFibGUgPSBoYXNPdmVyZmxvdyAmJiBpc1Zpc2li bGVUb0hpdFRlc3Q7Ci0KLSNpZiBFTkFCTEUoSU9TX1RPVUNIX0VWRU5UUykKICAgICBib29sIGFk ZGVkT3JSZW1vdmVkID0gZmFsc2U7Ci0jZW5kaWYKICAgICAKICAgICBBU1NFUlQobV9yZWdpc3Rl cmVkU2Nyb2xsYWJsZUFyZWEgPT0gZnJhbWVWaWV3LmNvbnRhaW5zU2Nyb2xsYWJsZUFyZWEodGhp cykpOwogICAgIAogICAgIGlmIChpc1Njcm9sbGFibGUpIHsKICAgICAgICAgaWYgKCFtX3JlZ2lz dGVyZWRTY3JvbGxhYmxlQXJlYSkgewotI2lmIEVOQUJMRShJT1NfVE9VQ0hfRVZFTlRTKQogICAg ICAgICAgICAgYWRkZWRPclJlbW92ZWQgPSBmcmFtZVZpZXcuYWRkU2Nyb2xsYWJsZUFyZWEodGhp cyk7Ci0jZW5kaWYKICAgICAgICAgICAgIG1fcmVnaXN0ZXJlZFNjcm9sbGFibGVBcmVhID0gdHJ1 ZTsKICAgICAgICAgfQogICAgIH0gZWxzZSBpZiAobV9yZWdpc3RlcmVkU2Nyb2xsYWJsZUFyZWEp IHsKLSNpZiBFTkFCTEUoSU9TX1RPVUNIX0VWRU5UUykKICAgICAgICAgYWRkZWRPclJlbW92ZWQg PSBmcmFtZVZpZXcucmVtb3ZlU2Nyb2xsYWJsZUFyZWEodGhpcyk7Ci0jZW5kaWYKICAgICAgICAg bV9yZWdpc3RlcmVkU2Nyb2xsYWJsZUFyZWEgPSBmYWxzZTsKICAgICB9CiAK