190195 2018-10-02 04:58:06 -0700 User installed fonts are not always disabled when they should be 2018-10-02 15:57:26 -0700 1 1 1 Unclassified WebKit Text WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned ap commit-queue ggaren mmaxfield webkit-bug-importer zalan oldest_to_newest 1465506 0 koivisto 2018-10-02 04:58:06 -0700 SVG images and some theme cases fail to respect the setting. 1465510 1 351372 koivisto 2018-10-02 05:24:49 -0700 Created attachment 351372 patch 1465511 2 351373 koivisto 2018-10-02 05:27:14 -0700 Created attachment 351373 patch 1465656 3 351373 ggaren 2018-10-02 10:24:54 -0700 Comment on attachment 351373 patch r=me 1465683 4 351373 commit-queue 2018-10-02 10:57:50 -0700 Comment on attachment 351373 patch Clearing flags on attachment: 351373 Committed r236753: <https://trac.webkit.org/changeset/236753> 1465684 5 commit-queue 2018-10-02 10:57:51 -0700 All reviewed patches have been landed. Closing bug. 1465686 6 webkit-bug-importer 2018-10-02 10:58:26 -0700 <rdar://problem/44944369> 1465694 7 351373 mmaxfield 2018-10-02 11:31:45 -0700 Comment on attachment 351373 patch View in context: https://bugs.webkit.org/attachment.cgi?id=351373&action=review > Source/WebCore/platform/graphics/FontDescription.cpp:83 > - , m_shouldAllowUserInstalledFonts(static_cast<unsigned>(AllowUserInstalledFonts::Yes)) > + , m_shouldAllowUserInstalledFonts(static_cast<unsigned>(AllowUserInstalledFonts::No)) The default setting for WKWebViews (and regular WebViews) is that user-installed fonts are allowed. Changing the default will cause tons of native apps to break. 1465697 8 koivisto 2018-10-02 11:39:07 -0700 > The default setting for WKWebViews (and regular WebViews) is that > user-installed fonts are allowed. Changing the default will cause tons of > native apps to break. This doesn't change any default settings. It only changes what happens when you construct a FontDescription and don't initialize allowUserInstalledFonts bit. All cases where this happens seemed to be places where enabling it was wrong. 1465710 9 koivisto 2018-10-02 11:59:04 -0700 Also all cases where we get this wrong is a potential fingerprinting vector so safe initialization is important here. 1465720 10 mmaxfield 2018-10-02 12:16:15 -0700 (In reply to Antti Koivisto from comment #9) > Also all cases where we get this wrong is a potential fingerprinting vector > so safe initialization is important here. False positives allow fingerprinting, but false negatives break native apps (which people have paid money for). We need to be sure this patch is correct. 351372 2018-10-02 05:24:49 -0700 2018-10-02 05:27:14 -0700 patch user-font-disable.patch text/plain 3497 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNjczNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDE4LTEwLTAyICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBVc2VyIGluc3RhbGxlZCBmb250 cyBhcmUgbm90IGFsd2F5cyBkaXNhYmxlZCB3aGVuIHRoZXkgc2hvdWxkIGJlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTAxOTUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTVkcgaW1hZ2VzIGFuZCBzb21l IHRoZW1lIGNhc2VzIGZhaWwgdG8gcmVzcGVjdCB0aGUgc2V0dGluZy4gQmVzaWRlcyB0aGUgb2J2 aW91cyBwcm9ibGVtIHRoaXMKKyAgICAgICAgaXMgYWxzbyBhIHBlcmZvcm1hbmNlIGlzc3VlIGFz IHZhcmlvdXMgZm9udCBjYWNoZXMgaW5jbHVkZSB0aGlzIHNldHRpbmcgaW4gdGhlIGtleS4KKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ZvbnREZXNjcmlwdGlvbi5jcHA6CisgICAgICAg IChXZWJDb3JlOjptX3Nob3VsZEFsbG93VXNlckluc3RhbGxlZEZvbnRzKToKKworICAgICAgICBJ bml0aWFsaXplIHRvICdObycgYnkgZGVmYXVsdC4gQWxsIHBhdGhzIHdoZXJlIHVzZXIgZm9udHMg bWFrZSBzZW5zZSBhbHJlYWR5IHNldCB0aGUgYml0IGZyb20KKyAgICAgICAgc2V0dGluZ3MuIFRo aXMgZml4ZXMgc29tZSBjYXNlcyBpbnN5c3RlbSB0aGVtZXMgdGhhdCBjb25zdHJ1Y3QgRm9udERl c2NyaXB0aW9ucyBmcm9tIHNjcmF0Y2guCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRWxl bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJFbGVtZW50OjpzdHlsZVdpbGxDaGFu Z2UpOgorCisgICAgICAgIEFkZCBhc3NlcnRpb24uIFRoaXMgdmVyaWZpZWQgdGhlIGNoYW5nZSB3 aXRoIHRoZSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHN2Zy9ncmFwaGljcy9TVkdJbWFn ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdJbWFnZTo6ZGF0YUNoYW5nZWQpOgorCisgICAg ICAgIEFsd2F5cyBkaXNhbGxvdyB1c2VyIGZvbnRzIGluIFNWRyB1c2VkIGFzIGltYWdlcy4KKwog MjAxOC0xMC0wMiAgQWxpY2lhIEJveWEgR2FyY8OtYSAgPGFib3lhQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW01TRV1bR1N0cmVhbWVyXSBBZGQgaDI2NHBhcnNlIHRvIGFjY2VwdCBNUDQgd2l0aG91 dCBzdHNzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250RGVzY3Jp cHRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L0ZvbnREZXNjcmlwdGlvbi5jcHAJKHJldmlzaW9uIDIzNjY1NykKKysrIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnREZXNjcmlwdGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTgwLDcgKzgwLDcgQEAgRm9udERlc2NyaXB0aW9uOjpGb250RGVzY3JpcHRpb24oKQogICAgICwg bV92YXJpYW50RWFzdEFzaWFuUnVieShzdGF0aWNfY2FzdDx1bnNpZ25lZD4oRm9udFZhcmlhbnRF YXN0QXNpYW5SdWJ5OjpOb3JtYWwpKQogICAgICwgbV9vcHRpY2FsU2l6aW5nKHN0YXRpY19jYXN0 PHVuc2lnbmVkPihGb250T3B0aWNhbFNpemluZzo6RW5hYmxlZCkpCiAgICAgLCBtX2ZvbnRTdHls ZUF4aXMoRm9udENhc2NhZGVEZXNjcmlwdGlvbjo6aW5pdGlhbEZvbnRTdHlsZUF4aXMoKSA9PSBG b250U3R5bGVBeGlzOjppdGFsKQotICAgICwgbV9zaG91bGRBbGxvd1VzZXJJbnN0YWxsZWRGb250 cyhzdGF0aWNfY2FzdDx1bnNpZ25lZD4oQWxsb3dVc2VySW5zdGFsbGVkRm9udHM6OlllcykpCisg ICAgLCBtX3Nob3VsZEFsbG93VXNlckluc3RhbGxlZEZvbnRzKHN0YXRpY19jYXN0PHVuc2lnbmVk PihBbGxvd1VzZXJJbnN0YWxsZWRGb250czo6Tm8pKQogewogfQogCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3BwCShyZXZpc2lvbiAyMzY2NTcpCisrKyBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTcwMSw2ICs3MDEsOCBAQCB2b2lkIFJlbmRlckVsZW1lbnQ6OmludmFsaWRhdGVDYWNoZWRG aXJzCiAKIHZvaWQgUmVuZGVyRWxlbWVudDo6c3R5bGVXaWxsQ2hhbmdlKFN0eWxlRGlmZmVyZW5j ZSBkaWZmLCBjb25zdCBSZW5kZXJTdHlsZSYgbmV3U3R5bGUpCiB7CisgICAgQVNTRVJUKHNldHRp bmdzKCkuc2hvdWxkQWxsb3dVc2VySW5zdGFsbGVkRm9udHMoKSB8fCBuZXdTdHlsZS5mb250RGVz Y3JpcHRpb24oKS5zaG91bGRBbGxvd1VzZXJJbnN0YWxsZWRGb250cygpID09IEFsbG93VXNlcklu c3RhbGxlZEZvbnRzOjpObyk7CisKICAgICBhdXRvKiBvbGRTdHlsZSA9IGhhc0luaXRpYWxpemVk U3R5bGUoKSA/ICZzdHlsZSgpIDogbnVsbHB0cjsKICAgICBpZiAob2xkU3R5bGUpIHsKICAgICAg ICAgLy8gSWYgb3VyIHotaW5kZXggY2hhbmdlcyB2YWx1ZSBvciBvdXIgdmlzaWJpbGl0eSBjaGFu Z2VzLApJbmRleDogU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR0ltYWdlLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvU1ZHSW1hZ2UuY3BwCShyZXZp c2lvbiAyMzY2NTcpCisrKyBTb3VyY2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvU1ZHSW1hZ2UuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC00NzQsNiArNDc0LDcgQEAgRW5jb2RlZERhdGFTdGF0dXMgU1ZH SW1hZ2U6OmRhdGFDaGFuZ2VkKAogICAgICAgICBtX3BhZ2UtPnNldHRpbmdzKCkuc2V0U2NyaXB0 RW5hYmxlZChmYWxzZSk7CiAgICAgICAgIG1fcGFnZS0+c2V0dGluZ3MoKS5zZXRQbHVnaW5zRW5h YmxlZChmYWxzZSk7CiAgICAgICAgIG1fcGFnZS0+c2V0dGluZ3MoKS5zZXRBY2NlbGVyYXRlZENv bXBvc2l0aW5nRW5hYmxlZChmYWxzZSk7CisgICAgICAgIG1fcGFnZS0+c2V0dGluZ3MoKS5zZXRT aG91bGRBbGxvd1VzZXJJbnN0YWxsZWRGb250cyhmYWxzZSk7CiAKICAgICAgICAgRnJhbWUmIGZy YW1lID0gbV9wYWdlLT5tYWluRnJhbWUoKTsKICAgICAgICAgZnJhbWUuc2V0VmlldyhGcmFtZVZp ZXc6OmNyZWF0ZShmcmFtZSkpOwo= 351373 2018-10-02 05:27:14 -0700 2018-10-02 11:31:45 -0700 patch user-font-disable-2.patch text/plain 3498 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNjczNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDE4LTEwLTAyICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBVc2VyIGluc3RhbGxlZCBmb250 cyBhcmUgbm90IGFsd2F5cyBkaXNhYmxlZCB3aGVuIHRoZXkgc2hvdWxkIGJlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTAxOTUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTVkcgaW1hZ2VzIGFuZCBzb21l IHRoZW1lIGNhc2VzIGZhaWwgdG8gcmVzcGVjdCB0aGUgc2V0dGluZy4gQmVzaWRlcyB0aGUgb2J2 aW91cyBwcm9ibGVtIHRoaXMKKyAgICAgICAgaXMgYWxzbyBhIHBlcmZvcm1hbmNlIGlzc3VlIGFz IHZhcmlvdXMgZm9udCBjYWNoZXMgaW5jbHVkZSB0aGlzIHNldHRpbmcgaW4gdGhlIGtleS4KKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ZvbnREZXNjcmlwdGlvbi5jcHA6CisgICAgICAg IChXZWJDb3JlOjptX3Nob3VsZEFsbG93VXNlckluc3RhbGxlZEZvbnRzKToKKworICAgICAgICBJ bml0aWFsaXplIHRvICdObycgYnkgZGVmYXVsdC4gQWxsIHBhdGhzIHdoZXJlIHVzZXIgZm9udHMg bWFrZSBzZW5zZSBhbHJlYWR5IHNldCB0aGUgYml0IGZyb20KKyAgICAgICAgc2V0dGluZ3MuIFRo aXMgZml4ZXMgc29tZSBjYXNlcyBpbiBzeXN0ZW0gdGhlbWVzIHRoYXQgY29uc3RydWN0IEZvbnRE ZXNjcmlwdGlvbnMgZnJvbSBzY3JhdGNoLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckVs ZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRWxlbWVudDo6c3R5bGVXaWxsQ2hh bmdlKToKKworICAgICAgICBBZGQgYXNzZXJ0aW9uLiBUaGlzIHZlcmlmaWVkIHRoZSBjaGFuZ2Ug d2l0aCB0aGUgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBzdmcvZ3JhcGhpY3MvU1ZHSW1h Z2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHSW1hZ2U6OmRhdGFDaGFuZ2VkKToKKworICAg ICAgICBBbHdheXMgZGlzYWxsb3cgdXNlciBmb250cyBpbiBTVkcgdXNlZCBhcyBpbWFnZXMuCisK IDIwMTgtMTAtMDIgIEFsaWNpYSBCb3lhIEdhcmPDrWEgIDxhYm95YUBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtNU0VdW0dTdHJlYW1lcl0gQWRkIGgyNjRwYXJzZSB0byBhY2NlcHQgTVA0IHdpdGhv dXQgc3RzcwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udERlc2Ny aXB0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9Gb250RGVzY3JpcHRpb24uY3BwCShyZXZpc2lvbiAyMzY2NTcpCisrKyBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250RGVzY3JpcHRpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBA IC04MCw3ICs4MCw3IEBAIEZvbnREZXNjcmlwdGlvbjo6Rm9udERlc2NyaXB0aW9uKCkKICAgICAs IG1fdmFyaWFudEVhc3RBc2lhblJ1Ynkoc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KEZvbnRWYXJpYW50 RWFzdEFzaWFuUnVieTo6Tm9ybWFsKSkKICAgICAsIG1fb3B0aWNhbFNpemluZyhzdGF0aWNfY2Fz dDx1bnNpZ25lZD4oRm9udE9wdGljYWxTaXppbmc6OkVuYWJsZWQpKQogICAgICwgbV9mb250U3R5 bGVBeGlzKEZvbnRDYXNjYWRlRGVzY3JpcHRpb246OmluaXRpYWxGb250U3R5bGVBeGlzKCkgPT0g Rm9udFN0eWxlQXhpczo6aXRhbCkKLSAgICAsIG1fc2hvdWxkQWxsb3dVc2VySW5zdGFsbGVkRm9u dHMoc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KEFsbG93VXNlckluc3RhbGxlZEZvbnRzOjpZZXMpKQor ICAgICwgbV9zaG91bGRBbGxvd1VzZXJJbnN0YWxsZWRGb250cyhzdGF0aWNfY2FzdDx1bnNpZ25l ZD4oQWxsb3dVc2VySW5zdGFsbGVkRm9udHM6Ok5vKSkKIHsKIH0KIApJbmRleDogU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJFbGVtZW50LmNwcAkocmV2aXNpb24gMjM2NjU3KQorKysg U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC03MDEsNiArNzAxLDggQEAgdm9pZCBSZW5kZXJFbGVtZW50OjppbnZhbGlkYXRlQ2FjaGVk RmlycwogCiB2b2lkIFJlbmRlckVsZW1lbnQ6OnN0eWxlV2lsbENoYW5nZShTdHlsZURpZmZlcmVu Y2UgZGlmZiwgY29uc3QgUmVuZGVyU3R5bGUmIG5ld1N0eWxlKQogeworICAgIEFTU0VSVChzZXR0 aW5ncygpLnNob3VsZEFsbG93VXNlckluc3RhbGxlZEZvbnRzKCkgfHwgbmV3U3R5bGUuZm9udERl c2NyaXB0aW9uKCkuc2hvdWxkQWxsb3dVc2VySW5zdGFsbGVkRm9udHMoKSA9PSBBbGxvd1VzZXJJ bnN0YWxsZWRGb250czo6Tm8pOworCiAgICAgYXV0byogb2xkU3R5bGUgPSBoYXNJbml0aWFsaXpl ZFN0eWxlKCkgPyAmc3R5bGUoKSA6IG51bGxwdHI7CiAgICAgaWYgKG9sZFN0eWxlKSB7CiAgICAg ICAgIC8vIElmIG91ciB6LWluZGV4IGNoYW5nZXMgdmFsdWUgb3Igb3VyIHZpc2liaWxpdHkgY2hh bmdlcywKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3N2Zy9ncmFwaGljcy9TVkdJbWFnZS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR0ltYWdlLmNwcAkocmV2 aXNpb24gMjM2NjU3KQorKysgU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR0ltYWdlLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNDc0LDYgKzQ3NCw3IEBAIEVuY29kZWREYXRhU3RhdHVzIFNW R0ltYWdlOjpkYXRhQ2hhbmdlZCgKICAgICAgICAgbV9wYWdlLT5zZXR0aW5ncygpLnNldFNjcmlw dEVuYWJsZWQoZmFsc2UpOwogICAgICAgICBtX3BhZ2UtPnNldHRpbmdzKCkuc2V0UGx1Z2luc0Vu YWJsZWQoZmFsc2UpOwogICAgICAgICBtX3BhZ2UtPnNldHRpbmdzKCkuc2V0QWNjZWxlcmF0ZWRD b21wb3NpdGluZ0VuYWJsZWQoZmFsc2UpOworICAgICAgICBtX3BhZ2UtPnNldHRpbmdzKCkuc2V0 U2hvdWxkQWxsb3dVc2VySW5zdGFsbGVkRm9udHMoZmFsc2UpOwogCiAgICAgICAgIEZyYW1lJiBm cmFtZSA9IG1fcGFnZS0+bWFpbkZyYW1lKCk7CiAgICAgICAgIGZyYW1lLnNldFZpZXcoRnJhbWVW aWV3OjpjcmVhdGUoZnJhbWUpKTsK