190191 2018-10-02 01:05:57 -0700 [JSCOnly Add an armv7 JSCOnly EWS that runs tests 2018-10-17 08:52:28 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 190190 1 guijemont webkit-unassigned aakash_jain abarth commit-queue eric ews-watchlist glenn guijemont+jsc-armv7-ews lforschler mcatanzaro webkit-bug-importer oldest_to_newest 1465436 0 guijemont 2018-10-02 01:05:57 -0700 We need to have an EWS for armv7 that runs the jsc tests. For this to happen, we will need to solve these two issues first: - #190189 [JSCOnly] Add an armv7 JSCOnly build-only EWS - #190190 Allow run-javascriptcore-tests to distribute tests between devices 1466381 1 351597 guijemont 2018-10-04 09:46:12 -0700 Created attachment 351597 Patch WIP patch for early review, not to be committed as I am still working on preparing the bot. 1466382 2 guijemont 2018-10-04 09:46:38 -0700 (In reply to Guillaume Emont from comment #1) > Created attachment 351597 [details] > Patch > > WIP patch for early review, not to be committed as I am still working on > preparing the bot. Also, this will need #190190 to be fixed to have a chance to work. 1467698 3 guijemont 2018-10-10 06:19:05 -0700 *** Bug 190189 has been marked as a duplicate of this bug. *** 1467699 4 351597 commit-queue 2018-10-10 06:33:10 -0700 Comment on attachment 351597 Patch Clearing flags on attachment: 351597 Committed r237001: <https://trac.webkit.org/changeset/237001> 1467700 5 commit-queue 2018-10-10 06:33:12 -0700 All reviewed patches have been landed. Closing bug. 1467701 6 webkit-bug-importer 2018-10-10 06:34:26 -0700 <rdar://problem/45158858> 1467711 7 guijemont 2018-10-10 07:27:08 -0700 Reading a little late that I was supposed[1] to add people to the bug ...oops! Does either of you need to do some manual operation to enable the bot, or did I forget something in the patch? The ews seems to be running on the builder, but never gets patches to process: 2018-10-10 07:23:28,109 - Fetching next work item for jsc-armv7-ews 2018-10-10 07:23:28,838 - No work item. Sleeping until 2018-10-10 07:25:28 (120 seconds). Meanwhile this EWS does not appear on https://webkit-queues.webkit.org/ or on test bubbles (tried with Bug 190428 ). [1] https://trac.webkit.org/wiki/EWS 1468354 8 lforschler 2018-10-11 21:40:30 -0700 Aakash, do you need to restart the ews server? 1468449 9 aakash_jain 2018-10-12 09:27:43 -0700 (In reply to Lucas Forschler from comment #8) > Aakash, do you need to restart the ews server? Yes, Restarted it. The change is now live: https://webkit-queues.webkit.org/queue-status/jsc-armv7-ews 1468457 10 guijemont 2018-10-12 09:51:21 -0700 New issue (log from bot): 2018-10-12 09:39:26,014 - Running: webkit-patch --status-host=webkit-queues.webkit.org --bot-id=igalia-jsc-armv7-ews apply-attachment --no-update --non-interac tive 352173 --port=jsc-only 2018-10-12 09:47:42,032 - Failed to run "['/home/buildbot/ews/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=igalia-js c-armv7-ews', 'apply-attachment', '--no-update', '--non-interactive', 352173, '--port=jsc-only']" exit_code: 1 cwd: /home/buildbot/ews/WebKit No handlers could be found for logger "webkitpy.common.system.user" Logging in as guijemont+jsc-armv7-ews@igalia.com... Received URLError: "unknown url type: https" while loading https://bugs.webkit.org/index.cgi?GoAheadAndLogIn=1. Retrying in 10 seconds... Received URLError: "unknown url type: https" while loading https://bugs.webkit.org/index.cgi?GoAheadAndLogIn=1. Retrying in 15.0 seconds... Received URLError: "unknown url type: https" while loading https://bugs.webkit.org/index.cgi?GoAheadAndLogIn=1. Retrying in 22.5 seconds... Received URLError: "unknown url type: https" while loading https://bugs.webkit.org/index.cgi?GoAheadAndLogIn=1. Retrying in 33.75 seconds... Received URLError: "unknown url type: https" while loading https://bugs.webkit.org/index.cgi?GoAheadAndLogIn=1. Retrying in 50.625 seconds... Received URLError: "unknown url type: https" while loading https://bugs.webkit.org/index.cgi?GoAheadAndLogIn=1. Retrying in 75.9375 seconds... Received URLError: "unknown url type: https" while loading https://bugs.webkit.org/index.cgi?GoAheadAndLogIn=1. Retrying in 113.90625 seconds... Received URLError: "unknown url type: https" while loading https://bugs.webkit.org/index.cgi?GoAheadAndLogIn=1. Retrying in 170.859375 seconds... Traceback (most recent call last): File "/home/buildbot/ews/WebKit/Tools/Scripts/webkit-patch", line 84, in <module> main() File "/home/buildbot/ews/WebKit/Tools/Scripts/webkit-patch", line 79, in main WebKitPatch(os.path.abspath(__file__)).main() File "/home/buildbot/ews/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/home/buildbot/ews/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/home/buildbot/ews/WebKit/Tools/Scripts/webkitpy/tool/commands/download.py", line 180, in execute patches = self._fetch_list_of_patches_to_process(options, args, tool) File "/home/buildbot/ews/WebKit/Tools/Scripts/webkitpy/tool/commands/download.py", line 224, in _fetch_list_of_patches_to_process patch = tool.bugs.fetch_attachment(patch_id, throw_on_access_error=True) File "/home/buildbot/ews/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 552, in fetch_attachment bug_id = self.bug_id_for_attachment_id(attachment_id, throw_on_access_error) File "/home/buildbot/ews/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 530, in bug_id_for_attachment_id return NetworkTransaction().run(lambda: self.get_bug_id_for_attachment_id(attachment_id, throw_on_access_error)) File "/home/buildbot/ews/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction.py", line 53, in run return request() File "/home/buildbot/ews/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 530, in <lambda> return NetworkTransaction().run(lambda: self.get_bug_id_for_attachment_id(attachment_id, throw_on_access_error)) File "/home/buildbot/ews/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 533, in get_bug_id_for_attachment_id self.authenticate() File "/home/buildbot/ews/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 576, in authenticate "index.cgi?GoAheadAndLogIn=1") File "/home/buildbot/ews/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 335, in open_url return NetworkTransaction().run(lambda: self.browser.open(url), url) File "/home/buildbot/ews/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction.py", line 61, in run self._check_for_timeout() File "/home/buildbot/ews/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction.py", line 67, in _check_for_timeout raise NetworkTimeout() webkitpy.common.net.networktransaction.NetworkTimeout: NetworkTimeout 2018-10-12 09:47:42,033 - Patch does not apply 2018-10-12 09:47:43,757 - Error: jsc-armv7-ews unable to apply patch. 2018-10-12 09:47:45,175 - Releasing work item 352173 from jsc-armv7-ews 1468458 11 guijemont 2018-10-12 09:52:18 -0700 (In reply to Guillaume Emont from comment #10) > New issue (log from bot): Actually visible in https://webkit-queues.webkit.org/results/9552471 1468464 12 guijemont+jsc-armv7-ews 2018-10-12 10:03:38 -0700 Double checked, and the credentials in .git/config seem correct for the account guijemont+jsc-armv7-ews@igalia.com 1468466 13 aakash_jain 2018-10-12 10:07:28 -0700 > Actually visible in https://webkit-queues.webkit.org/results/9552471 Need to debug. Might be related to: https://bugs.webkit.org/show_bug.cgi?id=187061 Also, please make sure that this bot(igalia-jsc-armv7-ews) can actually communicate with Bugzilla? (ping, curl etc.) 1468471 14 guijemont+jsc-armv7-ews 2018-10-12 10:13:19 -0700 (In reply to Aakash Jain from comment #13) > > Actually visible in https://webkit-queues.webkit.org/results/9552471 > > Need to debug. Might be related to: > https://bugs.webkit.org/show_bug.cgi?id=187061 > > Also, please make sure that this bot(igalia-jsc-armv7-ews) can actually > communicate with Bugzilla? (ping, curl etc.) Yes, I can wget https://bugs.webkit.org/index.cgi?GoAheadAndLogIn=1 from the host no problem. Looking at this bug and if there is any issue with our python install. 1468482 15 guijemont+jsc-armv7-ews 2018-10-12 10:38:10 -0700 (In reply to Guillaume Emont (jsc-armv7-ews) from comment #14) Manually running this works fine on the host FWIW: urllib2.urlopen("https://bugs.webkit.org/index.cgi?GoAheadAndLogIn=1").read() 1468484 16 guijemont+jsc-armv7-ews 2018-10-12 10:42:27 -0700 (In reply to Guillaume Emont (jsc-armv7-ews) from comment #15) > (In reply to Guillaume Emont (jsc-armv7-ews) from comment #14) > Manually running this works fine on the host FWIW: > > urllib2.urlopen("https://bugs.webkit.org/index.cgi?GoAheadAndLogIn=1").read() Oops. We have another python in the PATH, that is part of the buildroot "host" image used to generate the toolchain. This python indeed fails when trying the above, so I guess the script ends up using the wrong python (it is before in the path). I'll see what I can do about that. 1468510 17 guijemont+jsc-armv7-ews 2018-10-12 11:43:44 -0700 Changing the order of things in PATH seems to have fixed the python issue. Now to the next issue: https://webkit-queues.webkit.org/results/9553802 1468517 18 aakash_jain 2018-10-12 11:58:58 -0700 (In reply to Guillaume Emont (jsc-armv7-ews) from comment #17) > Changing the order of things in PATH seems to have fixed the python issue. > Now to the next issue: https://webkit-queues.webkit.org/results/9553802 Can you manually run this command on the bot and see if that works? ['/home/buildbot/ews/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=igalia-jsc-armv7-ews', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive', '--build-style=release', u'--group=jsc', '--port=jsc-only'] Also please run without 'u' to check if the unicode in u'--group=jsc' is causing any issues. 1468518 19 guijemont+jsc-armv7-ews 2018-10-12 12:00:52 -0700 manually added --jsc-only as a parameter in the run script, though I suspect I shouldn't have to. It is now building its first patch. 1468569 20 guijemont+jsc-armv7-ews 2018-10-12 14:20:13 -0700 (In reply to Guillaume Emont (jsc-armv7-ews) from comment #19) > manually added --jsc-only as a parameter in the run script, though I suspect > I shouldn't have to. It is now building its first patch. And the bug we have now is that my dealing of JSCTESTS_OPTIONS is not correct, I should split the arguments into a list. Patch upcoming 1468742 21 guijemont 2018-10-12 17:50:02 -0700 (In reply to Guillaume Emont (jsc-armv7-ews) from comment #20) > (In reply to Guillaume Emont (jsc-armv7-ews) from comment #19) > > manually added --jsc-only as a parameter in the run script, though I suspect > > I shouldn't have to. It is now building its first patch. > > And the bug we have now is that my dealing of JSCTESTS_OPTIONS is not > correct, I should split the arguments into a list. Patch upcoming Patch went to Bug 190537. Now I need to understand the weird build errors that I can't reproduce outside of the EWS, such as https://webkit-queues.webkit.org/results/9559484 1470115 22 guijemont 2018-10-17 08:52:28 -0700 EWS seems to be running fine now. I might have found an issue (Bug 190662) while debugging it though. 351597 2018-10-04 09:46:12 -0700 2018-10-10 06:33:10 -0700 Patch bug-190191-20181004184611.patch text/plain 3624 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NzE2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzg4YzUxZmVlOTgyNTA4ZGIwNjQ5ZDUyMmYyNzZiMGQw YTJmYzFiMS4uZWFiYmIwODQyNGFiODJmOGVlOGFhNjZiZjdmODg2ZmVhYmUzOWQxMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDE4LTEwLTA0ICBHdWlsbGF1bWUgRW1vbnQgIDxndWlqZW1vbnRAaWdhbGlhLmNvbT4K KworICAgICAgICBbSlNDT25seSBBZGQgYW4gYXJtdjcgSlNDT25seSBFV1MgdGhhdCBydW5zIHRl c3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTAx OTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFF1 ZXVlU3RhdHVzU2VydmVyL2NvbmZpZy9xdWV1ZXMucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9jb21tb24vY29uZmlnL2V3cy5qc29uOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv Y29tbW9uL2NvbmZpZy9wb3J0cy5weToKKyAgICAgICAgKERlcHJlY2F0ZWRQb3J0LnJ1bl9qYXZh c2NyaXB0Y29yZV90ZXN0c19jb21tYW5kKToKKyAgICAgICAgQWRkIHRoZSBwb3NzaWJpbGl0eSB0 byBwYXNzIGFyZ3VtZW50cyB0byBydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMgd2l0aAorICAgICAg ICB0aGUgSlNDVEVTVFNfT1BUSU9OUyBlbnZpcm9ubWVudCB2YXJpYWJsZQorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW1fdW5pdHRlc3Qu cHk6CisgICAgICAgICh0ZXN0X2V3c19uYW1lKToKKworCiAyMDE4LTEwLTAxICBSb3NzIEtpcnNs aW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBbV2luXVtEUlRdIEFjdHVh bGx5IHNldCAiZXhwZXJpbWVudGFsOldlYkFuaW1hdGlvbnNDU1NJbnRlZ3JhdGlvbkVuYWJsZWQi IHdoZW4gcmVxdWVzdGVkCmRpZmYgLS1naXQgYS9Ub29scy9RdWV1ZVN0YXR1c1NlcnZlci9jb25m aWcvcXVldWVzLnB5IGIvVG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvY29uZmlnL3F1ZXVlcy5weQpp bmRleCBlNDkyODdhYjczZmE4ZjdmOWViYjEzMGY1OGVhNTg4NGQ0YjRmZmE0Li5lN2RiYzEyMzRl M2VmNjQyZjBlZmUwZjFiOWE1OWQ0MDVlMGU2YmEwIDEwMDY0NAotLS0gYS9Ub29scy9RdWV1ZVN0 YXR1c1NlcnZlci9jb25maWcvcXVldWVzLnB5CisrKyBiL1Rvb2xzL1F1ZXVlU3RhdHVzU2VydmVy L2NvbmZpZy9xdWV1ZXMucHkKQEAgLTM5LDYgKzM5LDcgQEAgYWxsX3F1ZXVlX25hbWVzID0gWwog ICAgICJiaW5kaW5ncy1ld3MiLAogICAgICJqc2MtZXdzIiwKICAgICAianNjLW1pcHMtZXdzIiwK KyAgICAianNjLWFybXY3LWV3cyIsCiAgICAgIm1hYy1ld3MiLAogICAgICJtYWMtd2syLWV3cyIs CiAgICAgIm1hYy1kZWJ1Zy1ld3MiLApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9jb21tb24vY29uZmlnL2V3cy5qc29uIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v Y29uZmlnL2V3cy5qc29uCmluZGV4IDM3MWIxYTQwM2VlMjc5NTU0OWY3ZGVkMjkxMzUzNzRlNDg2 NGRmMjQuLjdiNDM3Yzg3ZmFkNmI1OGMzNmRiNDMxN2M3ZDEzOTYwMWJkNzM0MTggMTAwNjQ0Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9ld3MuanNvbgorKysgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvZXdzLmpzb24KQEAgLTYyLDYgKzYy LDE1IEBACiAgICAgICAgICAgICAiZ3VpamVtb250QGlnYWxpYS5jb20iCiAgICAgICAgIF0KICAg ICB9LAorICAgICJKU0MgQXJtdjcgRVdTIjogeworICAgICAgICAicG9ydCI6ICJqc2Mtb25seSIs CisgICAgICAgICJuYW1lIjogImpzYy1hcm12Ny1ld3MiLAorICAgICAgICAiZ3JvdXAiOiAianNj IiwKKyAgICAgICAgInJ1blRlc3RzIjogdHJ1ZSwKKyAgICAgICAgIndhdGNoZXJzIjogWworICAg ICAgICAgICAgImd1aWplbW9udEBpZ2FsaWEuY29tIgorICAgICAgICBdCisgICAgfSwKICAgICAi QmluZGluZ3MgRVdTIjogewogICAgICAgICAicG9ydCI6ICJtYWMiLAogICAgICAgICAibmFtZSI6 ICJiaW5kaW5ncy1ld3MiLApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21t b24vY29uZmlnL3BvcnRzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmln L3BvcnRzLnB5CmluZGV4IDI0YTc3ZTQ2MGM5MzE0NmUwMzcxODY2ZmFkZmUxOTdkMGM1ZDljZjEu LjNiM2VjMjNhNDJiMzkwMjRjNzFiZWY4MDY1OTFjYmUyNjUxNWQxODAgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9wb3J0cy5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvcG9ydHMucHkKQEAgLTExNiw2ICsxMTYsOCBA QCBjbGFzcyBEZXByZWNhdGVkUG9ydChvYmplY3QpOgogICAgIGRlZiBydW5famF2YXNjcmlwdGNv cmVfdGVzdHNfY29tbWFuZChzZWxmLCBidWlsZF9zdHlsZT1Ob25lKToKICAgICAgICAgY29tbWFu ZCA9IHNlbGYuc2NyaXB0X3NoZWxsX2NvbW1hbmQoInJ1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cyIp CiAgICAgICAgIGNvbW1hbmQuYXBwZW5kKCItLW5vLWZhaWwtZmFzdCIpCisgICAgICAgIGlmICdK U0NURVNUU19PUFRJT05TJyBpbiBvcy5lbnZpcm9uOgorICAgICAgICAgICAgY29tbWFuZC5hcHBl bmQob3MuZW52aXJvblsnSlNDVEVTVFNfT1BUSU9OUyddKQogICAgICAgICByZXR1cm4gc2VsZi5f YXBwZW5kX2J1aWxkX3N0eWxlX2ZsYWcoY29tbWFuZCwgYnVpbGRfc3R5bGUpCiAKICAgICBkZWYg cnVuX3dlYmtpdF90ZXN0c19jb21tYW5kKHNlbGYsIGJ1aWxkX3N0eWxlPU5vbmUpOgpkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5 c3RlbV91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9l YXJseXdhcm5pbmdzeXN0ZW1fdW5pdHRlc3QucHkKaW5kZXggYmIyYjA3MTkwMTM5NmYzYWRkNjFk MWIzMjU4ZmEzNjY0NjFjN2U5Ny4uOTE3MDRkZjU1OTg5OWQ2YTFhYzc2OWQxZjI1MmU1ODRjOWI2 OGQwMyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vh cmx5d2FybmluZ3N5c3RlbV91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtX3VuaXR0ZXN0LnB5CkBAIC0yMTMsNiAr MjEzLDcgQEAgTU9DSzogdXBkYXRlX3N0YXR1czogJShuYW1lKXMgQ2hlY2tlZCByZWxldmFuY2Ug b2YgcGF0Y2gKICAgICAgICAgICAgICdpb3Mtc2ltLWV3cycsCiAgICAgICAgICAgICAnanNjLWV3 cycsCiAgICAgICAgICAgICAnanNjLW1pcHMtZXdzJywKKyAgICAgICAgICAgICdqc2MtYXJtdjct ZXdzJywKICAgICAgICAgICAgICdtYWMtMzJiaXQtZXdzJywKICAgICAgICAgICAgICdtYWMtZGVi dWctZXdzJywKICAgICAgICAgICAgICdtYWMtZXdzJywK