190178 2018-10-01 17:12:38 -0700 Add release assertion to ensure m_owningPointerForClose is null in UniqueIDBDatabase::invokeOperationAndTransactionTimer() 2018-10-02 09:47:32 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu achristensen alecflett beidson cdumez commit-queue ews-watchlist jsbell webkit-bug-importer oldest_to_newest 1465320 0 sihui_liu 2018-10-01 17:12:38 -0700 As in rdar://problem/44902833, RELEASE_ASSERT(!m_owningPointerForClose) in UniqueIDBDatabase::scheduleShutdownForClose() frequently gets hit, which means m_owningPointerForClose is already acquired for close and we should not reach scheduleShutdownForClose. Since scheduleShutdownForClose() is fired on timer, it's hard to tell which function dispatches it a second time from the crash log. The added release assertions in the invoke function should help reveal the probblematic code path. 1465323 1 351325 sihui_liu 2018-10-01 17:17:17 -0700 Created attachment 351325 Patch 1465579 2 351325 cdumez 2018-10-02 08:57:44 -0700 Comment on attachment 351325 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351325&action=review > Source/WebCore/ChangeLog:8 > + This would help debug rdar://problem/44902833. How? I do not think we report to the user Network process crashes so they are unlikely to file a radar with reproduction case (since they won't know about the crash). 1465593 3 351325 cdumez 2018-10-02 09:18:20 -0700 Comment on attachment 351325 Patch Never mind. Getting the automated crash reports will suffice. 1465610 4 351325 commit-queue 2018-10-02 09:46:13 -0700 Comment on attachment 351325 Patch Clearing flags on attachment: 351325 Committed r236747: <https://trac.webkit.org/changeset/236747> 1465611 5 commit-queue 2018-10-02 09:46:14 -0700 All reviewed patches have been landed. Closing bug. 1465615 6 webkit-bug-importer 2018-10-02 09:47:32 -0700 <rdar://problem/44941165> 351325 2018-10-01 17:17:17 -0700 2018-10-02 09:46:13 -0700 Patch bug-190178-20181001171716.patch text/plain 1776 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2Njk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQyZmYwMTRhMDhhMWQw MmFlMDNlMjc0ZDNjOGE1ODIxOGExN2U4My4uNGQwOTVlNzZlMDBiZmY4M2NhZTA3OTQ5OTZjMzQ5 MjA4MjFmOWJjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTEwLTAxICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCByZWxlYXNlIGFzc2Vy dGlvbiB0byBlbnN1cmUgbV9vd25pbmdQb2ludGVyRm9yQ2xvc2UgaXMgbnVsbCBpbiBVbmlxdWVJ REJEYXRhYmFzZTo6aW52b2tlT3BlcmF0aW9uQW5kVHJhbnNhY3Rpb25UaW1lcigpCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTAxNzgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHdvdWxkIGhlbHAg ZGVidWcgcmRhcjovL3Byb2JsZW0vNDQ5MDI4MzMuCisKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4 ZWRkYi9zZXJ2ZXIvVW5pcXVlSURCRGF0YWJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURC U2VydmVyOjpVbmlxdWVJREJEYXRhYmFzZTo6aW52b2tlT3BlcmF0aW9uQW5kVHJhbnNhY3Rpb25U aW1lcik6CisKIDIwMTgtMTAtMDEgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgog CiAgICAgICAgIEF0dGVtcHQgdG8gZml4IHRoZSB3YXRjaE9TIGJ1aWxkIGFmdGVyIDxodHRwczov L3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMjM2Njc4PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL1VuaXF1ZUlEQkRhdGFiYXNlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9VbmlxdWVJREJEYXRhYmFzZS5j cHAKaW5kZXggYTRiYmQwMmY1OTkwZTBkNTZkMGEzNDc2OThmYzNkNzk0N2JlZDRmNS4uYTk4NzFk YTMzY2NjNjA1MjU4ZDUwZDMyNDVmMTFjMGRmZThlMWY0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL1VuaXF1ZUlEQkRhdGFiYXNlLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvVW5pcXVlSURCRGF0YWJh c2UuY3BwCkBAIC0xNTMzLDggKzE1MzMsOCBAQCBib29sIFVuaXF1ZUlEQkRhdGFiYXNlOjpoYXNV bmZpbmlzaGVkVHJhbnNhY3Rpb25zKCkgY29uc3QKIHZvaWQgVW5pcXVlSURCRGF0YWJhc2U6Omlu dm9rZU9wZXJhdGlvbkFuZFRyYW5zYWN0aW9uVGltZXIoKQogewogICAgIExPRyhJbmRleGVkREIs ICJVbmlxdWVJREJEYXRhYmFzZTo6aW52b2tlT3BlcmF0aW9uQW5kVHJhbnNhY3Rpb25UaW1lcigp Iik7Ci0gICAgQVNTRVJUKCFtX2hhcmRDbG9zZWRGb3JVc2VyRGVsZXRlKTsKLSAgICBBU1NFUlQo IW1fb3duaW5nUG9pbnRlckZvckNsb3NlKTsKKyAgICBSRUxFQVNFX0FTU0VSVCghbV9oYXJkQ2xv c2VkRm9yVXNlckRlbGV0ZSk7CisgICAgUkVMRUFTRV9BU1NFUlQoIW1fb3duaW5nUG9pbnRlckZv ckNsb3NlKTsKIAogICAgIGlmICghbV9vcGVyYXRpb25BbmRUcmFuc2FjdGlvblRpbWVyLmlzQWN0 aXZlKCkpCiAgICAgICAgIG1fb3BlcmF0aW9uQW5kVHJhbnNhY3Rpb25UaW1lci5zdGFydE9uZVNo b3QoMF9zKTsK