190176 2018-10-01 16:46:20 -0700 REGRESSION: TestWebKitAPI.WKWebView.ProvisionalURLNotChange API test is failing 2018-10-02 14:16:13 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 realdawei cdumez achristensen cdumez commit-queue ggaren lforschler ryanhaddad tsavell webkit-bug-importer oldest_to_newest 1465309 0 realdawei 2018-10-01 16:46:20 -0700 API test TestWebKitAPI.WKWebView.ProvisionalURLNotChange is failing on Mojave (Release and Debug) sample output: https://build.webkit.org/builders/Apple%20Mojave%20Release%20WK2%20(Tests)/builds/59/steps/run-api-tests/logs/stdio TestWebKitAPI.WKWebView.ProvisionalURLNotChange _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL. /Volumes/Data/slave/mojave-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProvisionalURLNotChange.mm:59 Expected equality of these values: [webView URL].absoluteString.UTF8String Which is: "http://www.webkit.org!/" "data:text/html,start" It has been failing since Mojave queues were added to build.webkit.org 1465314 1 webkit-bug-importer 2018-10-01 16:48:32 -0700 <rdar://problem/44925871> 1465681 2 cdumez 2018-10-02 10:54:48 -0700 This test was introduced in http://trac.webkit.org/r184151. It seems we have regressed it and [webView URL].absoluteString.UTF8String can now return an invalid URL. It could also be that we recognize "http://www.webkit.org!/" as a valid URL now. 1465704 3 cdumez 2018-10-02 11:52:23 -0700 It does not reproduce locally for me or Alex. 1465709 4 cdumez 2018-10-02 11:57:46 -0700 "http://www.webkit.org!" is valid URL according to WebKit's URL parser. 1465713 5 351426 cdumez 2018-10-02 12:02:34 -0700 Created attachment 351426 Patch 1465726 6 351426 achristensen 2018-10-02 12:34:24 -0700 Comment on attachment 351426 Patch This is a speculative fix. r=me 1465747 7 351426 commit-queue 2018-10-02 13:44:37 -0700 Comment on attachment 351426 Patch Clearing flags on attachment: 351426 Committed r236764: <https://trac.webkit.org/changeset/236764> 1465748 8 commit-queue 2018-10-02 13:44:39 -0700 All reviewed patches have been landed. Closing bug. 1465757 9 cdumez 2018-10-02 14:16:13 -0700 (In reply to Alex Christensen from comment #6) > Comment on attachment 351426 [details] > Patch > > This is a speculative fix. r=me David confirmed that this speculative fix made the test pass on the bot. 351426 2018-10-02 12:02:34 -0700 2018-10-02 13:44:37 -0700 Patch bug-190176-20181002120233.patch text/plain 1621 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NzUxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzYxOWZhNGI5NjMzNjk0MzhhYTNkZjFjODk5ZGI3YzZl NTgzMzY1OC4uOWQxNTNhNjM2MjIxMzVlMWFlNzg4ZDNjOWFkZDliYmVkZGU1MTMzMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE4LTEwLTAyICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgUkVHUkVTU0lPTjogVGVzdFdlYktpdEFQSS5XS1dlYlZpZXcuUHJvdmlzaW9uYWxVUkxOb3RD aGFuZ2UgQVBJIHRlc3QgaXMgZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMTc2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NDkyNTg3 MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2Ug YSBVUkwgdGhhdCBpcyB0cnVseSByZWNvZ25pemVkIGFzIGludmFsaWQgYnkgV2ViQ29yZSdzIFVS TCBwYXJzZXIuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1By b3Zpc2lvbmFsVVJMTm90Q2hhbmdlLm1tOgorICAgICAgICAoVEVTVCk6CisKIDIwMTgtMTAtMDIg IERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBpT1MgVGVz dFdlYktpdEFQSSBmYWlsdXJlcyBmb2xsb3dpbmcgPGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL2No YW5nZXNldC8yMzY2MTk+CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YktpdENvY29hL1Byb3Zpc2lvbmFsVVJMTm90Q2hhbmdlLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJLaXRDb2NvYS9Qcm92aXNpb25hbFVSTE5vdENoYW5nZS5tbQppbmRleCAyODQw ZjUxMjk2MGUxMjhlMzI4ZGM2Njk0YzM1Y2FiZjc0YWNiOTI5Li5kMTNjMTFkZGY2Zjg3Y2UyOTI1 YTU4MTY4YThjYmMwODc3M2NiNGVkIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYktpdENvY29hL1Byb3Zpc2lvbmFsVVJMTm90Q2hhbmdlLm1tCisrKyBiL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUHJvdmlzaW9uYWxVUkxOb3RDaGFuZ2UubW0K QEAgLTUyLDcgKzUyLDggQEAgVEVTVChXS1dlYlZpZXcsIFByb3Zpc2lvbmFsVVJMTm90Q2hhbmdl KQogICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6OnJ1bigmaXNEb25lKTsKICAgICBpc0RvbmUgPSBm YWxzZTsKIAotICAgIFt3ZWJWaWV3IGxvYWRSZXF1ZXN0OltOU1VSTFJlcXVlc3QgcmVxdWVzdFdp dGhVUkw6W05TVVJMIFVSTFdpdGhTdHJpbmc6QCJodHRwOi8vd3d3LndlYmtpdC5vcmchIl1dXTsK KyAgICBOU1VSTCAqaW52YWxpZFVSTCA9IFtOU1VSTCBVUkxXaXRoU3RyaW5nOkAiaHR0cHM6Ly9h QC9iIl07CisgICAgW3dlYlZpZXcgbG9hZFJlcXVlc3Q6W05TVVJMUmVxdWVzdCByZXF1ZXN0V2l0 aFVSTDppbnZhbGlkVVJMXV07CiAgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6cnVuKCZpc0RvbmUp OwogICAgIGlzRG9uZSA9IGZhbHNlOwogCg==