190153 2018-10-01 12:58:05 -0700 Convert tests to use navigation client 2018-10-04 09:56:46 -0700 1 1 1 Unclassified WebKit Tools / Tests Other PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro achristensen commit-queue lforschler mcatanzaro webkit-bug-importer oldest_to_newest 1465191 0 mcatanzaro 2018-10-01 12:58:05 -0700 [4613/4761] Building CXX object Tools/TestWebKitAPI...r/Tests/WebKit/DownloadDecideDestinationCrash.cpp.o ../../Tools/TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp: In function ‘void TestWebKitAPI::setPagePolicyClient(WKPageRef)’: ../../Tools/TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:69:55: warning: ‘void WKPageSetPagePolicyClient(WKPageRef, const WKPagePolicyClientBase*)’ is deprecated: use WKPageSetPageNavigationClient [-Wdeprecated-declarations] WKPageSetPagePolicyClient(page, &policyClient.base); ^ In file included from DerivedSources/ForwardingHeaders/WebKit/WKPage.h:1, from ../../Source/WebKit/UIProcess/API/C/WebKit2_C.h:53, from DerivedSources/ForwardingHeaders/WebKit/WebKit2_C.h:1, from ../../Tools/TestWebKitAPI/config.h:49, from ../../Tools/TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:26: ../../Source/WebKit/UIProcess/API/C/WKPage.h:229:16: note: declared here WK_EXPORT void WKPageSetPagePolicyClient(WKPageRef page, const WKPagePolicyClientBase* client) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKPageSetPageNavigationClient, macosx(WK_MAC_TBA)); ^~~~~~~~~~~~~~~~~~~~~~~~~ ../../Tools/TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:69:55: warning: ‘void WKPageSetPagePolicyClient(WKPageRef, const WKPagePolicyClientBase*)’ is deprecated: use WKPageSetPageNavigationClient [-Wdeprecated-declarations] WKPageSetPagePolicyClient(page, &policyClient.base); ^ In file included from DerivedSources/ForwardingHeaders/WebKit/WKPage.h:1, from ../../Source/WebKit/UIProcess/API/C/WebKit2_C.h:53, from DerivedSources/ForwardingHeaders/WebKit/WebKit2_C.h:1, from ../../Tools/TestWebKitAPI/config.h:49, from ../../Tools/TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:26: ../../Source/WebKit/UIProcess/API/C/WKPage.h:229:16: note: declared here WK_EXPORT void WKPageSetPagePolicyClient(WKPageRef page, const WKPagePolicyClientBase* client) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKPageSetPageNavigationClient, macosx(WK_MAC_TBA)); ^~~~~~~~~~~~~~~~~~~~~~~~~ [4649/4761] Building CXX object Tools/TestWebKitAPI...it/ProvisionalURLAfterWillSendRequestCallback.cpp.o ../../Tools/TestWebKitAPI/Tests/WebKit/ProvisionalURLAfterWillSendRequestCallback.cpp: In member function ‘virtual void TestWebKitAPI::WebKit2_ProvisionalURLAfterWillSendRequestCallback_Test::TestBody()’: ../../Tools/TestWebKitAPI/Tests/WebKit/ProvisionalURLAfterWillSendRequestCallback.cpp:80:65: warning: ‘void WKPageSetPageLoaderClient(WKPageRef, const WKPageLoaderClientBase*)’ is deprecated: use WKPageSetPageNavigationClient [-Wdeprecated-declarations] WKPageSetPageLoaderClient(webView.page(), &loaderClient.base); ^ In file included from DerivedSources/ForwardingHeaders/WebKit/WKPage.h:1, from ../../Source/WebKit/UIProcess/API/C/WebKit2_C.h:53, from DerivedSources/ForwardingHeaders/WebKit/WebKit2_C.h:1, from ../../Tools/TestWebKitAPI/config.h:49, from ../../Tools/TestWebKitAPI/Tests/WebKit/ProvisionalURLAfterWillSendRequestCallback.cpp:26: ../../Source/WebKit/UIProcess/API/C/WKPage.h:228:16: note: declared here WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, const WKPageLoaderClientBase* client) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKPageSetPageNavigationClient, macosx(WK_MAC_TBA)); ^~~~~~~~~~~~~~~~~~~~~~~~~ ../../Tools/TestWebKitAPI/Tests/WebKit/ProvisionalURLAfterWillSendRequestCallback.cpp:80:65: warning: ‘void WKPageSetPageLoaderClient(WKPageRef, const WKPageLoaderClientBase*)’ is deprecated: use WKPageSetPageNavigationClient [-Wdeprecated-declarations] WKPageSetPageLoaderClient(webView.page(), &loaderClient.base); ^ In file included from DerivedSources/ForwardingHeaders/WebKit/WKPage.h:1, from ../../Source/WebKit/UIProcess/API/C/WebKit2_C.h:53, from DerivedSources/ForwardingHeaders/WebKit/WebKit2_C.h:1, from ../../Tools/TestWebKitAPI/config.h:49, from ../../Tools/TestWebKitAPI/Tests/WebKit/ProvisionalURLAfterWillSendRequestCallback.cpp:26: ../../Source/WebKit/UIProcess/API/C/WKPage.h:228:16: note: declared here WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, const WKPageLoaderClientBase* client) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKPageSetPageNavigationClient, macosx(WK_MAC_TBA)); ^~~~~~~~~~~~~~~~~~~~~~~~~ 1465623 1 mcatanzaro 2018-10-02 09:57:33 -0700 These are all in cross-platform tests. Alex, I guess we should update the tests rather than silencing the warnings. 1465627 2 achristensen 2018-10-02 10:03:25 -0700 Definitely 1466043 3 351515 mcatanzaro 2018-10-03 06:53:48 -0700 Created attachment 351515 Patch 1466385 4 351515 commit-queue 2018-10-04 09:55:56 -0700 Comment on attachment 351515 Patch Clearing flags on attachment: 351515 Committed r236833: <https://trac.webkit.org/changeset/236833> 1466386 5 commit-queue 2018-10-04 09:55:57 -0700 All reviewed patches have been landed. Closing bug. 1466391 6 webkit-bug-importer 2018-10-04 09:56:46 -0700 <rdar://problem/45011949> 351515 2018-10-03 06:53:48 -0700 2018-10-04 09:55:56 -0700 Patch bug-190153-20181003155346.patch text/plain 4505 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2Nzg3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2NjN2Q3NzUwZDM3OTg5OTViODBmOWJlMWU0YTFlMzAz YmQ5NzBmYS4uZDA5ZmEwOTRkZWU2NmNjNzRiMTk3OTc1NjQyMjAwMjE4MjFkM2ZhMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDE4LTEwLTAzICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBDb252ZXJ0IHRlc3RzIHRvIHVzZSBuYXZpZ2F0aW9uIGNsaWVudAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMTUzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29udmVydCB0aGVz ZSB0ZXN0cyBmcm9tIFBhZ2VQb2xpY3lDbGllbnQgYW5kIFBhZ2VMb2FkZXJDbGllbnQgdG8gUGFn ZU5hdmlnYXRpb25DbGllbnQuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktp dC9Eb3dubG9hZERlY2lkZURlc3RpbmF0aW9uQ3Jhc2guY3BwOgorICAgICAgICAoVGVzdFdlYktp dEFQSTo6ZGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbik6CisgICAgICAgIChUZXN0V2Vi S2l0QVBJOjpzZXRQYWdlUG9saWN5Q2xpZW50KToKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYktpdC9Qcm92aXNpb25hbFVSTEFmdGVyV2lsbFNlbmRSZXF1ZXN0Q2FsbGJhY2suY3Bw OgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6ZGlkQ29tbWl0TmF2aWdhdGlvbkNhbGxiYWNrKToK KyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6 ZGlkQ29tbWl0TG9hZEZvckZyYW1lKTogRGVsZXRlZC4KKwogMjAxOC0xMC0wMiAgV2Vuc29uIEhz aWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViS2l0Ml0gRm9ybWF0 ID4gQm9sZCBhbmQgRm9ybWF0ID4gSXRhbGljIGRvbid0IHRvZ2dsZSBiZXR3ZWVuIGJvbGQgYW5k IGl0YWxpYyBzdHlsZQpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXQvRG93bmxvYWREZWNpZGVEZXN0aW5hdGlvbkNyYXNoLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0L0Rvd25sb2FkRGVjaWRlRGVzdGluYXRpb25DcmFzaC5jcHAKaW5kZXgg MTE5MjE2MWIwNWUzZTBiY2U2ODEzOGI1MmFjNGM1ODk4YjgzMDAxZi4uOWIwM2UyZmViODAzNjkx NmE1ZmZkZTc3ZjkzYWE2NGQ1ZjJmNDFjZCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJLaXQvRG93bmxvYWREZWNpZGVEZXN0aW5hdGlvbkNyYXNoLmNwcAorKysgYi9U b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9Eb3dubG9hZERlY2lkZURlc3RpbmF0aW9u Q3Jhc2guY3BwCkBAIC0zNSw3ICszNSw3IEBAIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJIHsKIAog c3RhdGljIGJvb2wgZGlkRGVjaWRlRGVzdGluYXRpb247CiAKLXN0YXRpYyB2b2lkIGRlY2lkZVBv bGljeUZvck5hdmlnYXRpb25BY3Rpb24oV0tQYWdlUmVmLCBXS0ZyYW1lUmVmLCBXS0ZyYW1lTmF2 aWdhdGlvblR5cGUsIFdLRXZlbnRNb2RpZmllcnMsIFdLRXZlbnRNb3VzZUJ1dHRvbiwgV0tGcmFt ZVJlZiwgV0tVUkxSZXF1ZXN0UmVmLCBXS0ZyYW1lUG9saWN5TGlzdGVuZXJSZWYgbGlzdGVuZXIs IFdLVHlwZVJlZiwgY29uc3Qgdm9pZCopCitzdGF0aWMgdm9pZCBkZWNpZGVQb2xpY3lGb3JOYXZp Z2F0aW9uQWN0aW9uKFdLUGFnZVJlZiwgV0tOYXZpZ2F0aW9uQWN0aW9uUmVmLCBXS0ZyYW1lUG9s aWN5TGlzdGVuZXJSZWYgbGlzdGVuZXIsIFdLVHlwZVJlZiwgY29uc3Qgdm9pZCopCiB7CiAgICAg V0tGcmFtZVBvbGljeUxpc3RlbmVyRG93bmxvYWQobGlzdGVuZXIpOwogfQpAQCAtNjAsMTMgKzYw LDEzIEBAIHN0YXRpYyB2b2lkIHNldENvbnRleHREb3dubG9hZENsaWVudChXS0NvbnRleHRSZWYg Y29udGV4dCkKIAogc3RhdGljIHZvaWQgc2V0UGFnZVBvbGljeUNsaWVudChXS1BhZ2VSZWYgcGFn ZSkKIHsKLSAgICBXS1BhZ2VQb2xpY3lDbGllbnRWMSBwb2xpY3lDbGllbnQ7Ci0gICAgbWVtc2V0 KCZwb2xpY3lDbGllbnQsIDAsIHNpemVvZihwb2xpY3lDbGllbnQpKTsKKyAgICBXS1BhZ2VOYXZp Z2F0aW9uQ2xpZW50VjAgbmF2aWdhdGlvbkNsaWVudDsKKyAgICBtZW1zZXQoJm5hdmlnYXRpb25D bGllbnQsIDAsIHNpemVvZihuYXZpZ2F0aW9uQ2xpZW50KSk7CiAKLSAgICBwb2xpY3lDbGllbnQu YmFzZS52ZXJzaW9uID0gMTsKLSAgICBwb2xpY3lDbGllbnQuZGVjaWRlUG9saWN5Rm9yTmF2aWdh dGlvbkFjdGlvbiA9IGRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb247CisgICAgbmF2aWdh dGlvbkNsaWVudC5iYXNlLnZlcnNpb24gPSAwOworICAgIG5hdmlnYXRpb25DbGllbnQuZGVjaWRl UG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbiA9IGRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rp b247CiAKLSAgICBXS1BhZ2VTZXRQYWdlUG9saWN5Q2xpZW50KHBhZ2UsICZwb2xpY3lDbGllbnQu YmFzZSk7CisgICAgV0tQYWdlU2V0UGFnZU5hdmlnYXRpb25DbGllbnQocGFnZSwgJm5hdmlnYXRp b25DbGllbnQuYmFzZSk7CiB9CiAKIFRFU1QoV2ViS2l0LCBEb3dubG9hZERlY2lkZURlc3RpbmF0 aW9uQ3Jhc2gpCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9Q cm92aXNpb25hbFVSTEFmdGVyV2lsbFNlbmRSZXF1ZXN0Q2FsbGJhY2suY3BwIGIvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXQvUHJvdmlzaW9uYWxVUkxBZnRlcldpbGxTZW5kUmVxdWVz dENhbGxiYWNrLmNwcAppbmRleCAyOTc5Zjc5MmMzZDA2MDdmMzY5MDQwYzgwM2JiNGNhYTQwMTYx NGZhLi5lZWM3NGZlYzc1YWZmMWJhMTE1NTY5ZDA3OTc0OThlZWRhOWVkYzc5IDEwMDY0NAotLS0g YS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9Qcm92aXNpb25hbFVSTEFmdGVyV2ls bFNlbmRSZXF1ZXN0Q2FsbGJhY2suY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMv V2ViS2l0L1Byb3Zpc2lvbmFsVVJMQWZ0ZXJXaWxsU2VuZFJlcXVlc3RDYWxsYmFjay5jcHAKQEAg LTM4LDEwICszOCw5IEBAIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJIHsKIAogc3RhdGljIGJvb2wg Y29tbWl0dGVkTG9hZDsKIAotc3RhdGljIHZvaWQgZGlkQ29tbWl0TG9hZEZvckZyYW1lKFdLUGFn ZVJlZiBwYWdlLCBXS0ZyYW1lUmVmIGZyYW1lLCBXS1R5cGVSZWYgdXNlckRhdGEsIGNvbnN0IHZv aWQqKQorc3RhdGljIHZvaWQgZGlkQ29tbWl0TmF2aWdhdGlvbkNhbGxiYWNrKFdLUGFnZVJlZiBw YWdlLCBXS05hdmlnYXRpb25SZWYsIFdLVHlwZVJlZiB1c2VyRGF0YSwgY29uc3Qgdm9pZCopCiB7 Ci0gICAgaWYgKCFXS0ZyYW1lSXNNYWluRnJhbWUoZnJhbWUpKQotICAgICAgICByZXR1cm47Cisg ICAgV0tGcmFtZVJlZiBmcmFtZSA9IFdLUGFnZUdldE1haW5GcmFtZShwYWdlKTsKIAogICAgIC8v IFRoZSBwcm92aXNpb25hbCBVUkwgc2hvdWxkIGJlIG51bGwuCiAgICAgRVhQRUNUX05VTEwoV0tG cmFtZUNvcHlQcm92aXNpb25hbFVSTChmcmFtZSkpOwpAQCAtNzIsMTIgKzcxLDEyIEBAIFRFU1Qo V2ViS2l0MiwgUHJvdmlzaW9uYWxVUkxBZnRlcldpbGxTZW5kUmVxdWVzdENhbGxiYWNrKQogCiAg ICAgUGxhdGZvcm1XZWJWaWV3IHdlYlZpZXcoY29udGV4dC5nZXQoKSk7CiAKLSAgICBXS1BhZ2VM b2FkZXJDbGllbnRWMCBsb2FkZXJDbGllbnQ7Ci0gICAgbWVtc2V0KCZsb2FkZXJDbGllbnQsIDAs IHNpemVvZihsb2FkZXJDbGllbnQpKTsKKyAgICBXS1BhZ2VOYXZpZ2F0aW9uQ2xpZW50VjAgbmF2 aWdhdGlvbkNsaWVudDsKKyAgICBtZW1zZXQoJm5hdmlnYXRpb25DbGllbnQsIDAsIHNpemVvZihu YXZpZ2F0aW9uQ2xpZW50KSk7CiAKLSAgICBsb2FkZXJDbGllbnQuYmFzZS52ZXJzaW9uID0gMDsK LSAgICBsb2FkZXJDbGllbnQuZGlkQ29tbWl0TG9hZEZvckZyYW1lID0gZGlkQ29tbWl0TG9hZEZv ckZyYW1lOwotICAgIFdLUGFnZVNldFBhZ2VMb2FkZXJDbGllbnQod2ViVmlldy5wYWdlKCksICZs b2FkZXJDbGllbnQuYmFzZSk7CisgICAgbmF2aWdhdGlvbkNsaWVudC5iYXNlLnZlcnNpb24gPSAw OworICAgIG5hdmlnYXRpb25DbGllbnQuZGlkQ29tbWl0TmF2aWdhdGlvbiA9IGRpZENvbW1pdE5h dmlnYXRpb25DYWxsYmFjazsKKyAgICBXS1BhZ2VTZXRQYWdlTmF2aWdhdGlvbkNsaWVudCh3ZWJW aWV3LnBhZ2UoKSwgJm5hdmlnYXRpb25DbGllbnQuYmFzZSk7CiAKICAgICBXS1JldGFpblB0cjxX S1VSTFJlZj4gdXJsKEFkb3B0V0ssIFV0aWw6OmNyZWF0ZVVSTEZvclJlc291cmNlKCJzaW1wbGUi LCAiaHRtbCIpKTsKICAgICBXS1BhZ2VMb2FkVVJMKHdlYlZpZXcucGFnZSgpLCB1cmwuZ2V0KCkp Owo=