190150 2018-10-01 11:40:48 -0700 [Win][DRT] Actually set "experimental:WebAnimationsCSSIntegrationEnabled" when requested 2018-10-01 22:25:25 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 190032 1 ross.kirsling ross.kirsling bfulgham commit-queue dino fujii graouts pvollan tsavell webkit-bug-importer oldest_to_newest 1465146 0 ross.kirsling 2018-10-01 11:40:48 -0700 [Win][DRT] Actually set "experimental:WebAnimationsCSSIntegrationEnabled" when requested 1465147 1 351280 ross.kirsling 2018-10-01 11:42:03 -0700 Created attachment 351280 Patch 1465341 2 fujii 2018-10-01 18:04:52 -0700 Mac port DRT has more options. Don't you need them? https://github.com/WebKit/webkit/blob/234976b18c6973855fa27c50eea2070878ea1488/Tools/DumpRenderTree/mac/DumpRenderTree.mm#L998 1465372 3 ross.kirsling 2018-10-01 19:38:44 -0700 (In reply to Fujii Hironori from comment #2) > Mac port DRT has more options. Don't you need them? > https://github.com/WebKit/webkit/blob/ > 234976b18c6973855fa27c50eea2070878ea1488/Tools/DumpRenderTree/mac/ > DumpRenderTree.mm#L998 Hmm, it would certainly seem like it, but evidently none of the other options currently have setters available in IWebPreferencesPrivate.idl: https://github.com/WebKit/webkit/blob/master/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl So I suppose it'd be better to add them in the future, if we ever end up needing them in WKL. 1465390 4 351280 commit-queue 2018-10-01 22:24:51 -0700 Comment on attachment 351280 Patch Clearing flags on attachment: 351280 Committed r236712: <https://trac.webkit.org/changeset/236712> 1465391 5 commit-queue 2018-10-01 22:24:53 -0700 All reviewed patches have been landed. Closing bug. 1465392 6 webkit-bug-importer 2018-10-01 22:25:25 -0700 <rdar://problem/44931046> 351280 2018-10-01 11:42:03 -0700 2018-10-01 22:24:51 -0700 Patch bug-190150-20181001114202.patch text/plain 1611 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NjY0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjMyYTJjY2UwNWFiZTE5MzU0NmQzM2JmNDFiZWY3ZDc3 N2M2OTZlMS4uMDI5M2RmMzY4Yzg4ZjVmOGI3YTc0YjlkNzUxOWNiYmI1NWQzNDJmNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE4LTEwLTAxICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4K KworICAgICAgICBbV2luXVtEUlRdIEFjdHVhbGx5IHNldCAiZXhwZXJpbWVudGFsOldlYkFuaW1h dGlvbnNDU1NJbnRlZ3JhdGlvbkVuYWJsZWQiIHdoZW4gcmVxdWVzdGVkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTAxNTAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3dpbi9E dW1wUmVuZGVyVHJlZS5jcHA6CisgICAgICAgIChzZXRXZWJQcmVmZXJlbmNlc0ZvclRlc3RPcHRp b25zKToKKyAgICAgICAgRFJUIGhhcyBiZWVuIHJlY29nbml6aW5nIHRoaXMgZmllbGQsIGJ1dCBu b3QgcHJvcGFnYXRpbmcgaXRzIHZhbHVlIHRvIFdlYlByZWZlcmVuY2VzLgorCiAyMDE4LTEwLTAx ICBPbGl2aWVyIEJsaW4gIDxvbGl2aWVyLmJsaW5Ac29mdGF0aG9tZS5jb20+CiAKICAgICAgICAg W1dQRV0gVXBkYXRlIGluc3RhbGwtZGVwZW5kZW5jaWVzCmRpZmYgLS1naXQgYS9Ub29scy9EdW1w UmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRyZWUuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUv d2luL0R1bXBSZW5kZXJUcmVlLmNwcAppbmRleCBiODUyNmJmMjRjYmU3ZjljNDYyZDdlZjlmODlk ODkzNDU4ZWRjMGQzLi43OTE3MWY3YTRjOTY3ZDUyNDEzNjc0YzIwN2NkNDRlZThhNWViMjRhIDEw MDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRyZWUuY3BwCisr KyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHAKQEAgLTg5NSw2 ICs4OTUsNyBAQCBzdGF0aWMgdm9pZCBzZXRXZWJQcmVmZXJlbmNlc0ZvclRlc3RPcHRpb25zKElX ZWJQcmVmZXJlbmNlcyogcHJlZmVyZW5jZXMsIGNvbnN0CiB7CiAgICAgQ09NUHRyPElXZWJQcmVm ZXJlbmNlc1ByaXZhdGU2PiBwcmVmc1ByaXZhdGUgeyBRdWVyeSwgcHJlZmVyZW5jZXMgfTsKIAor ICAgIHByZWZzUHJpdmF0ZS0+c2V0V2ViQW5pbWF0aW9uc0NTU0ludGVncmF0aW9uRW5hYmxlZChv cHRpb25zLmVuYWJsZVdlYkFuaW1hdGlvbnNDU1NJbnRlZ3JhdGlvbik7CiAgICAgcHJlZnNQcml2 YXRlLT5zZXRNZW51SXRlbUVsZW1lbnRFbmFibGVkKG9wdGlvbnMuZW5hYmxlTWVudUl0ZW1FbGVt ZW50KTsKICAgICBwcmVmc1ByaXZhdGUtPnNldE1vZGVybk1lZGlhQ29udHJvbHNFbmFibGVkKG9w dGlvbnMuZW5hYmxlTW9kZXJuTWVkaWFDb250cm9scyk7CiAgICAgcHJlZnNQcml2YXRlLT5zZXRJ c1NlY3VyZUNvbnRleHRBdHRyaWJ1dGVFbmFibGVkKG9wdGlvbnMuZW5hYmxlSXNTZWN1cmVDb250 ZXh0QXR0cmlidXRlKTsK