<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>190145</bug_id>
          
          <creation_ts>2018-10-01 11:05:18 -0700</creation_ts>
          <short_desc>ENABLE(ASSERT) used in grid code when !ASSERT_DISABLED is desired</short_desc>
          <delta_ts>2018-10-04 09:57:31 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>Other</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Michael Catanzaro">mcatanzaro</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>commit-queue</cc>
    
    <cc>jfernandez</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>rego</cc>
    
    <cc>svillar</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1465109</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-10-01 11:05:18 -0700</bug_when>
    <thetext>ENABLE(ASSERT) is not a real thing, but it&apos;s used in two grid files</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1465110</commentid>
    <comment_count>1</comment_count>
      <attachid>351271</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-10-01 11:07:45 -0700</bug_when>
    <thetext>Created attachment 351271
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1466387</commentid>
    <comment_count>2</comment_count>
      <attachid>351271</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-10-04 09:56:18 -0700</bug_when>
    <thetext>Comment on attachment 351271
Patch

Clearing flags on attachment: 351271

Committed r236834: &lt;https://trac.webkit.org/changeset/236834&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1466388</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-10-04 09:56:19 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1466393</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-10-04 09:57:31 -0700</bug_when>
    <thetext>&lt;rdar://problem/45012000&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>351271</attachid>
            <date>2018-10-01 11:07:45 -0700</date>
            <delta_ts>2018-10-04 09:56:18 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-190145-20181001200744.patch</filename>
            <type>text/plain</type>
            <size>3084</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NjU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTVlMzVhOWNiNTYxN2Vk
ZTk4ODNkYjU2YmQyZTZhYzJjZGIyZTBkMC4uY2E5OTNmMWE3OTBhZDYxYWZhOTg1NTMyNzZhMzQx
Mjg0ZmZhYzBmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTEwLTAxICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBFTkFCTEUo
QVNTRVJUKSB1c2VkIGluIGdyaWQgY29kZSB3aGVuICFBU1NFUlRfRElTQUJMRUQgaXMgZGVzaXJl
ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMTQ1
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVwbGFj
ZSBFTkFCTEUoQVNTRVJUKSwgd2hpY2ggZG9lc24ndCBleGlzdCwgd2l0aCAhQVNTRVJUX0RJU0FC
TEVELgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwOgorICAgICAgICAoV2Vi
Q29yZTo6UmVuZGVyR3JpZDo6cGxhY2VJdGVtc09uR3JpZCBjb25zdCk6CisgICAgICAgIChXZWJD
b3JlOjpSZW5kZXJHcmlkOjpiYXNlbGluZVBvc2l0aW9uIGNvbnN0KToKKyAgICAgICAgKiByZW5k
ZXJpbmcvc3R5bGUvR3JpZEFyZWEuaDoKKyAgICAgICAgKFdlYkNvcmU6OkdyaWRTcGFuOjpHcmlk
U3Bhbik6CisKIDIwMTgtMDktMzAgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAK
ICAgICAgICAgVXNlIFBvc2l0aW9uIGluc3RlYWQgb2YgUmFuZ2UgaW4gY3JlYXRlTWFya3VwSW50
ZXJuYWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJHcmlkLmNw
cCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJHcmlkLmNwcAppbmRleCBlMGNhMWMy
YWZhZDRiNzg2OGE3NDZjODdhZWFkZjI0MTFiZDg2NjNhLi44OTc1ZGU0ZDU0NTZjOWI1Mjc1N2M3
YzA2MWE4YjI3ZmJkNjU2MTE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv
UmVuZGVyR3JpZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckdyaWQu
Y3BwCkBAIC02MDYsNyArNjA2LDcgQEAgdm9pZCBSZW5kZXJHcmlkOjpwbGFjZUl0ZW1zT25Hcmlk
KEdyaWQmIGdyaWQsIHN0ZDo6b3B0aW9uYWw8TGF5b3V0VW5pdD4gYXZhaWxhYmwKICAgICB9CiAg
ICAgZ3JpZC5zZXRIYXNBbnlPcnRob2dvbmFsR3JpZEl0ZW0oaGFzQW55T3J0aG9nb25hbEdyaWRJ
dGVtKTsKIAotI2lmIEVOQUJMRShBU1NFUlQpCisjaWYgIUFTU0VSVF9ESVNBQkxFRAogICAgIGlm
IChncmlkLmhhc0dyaWRJdGVtcygpKSB7CiAgICAgICAgIEFTU0VSVChncmlkLm51bVRyYWNrcyhG
b3JSb3dzKSA+PSBHcmlkUG9zaXRpb25zUmVzb2x2ZXI6OmV4cGxpY2l0R3JpZFJvd0NvdW50KHN0
eWxlKCksIGdyaWQuYXV0b1JlcGVhdFRyYWNrcyhGb3JSb3dzKSkpOwogICAgICAgICBBU1NFUlQo
Z3JpZC5udW1UcmFja3MoRm9yQ29sdW1ucykgPj0gR3JpZFBvc2l0aW9uc1Jlc29sdmVyOjpleHBs
aWNpdEdyaWRDb2x1bW5Db3VudChzdHlsZSgpLCBncmlkLmF1dG9SZXBlYXRUcmFja3MoRm9yQ29s
dW1ucykpKTsKQEAgLTYyMiw3ICs2MjIsNyBAQCB2b2lkIFJlbmRlckdyaWQ6OnBsYWNlSXRlbXNP
bkdyaWQoR3JpZCYgZ3JpZCwgc3RkOjpvcHRpb25hbDxMYXlvdXRVbml0PiBhdmFpbGFibAogCiAg
ICAgZ3JpZC5zZXROZWVkc0l0ZW1zUGxhY2VtZW50KGZhbHNlKTsKIAotI2lmIEVOQUJMRShBU1NF
UlQpCisjaWYgIUFTU0VSVF9ESVNBQkxFRAogICAgIGZvciAoYXV0byogY2hpbGQgPSBncmlkLm9y
ZGVySXRlcmF0b3IoKS5maXJzdCgpOyBjaGlsZDsgY2hpbGQgPSBncmlkLm9yZGVySXRlcmF0b3Io
KS5uZXh0KCkpIHsKICAgICAgICAgaWYgKGdyaWQub3JkZXJJdGVyYXRvcigpLnNob3VsZFNraXBD
aGlsZCgqY2hpbGQpKQogICAgICAgICAgICAgY29udGludWU7CkBAIC0xMTQ0LDcgKzExNDQsNyBA
QCBib29sIFJlbmRlckdyaWQ6OmlzSW5saW5lQmFzZWxpbmVBbGlnbmVkQ2hpbGQoY29uc3QgUmVu
ZGVyQm94JiBjaGlsZCkgY29uc3QKIC8vIEZJWE1FOiBUaGlzIGxvZ2ljIGlzIHNoYXJlZCBieSBS
ZW5kZXJGbGV4aWJsZUJveCwgc28gaXQgbWlnaHQgYmUgcmVmYWN0b3JlZCBzb21laG93LgogaW50
IFJlbmRlckdyaWQ6OmJhc2VsaW5lUG9zaXRpb24oRm9udEJhc2VsaW5lLCBib29sLCBMaW5lRGly
ZWN0aW9uTW9kZSBkaXJlY3Rpb24sIExpbmVQb3NpdGlvbk1vZGUgbW9kZSkgY29uc3QKIHsKLSNp
ZiBFTkFCTEUoQVNTRVJUKQorI2lmICFBU1NFUlRfRElTQUJMRUQKICAgICBBU1NFUlQobW9kZSA9
PSBQb3NpdGlvbk9uQ29udGFpbmluZ0xpbmUpOwogI2Vsc2UKICAgICBVTlVTRURfUEFSQU0obW9k
ZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvR3JpZEFyZWEu
aCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9HcmlkQXJlYS5oCmluZGV4IGE1ODkw
YmUzMDk2Mzc0MDUyZDE5YzJiN2NjZDZkMDQxZmNmNGFkMGIuLjgxZTY2YjIxZTIwZTE4ZTZhN2Fj
Zjc3ZDUyODFkMjUxZTNhZmVjZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu
Zy9zdHlsZS9HcmlkQXJlYS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9H
cmlkQXJlYS5oCkBAIC0xNDgsNyArMTQ4LDcgQEAgcHJpdmF0ZToKICAgICBHcmlkU3BhbihpbnQg
c3RhcnRMaW5lLCBpbnQgZW5kTGluZSwgR3JpZFNwYW5UeXBlIHR5cGUpCiAgICAgICAgIDogbV90
eXBlKHR5cGUpCiAgICAgewotI2lmIEVOQUJMRShBU1NFUlQpCisjaWYgIUFTU0VSVF9ESVNBQkxF
RAogICAgICAgICBBU1NFUlQoc3RhcnRMaW5lIDwgZW5kTGluZSk7CiAgICAgICAgIGlmICh0eXBl
ID09IFRyYW5zbGF0ZWREZWZpbml0ZSkgewogICAgICAgICAgICAgQVNTRVJUKHN0YXJ0TGluZSA+
PSAwKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>