190135 2018-10-01 06:21:23 -0700 [GStreamer] Rare crash (_g_log_abort) in flushCurrentBuffer() 2018-10-01 10:40:59 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya aboya bugs-noreply commit-queue pnormand oldest_to_newest 1464976 0 aboya 2018-10-01 06:21:23 -0700 I've seen this happen once: (WebKitWebProcess:24060): GStreamer-CRITICAL **: gst_sample_get_info: assertion 'GST_IS_SAMPLE (sample)' failed Thread 1 (Thread 0x7f05dfa136c0 (LWP 24060)): #0 _g_log_abort () at /webkit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmessages.c:554 #1 0x00007f05c2850559 in g_logv () at /webkit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmessages.c:1362 #2 0x00007f05c2850712 in g_log () at /webkit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmessages.c:1403 #3 0x00007f05c5106bb2 in gst_sample_get_info () at /webkit/WebKitBuild/DependenciesGTK/Source/gstreamer-1.14.3/gst/gstsample.c:216 #4 0x00007f05d9e0c8ca in WebCore::MediaPlayerPrivateGStreamerBase::flushCurrentBuffer (this=0x7f0562e94000) at ../../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:921 #5 0x00007f05d9e0cfe5 in WebCore::MediaPlayerPrivateGStreamerBase::<lambda(GstPad*, GstPadProbeInfo*, gpointer)>::operator()(GstPad *, GstPadProbeInfo *, gpointer) const (__closure=0x0, info=0x7ffd075cd030, userData=0x7f0562e94000) at ../../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:1091 #6 0x00007f05d9e0d019 in WebCore::MediaPlayerPrivateGStreamerBase::<lambda(GstPad*, GstPadProbeInfo*, gpointer)>::_FUN(GstPad *, GstPadProbeInfo *, gpointer) () at ../../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:1093 #7 0x00007f05c50def8e in probe_hook_marshal () at /webkit/WebKitBuild/DependenciesGTK/Source/gstreamer-1.14.3/gst/gstpad.c:3561 #8 0x00007f05c283a6a4 in g_hook_list_marshal () at /webkit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/ghook.c:672 #9 0x00007f05c50de697 in do_probe_callbacks () at /webkit/WebKitBuild/DependenciesGTK/Source/gstreamer-1.14.3/gst/gstpad.c:3723 #10 0x00007f05c50e0ea3 in gst_pad_send_event_unchecked () at /webkit/WebKitBuild/DependenciesGTK/Source/gstreamer-1.14.3/gst/gstpad.c:5733 #11 0x00007f05c50e1564 in gst_pad_push_event_unchecked () at /webkit/WebKitBuild/DependenciesGTK/Source/gstreamer-1.14.3/gst/gstpad.c:5406 Probably m_sample is null at that point. 1464979 1 pnormand 2018-10-01 06:27:33 -0700 Steps to reproduce? 1464991 2 pnormand 2018-10-01 06:52:06 -0700 But yeah, looking at the code the crash reason is obvious anyway :) 1465042 3 351253 aboya 2018-10-01 09:41:42 -0700 Created attachment 351253 Patch 1465051 4 351253 pnormand 2018-10-01 09:52:24 -0700 Comment on attachment 351253 Patch Thanks! 1465092 5 351253 commit-queue 2018-10-01 10:40:57 -0700 Comment on attachment 351253 Patch Clearing flags on attachment: 351253 Committed r236668: <https://trac.webkit.org/changeset/236668> 1465093 6 commit-queue 2018-10-01 10:40:59 -0700 All reviewed patches have been landed. Closing bug. 351253 2018-10-01 09:41:42 -0700 2018-10-01 10:40:57 -0700 Patch bug-190135-20181001184141.patch text/plain 3907 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTZlMDQzMzQwNWQ1NjRi YjRkMTU0YTk1ZmRmZjg0ZjAxOGQwNzc1My4uODkyY2ViNjBlYWI3ZTMyMzFhZTlkOTA5NTBhZDhj OTU2NGIzZjU1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE4LTEwLTAxICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBGaXggYWJvcnQgaW4gZ3N0X3NhbXBsZV9nZXRfaW5mbygpCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTAxMzUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBIGZsdXNoIGNhbiBvY2N1ciBiZWZvcmUgYW55 IGZyYW1lIGhhcyBmaW5pc2hlZCBkZWNvZGluZyAtLSBlc3BlY2lhbGx5CisgICAgICAgIGluIHRl c3RzLCB3aGVyZSBhY3Rpb25zIG9uIHRoZSBwbGF5ZXIgb2Z0ZW4gb2NjdXIgaW4gcXVpY2sgc3Vj Y2Vzc2lvbi4KKworICAgICAgICBUaGVyZWZvcmUsIHRoZSBjb2RlIG11c3Qgbm90IGFzc3VtZSBi eSB0aGUgdGltZSBhIGZsdXNoIG9jY3VycyBhbnkKKyAgICAgICAgZnJhbWUgaGFzIHJlYWNoZWQg dGhlIHNpbmsuIFRoaXMgcGF0Y2ggZml4ZXMgYSBjYXNlIHdoZW4gc3VjaCB3cm9uZworICAgICAg ICBhc3N1bXB0aW9uIHdhcyBjYXVzaW5nIGdzdF9zYW1wbGVfZ2V0X2luZm8oKSB0byBhYm9ydCAo Y3Jhc2hpbmcKKyAgICAgICAgV2ViS2l0KS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6OmZsdXNoQ3VycmVudEJ1 ZmZlcik6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNl OjpjcmVhdGVHTEFwcFNpbmspOgorCiAyMDE4LTEwLTAxICBBbGljaWEgQm95YSBHYXJjw61hICA8 YWJveWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbTVNFXVtHU3RyZWFtZXJdIFNldCBhIG1pbmlt dW0gc2FtcGxlIHNpemUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXJCYXNlLmNwcAppbmRleCAyNmU2MjgyNzMxMzk0OTI5ZWQ4OTBkMjI0MzA2ZjAyNWU1 MjY2Y2FhLi5lYzhjNzA5ZjJiYmVjYmZhMTE1ZjlmMTQ2ZWUzZjYxMWFkNWQyNDY4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCkBA IC05MTYsMTEgKzkxNiwxMyBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6 OmZsdXNoQ3VycmVudEJ1ZmZlcigpCiAgICAgR1NUX0RFQlVHX09CSkVDVChwaXBlbGluZSgpLCAi Rmx1c2hpbmcgdmlkZW8gc2FtcGxlIik7CiAgICAgYXV0byBzYW1wbGVMb2NrZXIgPSBob2xkTG9j ayhtX3NhbXBsZU11dGV4KTsKIAotICAgIC8vIFJlcGxhY2UgYnkgYSBuZXcgc2FtcGxlIGhhdmlu ZyBvbmx5IHRoZSBjYXBzLCBzbyB0aGlzIGR1bW15IHNhbXBsZSBpcyBzdGlsbCB1c2VmdWwgdG8g Z2V0IHRoZSBkaW1lbnNpb25zLgotICAgIC8vIFRoaXMgcHJldmVudHMgcmVzaXppbmcgcHJvYmxl bXMgd2hlbiB0aGUgdmlkZW8gY2hhbmdlcyBpdHMgcXVhbGl0eSBhbmQgYSBEUkFJTiBpcyBwZXJm b3JtZWQuCi0gICAgY29uc3QgR3N0U3RydWN0dXJlKiBpbmZvID0gZ3N0X3NhbXBsZV9nZXRfaW5m byhtX3NhbXBsZS5nZXQoKSk7Ci0gICAgbV9zYW1wbGUgPSBhZG9wdEdSZWYoZ3N0X3NhbXBsZV9u ZXcobnVsbHB0ciwgZ3N0X3NhbXBsZV9nZXRfY2FwcyhtX3NhbXBsZS5nZXQoKSksCi0gICAgICAg IGdzdF9zYW1wbGVfZ2V0X3NlZ21lbnQobV9zYW1wbGUuZ2V0KCkpLCBpbmZvID8gZ3N0X3N0cnVj dHVyZV9jb3B5KGluZm8pIDogbnVsbHB0cikpOworICAgIGlmIChtX3NhbXBsZSkgeworICAgICAg ICAvLyBSZXBsYWNlIGJ5IGEgbmV3IHNhbXBsZSBoYXZpbmcgb25seSB0aGUgY2Fwcywgc28gdGhp cyBkdW1teSBzYW1wbGUgaXMgc3RpbGwgdXNlZnVsIHRvIGdldCB0aGUgZGltZW5zaW9ucy4KKyAg ICAgICAgLy8gVGhpcyBwcmV2ZW50cyByZXNpemluZyBwcm9ibGVtcyB3aGVuIHRoZSB2aWRlbyBj aGFuZ2VzIGl0cyBxdWFsaXR5IGFuZCBhIERSQUlOIGlzIHBlcmZvcm1lZC4KKyAgICAgICAgY29u c3QgR3N0U3RydWN0dXJlKiBpbmZvID0gZ3N0X3NhbXBsZV9nZXRfaW5mbyhtX3NhbXBsZS5nZXQo KSk7CisgICAgICAgIG1fc2FtcGxlID0gYWRvcHRHUmVmKGdzdF9zYW1wbGVfbmV3KG51bGxwdHIs IGdzdF9zYW1wbGVfZ2V0X2NhcHMobV9zYW1wbGUuZ2V0KCkpLAorICAgICAgICAgICAgZ3N0X3Nh bXBsZV9nZXRfc2VnbWVudChtX3NhbXBsZS5nZXQoKSksIGluZm8gPyBnc3Rfc3RydWN0dXJlX2Nv cHkoaW5mbykgOiBudWxscHRyKSk7CisgICAgfQogCiAgICAgYXV0byBwcm94eU9wZXJhdGlvbiA9 CiAgICAgICAgIFtdKFRleHR1cmVNYXBwZXJQbGF0Zm9ybUxheWVyUHJveHkmIHByb3h5KQpAQCAt MTA3Niw2ICsxMDc4LDExIEBAIEdzdEVsZW1lbnQqIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ckJhc2U6OmNyZWF0ZUdMQXBwU2luaygpCiAKICAgICBHUmVmUHRyPEdzdFBhZD4gcGFkID0gYWRv cHRHUmVmKGdzdF9lbGVtZW50X2dldF9zdGF0aWNfcGFkKGFwcHNpbmssICJzaW5rIikpOwogICAg IGdzdF9wYWRfYWRkX3Byb2JlKHBhZC5nZXQoKSwgc3RhdGljX2Nhc3Q8R3N0UGFkUHJvYmVUeXBl PihHU1RfUEFEX1BST0JFX1RZUEVfUVVFUllfRE9XTlNUUkVBTSB8IEdTVF9QQURfUFJPQkVfVFlQ RV9FVkVOVF9GTFVTSCksIFtdIChHc3RQYWQqLCBHc3RQYWRQcm9iZUluZm8qIGluZm8sICBncG9p bnRlciB1c2VyRGF0YSkgLT4gR3N0UGFkUHJvYmVSZXR1cm4geworICAgICAgICAvLyBJbiBzb21l IHBsYXRmb3JtcyAoZS5nLiBPcGVuTUFYIG9uIHRoZSBSYXNwYmVycnkgUGkpIHdoZW4gYSByZXNv bHV0aW9uIGNoYW5nZSBvY2N1cnMgdGhlCisgICAgICAgIC8vIHBpcGVsaW5lIGhhcyB0byBiZSBk cmFpbmVkIGJlZm9yZSBhIGZyYW1lIHdpdGggdGhlIG5ldyByZXNvbHV0aW9uIGNhbiBiZSBkZWNv ZGVkLgorICAgICAgICAvLyBJbiB0aGlzIGNvbnRleHQsIGl0J3MgaW1wb3J0YW50IHRoYXQgd2Ug ZG9uJ3QgaG9sZCByZWZlcmVuY2VzIHRvIGFueSBwcmV2aW91cyBmcmFtZQorICAgICAgICAvLyAo ZS5nLiBtX3NhbXBsZSkgc28gdGhhdCBkZWNvZGluZyBjYW4gY29udGludWUuCisgICAgICAgIC8v IFdlIGFyZSBhbHNvIG5vdCBzdXBwb3NlZCB0byBrZWVwIHRoZSBvcmlnaW5hbCBmcmFtZSBhZnRl ciBhIGZsdXNoLgogICAgICAgICBpZiAoaW5mby0+dHlwZSAmIEdTVF9QQURfUFJPQkVfVFlQRV9R VUVSWV9ET1dOU1RSRUFNKSB7CiAgICAgICAgICAgICBpZiAoR1NUX1FVRVJZX1RZUEUoR1NUX1BB RF9QUk9CRV9JTkZPX1FVRVJZKGluZm8pKSAhPSBHU1RfUVVFUllfRFJBSU4pCiAgICAgICAgICAg ICAgICAgcmV0dXJuIEdTVF9QQURfUFJPQkVfT0s7Cg==