190131 2018-10-01 05:52:21 -0700 [JSC] Add a JSONStringify overload that receives a JSValue space 2018-10-01 10:28:19 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 189947 1 koby.b webkit-unassigned commit-queue fpizlo keith_miller mark.lam msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1464967 0 koby.b 2018-10-01 05:52:21 -0700 Hi, In node-jsc, I neede to be able to pass a JSValue space to JSONStringify, not just the number of spaces to use. This patch add that overload to JSONStringify. Regarding tests, I wasn't sure there are c++ tests to JSONStringify or where should I add them. So for now I didn't add new tests. Thanks Koby 1464968 1 351238 koby.b 2018-10-01 05:55:43 -0700 Created attachment 351238 Patch 1464992 2 351238 ysuzuki 2018-10-01 06:55:27 -0700 Comment on attachment 351238 Patch r=me 1465001 3 351238 ysuzuki 2018-10-01 07:46:35 -0700 Comment on attachment 351238 Patch BTW, you can request both flags at the same time (r? and cq?). 1465010 4 351238 commit-queue 2018-10-01 08:12:32 -0700 Comment on attachment 351238 Patch Clearing flags on attachment: 351238 Committed r236660: <https://trac.webkit.org/changeset/236660> 1465011 5 commit-queue 2018-10-01 08:12:33 -0700 All reviewed patches have been landed. Closing bug. 1465013 6 webkit-bug-importer 2018-10-01 08:13:25 -0700 <rdar://problem/44908757> 1465078 7 koby.b 2018-10-01 10:28:19 -0700 @Yusuke thanks, I thought I had to wait for the review before settings the cq? flag. 351238 2018-10-01 05:55:43 -0700 2018-10-01 08:12:32 -0700 Patch bug-190131-20181001155541.patch text/plain 2494 koby.b U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NjQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 YjM3ODgzYmEzZTA3MDUzMTkxZmFkNTlmMDUzODkzYTcwYWQ4YjljLi4xOTEyMWY4MTFjYjc3MGYx ZTRiYWE4ZjVhMzQ0ZDk5NGNlYjUwYWI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOC0xMC0wMSAgS29ieSBCb3lhbmdvICA8a29ieS5iQG1jZS1zeXMuY29t PgorCisgICAgICAgIFtKU0NdIEFkZCBhIEpTT05TdHJpbmdpZnkgb3ZlcmxvYWQgdGhhdCByZWNl aXZlcyBhIEpTVmFsdWUgc3BhY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5MDEzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcnVudGltZS9KU09OT2JqZWN0LmNwcDoKKyAgICAgICAgKiBydW50aW1l L0pTT05PYmplY3QuaDoKKwogMjAxOC0wOS0yNSAgS29ieSBCb3lhbmdvICA8a29ieS5iQG1jZS5z eXN0ZW1zPgogCiAgICAgICAgIFtKU0NdIG9mZmxpbmVhc20gcGFyc2VyIHNob3VsZCBoYW5kbGUg Q1JMRiBpbiBhc20gZmlsZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0pTT05PYmplY3QuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPTk9i amVjdC5jcHAKaW5kZXggNDBmMDRjNWRkM2VlYjM5MjQ4ODY1ZjI0ZjNhYmIwMjU3ZDgzM2FiNy4u NzQwNGU3MTQwZGRkYTM4MjBjYjNjMDA4ZDdkMDVmMjQxZGVkODM3YSAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPTk9iamVjdC5jcHAKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPTk9iamVjdC5jcHAKQEAgLTg1NCwxMSArODU0LDExIEBA IEpTVmFsdWUgSlNPTlBhcnNlKEV4ZWNTdGF0ZSogZXhlYywgY29uc3QgU3RyaW5nJiBqc29uKQog ICAgIHJldHVybiBqc29uUGFyc2VyLnRyeUxpdGVyYWxQYXJzZSgpOwogfQogCi1TdHJpbmcgSlNP TlN0cmluZ2lmeShFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUgdmFsdWUsIHVuc2lnbmVkIGluZGVu dCkKK1N0cmluZyBKU09OU3RyaW5naWZ5KEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSwg SlNWYWx1ZSBzcGFjZSkKIHsKICAgICBWTSYgdm0gPSBleGVjLT52bSgpOwogICAgIGF1dG8gdGhy b3dTY29wZSA9IERFQ0xBUkVfVEhST1dfU0NPUEUodm0pOwotICAgIFN0cmluZ2lmaWVyIHN0cmlu Z2lmaWVyKGV4ZWMsIGpzTnVsbCgpLCBqc051bWJlcihpbmRlbnQpKTsKKyAgICBTdHJpbmdpZmll ciBzdHJpbmdpZmllcihleGVjLCBqc051bGwoKSwgc3BhY2UpOwogICAgIFJFVFVSTl9JRl9FWENF UFRJT04odGhyb3dTY29wZSwgeyB9KTsKICAgICBKU1ZhbHVlIHJlc3VsdCA9IHN0cmluZ2lmaWVy LnN0cmluZ2lmeSh2YWx1ZSk7CiAgICAgaWYgKFVOTElLRUxZKHRocm93U2NvcGUuZXhjZXB0aW9u KCkpIHx8IHJlc3VsdC5pc1VuZGVmaW5lZE9yTnVsbCgpKQpAQCAtODY2LDQgKzg2Niw5IEBAIFN0 cmluZyBKU09OU3RyaW5naWZ5KEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSwgdW5zaWdu ZWQgaW5kZW50KQogICAgIHJldHVybiByZXN1bHQuZ2V0U3RyaW5nKGV4ZWMpOwogfQogCitTdHJp bmcgSlNPTlN0cmluZ2lmeShFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUgdmFsdWUsIHVuc2lnbmVk IGluZGVudCkKK3sKKyAgICByZXR1cm4gSlNPTlN0cmluZ2lmeShleGVjLCB2YWx1ZSwganNOdW1i ZXIoaW5kZW50KSk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIEpTQwpkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPTk9iamVjdC5oIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvSlNPTk9iamVjdC5oCmluZGV4IDVjNmI1NGU5OTE1NTA1MTdiYjcyODhhYThh OTI4NTE3ZGU4YmUxMDcuLjJjMDRmMWU4ODQ5NmRiMGNkZGMyNjE1ODRiOTFjNzYwMDJmOGRjN2Ig MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT05PYmplY3QuaAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09OT2JqZWN0LmgKQEAgLTU2LDYg KzU2LDcgQEAgcHJpdmF0ZToKIH07CiAKIEpTX0VYUE9SVF9QUklWQVRFIEpTVmFsdWUgSlNPTlBh cnNlKEV4ZWNTdGF0ZSosIGNvbnN0IFN0cmluZyYpOworSlNfRVhQT1JUX1BSSVZBVEUgU3RyaW5n IEpTT05TdHJpbmdpZnkoRXhlY1N0YXRlKiwgSlNWYWx1ZSwgSlNWYWx1ZSBzcGFjZSk7CiBKU19F WFBPUlRfUFJJVkFURSBTdHJpbmcgSlNPTlN0cmluZ2lmeShFeGVjU3RhdGUqLCBKU1ZhbHVlLCB1 bnNpZ25lZCBpbmRlbnQpOwogICAgIAogfSAvLyBuYW1lc3BhY2UgSlNDCg==