190125 2018-10-01 04:33:08 -0700 [MSE][GStreamer] Set a minimum sample duration 2018-10-01 11:39:00 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya aboya bugs-noreply calvaris commit-queue oldest_to_newest 1464945 0 aboya 2018-10-01 04:33:08 -0700 The last sample of the audio track in the asset used in this test player has a tiny duration (100 ns): http://orange-opensource.github.io/hasplayer.js/1.2.0/player.html?url=http://playready.directtaps.net/smoothstreaming/SSWSS720H264/SuperSpeedway_720.ism/Manifest So small, we are truncating it to zero. We're not supposed to have frames with zero duration an. Instead, lets set a minimum frame duration for those fringe cases. 1465035 1 351251 aboya 2018-10-01 09:21:46 -0700 Created attachment 351251 Patch 1465088 2 351251 calvaris 2018-10-01 10:38:10 -0700 Comment on attachment 351251 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351251&action=review > Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp:59 > + m_duration = createMediaTime(std::max(GST_BUFFER_DURATION(buffer), minimumDuration)); I'd recommend moving this above to a more prominent position than inside this method. 1465106 3 351270 aboya 2018-10-01 10:59:43 -0700 Created attachment 351270 Patch 1465143 4 351270 commit-queue 2018-10-01 11:38:58 -0700 Comment on attachment 351270 Patch Clearing flags on attachment: 351270 Committed r236679: <https://trac.webkit.org/changeset/236679> 1465144 5 commit-queue 2018-10-01 11:39:00 -0700 All reviewed patches have been landed. Closing bug. 351251 2018-10-01 09:21:46 -0700 2018-10-01 10:59:40 -0700 Patch bug-190125-20181001182145.patch text/plain 3075 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDM5ZjMwNTg5NTdmOTJl YmZjMGVkNzVkNzc5MmI0NmU2MDc0MDA3MS4uYTZlMDQzMzQwNWQ1NjRiYjRkMTU0YTk1ZmRmZjg0 ZjAxOGQwNzc1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE4LTEwLTAxICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbTVNFXVtHU3Ry ZWFtZXJdIFNldCBhIG1pbmltdW0gc2FtcGxlIHNpemUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDEyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBsYXN0IHNhbXBsZSBvZiB0aGUgYXVkaW8gdHJh Y2sgaW4gdGhlIGFzc2V0IHVzZWQgaW4gdGhpcyB0ZXN0CisgICAgICAgIHBsYXllciBoYXMgYSB0 aW55IGR1cmF0aW9uICgxMDAgbnMpOgorCisgICAgICAgIGh0dHA6Ly9vcmFuZ2Utb3BlbnNvdXJj ZS5naXRodWIuaW8vaGFzcGxheWVyLmpzLzEuMi4wL3BsYXllci5odG1sP3VybD1odHRwOi8vcGxh eXJlYWR5LmRpcmVjdHRhcHMubmV0L3Ntb290aHN0cmVhbWluZy9TU1dTUzcyMEgyNjQvU3VwZXJT cGVlZHdheV83MjAuaXNtL01hbmlmZXN0CisKKyAgICAgICAgU28gc21hbGwsIHdlIHdlcmUgdHJ1 bmNhdGluZyBpdCB0byB6ZXJvLiBXZSdyZSBub3Qgc3VwcG9zZWQgdG8gaGF2ZQorICAgICAgICBm cmFtZXMgd2l0aCB6ZXJvIGR1cmF0aW9uLiBJbnN0ZWFkLCBsZXRzIHNldCBhIG1pbmltdW0gZnJh bWUgZHVyYXRpb24KKyAgICAgICAgZm9yIHRob3NlIGZyaW5nZSBjYXNlcy4KKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVNhbXBsZUdTdHJlYW1lci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpNZWRpYVNhbXBsZUdTdHJlYW1lcjo6TWVkaWFTYW1wbGVHU3RyZWFt ZXIpOgorCiAyMDE4LTA5LTI4ICBBbGljaWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNv bT4KIAogICAgICAgICBbTVNFXSBVc2UgdG9sZXJhbmNlIHdoZW4gZ3Jvd2luZyB0aGUgY29kZWQg ZnJhbWUgZ3JvdXAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9NZWRpYVNhbXBsZUdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFTYW1wbGVHU3RyZWFtZXIuY3BwCmluZGV4IDMw MzM0YTFmN2Y0MThlZjdjNzdlYWM0NmU1Yjg4MTE1ZjU1NjFiYTIuLjk4YTFjMGIwYWUzNTI5ZDli MzQ3NTU5OWE0MDA4ZjI5MjZmNDViY2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVNhbXBsZUdTdHJlYW1lci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhU2FtcGxlR1N0cmVh bWVyLmNwcApAQCAtMjMsNiArMjMsOCBAQAogCiAjaW5jbHVkZSAiR1N0cmVhbWVyQ29tbW9uLmgi CiAKKyNpbmNsdWRlIDxhbGdvcml0aG0+CisKICNpZiBFTkFCTEUoVklERU8pICYmIFVTRShHU1RS RUFNRVIpCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAgLTQ3LDkgKzQ5LDE1IEBAIE1lZGlhU2Ft cGxlR1N0cmVhbWVyOjpNZWRpYVNhbXBsZUdTdHJlYW1lcihHUmVmUHRyPEdzdFNhbXBsZT4mJiBz YW1wbGUsIGNvbnN0IEZsCiAgICAgICAgIG1fcHRzID0gY3JlYXRlTWVkaWFUaW1lKEdTVF9CVUZG RVJfUFRTKGJ1ZmZlcikpOwogICAgIGlmIChHU1RfQlVGRkVSX0RUU19JU19WQUxJRChidWZmZXIp IHx8IEdTVF9CVUZGRVJfUFRTX0lTX1ZBTElEKGJ1ZmZlcikpCiAgICAgICAgIG1fZHRzID0gY3Jl YXRlTWVkaWFUaW1lKEdTVF9CVUZGRVJfRFRTX09SX1BUUyhidWZmZXIpKTsKLSAgICBpZiAoR1NU X0JVRkZFUl9EVVJBVElPTl9JU19WQUxJRChidWZmZXIpKQotICAgICAgICBtX2R1cmF0aW9uID0g Y3JlYXRlTWVkaWFUaW1lKEdTVF9CVUZGRVJfRFVSQVRJT04oYnVmZmVyKSk7Ci0gICAgZWxzZSB7 CisgICAgaWYgKEdTVF9CVUZGRVJfRFVSQVRJT05fSVNfVkFMSUQoYnVmZmVyKSkgeworICAgICAg ICAvLyBTb21ldGltZXMgKGFsYmVpdCByYXJlbHksIHNvIGZhciBzZWVuIG9ubHkgYXQgdGhlIGVu ZCBvZiBhIHRyYWNrKQorICAgICAgICAvLyBmcmFtZXMgaGF2ZSB2ZXJ5IHNtYWxsIGR1cmF0aW9u cywgc28gc21hbGwgdGhhdCBtYXkgYmUgdW5kZXIgdGhlCisgICAgICAgIC8vIHByZWNpc2lvbiB3 ZSBhcmUgd29ya2luZyB3aXRoIGFuZCBiZSB0cnVuY2F0ZWQgdG8gemVyby4KKyAgICAgICAgLy8g U291cmNlQnVmZmVyIGFsZ29yaXRobXMgYXJlIG5vdCBleHBlY3RpbmcgZnJhbWVzIHdpdGggemVy by1kdXJhdGlvbiwKKyAgICAgICAgLy8gc28gbGV0J3MgdXNlIHNvbWV0aGluZyB2ZXJ5IHNtYWxs IGluc3RlYWQgaW4gdGhvc2UgZnJpbmdlIGNhc2VzLgorICAgICAgICBjb25zdCBHc3RDbG9ja1Rp bWUgbWluaW11bUR1cmF0aW9uID0gMTAwMDsgLy8gMSB1cworICAgICAgICBtX2R1cmF0aW9uID0g Y3JlYXRlTWVkaWFUaW1lKHN0ZDo6bWF4KEdTVF9CVUZGRVJfRFVSQVRJT04oYnVmZmVyKSwgbWlu aW11bUR1cmF0aW9uKSk7CisgICAgfSBlbHNlIHsKICAgICAgICAgLy8gVW5mb3J0dW5hdGVseSwg c29tZXRpbWVzIHNhbXBsZXMgZG9uJ3QgcHJvdmlkZSBhIGR1cmF0aW9uLiBUaGlzIGNhbiBuZXZl ciBoYXBwZW4gaW4gTVA0IGJlY2F1c2Ugb2YgdGhlIHdheQogICAgICAgICAvLyB0aGUgZm9ybWF0 IGlzIGxhaWQgb3V0LCBidXQgaXQncyBwcmV0dHkgY29tbW9uIGluIFdlYk0uCiAgICAgICAgIC8v IFRoZSBnb29kIHBhcnQgaXMgdGhhdCBkdXJhdGlvbnMgZG9uJ3QgbWF0dGVyIGZvciBwbGF5YmFj aywganVzdCBmb3IgYnVmZmVyZWQgcmFuZ2VzIGFuZCBjb2RlZCBmcmFtZSBkZWxldGlvbi4K 351270 2018-10-01 10:59:43 -0700 2018-10-01 11:38:58 -0700 Patch bug-190125-20181001195942.patch text/plain 3368 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDM5ZjMwNTg5NTdmOTJl YmZjMGVkNzVkNzc5MmI0NmU2MDc0MDA3MS4uOGVmMjI4N2I0ZmJlMDYyYzM3MTNmNzJkOTA1OWYx YjU4MGY2YzJlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE4LTEwLTAxICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbTVNFXVtHU3Ry ZWFtZXJdIFNldCBhIG1pbmltdW0gc2FtcGxlIGR1cmF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTAxMjUKKworICAgICAgICBSZXZpZXdlZCBi eSBYYWJpZXIgUm9kcmlndWV6LUNhbHZhci4KKworICAgICAgICBUaGUgbGFzdCBzYW1wbGUgb2Yg dGhlIGF1ZGlvIHRyYWNrIGluIHRoZSBhc3NldCB1c2VkIGluIHRoaXMgdGVzdAorICAgICAgICBw bGF5ZXIgaGFzIGEgdGlueSBkdXJhdGlvbiAoMTAwIG5zKToKKworICAgICAgICBodHRwOi8vb3Jh bmdlLW9wZW5zb3VyY2UuZ2l0aHViLmlvL2hhc3BsYXllci5qcy8xLjIuMC9wbGF5ZXIuaHRtbD91 cmw9aHR0cDovL3BsYXlyZWFkeS5kaXJlY3R0YXBzLm5ldC9zbW9vdGhzdHJlYW1pbmcvU1NXU1M3 MjBIMjY0L1N1cGVyU3BlZWR3YXlfNzIwLmlzbS9NYW5pZmVzdAorCisgICAgICAgIFNvIHNtYWxs LCB3ZSB3ZXJlIHRydW5jYXRpbmcgaXQgdG8gemVyby4gV2UncmUgbm90IHN1cHBvc2VkIHRvIGhh dmUKKyAgICAgICAgZnJhbWVzIHdpdGggemVybyBkdXJhdGlvbi4gSW5zdGVhZCwgbGV0cyBzZXQg YSBtaW5pbXVtIGZyYW1lIGR1cmF0aW9uCisgICAgICAgIGZvciB0aG9zZSBmcmluZ2UgY2FzZXMu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFTYW1wbGVHU3Ry ZWFtZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFTYW1wbGVHU3RyZWFtZXI6Ok1lZGlh U2FtcGxlR1N0cmVhbWVyKToKKwogMjAxOC0wOS0yOCAgQWxpY2lhIEJveWEgR2FyY8OtYSAgPGFi b3lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW01TRV0gVXNlIHRvbGVyYW5jZSB3aGVuIGdyb3dp bmcgdGhlIGNvZGVkIGZyYW1lIGdyb3VwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFTYW1wbGVHU3RyZWFtZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhU2FtcGxlR1N0cmVhbWVy LmNwcAppbmRleCAzMDMzNGExZjdmNDE4ZWY3Yzc3ZWFjNDZlNWI4ODExNWY1NTYxYmEyLi4zYjZi MzVhYjhlZjVmNDZlYjYyZTU3NTZjZjJmYzdiYThkNGJjZjM2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFTYW1wbGVHU3RyZWFtZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRp YVNhbXBsZUdTdHJlYW1lci5jcHAKQEAgLTIzLDYgKzIzLDggQEAKIAogI2luY2x1ZGUgIkdTdHJl YW1lckNvbW1vbi5oIgogCisjaW5jbHVkZSA8YWxnb3JpdGhtPgorCiAjaWYgRU5BQkxFKFZJREVP KSAmJiBVU0UoR1NUUkVBTUVSKQogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC0zNCw2ICszNiw3 IEBAIE1lZGlhU2FtcGxlR1N0cmVhbWVyOjpNZWRpYVNhbXBsZUdTdHJlYW1lcihHUmVmUHRyPEdz dFNhbXBsZT4mJiBzYW1wbGUsIGNvbnN0IEZsCiAgICAgLCBtX3RyYWNrSWQodHJhY2tJZCkKICAg ICAsIG1fcHJlc2VudGF0aW9uU2l6ZShwcmVzZW50YXRpb25TaXplKQogeworICAgIGNvbnN0IEdz dENsb2NrVGltZSBtaW5pbXVtRHVyYXRpb24gPSAxMDAwOyAvLyAxIHVzCiAgICAgQVNTRVJUKHNh bXBsZSk7CiAgICAgR3N0QnVmZmVyKiBidWZmZXIgPSBnc3Rfc2FtcGxlX2dldF9idWZmZXIoc2Ft cGxlLmdldCgpKTsKICAgICBSRUxFQVNFX0FTU0VSVChidWZmZXIpOwpAQCAtNDcsOSArNTAsMTQg QEAgTWVkaWFTYW1wbGVHU3RyZWFtZXI6Ok1lZGlhU2FtcGxlR1N0cmVhbWVyKEdSZWZQdHI8R3N0 U2FtcGxlPiYmIHNhbXBsZSwgY29uc3QgRmwKICAgICAgICAgbV9wdHMgPSBjcmVhdGVNZWRpYVRp bWUoR1NUX0JVRkZFUl9QVFMoYnVmZmVyKSk7CiAgICAgaWYgKEdTVF9CVUZGRVJfRFRTX0lTX1ZB TElEKGJ1ZmZlcikgfHwgR1NUX0JVRkZFUl9QVFNfSVNfVkFMSUQoYnVmZmVyKSkKICAgICAgICAg bV9kdHMgPSBjcmVhdGVNZWRpYVRpbWUoR1NUX0JVRkZFUl9EVFNfT1JfUFRTKGJ1ZmZlcikpOwot ICAgIGlmIChHU1RfQlVGRkVSX0RVUkFUSU9OX0lTX1ZBTElEKGJ1ZmZlcikpCi0gICAgICAgIG1f ZHVyYXRpb24gPSBjcmVhdGVNZWRpYVRpbWUoR1NUX0JVRkZFUl9EVVJBVElPTihidWZmZXIpKTsK LSAgICBlbHNlIHsKKyAgICBpZiAoR1NUX0JVRkZFUl9EVVJBVElPTl9JU19WQUxJRChidWZmZXIp KSB7CisgICAgICAgIC8vIFNvbWV0aW1lcyAoYWxiZWl0IHJhcmVseSwgc28gZmFyIHNlZW4gb25s eSBhdCB0aGUgZW5kIG9mIGEgdHJhY2spCisgICAgICAgIC8vIGZyYW1lcyBoYXZlIHZlcnkgc21h bGwgZHVyYXRpb25zLCBzbyBzbWFsbCB0aGF0IG1heSBiZSB1bmRlciB0aGUKKyAgICAgICAgLy8g cHJlY2lzaW9uIHdlIGFyZSB3b3JraW5nIHdpdGggYW5kIGJlIHRydW5jYXRlZCB0byB6ZXJvLgor ICAgICAgICAvLyBTb3VyY2VCdWZmZXIgYWxnb3JpdGhtcyBhcmUgbm90IGV4cGVjdGluZyBmcmFt ZXMgd2l0aCB6ZXJvLWR1cmF0aW9uLAorICAgICAgICAvLyBzbyBsZXQncyB1c2Ugc29tZXRoaW5n IHZlcnkgc21hbGwgaW5zdGVhZCBpbiB0aG9zZSBmcmluZ2UgY2FzZXMuCisgICAgICAgIG1fZHVy YXRpb24gPSBjcmVhdGVNZWRpYVRpbWUoc3RkOjptYXgoR1NUX0JVRkZFUl9EVVJBVElPTihidWZm ZXIpLCBtaW5pbXVtRHVyYXRpb24pKTsKKyAgICB9IGVsc2UgewogICAgICAgICAvLyBVbmZvcnR1 bmF0ZWx5LCBzb21ldGltZXMgc2FtcGxlcyBkb24ndCBwcm92aWRlIGEgZHVyYXRpb24uIFRoaXMg Y2FuIG5ldmVyIGhhcHBlbiBpbiBNUDQgYmVjYXVzZSBvZiB0aGUgd2F5CiAgICAgICAgIC8vIHRo ZSBmb3JtYXQgaXMgbGFpZCBvdXQsIGJ1dCBpdCdzIHByZXR0eSBjb21tb24gaW4gV2ViTS4KICAg ICAgICAgLy8gVGhlIGdvb2QgcGFydCBpcyB0aGF0IGR1cmF0aW9ucyBkb24ndCBtYXR0ZXIgZm9y IHBsYXliYWNrLCBqdXN0IGZvciBidWZmZXJlZCByYW5nZXMgYW5kIGNvZGVkIGZyYW1lIGRlbGV0 aW9uLgo=