190121 2018-10-01 02:46:44 -0700 [WTF] r236617 broke JSCOnly build on Windows 2018-10-01 05:34:24 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 189947 1 koby.b webkit-unassigned commit-queue mark.lam webkit-bug-importer ysuzuki oldest_to_newest 1464923 0 koby.b 2018-10-01 02:46:44 -0700 Hi, After updating my copy of WebKit, the Windows build of JSCOnly port fails with the following error: c:\togithub\webkit-original\webkit\source\wtf\wtf\generic\mainthreadgeneric.cpp(33): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C :\togithub\WebKit-Original\webkit\WebKitBuild\Release\Source\WTF\wtf\WTF.vcxproj] Looking at the file, it seems that since r236617 MainThreadGeneric.cpp always includes pthread.h, which is a problem since it isn't available on Windows (on the JSCOnly port uses MainThreadGeneric.cpp on all platforms). What do you think? should this be fixed in MainThreadGeneric or should the JSCOnly use the Windows implementation of MainThread? Thanks, Koby 1464929 1 ysuzuki 2018-10-01 03:13:23 -0700 (In reply to Koby from comment #0) > Hi, > After updating my copy of WebKit, the Windows build of JSCOnly port fails > with the following error: > c:\togithub\webkit-original\webkit\source\wtf\wtf\generic\mainthreadgeneric. > cpp(33): fatal error C1083: Cannot open include file: 'pthread.h': No such > file or directory [C > :\togithub\WebKit-Original\webkit\WebKitBuild\Release\Source\WTF\wtf\WTF. > vcxproj] > > Looking at the file, it seems that since r236617 MainThreadGeneric.cpp > always includes pthread.h, which is a problem since it isn't available on > Windows (on the JSCOnly port uses MainThreadGeneric.cpp on all platforms). > > What do you think? should this be fixed in MainThreadGeneric or should the > JSCOnly use the Windows implementation of MainThread? > > Thanks, > Koby Use MainThreadWin instead in Window. 1464932 2 koby.b 2018-10-01 03:30:20 -0700 Thanks! it seems to compile. I'll test it and upload a patch here. If I'm moving MainThread to the Windows implementation, is there anything else I need to change? Like the WorkQueueGeneric which is currently used (vs WorkQueueWin)? 1464934 3 ysuzuki 2018-10-01 03:33:21 -0700 (In reply to Koby from comment #2) > Thanks! it seems to compile. I'll test it and upload a patch here. > If I'm moving MainThread to the Windows implementation, is there anything > else I need to change? Like the WorkQueueGeneric which is currently used (vs > WorkQueueWin)? Just using MainThreadWin.cpp instead of MainThreadGeneric.cpp is OK. It should work. 1464951 4 351236 koby.b 2018-10-01 04:46:49 -0700 Created attachment 351236 Patch 1464952 5 koby.b 2018-10-01 04:47:11 -0700 Added a patch :) 1464953 6 351236 ysuzuki 2018-10-01 04:50:39 -0700 Comment on attachment 351236 Patch r=me 1464962 7 351236 commit-queue 2018-10-01 05:33:12 -0700 Comment on attachment 351236 Patch Clearing flags on attachment: 351236 Committed r236655: <https://trac.webkit.org/changeset/236655> 1464963 8 commit-queue 2018-10-01 05:33:14 -0700 All reviewed patches have been landed. Closing bug. 1464964 9 webkit-bug-importer 2018-10-01 05:34:24 -0700 <rdar://problem/44906628> 351236 2018-10-01 04:46:49 -0700 2018-10-01 05:33:12 -0700 Patch bug-190121-20181001144646.patch text/plain 1501 koby.b U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NjQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDMwYTBjNTliZjM0MWNmYzIwMDFjMzc4 OGUwOGM3MDFkN2NlZTk2MDQuLjQ5YjVjZTA0ZmZjOWM0N2ZiM2E5ZDJkMDdlNGM3NjVlOWU4NTdh YmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMTAtMDEgIEtvYnkgQm95YW5nbyAgPGtvYnku YkBtY2Utc3lzLmNvbT4KKworICAgICAgICBbV1RGXVtKU0NPTkxZXSBVc2UgTWFpblRocmVhZFdp biBvbiBXaW5kb3dzIGluIHRoZSBKU0NPbmx5IHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDEyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgZml4ZXMgSlNDT25seSBidWlsZCBvbiBXaW5k b3dzIGFmdGVyIHIyMzY2MTcuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm1KU0NPbmx5LmNtYWtl OgorCiAyMDE4LTA5LTI2ICBLb2J5IEJveWFuZ28gIDxrb2J5LmJAbWNlLnN5c3RlbXM+CiAKICAg ICAgICAgW1dURl0gQWRkIEV4dGVybmFsU3RyaW5nSW1wbCwgYSBTdHJpbmdJbXBsIGZvciB1c2Vy IGNvbnRyb2xsZWQgYnVmZmVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm1K U0NPbmx5LmNtYWtlIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm1KU0NPbmx5LmNtYWtlCmluZGV4 IDRkMGUwZjEyYTFmYjcxYjcwYzk1MmEwMWMwZjM2MDFmMmZjNWM4ODAuLmJhMDUwOTBmNzdiNDRl ZWYzZjQ0OTZhNzhiMjBmODE3MTRiZDQyNmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1Bs YXRmb3JtSlNDT25seS5jbWFrZQorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUpTQ09ubHku Y21ha2UKQEAgLTEsNSArMSw0IEBACiBsaXN0KEFQUEVORCBXVEZfU09VUkNFUwotICAgIGdlbmVy aWMvTWFpblRocmVhZEdlbmVyaWMuY3BwCiAgICAgZ2VuZXJpYy9Xb3JrUXVldWVHZW5lcmljLmNw cAogKQogCkBAIC05LDYgKzgsNyBAQCBpZiAoV0lOMzIpCiAKICAgICAgICAgd2luL0NQVVRpbWVX aW4uY3BwCiAgICAgICAgIHdpbi9MYW5ndWFnZVdpbi5jcHAKKyAgICAgICAgd2luL01haW5UaHJl YWRXaW4uY3BwCiAgICAgKQogICAgIGxpc3QoQVBQRU5EIFdURl9QVUJMSUNfSEVBREVSUwogICAg ICAgICB0ZXh0L3dpbi9XQ2hhclN0cmluZ0V4dHJhcy5oCkBAIC0xNyw2ICsxNyw4IEBAIGVsc2Ug KCkKICAgICBsaXN0KEFQUEVORCBXVEZfU09VUkNFUwogICAgICAgICBVbmlTdGRFeHRyYXMuY3Bw CiAKKyAgICAgICAgZ2VuZXJpYy9NYWluVGhyZWFkR2VuZXJpYy5jcHAKKwogICAgICAgICB0ZXh0 L3VuaXgvVGV4dEJyZWFrSXRlcmF0b3JJbnRlcm5hbElDVVVuaXguY3BwCiAKICAgICAgICAgdW5p eC9MYW5ndWFnZVVuaXguY3BwCg==