190118 2018-09-30 10:13:40 -0700 'HAVE_PTHREAD_MAIN_NP' macro redefined warning when building --jsc-only on macOS 2018-10-01 04:57:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ticaiolima ticaiolima commit-queue webkit-bug-importer ysuzuki oldest_to_newest 1464862 0 ticaiolima 2018-09-30 10:13:40 -0700 Here is the warning when compiling --jsc-only on macOS: In file included from /webkit/Source/JavaScriptCore/API/tests/testapi.c:27: In file included from /webkit/Source/JavaScriptCore/config.h:31: In file included from /webkit/Source/JavaScriptCore/runtime/JSExportMacros.h:32: In file included from /webkit/WebKitBaselineBuild/Release/DerivedSources/ForwardingHeaders/wtf/ExportMacros.h:32: /webkit/WebKitBaselineBuild/Release/DerivedSources/ForwardingHeaders/wtf/Platform.h:658:9: warning: 'HAVE_PTHREAD_MAIN_NP' macro redefined [-Wmacro-redefined] #define HAVE_PTHREAD_MAIN_NP 1 ^ /webkit/WebKitBaselineBuild/Release/cmakeconfig.h:128:9: note: previous definition is here #define HAVE_PTHREAD_MAIN_NP 0 1464863 1 351215 ticaiolima 2018-09-30 10:25:50 -0700 Created attachment 351215 Patch 1464928 2 351215 ysuzuki 2018-10-01 03:12:51 -0700 Comment on attachment 351215 Patch r=me 1464944 3 351215 ticaiolima 2018-10-01 04:30:30 -0700 Comment on attachment 351215 Patch Thx for the review 1464955 4 351215 commit-queue 2018-10-01 04:56:29 -0700 Comment on attachment 351215 Patch Clearing flags on attachment: 351215 Committed r236654: <https://trac.webkit.org/changeset/236654> 1464956 5 commit-queue 2018-10-01 04:56:31 -0700 All reviewed patches have been landed. Closing bug. 1464957 6 webkit-bug-importer 2018-10-01 04:57:26 -0700 <rdar://problem/44906284> 351215 2018-09-30 10:25:50 -0700 2018-10-01 04:56:29 -0700 Patch bug-190118-20180930192536.patch text/plain 1489 ticaiolima U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IGQwM2QyMWI2Y2RhMWY0ZmE2YzFlMmM3NGQ2NTBiM2UzNTY2NTdlMGMuLjI3NDBkYWE5MjFiNGVk OWUxZTFiOTcxNmRhMmZiYzcxMWE5Y2U1M2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC0xMzQsNyArMTM0LDkgQEAgV0VCS0lUX0NIRUNLX0hBVkVfRlVOQ1RJT04oSEFWRV9WQVNQUklO VEYgdmFzcHJpbnRmKQogCiAjIENoZWNrIGZvciBzeW1ib2xzCiBXRUJLSVRfQ0hFQ0tfSEFWRV9T WU1CT0woSEFWRV9SRUdFWF9IIHJlZ2V4ZWMgcmVnZXguaCkKK2lmIChOT1QgKCR7Q01BS0VfU1lT VEVNX05BTUV9IFNUUkVRVUFMICJEYXJ3aW4iKSkKIFdFQktJVF9DSEVDS19IQVZFX1NZTUJPTChI QVZFX1BUSFJFQURfTUFJTl9OUCBwdGhyZWFkX21haW5fbnAgcHRocmVhZF9ucC5oKQorZW5kaWYg KCkKICMgV2luZG93cyBoYXMgc2lnbmFsLmggYnV0IGlzIG1pc3Npbmcgc3ltYm9scyB0aGF0IGFy ZSB1c2VkIGluIGNhbGxzIHRvIHNpZ25hbC4KIFdFQktJVF9DSEVDS19IQVZFX1NZTUJPTChIQVZF X1NJR05BTF9IIFNJR1RSQVAgc2lnbmFsLmgpCiAKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0No YW5nZUxvZwppbmRleCBiYjY0YmMwN2FiYzRiMjA0ZTM1NzhkNzgyN2IzNTQ3ZmQ5ODg5NzhhLi40 OTY2N2VjYTllYTcwY2JjZmMxM2Q4MDE3NmM0ZGU1MGYyMTkwZWM2IDEwMDY0NAotLS0gYS9DaGFu Z2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDktMzAgIENhaW8g TGltYSAgPHRpY2Fpb2xpbWFAZ21haWwuY29tPgorCisgICAgICAgICdIQVZFX1BUSFJFQURfTUFJ Tl9OUCcgbWFjcm8gcmVkZWZpbmVkIHdhcm5pbmcgd2hlbiBidWlsZGluZyAtLWpzYy1vbmx5IG9u IG1hY09TCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTAxMTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX ZSBkZWZpbmUgSEFWRV9QVEhSRUFEX01BSU5fTlAgaW4gV1RGL3d0Zi9QbGF0Zm9ybS5oIHdoZW4g dGhlIE9TIGlzCisgICAgICAgIERhcndpbi4gSW4gc3VjaCBjYXNlLCB3ZSBkb24ndCBuZWVkIHRv IGNoZWNrIHN5bWJvbHMgZm9yCisgICAgICAgIHB0aHJlYWRfbWFpbl9ucCB3aGVuIGdlbmVyYXRp bmcgYnVpbGQgZm9yIHRoaXMgc3lzdGVtLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlv bnNDb21tb24uY21ha2U6CisKIDIwMTgtMDktMjggIE1pa2UgR29yc2UgIDxtZ29yc2VAYWx1bS53 cGkuZWR1PgogCiAgICAgICAgIGNtYWtlIGNhbm5vdCBydW4gaWYgcHl0aG9uIDIgaXNuJ3QgYXZh aWxhYmxlCg==