190116 2018-09-30 02:26:26 -0700 [JSC][CMake] Enable API tests in JSCOnly port on Windows 2021-11-01 12:55:31 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 189947 1 koby.b webkit-unassigned achristensen fpizlo keith_miller lforschler mark.lam msaboff saam ysuzuki oldest_to_newest 1464848 0 koby.b 2018-09-30 02:26:26 -0700 Hi, As I work on node-jsc mainly on Windows, I wanted to be able to run TestWTF (and the rest of the tests) on Windows when working with the JSCOnly port. This patch enables API tests in the JSCOnly port on Windows, and specifically TestWTF. Note that TestWTF will compile with WTF sources like on other platofrms (and not link with WTF like the other Windows ports). Koby 1464850 1 351212 koby.b 2018-09-30 02:37:26 -0700 Created attachment 351212 Patch 1810822 2 351212 achristensen 2021-11-01 12:55:31 -0700 Comment on attachment 351212 Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review. 351212 2018-09-30 02:37:26 -0700 2021-11-01 12:55:31 -0700 Patch bug-190116-20180930123723.patch text/plain 2868 koby.b U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NjQ1CmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFu Z2VMb2cKaW5kZXggYmI2NGJjMDdhYmM0YjIwNGUzNTc4ZDc4MjdiMzU0N2ZkOTg4OTc4YS4uOWNh YTA1ZTI2ZWYxZjZlODNlZTdmMTc4MTViOGYwMjA1MzliMDdmYSAxMDA2NDQKLS0tIGEvQ2hhbmdl TG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE4LTA5LTMwICBLb2J5IEJv eWFuZ28gIDxrb2J5LmJAbWNlLXN5cy5jb20+CisKKyAgICAgICAgW0pTQ11bQ01ha2VdIEVuYWJs ZSBBUEkgdGVzdHMgaW4gSlNDT25seSBwb3J0IG9uIFdpbmRvd3MuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTAxMTYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zSlND T25seS5jbWFrZToKKwogMjAxOC0wOS0yOCAgTWlrZSBHb3JzZSAgPG1nb3JzZUBhbHVtLndwaS5l ZHU+CiAKICAgICAgICAgY21ha2UgY2Fubm90IHJ1biBpZiBweXRob24gMiBpc24ndCBhdmFpbGFi bGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zSlNDT25seS5jbWFrZSBiL1NvdXJj ZS9jbWFrZS9PcHRpb25zSlNDT25seS5jbWFrZQppbmRleCA1MGRmMDNlYjYwMDQ0ZWEwNzhmZWFj M2I1N2MyYmU5Yzc2YTlhN2YxLi44NDRhYzEzNGE4MTE3MDRmYThkZDBkMmE5ZWQ5NjVmYWM0Y2Rk NjQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0pTQ09ubHkuY21ha2UKKysrIGIv U291cmNlL2NtYWtlL09wdGlvbnNKU0NPbmx5LmNtYWtlCkBAIC0zNiwxMSArMzYsNyBAQCBzZXQo RU5BQkxFX1dFQkNPUkUgT0ZGKQogc2V0KEVOQUJMRV9XRUJLSVRfTEVHQUNZIE9GRikKIHNldChF TkFCTEVfV0VCS0lUIE9GRikKIAotaWYgKFdJTjMyKQotICAgIHNldChFTkFCTEVfQVBJX1RFU1RT IE9GRikKLWVsc2UgKCkKLSAgICBzZXQoRU5BQkxFX0FQSV9URVNUUyBPTikKLWVuZGlmICgpCitz ZXQoRU5BQkxFX0FQSV9URVNUUyBPTikKIAogaWYgKFdURl9DUFVfQVJNIE9SIFdURl9DUFVfTUlQ UykKICAgICBTRVRfQU5EX0VYUE9TRV9UT19CVUlMRChVU0VfQ0FQU1RPTkUgVFJVRSkKZGlmZiAt LWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1N2ExMTVjNjJk MThjYzk2MThiNWVmMjM3MTQwMGY1MGU0YzdjYjRhLi5iZGEyMDQwZjg3Y2YxODVjZTVkYjU4Nzk2 ZTA2ZTI5ZTk1MmVjNmQ5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDktMzAgIEtvYnkgQm95YW5nbyAgPGtv YnkuYkBtY2Utc3lzLmNvbT4KKworICAgICAgICBbSlNDXVtDTWFrZV0gRW5hYmxlIEFQSSB0ZXN0 cyBpbiBKU0NPbmx5IHBvcnQgb24gV2luZG93cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDExNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9DTWFrZUxpc3RzLnR4dDoKKyAg ICAgICAgKiBUZXN0V2ViS2l0QVBJL1BsYXRmb3JtSlNDT25seS5jbWFrZToKKwogMjAxOC0wOS0y NiAgS29ieSBCb3lhbmdvICA8a29ieS5iQG1jZS5zeXN0ZW1zPgogCiAgICAgICAgIFtXVEZdIEFk ZCBFeHRlcm5hbFN0cmluZ0ltcGwsIGEgU3RyaW5nSW1wbCBmb3IgdXNlciBjb250cm9sbGVkIGJ1 ZmZlcnMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvQ01ha2VMaXN0cy50eHQgYi9U b29scy9UZXN0V2ViS2l0QVBJL0NNYWtlTGlzdHMudHh0CmluZGV4IDgzMWMxYmE5YzYwNDU3MmQ5 YjllNTZhZDE0ZDZiMDU4MDMyOGFmN2QuLjU1M2JkOTdmOThkMzhhYTdkYzAyMTZmYTU3MTlhYzdm ZTE0ODk2M2QgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvQ01ha2VMaXN0cy50eHQK KysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9DTWFrZUxpc3RzLnR4dApAQCAtMjQ5LDcgKzI0OSw3 IEBAIGFkZF9leGVjdXRhYmxlKFRlc3RXVEYKICAgICAke1Rlc3RXVEZfU09VUkNFU30KICkKIAot aWYgKFdJTjMyKQoraWYgKFdJTjMyIEFORCBOT1QgIiR7UE9SVH0iIFNUUkVRVUFMICJKU0NPbmx5 IikKICAgICBhZGRfZGVwZW5kZW5jaWVzKFRlc3RXVEYgVGVzdFdURkxpYikKIGVsc2UgKCkKICAg ICBhZGRfZGVwZW5kZW5jaWVzKFRlc3RXVEYgV1RGICR7VGVzdFdlYktpdEFQSV9ERVBFTkRFTkNJ RVN9KQpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9QbGF0Zm9ybUpTQ09ubHkuY21h a2UgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1BsYXRmb3JtSlNDT25seS5jbWFrZQppbmRleCBhM2Zh MmRhOTU1ZDVhMzljMWMzOTY4MGMyMWU4Y2RlNmU4ZmI1YzgwLi4xYTE4NzE3Y2U4MzQ4NzE2Mjky M2JhZmU4MjgwOTQ4OWNkZGE5MDY0IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Bs YXRmb3JtSlNDT25seS5jbWFrZQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1BsYXRmb3JtSlND T25seS5jbWFrZQpAQCAtMjUsMyArMjUsMTAgQEAgc2V0KHRlc3RfbWFpbl9TT1VSQ0VTCiBsaXN0 KEFQUEVORCBUZXN0V1RGX1NPVVJDRVMKICAgICAke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9X VEYvUnVuTG9vcC5jcHAKICkKKworaWYgKFdJTjMyKQorICAgIGluY2x1ZGVfZGlyZWN0b3JpZXMo U1lTVEVNCisgICAgICAgICR7SUNVX0lOQ0xVREVfRElSU30KKyAgICApCisgICAgYWRkX2RlZmlu aXRpb25zKC1EU1RBVElDQUxMWV9MSU5LRURfV0lUSF9XVEYpCitlbmRpZiAoKQpcIE5vIG5ld2xp bmUgYXQgZW5kIG9mIGZpbGUK