190097 2018-09-28 15:35:40 -0700 Skip debug assertion in ResourceLoadStatisticsMemoryStore::recursivelyGetAllDomainsThatHaveRedirectedToThisDomain() 2018-09-28 18:36:35 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=190055 InRadar P2 Normal --- 1 wilander wilander cdumez commit-queue webkit-bug-importer oldest_to_newest 1464557 0 wilander 2018-09-28 15:35:40 -0700 The change in https://bugs.webkit.org/show_bug.cgi?id=190055 causes a re-classification that may trigger a debug assertion in ResourceLoadStatisticsMemoryStore::recursivelyGetAllDomainsThatHaveRedirectedToThisDomain(). We should skip the assertion for statistics model version 14. 1464559 1 webkit-bug-importer 2018-09-28 15:36:14 -0700 <rdar://problem/44877080> 1464562 2 351127 wilander 2018-09-28 15:40:26 -0700 Created attachment 351127 Patch 1464659 3 351127 wilander 2018-09-28 18:11:06 -0700 Comment on attachment 351127 Patch Thanks, Chris! The iOS-sim bot seems to have unrelated issues. 1464667 4 351127 commit-queue 2018-09-28 18:36:34 -0700 Comment on attachment 351127 Patch Clearing flags on attachment: 351127 Committed r236630: <https://trac.webkit.org/changeset/236630> 1464668 5 commit-queue 2018-09-28 18:36:35 -0700 All reviewed patches have been landed. Closing bug. 351127 2018-09-28 15:40:26 -0700 2018-09-28 18:36:34 -0700 Patch bug-190097-20180928154025.patch text/plain 2336 wilander U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM3OTA4MjdmOTBhZmZhYTUw MDU0NWEyYjI1ZmU4M2UyM2E3ZTZmY2EuLjFjNzMzNWM1YWZiMzhkOGNlYWNlNDg1MDk2MGM0YTk5 ODdiODZmYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTgtMDktMjggIEpvaG4gV2ls YW5kZXIgIDx3aWxhbmRlckBhcHBsZS5jb20+CisKKyAgICAgICAgU2tpcCBkZWJ1ZyBhc3NlcnRp b24gaW4gUmVzb3VyY2VMb2FkU3RhdGlzdGljc01lbW9yeVN0b3JlOjpyZWN1cnNpdmVseUdldEFs bERvbWFpbnNUaGF0SGF2ZVJlZGlyZWN0ZWRUb1RoaXNEb21haW4oKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMDk3CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS80NDg3NzA4MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGUgY2hhbmdlIGluIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTAwNTUgY2F1c2VzIGEKKyAgICAgICAgcmUtY2xhc3NpZmljYXRpb24gdGhhdCBt YXkgdHJpZ2dlciBhIGRlYnVnIGFzc2VydGlvbiBpbgorICAgICAgICBSZXNvdXJjZUxvYWRTdGF0 aXN0aWNzTWVtb3J5U3RvcmU6OnJlY3Vyc2l2ZWx5R2V0QWxsRG9tYWluc1RoYXRIYXZlUmVkaXJl Y3RlZFRvVGhpc0RvbWFpbigpLgorICAgICAgICBXZSBzaG91bGQgc2tpcCB0aGUgYXNzZXJ0aW9u IGZvciBzdGF0aXN0aWNzIG1vZGVsIHZlcnNpb24gMTQgdG8gYXZvaWQKKyAgICAgICAgdGhpcy4K KworICAgICAgICAqIFVJUHJvY2Vzcy9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzTWVtb3J5U3RvcmUu Y3BwOgorICAgICAgICAoV2ViS2l0OjpSZXNvdXJjZUxvYWRTdGF0aXN0aWNzTWVtb3J5U3RvcmU6 OnJlY3Vyc2l2ZWx5R2V0QWxsRG9tYWluc1RoYXRIYXZlUmVkaXJlY3RlZFRvVGhpc0RvbWFpbiBj b25zdCk6CisKIDIwMTgtMDktMjggIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmVuYW1lIGNyZWF0ZU1hcmt1cCB0byBzZXJpYWxpemVQcmVzZXJ2aW5nVmlzdWFs QXBwZWFyYW5jZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvUmVzb3VyY2VM b2FkU3RhdGlzdGljc01lbW9yeVN0b3JlLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1Jl c291cmNlTG9hZFN0YXRpc3RpY3NNZW1vcnlTdG9yZS5jcHAKaW5kZXggMzljMmU0MTEzNDE3YTc2 MmRiMTdhY2ZhMDc5MDk0YzU1OWM1NGM0Mi4uN2QxN2FmZTJhNjE5NGVjY2FiZDlmMTRmYzJjYjRh NjcyODJmZGE2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvUmVzb3VyY2VM b2FkU3RhdGlzdGljc01lbW9yeVN0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzTWVtb3J5U3RvcmUuY3BwCkBAIC0yNzAsOCArMjcwLDEw IEBAIHVuc2lnbmVkIFJlc291cmNlTG9hZFN0YXRpc3RpY3NNZW1vcnlTdG9yZTo6cmVjdXJzaXZl bHlHZXRBbGxEb21haW5zVGhhdEhhdmVSZWRpCiAgICAgQVNTRVJUKCFSdW5Mb29wOjppc01haW4o KSk7CiAKICAgICBpZiAobnVtYmVyT2ZSZWN1cnNpdmVDYWxscyA+PSBtYXhOdW1iZXJPZlJlY3Vy c2l2ZUNhbGxzSW5SZWRpcmVjdFRyYWNlQmFjaykgewotICAgICAgICBBU1NFUlRfTk9UX1JFQUNI RUQoKTsKLSAgICAgICAgV1RGTG9nQWx3YXlzKCJIaXQgJXUgcmVjdXJzaXZlIGNhbGxzIGluIHJl ZGlyZWN0IGJhY2t0cmFjZS4gUmV0dXJuaW5nIGVhcmx5LiIsIG1heE51bWJlck9mUmVjdXJzaXZl Q2FsbHNJblJlZGlyZWN0VHJhY2VCYWNrKTsKKyAgICAgICAgLy8gTW9kZWwgdmVyc2lvbiAxNCBp bnZva2VzIGEgZGVsaWJlcmF0ZSByZS1jbGFzc2lmaWNhdGlvbiBvZiB0aGUgd2hvbGUgc2V0Lgor ICAgICAgICBpZiAoc3RhdGlzdGljc01vZGVsVmVyc2lvbiAhPSAxNCkKKyAgICAgICAgICAgIEFT U0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICBSRUxFQVNFX0xPRyhSZXNvdXJjZUxvYWRTdGF0 aXN0aWNzLCAiSGl0ICV1IHJlY3Vyc2l2ZSBjYWxscyBpbiByZWRpcmVjdCBiYWNrdHJhY2UuIFJl dHVybmluZyBlYXJseS4iLCBtYXhOdW1iZXJPZlJlY3Vyc2l2ZUNhbGxzSW5SZWRpcmVjdFRyYWNl QmFjayk7CiAgICAgICAgIHJldHVybiBudW1iZXJPZlJlY3Vyc2l2ZUNhbGxzOwogICAgIH0KIAo=