190096 2018-09-28 15:27:05 -0700 REGRESSION (r236091): CSSKeywordCompletions.js has "checkout" instead of "check-out" as a value for -apple-pay-button-type 2018-10-04 09:40:52 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aestes aestes aestes commit-queue hi joepeck rniwa simon.fraser thorton webkit-bug-importer zalan oldest_to_newest 1464544 0 aestes 2018-09-28 15:27:05 -0700 REGRESSION (r236091): CSSKeywordCompletions.js has "checkout" instead of "check-out" as a value for -apple-pay-button-type 1464548 1 351122 aestes 2018-09-28 15:30:32 -0700 Created attachment 351122 Patch 1464583 2 hi 2018-09-28 16:03:19 -0700 In reality, these completions only serve to provide autocompletion for older backends. It's still good to have it correct, but future releases won't need this list. :) 1464588 3 351122 commit-queue 2018-09-28 16:13:45 -0700 Comment on attachment 351122 Patch Clearing flags on attachment: 351122 Committed r236622: <https://trac.webkit.org/changeset/236622> 1464589 4 commit-queue 2018-09-28 16:13:47 -0700 All reviewed patches have been landed. Closing bug. 1464590 5 webkit-bug-importer 2018-09-28 16:14:24 -0700 <rdar://problem/44878214> 1464602 6 351122 ap 2018-09-28 16:26:47 -0700 Comment on attachment 351122 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351122&action=review > Source/WebInspectorUI/ChangeLog:8 > + I changed "checkout" to "check-out" in r235754, but it somehow got flipped back to "checkout" in r236091. Is this testable? 1466376 7 aestes 2018-10-04 09:36:12 -0700 (In reply to Alexey Proskuryakov from comment #6) > Comment on attachment 351122 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=351122&action=review > > > Source/WebInspectorUI/ChangeLog:8 > > + I changed "checkout" to "check-out" in r235754, but it somehow got flipped back to "checkout" in r236091. > > Is this testable? I'm guessing no, because it would require running the front-end against an older backend. Devin would know for sure. 1466380 8 351122 hi 2018-10-04 09:40:52 -0700 Comment on attachment 351122 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351122&action=review >>> Source/WebInspectorUI/ChangeLog:8 >>> + I changed "checkout" to "check-out" in r235754, but it somehow got flipped back to "checkout" in r236091. >> >> Is this testable? > > I'm guessing no, because it would require running the front-end against an older backend. Devin would know for sure. That is correct. We'd need to run the current WebInspector front-end against a pre-r236091 backend. 351122 2018-09-28 15:30:32 -0700 2018-09-28 16:13:45 -0700 Patch bug-190096-20180928153032.patch text/plain 1641 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAy OWM1YTgwYWFlYjk5MTIyY2Q2YWQwOTQ4MDA0ZDhjOTc5MDZhMTQ4Li5hNzcxMmUzOGFkNTk1NzY1 ZWVmYmNmMTNjMmRhZjU1YmM1YzNiNTkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOC0wOS0yOCAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CisK KyAgICAgICAgUkVHUkVTU0lPTiAocjIzNjA5MSk6IENTU0tleXdvcmRDb21wbGV0aW9ucy5qcyBo YXMgImNoZWNrb3V0IiBpbnN0ZWFkIG9mICJjaGVjay1vdXQiIGFzIGEgdmFsdWUgZm9yIC1hcHBs ZS1wYXktYnV0dG9uLXR5cGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5MDA5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEkgY2hhbmdlZCAiY2hlY2tvdXQiIHRvICJjaGVjay1vdXQiIGluIHIyMzU3NTQs IGJ1dCBpdCBzb21laG93IGdvdCBmbGlwcGVkIGJhY2sgdG8gImNoZWNrb3V0IiBpbiByMjM2MDkx LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTS2V5d29yZENvbXBsZXRpb25z LmpzOgorCiAyMDE4LTA5LTI4ICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAogICAg ICAgICBbQXBwbGUgUGF5XSBSZW1vdmUgdGhlICJpbi1zdG9yZSIgYnV0dG9uIHR5cGUKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9DU1NLZXl3 b3JkQ29tcGxldGlvbnMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9N b2RlbHMvQ1NTS2V5d29yZENvbXBsZXRpb25zLmpzCmluZGV4IDhiNjU0ODY4YTM3YWJlODU5NzM1 ODJlZmMxNjllOGY1MjRjN2UyNzQuLmE5MDhjMWY2ZTA3ZDAzNGExOWY3ODYyMmY1N2FiYmNlMjQ5 Njg4MGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01v ZGVscy9DU1NLZXl3b3JkQ29tcGxldGlvbnMuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0tleXdvcmRDb21wbGV0aW9ucy5qcwpAQCAtNzc0LDcg Kzc3NCw3IEBAIFdJLkNTU0tleXdvcmRDb21wbGV0aW9ucy5fcHJvcGVydHlLZXl3b3JkTWFwID0g ewogICAgICAgICAiYmxhY2siLCAid2hpdGUiLCAid2hpdGUtb3V0bGluZSIsCiAgICAgXSwKICAg ICAiLWFwcGxlLXBheS1idXR0b24tdHlwZSI6IFsKLSAgICAgICAgInBsYWluIiwgImJ1eSIsICJz ZXQtdXAiLCAiZG9uYXRlIiwgImNoZWNrb3V0IiwgImJvb2siLCAic3Vic2NyaWJlIiwKKyAgICAg ICAgInBsYWluIiwgImJ1eSIsICJzZXQtdXAiLCAiZG9uYXRlIiwgImNoZWNrLW91dCIsICJib29r IiwgInN1YnNjcmliZSIsCiAgICAgXSwKICAgICAiLWFwcGxlLXRyYWlsaW5nLXdvcmQiOiBbCiAg ICAgICAgICJhdXRvIiwgIi13ZWJraXQtcGFydGlhbGx5LWJhbGFuY2VkIiwK