190078 2018-09-28 09:33:24 -0700 Remove some unused RenderLayer code 2018-09-28 14:04:24 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1464408 0 simon.fraser 2018-09-28 09:33:24 -0700 Remove some unused RenderLayer code 1464409 1 351085 simon.fraser 2018-09-28 09:34:27 -0700 Created attachment 351085 Patch 1464489 2 351085 commit-queue 2018-09-28 14:03:31 -0700 Comment on attachment 351085 Patch Clearing flags on attachment: 351085 Committed r236611: <https://trac.webkit.org/changeset/236611> 1464490 3 commit-queue 2018-09-28 14:03:33 -0700 All reviewed patches have been landed. Closing bug. 1464491 4 webkit-bug-importer 2018-09-28 14:04:24 -0700 <rdar://problem/44874256> 351085 2018-09-28 09:34:27 -0700 2018-09-28 14:03:31 -0700 Patch bug-190078-20180928093426.patch text/plain 5669 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWQwZTk1Y2YwOGFkMDZj MmUwYmYxNTMzNjk3ZDVlNGJlZTNkZDI5Ni4uNTZkYzEzNjI0NTIyNGNkMGM2NTg0ZWJhYzdhZjMw MjVmOTYzNzVlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTA5LTI4ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBzb21l IHVudXNlZCBSZW5kZXJMYXllciBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTAwNzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGUgJ291dE9mRmxvd0Rlc2NlbmRhbnRDb250YWluaW5nQmxvY2tz JyBjb2RlIHdhcyByZWxhdGVkIHRvIHRoZSBhY2NlbGVyYXRlZCBvdmVyZmxvdyBzY3JvbGxpbmcg Y29kZSB0aGF0CisgICAgICAgIEkgcmVtb3ZlZCByZWNlbnRseS4KKyAgICAgICAgCisgICAgICAg IHVwZGF0ZURlc2NlbmRhbnRzTGF5ZXJMaXN0c0lmTmVlZGVkKCkgaXMgbmV2ZXIgY2FsbGVkLgor CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlckxheWVyOjp1cGRhdGVEZXNjZW5kYW50RGVwZW5kZW50RmxhZ3MpOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmNhbGN1bGF0ZUNsaXBSZWN0cyBjb25zdCk6CisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmg6CisKIDIwMTgtMDktMjYgIEFudG9pbmUgUXVpbnQg IDxncmFvdXRzQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViIEFuaW1hdGlvbnNdIEVuc3VyZSBy ZW5kZXJlcnMgd2l0aCBhY2NlbGVyYXRlZCBhbmltYXRpb25zIGhhdmUgbGF5ZXJzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAppbmRleCBlZjQzNDQwYTA3NzliMWU2ZDFk MGUwZGU2MzA0NDNjNGM3ODkzMWVmLi4zOGQ3ZTYxMjhlODllY2Q0MWU2ZDAxNWIwNWM0YmVlYTZi Nzc5ODNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKQEAgLTEw MDQsNyArMTAwNCw3IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnNldEFuY2VzdG9yQ2hhaW5IYXNWaXNp YmxlRGVzY2VuZGFudCgpCiAgICAgfQogfQogCi12b2lkIFJlbmRlckxheWVyOjp1cGRhdGVEZXNj ZW5kYW50RGVwZW5kZW50RmxhZ3MoSGFzaFNldDxjb25zdCBSZW5kZXJPYmplY3QqPiogb3V0T2ZG bG93RGVzY2VuZGFudENvbnRhaW5pbmdCbG9ja3MpCit2b2lkIFJlbmRlckxheWVyOjp1cGRhdGVE ZXNjZW5kYW50RGVwZW5kZW50RmxhZ3MoKQogewogICAgIGlmIChtX3Zpc2libGVEZXNjZW5kYW50 U3RhdHVzRGlydHkgfHwgbV9oYXNTZWxmUGFpbnRpbmdMYXllckRlc2NlbmRhbnREaXJ0eSB8fCBo YXNOb3RJc29sYXRlZEJsZW5kaW5nRGVzY2VuZGFudHNTdGF0dXNEaXJ0eSgpKSB7CiAgICAgICAg IGJvb2wgaGFzVmlzaWJsZURlc2NlbmRhbnQgPSBmYWxzZTsKQEAgLTEwMTMsMjAgKzEwMTMsOCBA QCB2b2lkIFJlbmRlckxheWVyOjp1cGRhdGVEZXNjZW5kYW50RGVwZW5kZW50RmxhZ3MoSGFzaFNl dDxjb25zdCBSZW5kZXJPYmplY3QqPiogbwogICAgICAgICBib29sIGhhc05vdElzb2xhdGVkQmxl bmRpbmdEZXNjZW5kYW50cyA9IGZhbHNlOwogI2VuZGlmCiAKLSAgICAgICAgSGFzaFNldDxjb25z dCBSZW5kZXJPYmplY3QqPiBjaGlsZE91dE9mRmxvd0Rlc2NlbmRhbnRDb250YWluaW5nQmxvY2tz OwogICAgICAgICBmb3IgKFJlbmRlckxheWVyKiBjaGlsZCA9IGZpcnN0Q2hpbGQoKTsgY2hpbGQ7 IGNoaWxkID0gY2hpbGQtPm5leHRTaWJsaW5nKCkpIHsKLSAgICAgICAgICAgIGNoaWxkT3V0T2ZG bG93RGVzY2VuZGFudENvbnRhaW5pbmdCbG9ja3MuY2xlYXIoKTsKLSAgICAgICAgICAgIGNoaWxk LT51cGRhdGVEZXNjZW5kYW50RGVwZW5kZW50RmxhZ3MoJmNoaWxkT3V0T2ZGbG93RGVzY2VuZGFu dENvbnRhaW5pbmdCbG9ja3MpOwotCi0gICAgICAgICAgICBib29sIGNoaWxkSXNPdXRPZkZsb3dQ b3NpdGlvbmVkID0gY2hpbGQtPnJlbmRlcmVyKCkuaXNPdXRPZkZsb3dQb3NpdGlvbmVkKCk7Ci0g ICAgICAgICAgICBpZiAoY2hpbGRJc091dE9mRmxvd1Bvc2l0aW9uZWQpCi0gICAgICAgICAgICAg ICAgY2hpbGRPdXRPZkZsb3dEZXNjZW5kYW50Q29udGFpbmluZ0Jsb2Nrcy5hZGQoY2hpbGQtPnJl bmRlcmVyKCkuY29udGFpbmluZ0Jsb2NrKCkpOwotCi0gICAgICAgICAgICBpZiAob3V0T2ZGbG93 RGVzY2VuZGFudENvbnRhaW5pbmdCbG9ja3MpIHsKLSAgICAgICAgICAgICAgICBIYXNoU2V0PGNv bnN0IFJlbmRlck9iamVjdCo+Ojpjb25zdF9pdGVyYXRvciBpdCA9IGNoaWxkT3V0T2ZGbG93RGVz Y2VuZGFudENvbnRhaW5pbmdCbG9ja3MuYmVnaW4oKTsKLSAgICAgICAgICAgICAgICBmb3IgKDsg aXQgIT0gY2hpbGRPdXRPZkZsb3dEZXNjZW5kYW50Q29udGFpbmluZ0Jsb2Nrcy5lbmQoKTsgKytp dCkKLSAgICAgICAgICAgICAgICAgICAgb3V0T2ZGbG93RGVzY2VuZGFudENvbnRhaW5pbmdCbG9j a3MtPmFkZCgqaXQpOwotICAgICAgICAgICAgfQorICAgICAgICAgICAgY2hpbGQtPnVwZGF0ZURl c2NlbmRhbnREZXBlbmRlbnRGbGFncygpOwogCiAgICAgICAgICAgICBoYXNWaXNpYmxlRGVzY2Vu ZGFudCB8PSBjaGlsZC0+bV9oYXNWaXNpYmxlQ29udGVudCB8fCBjaGlsZC0+bV9oYXNWaXNpYmxl RGVzY2VuZGFudDsKICAgICAgICAgICAgIGhhc1NlbGZQYWludGluZ0xheWVyRGVzY2VuZGFudCB8 PSBjaGlsZC0+aXNTZWxmUGFpbnRpbmdMYXllcigpIHx8IGNoaWxkLT5oYXNTZWxmUGFpbnRpbmdM YXllckRlc2NlbmRhbnQoKTsKQEAgLTEwNDIsOSArMTAzMCw2IEBAIHZvaWQgUmVuZGVyTGF5ZXI6 OnVwZGF0ZURlc2NlbmRhbnREZXBlbmRlbnRGbGFncyhIYXNoU2V0PGNvbnN0IFJlbmRlck9iamVj dCo+KiBvCiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KIAotICAgICAgICBpZiAo b3V0T2ZGbG93RGVzY2VuZGFudENvbnRhaW5pbmdCbG9ja3MpCi0gICAgICAgICAgICBvdXRPZkZs b3dEZXNjZW5kYW50Q29udGFpbmluZ0Jsb2Nrcy0+cmVtb3ZlKCZyZW5kZXJlcigpKTsKLQogICAg ICAgICBtX2hhc1Zpc2libGVEZXNjZW5kYW50ID0gaGFzVmlzaWJsZURlc2NlbmRhbnQ7CiAgICAg ICAgIG1fdmlzaWJsZURlc2NlbmRhbnRTdGF0dXNEaXJ0eSA9IGZhbHNlOwogICAgICAgICBtX2hh c1NlbGZQYWludGluZ0xheWVyRGVzY2VuZGFudCA9IGhhc1NlbGZQYWludGluZ0xheWVyRGVzY2Vu ZGFudDsKQEAgLTU5NjgsMzIgKzU5NTMsNiBAQCB2b2lkIFJlbmRlckxheWVyOjp1cGRhdGVMYXll ckxpc3RzSWZOZWVkZWQoKQogICAgIH0KIH0KIAotdm9pZCBSZW5kZXJMYXllcjo6dXBkYXRlRGVz Y2VuZGFudHNMYXllckxpc3RzSWZOZWVkZWQoYm9vbCByZWN1cnNpdmUpCi17Ci0gICAgVmVjdG9y PFJlbmRlckxheWVyKj4gbGF5ZXJzVG9VcGRhdGU7Ci0gICAgCi0gICAgaWYgKGF1dG8qIGxpc3Qg PSBuZWdaT3JkZXJMaXN0KCkpIHsKLSAgICAgICAgZm9yIChhdXRvKiBjaGlsZExheWVyIDogKmxp c3QpCi0gICAgICAgICAgICBsYXllcnNUb1VwZGF0ZS5hcHBlbmQoY2hpbGRMYXllcik7Ci0gICAg fQotICAgIAotICAgIGlmIChhdXRvKiBsaXN0ID0gbm9ybWFsRmxvd0xpc3QoKSkgewotICAgICAg ICBmb3IgKGF1dG8qIGNoaWxkTGF5ZXIgOiAqbGlzdCkKLSAgICAgICAgICAgIGxheWVyc1RvVXBk YXRlLmFwcGVuZChjaGlsZExheWVyKTsKLSAgICB9Ci0gICAgCi0gICAgaWYgKGF1dG8qIGxpc3Qg PSBwb3NaT3JkZXJMaXN0KCkpIHsKLSAgICAgICAgZm9yIChhdXRvKiBjaGlsZExheWVyIDogKmxp c3QpCi0gICAgICAgICAgICBsYXllcnNUb1VwZGF0ZS5hcHBlbmQoY2hpbGRMYXllcik7Ci0gICAg fQotICAgIAotICAgIGZvciAoYXV0byogY2hpbGRMYXllciA6IGxheWVyc1RvVXBkYXRlKSB7Ci0g ICAgICAgIGNoaWxkTGF5ZXItPnVwZGF0ZUxheWVyTGlzdHNJZk5lZWRlZCgpOwotICAgICAgICBp ZiAocmVjdXJzaXZlKQotICAgICAgICAgICAgY2hpbGRMYXllci0+dXBkYXRlRGVzY2VuZGFudHNM YXllckxpc3RzSWZOZWVkZWQodHJ1ZSk7Ci0gICAgfQotfQotCiB2b2lkIFJlbmRlckxheWVyOjp1 cGRhdGVDb21wb3NpdGluZ0FuZExheWVyTGlzdHNJZk5lZWRlZCgpCiB7CiAgICAgaWYgKGNvbXBv c2l0b3IoKS5pbkNvbXBvc2l0aW5nTW9kZSgpKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJMYXllci5oCmluZGV4IDY4ZDdlOTNmMzc4MzkzMmJkNTU1ZDA2NGE4MDJhNzBiZThlZmU3ODcu LjI3ZTkzNWIzOWRmNWU2ZjU4ZmExN2I2MWI5ZWMwODQ5NWVkOGQ2MDUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllci5oCkBAIC0zNzgsOSArMzc4LDYgQEAgcHVibGljOgogICAg IC8vIFVwZGF0ZSBvdXIgbm9ybWFsIGFuZCB6LWluZGV4IGxpc3RzLgogICAgIHZvaWQgdXBkYXRl TGF5ZXJMaXN0c0lmTmVlZGVkKCk7CiAKLSAgICAvLyBVcGRhdGUgdGhlIG5vcm1hbCBhbmQgei1p bmRleCBsaXN0cyBvZiBvdXIgZGVzY2VuZGFudHMuCi0gICAgdm9pZCB1cGRhdGVEZXNjZW5kYW50 c0xheWVyTGlzdHNJZk5lZWRlZChib29sIHJlY3Vyc2l2ZSk7Ci0KICAgICAvLyBGSVhNRTogV2Ug c2hvdWxkIEFTU0VSVCghbV92aXNpYmxlQ29udGVudFN0YXR1c0RpcnR5KSBoZXJlLCBidXQgc2Vl IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTA0NAogICAgIC8vIGRp dHRvIGZvciBoYXNWaXNpYmxlRGVzY2VuZGFudCgpLCBzZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTcxMjc3CiAgICAgYm9vbCBoYXNWaXNpYmxlQ29udGVudCgpIGNv bnN0IHsgcmV0dXJuIG1faGFzVmlzaWJsZUNvbnRlbnQ7IH0KQEAgLTkxMyw3ICs5MTAsNyBAQCBw cml2YXRlOgogICAgIHZvaWQgZGlydHlBbmNlc3RvckNoYWluVmlzaWJsZURlc2NlbmRhbnRTdGF0 dXMoKTsKICAgICB2b2lkIHNldEFuY2VzdG9yQ2hhaW5IYXNWaXNpYmxlRGVzY2VuZGFudCgpOwog Ci0gICAgdm9pZCB1cGRhdGVEZXNjZW5kYW50RGVwZW5kZW50RmxhZ3MoSGFzaFNldDxjb25zdCBS ZW5kZXJPYmplY3QqPiogb3V0T2ZGbG93RGVzY2VuZGFudENvbnRhaW5pbmdCbG9ja3MgPSBudWxs cHRyKTsKKyAgICB2b2lkIHVwZGF0ZURlc2NlbmRhbnREZXBlbmRlbnRGbGFncygpOwogCiAgICAg Ym9vbCBoYXMzRFRyYW5zZm9ybWVkRGVzY2VuZGFudCgpIGNvbnN0IHsgcmV0dXJuIG1faGFzM0RU cmFuc2Zvcm1lZERlc2NlbmRhbnQ7IH0KIAo=