190077 2018-09-28 09:26:13 -0700 Drop iOS specific quirk in SettingsBase::scriptEnabledChanged() 2018-09-28 10:04:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez commit-queue ggaren koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1464405 0 cdumez 2018-09-28 09:26:13 -0700 Drop iOS specific quirk in SettingsBase::scriptEnabledChanged() 1464406 1 cdumez 2018-09-28 09:26:29 -0700 <rdar://problem/44812613> 1464407 2 351084 cdumez 2018-09-28 09:29:43 -0700 Created attachment 351084 Patch 1464417 3 351084 simon.fraser 2018-09-28 09:58:21 -0700 Comment on attachment 351084 Patch Did we look at internal SVN history to see why this was added? 1464419 4 cdumez 2018-09-28 10:01:33 -0700 (In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 351084 [details] > Patch > > Did we look at internal SVN history to see why this was added? I haven't because I did not know this was a thing. I tried to git blame and did not find anything useful. 1464420 5 351084 commit-queue 2018-09-28 10:04:12 -0700 Comment on attachment 351084 Patch Clearing flags on attachment: 351084 Committed r236600: <https://trac.webkit.org/changeset/236600> 1464421 6 commit-queue 2018-09-28 10:04:13 -0700 All reviewed patches have been landed. Closing bug. 351084 2018-09-28 09:29:43 -0700 2018-09-28 10:04:12 -0700 Patch bug-190077-20180928092942.patch text/plain 2961 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NTk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzBhZjg3NDFhYTFjZmRj MTU5MGI4MTczODNiMGI2YTU0N2Q5MTYwYi4uYzY3Nzc1ZjRhOTgzMmZmNzU2Y2QxN2M3YmFiY2Yx MmJiNTIyZmNmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE4LTA5LTI4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCBpT1Mgc3BlY2lmaWMg cXVpcmsgaW4gU2V0dGluZ3NCYXNlOjpzY3JpcHRFbmFibGVkQ2hhbmdlZCgpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTAwNzcKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzQ0ODEyNjEzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIERyb3AgaU9TIHNwZWNpZmljIHF1aXJrIGluIFNldHRpbmdzQmFzZTo6 c2NyaXB0RW5hYmxlZENoYW5nZWQoKSB0aGF0IHdvdWxkIGRpcnR5IHN0eWxlIGFmdGVyIHRoZQor ICAgICAgICAiSmF2YVNjcmlwdEVuYWJsZWQiIHNldHRpbmcncyBzdGF0ZSBpcyB0b2dnbGVkLiBJ IGRvIG5vdCBzZWUgYSBnb29kIHJlYXNvbiB0byBkbyB0aGlzIGdpdmVuIHRoYXQKKyAgICAgICAg c2NyaXB0cyB3b3VsZCBub3QgZ2V0IGV4ZWN1dGVkIHVudGlsIGEgcmVsb2FkLgorCisgICAgICAg IElmIHdlIGZpbmQgb3V0IGFmdGVyIGRyb3BwaW5nIHRoaXMgdGhhdCB0aGlzIGlzIGFjdHVhbGx5 IHVzZWZ1bCBmb3Igc29tZSByZWFzb24sIHRoZW4gd2UgY2FuCisgICAgICAgIGFsd2F5cyBicmlu ZyBpdCBiYWNrIGFuZCBjb25zaWRlciBtYWtpbmcgdGhpcyBub24taU9TIHNwZWNpZmljLCBhcyB3 ZWxsIGFzIGRvY3VtZW50aW5nIHdoeSB0aGlzCisgICAgICAgIGl0IGlzIG5lZWRlZC4KKworICAg ICAgICAqIHBhZ2UvU2V0dGluZ3MueWFtbDoKKyAgICAgICAgKiBwYWdlL1NldHRpbmdzQmFzZS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpTZXR0aW5nc0Jhc2U6OnNjcmlwdEVuYWJsZWRDaGFuZ2Vk KTogRGVsZXRlZC4KKyAgICAgICAgKiBwYWdlL1NldHRpbmdzQmFzZS5oOgorCiAyMDE4LTA5LTI3 ICBCYXN1a2UgU3V6dWtpICA8QmFzdWtlLlN1enVraUBzb255LmNvbT4KIAogICAgICAgICBbQ3Vy bF0gRml4IHByaW9yaXR5IGlzc3VlIHdpdGggbXVsdGlwbGUgY29va2llcyB3aXRoIGRpZmZlcmVu dCBsZXZlbCBvZiBwYXRoLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5n cy55YW1sIGIvU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy55YW1sCmluZGV4IGNlMjVlODk2 NzUzMjljYmIzNDFlYjJhY2UzNjNjYmNkNDU2ZDY5Y2YuLmVkZDMyMzJhN2Y2OTFjMTc5OTVjNDk3 YTM1Y2FkZDU4Y2RhOTZlZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGlu Z3MueWFtbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLnlhbWwKQEAgLTY1NSw3 ICs2NTUsNiBAQCBpbWFnZXNFbmFibGVkOgogc2NyaXB0RW5hYmxlZDoKICAgaW5pdGlhbDogZmFs c2UKICAgZ2V0dGVyOiBpc1NjcmlwdEVuYWJsZWQKLSAgb25DaGFuZ2U6IHNjcmlwdEVuYWJsZWRD aGFuZ2VkCiBwbHVnaW5zRW5hYmxlZDoKICAgaW5pdGlhbDogZmFsc2UKICAgZ2V0dGVyOiBhcmVQ bHVnaW5zRW5hYmxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5nc0Jh c2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5nc0Jhc2UuY3BwCmluZGV4IGM4Njdh ZTM5ODcyMzFhMjE5NWUxZDZhNWJmMDNhYjkwNjQ1MDc4YWUuLmU2MTUxMzIwMDU2ZDI4MWNlNDhh ZDZkYTU3Y2UwNWM4YzA2Y2QyMWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0 dGluZ3NCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzQmFzZS5jcHAK QEAgLTI5MiwxNSArMjkyLDYgQEAgdm9pZCBTZXR0aW5nc0Jhc2U6OmltYWdlTG9hZGluZ1NldHRp bmdzVGltZXJGaXJlZCgpCiAgICAgfQogfQogCi12b2lkIFNldHRpbmdzQmFzZTo6c2NyaXB0RW5h YmxlZENoYW5nZWQoKQotewotI2lmIFBMQVRGT1JNKElPUykKLSAgICAvLyBGSVhNRTogV2h5IGRv IHdlIG9ubHkgZG8gdGhpcyBvbiBpT1M/Ci0gICAgaWYgKG1fcGFnZSkKLSAgICAgICAgbV9wYWdl LT5zZXROZWVkc1JlY2FsY1N0eWxlSW5BbGxGcmFtZXMoKTsKLSNlbmRpZgotfQotCiB2b2lkIFNl dHRpbmdzQmFzZTo6cGx1Z2luc0VuYWJsZWRDaGFuZ2VkKCkKIHsKICAgICBQYWdlOjpyZWZyZXNo UGx1Z2lucyhmYWxzZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdz QmFzZS5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5nc0Jhc2UuaAppbmRleCAxOTJiNzE1 MzM3YWU2Y2ExNWM3ZWRkMWZjYzk2Y2Q1ZWNmYzVlZjVkLi5hYTgwNGNkYjA4NGUwZDZhM2ZkM2Rl ZWI2ZjYxZDU1NDNhZjM0MWIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRp bmdzQmFzZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3NCYXNlLmgKQEAgLTE3 OCw3ICsxNzgsNiBAQCBwcm90ZWN0ZWQ6CiAgICAgdm9pZCBzZXROZWVkc1JlbGF5b3V0QWxsRnJh bWVzKCk7CiAgICAgdm9pZCBtZWRpYVR5cGVPdmVycmlkZUNoYW5nZWQoKTsKICAgICB2b2lkIGlt YWdlc0VuYWJsZWRDaGFuZ2VkKCk7Ci0gICAgdm9pZCBzY3JpcHRFbmFibGVkQ2hhbmdlZCgpOwog ICAgIHZvaWQgcGx1Z2luc0VuYWJsZWRDaGFuZ2VkKCk7CiAgICAgdm9pZCB1c2VyU3R5bGVTaGVl dExvY2F0aW9uQ2hhbmdlZCgpOwogICAgIHZvaWQgdXNlc1BhZ2VDYWNoZUNoYW5nZWQoKTsK