190075 2018-09-28 08:43:57 -0700 cmake cannot run if python 2 isn't available 2018-09-28 18:01:45 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Linux RESOLVED FIXED InRadar P2 Normal --- 1 mgorse webkit-unassigned commit-queue dean_johnson lforschler mcatanzaro mgorse webkit-bug-importer oldest_to_newest 1464386 0 mgorse 2018-09-28 08:43:57 -0700 The build tools now support python 3, but cmake still fails if /usr/bin/python3 is available but /usr/bin/python is not. See https://bugs.webkit.org/show_bug.cgi?id=156674#c36 1464394 1 351078 mgorse 2018-09-28 08:58:45 -0700 Created attachment 351078 Patch. 1464432 2 351078 mcatanzaro 2018-09-28 10:49:46 -0700 Comment on attachment 351078 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=351078&action=review > Source/cmake/WebKitCommon.cmake:24 > > +set(Python_ADDITIONAL_VERSIONS 3) > find_package(PythonInterp 2.7.0 REQUIRED) The indentation is wrong here 1464453 3 351098 mgorse 2018-09-28 11:51:59 -0700 Created attachment 351098 Patch. Fixed indentation. 1464651 4 351098 commit-queue 2018-09-28 18:00:47 -0700 Comment on attachment 351098 Patch. Clearing flags on attachment: 351098 Committed r236629: <https://trac.webkit.org/changeset/236629> 1464652 5 commit-queue 2018-09-28 18:00:49 -0700 All reviewed patches have been landed. Closing bug. 1464656 6 webkit-bug-importer 2018-09-28 18:01:45 -0700 <rdar://problem/44880316> 351078 2018-09-28 08:58:45 -0700 2018-09-28 11:51:59 -0700 Patch. cmake.patch text/plain 1477 mgorse RnJvbSA1ZTk3MDc4ZDA2ZmY0YmM4OTM5YWI3NTY1YjQyZmQ0ZDc3ODJlOWFkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEdvcnNlIDxtZ29yc2VAYWx1bS53cGkuZWR1PgpEYXRl OiBGcmksIDI4IFNlcCAyMDE4IDEwOjU2OjM4IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gY21ha2U6 IHNldCBQeXRob25fQURESVRJT05BTF9WRVJTSU9OUyB0byAzCgotLS0KIENoYW5nZUxvZyAgICAg ICAgICAgICAgICAgICAgICAgfCAxMCArKysrKysrKysrCiBTb3VyY2UvY21ha2UvV2ViS2l0Q29t bW9uLmNtYWtlIHwgIDEgKwogMiBmaWxlcyBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspCgpkaWZm IC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDhlODY5M2JiNjU3Li4yYmRmYmZk YjMxNyAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE4LTA5LTI4ICBNaWtlIEdvcnNlICA8bWdvcnNlQGFsdW0ud3BpLmVkdT4KKworICAg ICAgICBjbWFrZSBjYW5ub3QgcnVuIGlmIHB5dGhvbiAyIGlzbid0IGF2YWlsYWJsZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMDc1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2Uv V2ViS2l0Q29tbW9uLmNtYWtlOiBTZXQgUHl0aG9uX0FERElUSU9OQUxfVkVSU0lPTlMKKyAgICAg ICAgdG8gMywgc28gdGhhdCBhIHB5dGhvbjMgYmluYXJ5IHdpbGwgYmUgZm91bmQuCisKIDIwMTgt MDktMjEgIFl1c3VrZSBTdXp1a2kgIDx5dXN1a2VzdXp1a2lAc2xvd3N0YXJ0Lm9yZz4KIAogICAg ICAgICBbSlNDXSBFbmFibGUgTExJbnQgQVNNIGludGVycHJldGVyIG9uIFg2NCBhbmQgQVJNNjQg aW4gbm9uIEpJVCBjb25maWd1cmF0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2ViS2l0 Q29tbW9uLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdENvbW1vbi5jbWFrZQppbmRleCBmZDhk OGRjZTc2NC4uYmRkODFmOTk2NWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9XZWJLaXRDb21t b24uY21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktpdENvbW1vbi5jbWFrZQpAQCAtMjAsNiAr MjAsNyBAQCBpZiAoTk9UIEhBU19SVU5fV0VCS0lUX0NPTU1PTikKICAgICBmaW5kX3BhY2thZ2Uo UGVybCA1LjEwLjAgUkVRVUlSRUQpCiAgICAgZmluZF9wYWNrYWdlKFBlcmxNb2R1bGVzIENPTVBP TkVOVFMgSlNPTjo6UFAgUkVRVUlSRUQpCiAKK3NldChQeXRob25fQURESVRJT05BTF9WRVJTSU9O UyAzKQogICAgIGZpbmRfcGFja2FnZShQeXRob25JbnRlcnAgMi43LjAgUkVRVUlSRUQpCiAKICAg ICAjIFdlIGNhbm5vdCBjaGVjayBmb3IgUlVCWV9GT1VORCBiZWNhdXNlIGl0IGlzIHNldCBvbmx5 IHdoZW4gdGhlIGZ1bGwgcGFja2FnZSBpcyBpbnN0YWxsZWQgYW5kCi0tIAoyLjE4LjAKCg== 351098 2018-09-28 11:51:59 -0700 2018-09-28 18:00:47 -0700 Patch. cmake.patch text/plain 1481 mgorse RnJvbSBhOWY3ZTZlYjcxYjBmMGNiMjRhMjJjMmM0YjYxZjhkNWE0NTNlYjUxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEdvcnNlIDxtZ29yc2VAYWx1bS53cGkuZWR1PgpEYXRl OiBGcmksIDI4IFNlcCAyMDE4IDEwOjU2OjM4IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gY21ha2U6 IHNldCBQeXRob25fQURESVRJT05BTF9WRVJTSU9OUyB0byAzCgotLS0KIENoYW5nZUxvZyAgICAg ICAgICAgICAgICAgICAgICAgfCAxMCArKysrKysrKysrCiBTb3VyY2UvY21ha2UvV2ViS2l0Q29t bW9uLmNtYWtlIHwgIDEgKwogMiBmaWxlcyBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspCgpkaWZm IC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDhlODY5M2JiNjU3Li4yYmRmYmZk YjMxNyAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE4LTA5LTI4ICBNaWtlIEdvcnNlICA8bWdvcnNlQGFsdW0ud3BpLmVkdT4KKworICAg ICAgICBjbWFrZSBjYW5ub3QgcnVuIGlmIHB5dGhvbiAyIGlzbid0IGF2YWlsYWJsZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMDc1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2Uv V2ViS2l0Q29tbW9uLmNtYWtlOiBTZXQgUHl0aG9uX0FERElUSU9OQUxfVkVSU0lPTlMKKyAgICAg ICAgdG8gMywgc28gdGhhdCBhIHB5dGhvbjMgYmluYXJ5IHdpbGwgYmUgZm91bmQuCisKIDIwMTgt MDktMjEgIFl1c3VrZSBTdXp1a2kgIDx5dXN1a2VzdXp1a2lAc2xvd3N0YXJ0Lm9yZz4KIAogICAg ICAgICBbSlNDXSBFbmFibGUgTExJbnQgQVNNIGludGVycHJldGVyIG9uIFg2NCBhbmQgQVJNNjQg aW4gbm9uIEpJVCBjb25maWd1cmF0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2ViS2l0 Q29tbW9uLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdENvbW1vbi5jbWFrZQppbmRleCBmZDhk OGRjZTc2NC4uY2FmYjY2YWZhMDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9XZWJLaXRDb21t b24uY21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktpdENvbW1vbi5jbWFrZQpAQCAtMjAsNiAr MjAsNyBAQCBpZiAoTk9UIEhBU19SVU5fV0VCS0lUX0NPTU1PTikKICAgICBmaW5kX3BhY2thZ2Uo UGVybCA1LjEwLjAgUkVRVUlSRUQpCiAgICAgZmluZF9wYWNrYWdlKFBlcmxNb2R1bGVzIENPTVBP TkVOVFMgSlNPTjo6UFAgUkVRVUlSRUQpCiAKKyAgICBzZXQoUHl0aG9uX0FERElUSU9OQUxfVkVS U0lPTlMgMykKICAgICBmaW5kX3BhY2thZ2UoUHl0aG9uSW50ZXJwIDIuNy4wIFJFUVVJUkVEKQog CiAgICAgIyBXZSBjYW5ub3QgY2hlY2sgZm9yIFJVQllfRk9VTkQgYmVjYXVzZSBpdCBpcyBzZXQg b25seSB3aGVuIHRoZSBmdWxsIHBhY2thZ2UgaXMgaW5zdGFsbGVkIGFuZAotLSAKMi4xOC4wCgo=