190072 2018-09-27 23:42:55 -0700 Web Inspector: image resources without content are still shown when the Images folder is selected 2018-09-28 01:05:42 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1464321 0 hi 2018-09-27 23:42:55 -0700 In inspector2, clicking on the "Images" folder will show the list of images used by WebInspector. Since we use a lot of SVG fragment images, these won't display properly. As a result, a large "Resource has no content" over the entire content area, making it impossible to see any other images. We should remove the image's `WI.ImageResourceContentView` if it has no content, just like how we remove it if there's an error. 1464322 1 351059 hi 2018-09-27 23:44:29 -0700 Created attachment 351059 Patch 1464332 2 mattbaker 2018-09-28 00:31:44 -0700 I tried to repro this and was able to view some images and not others. Steps to reproduce or screenshots would be help to clarify and illustrate the problem. 1464333 3 mattbaker 2018-09-28 00:37:18 -0700 (In reply to Matt Baker from comment #2) > I tried to repro this and was able to view some images and not others. Steps > to reproduce or screenshots would be help to clarify and illustrate the > problem. Disregard, I misread the bug description. 1464334 4 351059 mattbaker 2018-09-28 00:38:13 -0700 Comment on attachment 351059 Patch r=me 1464340 5 351059 commit-queue 2018-09-28 01:04:17 -0700 Comment on attachment 351059 Patch Clearing flags on attachment: 351059 Committed r236596: <https://trac.webkit.org/changeset/236596> 1464341 6 commit-queue 2018-09-28 01:04:19 -0700 All reviewed patches have been landed. Closing bug. 1464342 7 webkit-bug-importer 2018-09-28 01:05:42 -0700 <rdar://problem/44857443> 351059 2018-09-27 23:44:29 -0700 2018-09-28 01:04:17 -0700 Patch bug-190072-20180927234428.patch text/plain 1584 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDdjYjgxM2YwYWM4MTE4NWI2NDc4NDcxOTBkODBk Mjk1YTdmMzA5YWMuLmFiZWM5ZmJjNTFjNjllY2Q0ZTVhZmM2YTdjMWU0NTU3ODczNmI0ZDQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA5LTI3ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBp bWFnZSByZXNvdXJjZXMgd2l0aG91dCBjb250ZW50IGFyZSBzdGlsbCBzaG93biB3aGVuIHRoZSBJ bWFnZXMgZm9sZGVyIGlzIHNlbGVjdGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTAwNzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VDb250ZW50Vmll dy5qczoKKyAgICAgICAgKFdJLlJlc291cmNlQ29udGVudFZpZXcucHJvdG90eXBlLnNob3dHZW5l cmljTm9Db250ZW50TWVzc2FnZSk6CisgICAgICAgIFRyZWF0IHBhdGhzIHRoYXQgcmVzdWx0IGlu IGEgIlJlc291cmNlIGhhcyBubyBjb250ZW50IiBtZXNzYWdlIGFzIGEgImNvbnRlbnQgZXJyb3Ii LgorCiAyMDE4LTA5LTI2ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBIaWRlIERPTSBhbmQgWEhSIGJyZWFrcG9pbnQgc2VjdGlvbnMg d2hlbiB0aGV5IGFyZSBlbXB0eQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlQ29udGVudFZpZXcuanMKaW5kZXgg ZjVkZmU0NjM2MTkxOGY1NDM3N2JmNjNhMDJiZWVjYTEwOGFmMDI5ZC4uMTMwZGY1NmQxZGJkZTE5 NjVmOGI0MTEwNGE3NjQzNmM3MjI4ZjFhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VDb250ZW50Vmlldy5qcworKysgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZUNvbnRlbnRWaWV3 LmpzCkBAIC04NCw2ICs4NCw4IEBAIFdJLlJlc291cmNlQ29udGVudFZpZXcgPSBjbGFzcyBSZXNv dXJjZUNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29udGVudFZpZXcKICAgICBzaG93R2VuZXJpY05v Q29udGVudE1lc3NhZ2UoKQogICAgIHsKICAgICAgICAgdGhpcy5zaG93TWVzc2FnZShXSS5VSVN0 cmluZygiUmVzb3VyY2UgaGFzIG5vIGNvbnRlbnQiKSk7CisKKyAgICAgICAgdGhpcy5kaXNwYXRj aEV2ZW50VG9MaXN0ZW5lcnMoV0kuUmVzb3VyY2VDb250ZW50Vmlldy5FdmVudC5Db250ZW50RXJy b3IpOwogICAgIH0KIAogICAgIHNob3dHZW5lcmljRXJyb3JNZXNzYWdlKCkK