<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>190071</bug_id>
          
          <creation_ts>2018-09-27 23:37:03 -0700</creation_ts>
          <short_desc>[WinCairo] error C2027: use of undefined type &apos;WTF::EnumTraits&lt;E&gt;&apos; while compiling AuthenticationChallengeProxy.cpp</short_desc>
          <delta_ts>2018-09-28 00:09:28 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Fujii Hironori">fujii</reporter>
          <assigned_to name="Fujii Hironori">fujii</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1464318</commentid>
    <comment_count>0</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-09-27 23:37:03 -0700</bug_when>
    <thetext>WinCairo Debug builds can&apos;t compile AuthenticationChallengeProxy.cpp.

https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Debug%20%28Build%29/builds/3187/

&gt; [5941/6192] Building CXX object Source\WebKit\CMakeFiles\WebKit.dir\__\__\DerivedSources\WebKit\unified-sources\UnifiedSource34.cpp.obj
&gt; FAILED: Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/unified-sources/UnifiedSource34.cpp.obj 
&gt; &quot;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.14.26428\bin\Hostx64\x64\cl.exe&quot;  (...) /FS -c DerivedSources\WebKit\unified-sources\UnifiedSource34.cpp
&gt; C:\WebKit-BuildWorker\wincairo-wkl-debug\build\WebKitBuild\Debug\DerivedSources\ForwardingHeaders\wtf/EnumTraits.h(59): error C2027: use of undefined type &apos;WTF::EnumTraits&lt;E&gt;&apos;
&gt;         with
&gt;         [
&gt;             E=WebKit::AuthenticationChallengeDisposition
&gt;         ]
&gt; C:\WebKit-BuildWorker\wincairo-wkl-debug\build\WebKitBuild\Debug\DerivedSources\ForwardingHeaders\wtf/EnumTraits.h(59): note: see declaration of &apos;WTF::EnumTraits&lt;E&gt;&apos;
&gt;         with
&gt;         [
&gt;             E=WebKit::AuthenticationChallengeDisposition
&gt;         ]
&gt; c:\webkit-buildworker\wincairo-wkl-debug\build\source\webkit\platform\ipc\Encoder.h(116): note: see reference to function template instantiation &apos;bool WTF::isValidEnum&lt;E,uint64_t&gt;(T)&apos; being compiled
&gt;         with
&gt;         [
&gt;             E=WebKit::AuthenticationChallengeDisposition,
&gt;             T=uint64_t
&gt;         ]
&gt; c:\webkit-buildworker\wincairo-wkl-debug\build\source\webkit\platform\ipc\Encoder.h(84): note: see reference to function template instantiation &apos;void IPC::Encoder::encode&lt;WebKit::AuthenticationChallengeDisposition&gt;(E)&apos; being compiled
&gt;         with
&gt;         [
&gt;             E=WebKit::AuthenticationChallengeDisposition
&gt;         ]
&gt; C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Platform\IPC\ArgumentCoders.h(165): note: see reference to function template instantiation &apos;IPC::Encoder &amp;IPC::Encoder::operator &lt;&lt;&lt;const WebKit::AuthenticationChallengeDisposition&amp;,0x0&gt;(T)&apos; being compiled
&gt;         with
&gt;         [
&gt;             T=const WebKit::AuthenticationChallengeDisposition &amp;
&gt;         ]
&gt; C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Platform\IPC\ArgumentCoders.h(165): note: while compiling class template member function &apos;void IPC::TupleCoder&lt;2,uint64_t,WebKit::AuthenticationChallengeDisposition,const WebCore::Credential &amp;&gt;::encode(IPC::Encoder &amp;,const std::tuple&lt;uint64_t,WebKit::AuthenticationChallengeDisposition,const WebCore::Credential &amp;&gt; &amp;)&apos;
&gt; C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Platform\IPC\ArgumentCoders.h(167): note: see reference to function template instantiation &apos;void IPC::TupleCoder&lt;2,uint64_t,WebKit::AuthenticationChallengeDisposition,const WebCore::Credential &amp;&gt;::encode(IPC::Encoder &amp;,const std::tuple&lt;uint64_t,WebKit::AuthenticationChallengeDisposition,const WebCore::Credential &amp;&gt; &amp;)&apos; being compiled
&gt; C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Platform\IPC\ArgumentCoders.h(165): note: see reference to class template instantiation &apos;IPC::TupleCoder&lt;2,uint64_t,WebKit::AuthenticationChallengeDisposition,const WebCore::Credential &amp;&gt;&apos; being compiled
&gt; C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Platform\IPC\ArgumentCoders.h(165): note: while compiling class template member function &apos;void IPC::TupleCoder&lt;3,uint64_t,WebKit::AuthenticationChallengeDisposition,const WebCore::Credential &amp;&gt;::encode(IPC::Encoder &amp;,const std::tuple&lt;uint64_t,WebKit::AuthenticationChallengeDisposition,const WebCore::Credential &amp;&gt; &amp;)&apos;
&gt; C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Platform\IPC\ArgumentCoders.h(205): note: see reference to function template instantiation &apos;void IPC::TupleCoder&lt;3,uint64_t,WebKit::AuthenticationChallengeDisposition,const WebCore::Credential &amp;&gt;::encode(IPC::Encoder &amp;,const std::tuple&lt;uint64_t,WebKit::AuthenticationChallengeDisposition,const WebCore::Credential &amp;&gt; &amp;)&apos; being compiled
&gt; C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Platform\IPC\ArgumentCoders.h(204): note: see reference to class template instantiation &apos;IPC::TupleCoder&lt;3,uint64_t,WebKit::AuthenticationChallengeDisposition,const WebCore::Credential &amp;&gt;&apos; being compiled
&gt; C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Platform\IPC\ArgumentCoders.h(204): note: while compiling class template member function &apos;void IPC::ArgumentCoder&lt;std::tuple&lt;uint64_t,WebKit::AuthenticationChallengeDisposition,const WebCore::Credential &amp;&gt;&gt;::encode(IPC::Encoder &amp;,const std::tuple&lt;uint64_t,WebKit::AuthenticationChallengeDisposition,const WebCore::Credential &amp;&gt; &amp;)&apos;
&gt; c:\webkit-buildworker\wincairo-wkl-debug\build\source\webkit\platform\ipc\Encoder.h(71): note: see reference to function template instantiation &apos;void IPC::ArgumentCoder&lt;std::tuple&lt;uint64_t,WebKit::AuthenticationChallengeDisposition,const WebCore::Credential &amp;&gt;&gt;::encode(IPC::Encoder &amp;,const std::tuple&lt;uint64_t,WebKit::AuthenticationChallengeDisposition,const WebCore::Credential &amp;&gt; &amp;)&apos; being compiled
&gt; c:\webkit-buildworker\wincairo-wkl-debug\build\source\webkit\platform\ipc\Encoder.h(71): note: see reference to class template instantiation &apos;IPC::ArgumentCoder&lt;std::tuple&lt;uint64_t,WebKit::AuthenticationChallengeDisposition,const WebCore::Credential &amp;&gt;&gt;&apos; being compiled
&gt; C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\Platform\IPC\Connection.h(407): note: see reference to function template instantiation &apos;void IPC::Encoder::encode&lt;const Messages::AuthenticationManager::CompleteAuthenticationChallenge::Arguments&amp;,0x0&gt;(T)&apos; being compiled
&gt;         with
&gt;         [
&gt;             T=const Messages::AuthenticationManager::CompleteAuthenticationChallenge::Arguments &amp;
&gt;         ]
&gt; C:\WebKit-BuildWorker\wincairo-wkl-debug\build\Source\WebKit\UIProcess/Authentication/AuthenticationChallengeProxy.cpp(55): note: see reference to function template instantiation &apos;bool IPC::Connection::send&lt;Messages::AuthenticationManager::CompleteAuthenticationChallenge&gt;(T &amp;&amp;,uint64_t,WTF::OptionSet&lt;IPC::SendOption&gt;)&apos; being compiled
&gt;         with
&gt;         [
&gt;             T=Messages::AuthenticationManager::CompleteAuthenticationChallenge
&gt;         ]
&gt; C:\WebKit-BuildWorker\wincairo-wkl-debug\build\WebKitBuild\Debug\DerivedSources\ForwardingHeaders\wtf/EnumTraits.h(59): error C2146: syntax error: missing &apos;&gt;&apos; before identifier &apos;values&apos;
&gt; C:\WebKit-BuildWorker\wincairo-wkl-debug\build\WebKitBuild\Debug\DerivedSources\ForwardingHeaders\wtf/EnumTraits.h(59): error C2027: use of undefined type &apos;WTF::EnumValueChecker&lt;T,int&gt;&apos;
&gt;         with
&gt;         [
&gt;             T=uint64_t
&gt;         ]
&gt; C:\WebKit-BuildWorker\wincairo-wkl-debug\build\WebKitBuild\Debug\DerivedSources\ForwardingHeaders\wtf/EnumTraits.h(59): note: see declaration of &apos;WTF::EnumValueChecker&lt;T,int&gt;&apos;
&gt;         with
&gt;         [
&gt;             T=uint64_t
&gt;         ]
&gt; C:\WebKit-BuildWorker\wincairo-wkl-debug\build\WebKitBuild\Debug\DerivedSources\ForwardingHeaders\wtf/EnumTraits.h(59): error C2672: &apos;WTF::isValidEnum&apos;: no matching overloaded function found
&gt; C:\WebKit-BuildWorker\wincairo-wkl-debug\build\WebKitBuild\Debug\DerivedSources\ForwardingHeaders\wtf/EnumTraits.h(59): error C2783: &apos;enable_if&lt;_Test,_Ty&gt;::type WTF::isValidEnum(T)&apos;: could not deduce template argument for &apos;E&apos;
&gt;         with
&gt;         [
&gt;             _Ty=bool
&gt;         ]
&gt; C:\WebKit-BuildWorker\wincairo-wkl-debug\build\WebKitBuild\Debug\DerivedSources\ForwardingHeaders\wtf/EnumTraits.h(55): note: see declaration of &apos;WTF::isValidEnum&apos;
&gt; [5942/6192] Building CXX object Source\WebKit\CMakeFiles\WebKit.dir\__\__\DerivedSources\WebKit\unified-sources\UnifiedSource25.cpp.obj
&gt; c:\webkit-buildworker\wincairo-wkl-debug\build\source\webkit\uiprocess\webpageproxy.cpp(6145) : warning C4701: potentially uninitialized local variable &apos;error&apos; used
&gt; [5943/6192] Building CXX object Source\WebKit\CMakeFiles\WebKit.dir\__\__\DerivedSources\WebKit\unified-sources\UnifiedSource38.cpp.obj
&gt; [5944/6192] Building CXX object Source\WebKit\CMakeFiles\WebKit.dir\__\__\DerivedSources\WebKit\unified-sources\UnifiedSource36.cpp.obj
&gt; [5945/6192] Building CXX object Source\WebKit\CMakeFiles\WebKit.dir\__\__\DerivedSources\WebKit\unified-sources\UnifiedSource37.cpp.obj
&gt; [5946/6192] Building CXX object Source\WebKit\CMakeFiles\WebKit.dir\__\__\DerivedSources\WebKit\unified-sources\UnifiedSource35.cpp.obj
&gt; [5947/6192] Building CXX object Source\WebKit\CMakeFiles\WebKit.dir\__\__\DerivedSources\WebKit\unified-sources\UnifiedSource33.cpp.obj
&gt; [5948/6192] Building CXX object Source\WebKit\CMakeFiles\WebKit.dir\__\__\DerivedSources\WebKit\unified-sources\UnifiedSource42.cpp.obj
&gt; [5949/6192] Building CXX object Source\WebKit\CMakeFiles\WebKit.dir\__\__\DerivedSources\WebKit\unified-sources\UnifiedSource41.cpp.obj
&gt; [5950/6192] Building CXX object Source\WebKit\CMakeFiles\WebKit.dir\__\__\DerivedSources\WebKit\unified-sources\UnifiedSource39.cpp.obj
&gt; ninja: build stopped: subcommand failed.
&gt; 
&gt; 
&gt; ===== BUILD FAILED ======</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1464320</commentid>
    <comment_count>1</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-09-27 23:37:57 -0700</bug_when>
    <thetext>Bug 189719 seems the culprit.
http://trac.webkit.org/r236344</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1464323</commentid>
    <comment_count>2</comment_count>
      <attachid>351060</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-09-27 23:50:11 -0700</bug_when>
    <thetext>Created attachment 351060
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1464327</commentid>
    <comment_count>3</comment_count>
      <attachid>351060</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-09-28 00:08:18 -0700</bug_when>
    <thetext>Comment on attachment 351060
Patch

Clearing flags on attachment: 351060

Committed r236595: &lt;https://trac.webkit.org/changeset/236595&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1464328</commentid>
    <comment_count>4</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-09-28 00:08:20 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1464329</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-09-28 00:09:28 -0700</bug_when>
    <thetext>&lt;rdar://problem/44856594&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>351060</attachid>
            <date>2018-09-27 23:50:11 -0700</date>
            <delta_ts>2018-09-27 23:50:11 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-190071-20180928155010.patch</filename>
            <type>text/plain</type>
            <size>1518</size>
            <attacher name="Fujii Hironori">fujii</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdjNzM0MTRkMmJkMjI2OWNi
YzJkOWJlMzcxMjI2YWYzNjUyOWEwZmMuLjRmMWMxMmQ5M2QxZDJhZDVkNTY1MjA4MjAyNzg2Nzhj
YjM0N2RmNDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMDktMjcgIEZ1amlpIEhp
cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXSBl
cnJvciBDMjAyNzogdXNlIG9mIHVuZGVmaW5lZCB0eXBlICdXVEY6OkVudW1UcmFpdHM8RT4nIHdo
aWxlIGNvbXBpbGluZyBBdXRoZW50aWNhdGlvbkNoYWxsZW5nZVByb3h5LmNwcAorICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMDcxCisKKyAgICAgICAg
VW5yZXZpZXdlZCBidWlsZCBmaXggZm9yIFdpbkNhaXJvIHBvcnQuCisKKyAgICAgICAgQXV0aGVu
dGljYXRpb25DaGFsbGVuZ2VEaXNwb3NpdGlvbiB3YXMgbm90IGRlZmluZWQgaW4gdGhpcyBmaWxl
LgorCisgICAgICAgICogVUlQcm9jZXNzL0F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uQ2hh
bGxlbmdlUHJveHkuY3BwOiBJbmNsdWRlICJBdXRoZW50aWNhdGlvbkNoYWxsZW5nZURpc3Bvc2l0
aW9uLmgiLgorCiAyMDE4LTA5LTI2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgog
CiAgICAgICAgIFVzZSBlbnVtIGNsYXNzIGluIGNyZWF0ZU1hcmt1cCBhcmd1bWVudHMKZGlmZiAt
LWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0
aW9uQ2hhbGxlbmdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXV0aGVudGlj
YXRpb24vQXV0aGVudGljYXRpb25DaGFsbGVuZ2VQcm94eS5jcHAKaW5kZXggZTU5ZDA5Y2QwY2I0
NTY5Mzc1Yzc1MzRhOTNkODc4YTRlMWM0MDIzNC4uYjJjODllMjYxNTNhZDAwZWJiZjk1ZWQ0ZTFh
ZGU0NDdlOTU4YTg1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXV0aGVu
dGljYXRpb24vQXV0aGVudGljYXRpb25DaGFsbGVuZ2VQcm94eS5jcHAKKysrIGIvU291cmNlL1dl
YktpdC9VSVByb2Nlc3MvQXV0aGVudGljYXRpb24vQXV0aGVudGljYXRpb25DaGFsbGVuZ2VQcm94
eS5jcHAKQEAgLTI2LDYgKzI2LDcgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJB
dXRoZW50aWNhdGlvbkNoYWxsZW5nZVByb3h5LmgiCiAKKyNpbmNsdWRlICJBdXRoZW50aWNhdGlv
bkNoYWxsZW5nZURpc3Bvc2l0aW9uLmgiCiAjaW5jbHVkZSAiQXV0aGVudGljYXRpb25EZWNpc2lv
bkxpc3RlbmVyLmgiCiAjaW5jbHVkZSAiQXV0aGVudGljYXRpb25NYW5hZ2VyLmgiCiAjaW5jbHVk
ZSAiQXV0aGVudGljYXRpb25NYW5hZ2VyTWVzc2FnZXMuaCIK
</data>

          </attachment>
      

    </bug>

</bugzilla>