190066 2018-09-27 19:34:56 -0700 DFG::OSRExit::m_patchableCodeOffset should not be an int 2018-09-27 21:47:07 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin fpizlo ggaren gskachkov keith_miller mark.lam msaboff rmorisset ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1464267 0 saam 2018-09-27 19:34:56 -0700 ... 1464270 1 saam 2018-09-27 19:41:43 -0700 <rdar://problem/39498244> 1464271 2 351041 saam 2018-09-27 19:42:48 -0700 Created attachment 351041 patch 1464298 3 351041 mark.lam 2018-09-27 21:42:24 -0700 Comment on attachment 351041 patch r=me 1464300 4 saam 2018-09-27 21:47:07 -0700 landed in: https://trac.webkit.org/changeset/236585/webkit 351041 2018-09-27 19:42:48 -0700 2018-09-27 21:42:24 -0700 patch a-backup.diff text/plain 6087 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjM2NTgxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDE4LTA5LTI3ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IERGRzo6T1NSRXhpdDo6bV9wYXRjaGFibGVDb2RlT2Zmc2V0IHNob3VsZCBub3QgYmUgYW4gaW50 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTAwNjYK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM5NDk4MjQ0PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR0pJVENvbXBpbGVyLmNwcDoKKyAg ICAgICAgKEpTQzo6REZHOjpKSVRDb21waWxlcjo6bGlua09TUkV4aXRzKToKKyAgICAgICAgKEpT Qzo6REZHOjpKSVRDb21waWxlcjo6bGluayk6CisgICAgICAgICogZGZnL0RGR09TUkV4aXQuY3Bw OgorICAgICAgICAoSlNDOjpERkc6Ok9TUkV4aXQ6OmNvZGVMb2NhdGlvbkZvclJlcGF0Y2ggY29u c3QpOgorICAgICAgICAoSlNDOjpERkc6Ok9TUkV4aXQ6OmNvbXBpbGVPU1JFeGl0KToKKyAgICAg ICAgKEpTQzo6REZHOjpPU1JFeGl0OjpzZXRQYXRjaGFibGVDb2RlT2Zmc2V0KTogRGVsZXRlZC4K KyAgICAgICAgKEpTQzo6REZHOjpPU1JFeGl0OjpnZXRQYXRjaGFibGVDb2RlT2Zmc2V0QXNKdW1w IGNvbnN0KTogRGVsZXRlZC4KKyAgICAgICAgKEpTQzo6REZHOjpPU1JFeGl0Ojpjb3JyZWN0SnVt cCk6IERlbGV0ZWQuCisgICAgICAgICogZGZnL0RGR09TUkV4aXQuaDoKKyAgICAgICAgKiBkZmcv REZHT1NSRXhpdENvbXBpbGF0aW9uSW5mby5oOgorCiAyMDE4LTA5LTI3ICBNYXJrIExhbSAgPG1h cmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBERkc6Ok9TUkVudHJ5OjptX21hY2hpbmVDb2Rl T2Zmc2V0IHNob3VsZCBiZSBhIENvZGVMb2NhdGlvbi4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHSklUQ29tcGlsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHSklUQ29tcGlsZXIuY3BwCShyZXZpc2lvbiAyMzY1NzgpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvbXBpbGVyLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTAyLDEwICsxMDIsOCBAQCB2b2lkIEpJVENvbXBpbGVyOjpsaW5rT1NSRXhpdHMoKQogICAg ICAgICAgICAgYWRkTGlua1Rhc2soW3RhcmdldCwgb3NyRXhpdFRodW5rTGFiZWxdIChMaW5rQnVm ZmVyJiBsaW5rQnVmZmVyKSB7CiAgICAgICAgICAgICAgICAgbGlua0J1ZmZlci5saW5rKHRhcmdl dCwgb3NyRXhpdFRodW5rTGFiZWwpOwogICAgICAgICAgICAgfSk7Ci0gICAgICAgIH0gZWxzZSB7 Ci0gICAgICAgICAgICBPU1JFeGl0JiBleGl0ID0gbV9qaXRDb2RlLT5vc3JFeGl0W2ldOwotICAg ICAgICAgICAgZXhpdC5zZXRQYXRjaGFibGVDb2RlT2Zmc2V0KHBhdGNoYWJsZUp1bXAoKSk7Ci0g ICAgICAgIH0KKyAgICAgICAgfSBlbHNlCisgICAgICAgICAgICBpbmZvLm1fcGF0Y2hhYmxlSnVt cCA9IHBhdGNoYWJsZUp1bXAoKTsKICAgICB9CiB9CiAKQEAgLTMwMCw5ICsyOTgsOSBAQCB2b2lk IEpJVENvbXBpbGVyOjpsaW5rKExpbmtCdWZmZXImIGxpbmtCCiAgICAgZm9yICh1bnNpZ25lZCBp ID0gMDsgaSA8IG1faml0Q29kZS0+b3NyRXhpdC5zaXplKCk7ICsraSkgewogICAgICAgICBPU1JF eGl0Q29tcGlsYXRpb25JbmZvJiBpbmZvID0gbV9leGl0Q29tcGlsYXRpb25JbmZvW2ldOwogICAg ICAgICBpZiAoIU9wdGlvbnM6OnVzZVByb2JlT1NSRXhpdCgpKSB7CisgICAgICAgICAgICBsaW5r QnVmZmVyLmxpbmsoaW5mby5tX3BhdGNoYWJsZUp1bXAubV9qdW1wLCB0YXJnZXQpOwogICAgICAg ICAgICAgT1NSRXhpdCYgZXhpdCA9IG1faml0Q29kZS0+b3NyRXhpdFtpXTsKLSAgICAgICAgICAg IGxpbmtCdWZmZXIubGluayhleGl0LmdldFBhdGNoYWJsZUNvZGVPZmZzZXRBc0p1bXAoKSwgdGFy Z2V0KTsKLSAgICAgICAgICAgIGV4aXQuY29ycmVjdEp1bXAobGlua0J1ZmZlcik7CisgICAgICAg ICAgICBleGl0Lm1fcGF0Y2hhYmxlSnVtcExvY2F0aW9uID0gbGlua0J1ZmZlci5sb2NhdGlvbk9m PEpTSW50ZXJuYWxQdHJUYWc+KGluZm8ubV9wYXRjaGFibGVKdW1wKTsKICAgICAgICAgfQogICAg ICAgICBpZiAoaW5mby5tX3JlcGxhY2VtZW50U291cmNlLmlzU2V0KCkpIHsKICAgICAgICAgICAg IG1faml0Q29kZS0+Y29tbW9uLmp1bXBSZXBsYWNlbWVudHMuYXBwZW5kKEp1bXBSZXBsYWNlbWVu dCgKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPU1JFeGl0LmNwcAkocmV2aXNp b24gMjM2NTc4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPU1JFeGl0LmNwcAko d29ya2luZyBjb3B5KQpAQCAtOTIxLDI2ICs5MjEsOSBAQCBPU1JFeGl0OjpPU1JFeGl0KEV4aXRL aW5kIGtpbmQsIEpTVmFsdWVTCiAgICAgREZHX0FTU0VSVChqaXQtPm1faml0LmdyYXBoKCksIGpp dC0+bV9jdXJyZW50Tm9kZSwgY2FuRXhpdCk7CiB9CiAKLXZvaWQgT1NSRXhpdDo6c2V0UGF0Y2hh YmxlQ29kZU9mZnNldChNYWNyb0Fzc2VtYmxlcjo6UGF0Y2hhYmxlSnVtcCBjaGVjaykKK0NvZGVM b2NhdGlvbkp1bXA8SlNJbnRlcm5hbFB0clRhZz4gT1NSRXhpdDo6Y29kZUxvY2F0aW9uRm9yUmVw YXRjaCgpIGNvbnN0CiB7Ci0gICAgbV9wYXRjaGFibGVDb2RlT2Zmc2V0ID0gY2hlY2subV9qdW1w Lm1fbGFiZWwubV9vZmZzZXQ7Ci19Ci0KLU1hY3JvQXNzZW1ibGVyOjpKdW1wIE9TUkV4aXQ6Omdl dFBhdGNoYWJsZUNvZGVPZmZzZXRBc0p1bXAoKSBjb25zdAotewotICAgIHJldHVybiBNYWNyb0Fz c2VtYmxlcjo6SnVtcChBc3NlbWJsZXJMYWJlbChtX3BhdGNoYWJsZUNvZGVPZmZzZXQpKTsKLX0K LQotQ29kZUxvY2F0aW9uSnVtcDxKU0ludGVybmFsUHRyVGFnPiBPU1JFeGl0Ojpjb2RlTG9jYXRp b25Gb3JSZXBhdGNoKENvZGVCbG9jayogZGZnQ29kZUJsb2NrKSBjb25zdAotewotICAgIHJldHVy biBDb2RlTG9jYXRpb25KdW1wPEpTSW50ZXJuYWxQdHJUYWc+KHRhZ0NvZGVQdHI8SlNJbnRlcm5h bFB0clRhZz4oZGZnQ29kZUJsb2NrLT5qaXRDb2RlKCktPmRhdGFBZGRyZXNzQXRPZmZzZXQobV9w YXRjaGFibGVDb2RlT2Zmc2V0KSkpOwotfQotCi12b2lkIE9TUkV4aXQ6OmNvcnJlY3RKdW1wKExp bmtCdWZmZXImIGxpbmtCdWZmZXIpCi17Ci0gICAgTWFjcm9Bc3NlbWJsZXI6OkxhYmVsIGxhYmVs OwotICAgIGxhYmVsLm1fbGFiZWwubV9vZmZzZXQgPSBtX3BhdGNoYWJsZUNvZGVPZmZzZXQ7Ci0g ICAgbV9wYXRjaGFibGVDb2RlT2Zmc2V0ID0gbGlua0J1ZmZlci5vZmZzZXRPZihsYWJlbCk7Cisg ICAgcmV0dXJuIENvZGVMb2NhdGlvbkp1bXA8SlNJbnRlcm5hbFB0clRhZz4obV9wYXRjaGFibGVK dW1wTG9jYXRpb24pOwogfQogCiB2b2lkIE9TUkV4aXQ6OmVtaXRSZXN0b3JlQXJndW1lbnRzKEND YWxsSGVscGVycyYgaml0LCBjb25zdCBPcGVyYW5kczxWYWx1ZVJlY292ZXJ5PiYgb3BlcmFuZHMp CkBAIC0xMDgyLDcgKzEwNjUsNyBAQCB2b2lkIEpJVF9PUEVSQVRJT04gT1NSRXhpdDo6Y29tcGls ZU9TUkV4CiAgICAgICAgICAgICAgICAgdG9DU3RyaW5nKGlnbm9yaW5nQ29udGV4dDxEdW1wQ29u dGV4dD4ob3BlcmFuZHMpKS5kYXRhKCkpOwogICAgIH0KIAotICAgIE1hY3JvQXNzZW1ibGVyOjpy ZXBhdGNoSnVtcChleGl0LmNvZGVMb2NhdGlvbkZvclJlcGF0Y2goY29kZUJsb2NrKSwgQ29kZUxv Y2F0aW9uTGFiZWw8T1NSRXhpdFB0clRhZz4oZXhpdC5tX2NvZGUuY29kZSgpKSk7CisgICAgTWFj cm9Bc3NlbWJsZXI6OnJlcGF0Y2hKdW1wKGV4aXQuY29kZUxvY2F0aW9uRm9yUmVwYXRjaCgpLCBD b2RlTG9jYXRpb25MYWJlbDxPU1JFeGl0UHRyVGFnPihleGl0Lm1fY29kZS5jb2RlKCkpKTsKIAog ICAgIHZtLT5vc3JFeGl0SnVtcERlc3RpbmF0aW9uID0gZXhpdC5tX2NvZGUuY29kZSgpLmV4ZWN1 dGFibGVBZGRyZXNzKCk7CiB9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09T UkV4aXQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkV4 aXQuaAkocmV2aXNpb24gMjM2NTc4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdP U1JFeGl0LmgJKHdvcmtpbmcgY29weSkKQEAgLTE0NSw4ICsxNDUsNyBAQCBzdHJ1Y3QgT1NSRXhp dCA6IHB1YmxpYyBPU1JFeGl0QmFzZSB7CiAgICAgc3RhdGljIHZvaWQgSklUX09QRVJBVElPTiBj b21waWxlT1NSRXhpdChFeGVjU3RhdGUqKSBXVEZfSU5URVJOQUw7CiAgICAgc3RhdGljIHZvaWQg ZXhlY3V0ZU9TUkV4aXQoUHJvYmU6OkNvbnRleHQmKTsKIAotICAgIC8vIEZJWE1FOiA8cmRhcjov L3Byb2JsZW0vMzk0OTgyNDQ+LgotICAgIHVuc2lnbmVkIG1fcGF0Y2hhYmxlQ29kZU9mZnNldCB7 IDAgfTsKKyAgICBDb2RlTG9jYXRpb25MYWJlbDxKU0ludGVybmFsUHRyVGFnPiBtX3BhdGNoYWJs ZUp1bXBMb2NhdGlvbjsKICAgICBNYWNyb0Fzc2VtYmxlckNvZGVSZWY8T1NSRXhpdFB0clRhZz4g bV9jb2RlOwogCiAgICAgUmVmUHRyPE9TUkV4aXRTdGF0ZT4gZXhpdFN0YXRlOwpAQCAtMTU2LDEw ICsxNTUsNyBAQCBzdHJ1Y3QgT1NSRXhpdCA6IHB1YmxpYyBPU1JFeGl0QmFzZSB7CiAgICAgCiAg ICAgdW5zaWduZWQgbV9yZWNvdmVyeUluZGV4OwogCi0gICAgdm9pZCBzZXRQYXRjaGFibGVDb2Rl T2Zmc2V0KE1hY3JvQXNzZW1ibGVyOjpQYXRjaGFibGVKdW1wKTsKLSAgICBNYWNyb0Fzc2VtYmxl cjo6SnVtcCBnZXRQYXRjaGFibGVDb2RlT2Zmc2V0QXNKdW1wKCkgY29uc3Q7Ci0gICAgQ29kZUxv Y2F0aW9uSnVtcDxKU0ludGVybmFsUHRyVGFnPiBjb2RlTG9jYXRpb25Gb3JSZXBhdGNoKENvZGVC bG9jayopIGNvbnN0OwotICAgIHZvaWQgY29ycmVjdEp1bXAoTGlua0J1ZmZlciYpOworICAgIENv ZGVMb2NhdGlvbkp1bXA8SlNJbnRlcm5hbFB0clRhZz4gY29kZUxvY2F0aW9uRm9yUmVwYXRjaCgp IGNvbnN0OwogCiAgICAgdW5zaWduZWQgbV9zdHJlYW1JbmRleDsKICAgICB2b2lkIGNvbnNpZGVy QWRkaW5nQXNGcmVxdWVudEV4aXRTaXRlKENvZGVCbG9jayogcHJvZmlsZWRDb2RlQmxvY2spCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkV4aXRDb21waWxhdGlvbkluZm8u aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkV4aXRDb21w aWxhdGlvbkluZm8uaAkocmV2aXNpb24gMjM2NTc4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdPU1JFeGl0Q29tcGlsYXRpb25JbmZvLmgJKHdvcmtpbmcgY29weSkKQEAgLTM1LDYg KzM1LDcgQEAgc3RydWN0IE9TUkV4aXRDb21waWxhdGlvbkluZm8gewogICAgIE1hY3JvQXNzZW1i bGVyOjpKdW1wTGlzdCBtX2ZhaWx1cmVKdW1wczsKICAgICBNYWNyb0Fzc2VtYmxlcjo6TGFiZWwg bV9yZXBsYWNlbWVudFNvdXJjZTsKICAgICBNYWNyb0Fzc2VtYmxlcjo6TGFiZWwgbV9yZXBsYWNl bWVudERlc3RpbmF0aW9uOworICAgIE1hY3JvQXNzZW1ibGVyOjpQYXRjaGFibGVKdW1wIG1fcGF0 Y2hhYmxlSnVtcDsKIH07CiAKIH0gfSAvLyBuYW1lc3BhY2UgSlNDOjpERkcK