190064 2018-09-27 17:53:16 -0700 Don't use int offsets in StructureStubInfo 2018-09-27 21:27:32 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin fpizlo ggaren gskachkov keith_miller mark.lam msaboff rmorisset ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1464243 0 saam 2018-09-27 17:53:16 -0700 ... 1464244 1 saam 2018-09-27 17:54:16 -0700 <rdar://problem/44784719> 1464258 2 351036 saam 2018-09-27 18:51:38 -0700 Created attachment 351036 patch 1464286 3 351036 mark.lam 2018-09-27 21:05:14 -0700 Comment on attachment 351036 patch View in context: https://bugs.webkit.org/attachment.cgi?id=351036&action=review r=me. > Source/JavaScriptCore/bytecode/StructureStubInfo.h:189 > RegisterSet usedRegisters; I suggest moving this after the CodeLocations for better packing of this struct. It was well packed before with the trailing 32-bit ints. It won't be anymore with the 64-bit CodeLocations, unless we move it after. 1464294 4 saam 2018-09-27 21:27:32 -0700 landed in: https://trac.webkit.org/changeset/236584/webkit 351036 2018-09-27 18:51:38 -0700 2018-09-27 21:05:14 -0700 patch a-backup.diff text/plain 5793 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjM2NTgxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE4LTA5LTI3ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IERvbid0IHVzZSBpbnQgb2Zmc2V0cyBpbiBTdHJ1Y3R1cmVTdHViSW5mbworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMDY0CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS80NDc4NDcxOT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGJ5dGVjb2RlL0lubGluZUFjY2Vzcy5jcHA6CisgICAgICAgIChKU0M6 OmxpbmtDb2RlSW5saW5lKToKKyAgICAgICAgKiBieXRlY29kZS9TdHJ1Y3R1cmVTdHViSW5mby5o OgorICAgICAgICAoSlNDOjpTdHJ1Y3R1cmVTdHViSW5mbzo6c2xvd1BhdGhDYWxsTG9jYXRpb24p OgorICAgICAgICAoSlNDOjpTdHJ1Y3R1cmVTdHViSW5mbzo6ZG9uZUxvY2F0aW9uKToKKyAgICAg ICAgKEpTQzo6U3RydWN0dXJlU3R1YkluZm86OnNsb3dQYXRoU3RhcnRMb2NhdGlvbik6CisgICAg ICAgICogaml0L0pJVElubGluZUNhY2hlR2VuZXJhdG9yLmNwcDoKKyAgICAgICAgKEpTQzo6SklU SW5saW5lQ2FjaGVHZW5lcmF0b3I6OmZpbmFsaXplKToKKwogMjAxOC0wOS0yNyAgTWFyayBMYW0g IDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgREZHOjpPU1JFbnRyeTo6bV9tYWNoaW5l Q29kZU9mZnNldCBzaG91bGQgYmUgYSBDb2RlTG9jYXRpb24uCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvYnl0ZWNvZGUvSW5saW5lQWNjZXNzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvSW5saW5lQWNjZXNzLmNwcAkocmV2aXNpb24gMjM2NTc4 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0lubGluZUFjY2Vzcy5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTE0Miw5ICsxNDIsOSBAQCB2b2lkIElubGluZUFjY2Vzczo6ZHVtcENh Y2hlU2l6ZXNBbmRDcmFzCiB0ZW1wbGF0ZSA8dHlwZW5hbWUgRnVuY3Rpb24+CiBBTFdBWVNfSU5M SU5FIHN0YXRpYyBib29sIGxpbmtDb2RlSW5saW5lKGNvbnN0IGNoYXIqIG5hbWUsIENDYWxsSGVs cGVycyYgaml0LCBTdHJ1Y3R1cmVTdHViSW5mbyYgc3R1YkluZm8sIGNvbnN0IEZ1bmN0aW9uJiBm dW5jdGlvbikKIHsKLSAgICBpZiAoaml0Lm1fYXNzZW1ibGVyLmJ1ZmZlcigpLmNvZGVTaXplKCkg PD0gc3R1YkluZm8ucGF0Y2guaW5saW5lU2l6ZSkgeworICAgIGlmIChqaXQubV9hc3NlbWJsZXIu YnVmZmVyKCkuY29kZVNpemUoKSA8PSBzdHViSW5mby5wYXRjaC5pbmxpbmVTaXplKCkpIHsKICAg ICAgICAgYm9vbCBuZWVkc0JyYW5jaENvbXBhY3Rpb24gPSBmYWxzZTsKLSAgICAgICAgTGlua0J1 ZmZlciBsaW5rQnVmZmVyKGppdCwgc3R1YkluZm8ucGF0Y2guc3RhcnQsIHN0dWJJbmZvLnBhdGNo LmlubGluZVNpemUsIEpJVENvbXBpbGF0aW9uTXVzdFN1Y2NlZWQsIG5lZWRzQnJhbmNoQ29tcGFj dGlvbik7CisgICAgICAgIExpbmtCdWZmZXIgbGlua0J1ZmZlcihqaXQsIHN0dWJJbmZvLnBhdGNo LnN0YXJ0LCBzdHViSW5mby5wYXRjaC5pbmxpbmVTaXplKCksIEpJVENvbXBpbGF0aW9uTXVzdFN1 Y2NlZWQsIG5lZWRzQnJhbmNoQ29tcGFjdGlvbik7CiAgICAgICAgIEFTU0VSVChsaW5rQnVmZmVy LmlzVmFsaWQoKSk7CiAgICAgICAgIGZ1bmN0aW9uKGxpbmtCdWZmZXIpOwogICAgICAgICBGSU5B TElaRV9DT0RFKGxpbmtCdWZmZXIsIE5vUHRyVGFnLCAiSW5saW5lQWNjZXNzVHlwZTogJyVzJyIs IG5hbWUpOwpAQCAtMTU5LDcgKzE1OSw3IEBAIEFMV0FZU19JTkxJTkUgc3RhdGljIGJvb2wgbGlu a0NvZGVJbmxpbmUKICAgICBjb25zdCBib29sIGZhaWxJZkNhbnRJbmxpbmUgPSBmYWxzZTsKICAg ICBpZiAoZmFpbElmQ2FudElubGluZSkgewogICAgICAgICBkYXRhTG9nKCJGYWlsdXJlIGZvcjog IiwgbmFtZSwgIlxuIik7Ci0gICAgICAgIGRhdGFMb2coInJlYWwgc2l6ZTogIiwgaml0Lm1fYXNz ZW1ibGVyLmJ1ZmZlcigpLmNvZGVTaXplKCksICIgaW5saW5lIHNpemU6Iiwgc3R1YkluZm8ucGF0 Y2guaW5saW5lU2l6ZSwgIlxuIik7CisgICAgICAgIGRhdGFMb2coInJlYWwgc2l6ZTogIiwgaml0 Lm1fYXNzZW1ibGVyLmJ1ZmZlcigpLmNvZGVTaXplKCksICIgaW5saW5lIHNpemU6Iiwgc3R1Yklu Zm8ucGF0Y2guaW5saW5lU2l6ZSgpLCAiXG4iKTsKICAgICAgICAgQ1JBU0goKTsKICAgICB9CiAK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9TdHJ1Y3R1cmVTdHViSW5mby5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9TdHJ1Y3R1cmVT dHViSW5mby5oCShyZXZpc2lvbiAyMzY1NzgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0 ZWNvZGUvU3RydWN0dXJlU3R1YkluZm8uaAkod29ya2luZyBjb3B5KQpAQCAtMTg3LDkgKzE4Nywx NyBAQCBwdWJsaWM6CiAgICAgc3RydWN0IHsKICAgICAgICAgQ29kZUxvY2F0aW9uTGFiZWw8SklU U3R1YlJvdXRpbmVQdHJUYWc+IHN0YXJ0OyAvLyBUaGlzIGlzIGVpdGhlciB0aGUgc3RhcnQgb2Yg dGhlIGlubGluZSBJQyBmb3IgKmJ5SWQgY2FjaGVzLiBvciB0aGUgbG9jYXRpb24gb2YgcGF0Y2hh YmxlIGp1bXAgZm9yICdpbnN0YW5jZW9mJyBjYWNoZXMuCiAgICAgICAgIFJlZ2lzdGVyU2V0IHVz ZWRSZWdpc3RlcnM7Ci0gICAgICAgIHVpbnQzMl90IGlubGluZVNpemU7Ci0gICAgICAgIGludDMy X3QgZGVsdGFGcm9tU3RhcnRUb1Nsb3dQYXRoQ2FsbExvY2F0aW9uOwotICAgICAgICBpbnQzMl90 IGRlbHRhRnJvbVN0YXJ0VG9TbG93UGF0aFN0YXJ0OworCisgICAgICAgIENvZGVMb2NhdGlvbkxh YmVsPEpTSW50ZXJuYWxQdHJUYWc+IGRvbmVMb2NhdGlvbjsKKyAgICAgICAgQ29kZUxvY2F0aW9u Q2FsbDxKU0ludGVybmFsUHRyVGFnPiBzbG93UGF0aENhbGxMb2NhdGlvbjsKKyAgICAgICAgQ29k ZUxvY2F0aW9uTGFiZWw8SklUU3R1YlJvdXRpbmVQdHJUYWc+IHNsb3dQYXRoU3RhcnRMb2NhdGlv bjsKKworICAgICAgICB1aW50MzJfdCBpbmxpbmVTaXplKCkgY29uc3QKKyAgICAgICAgeworICAg ICAgICAgICAgaW50MzJfdCBpbmxpbmVTaXplID0gTWFjcm9Bc3NlbWJsZXI6OmRpZmZlcmVuY2VC ZXR3ZWVuQ29kZVB0cihzdGFydCwgZG9uZUxvY2F0aW9uKTsKKyAgICAgICAgICAgIEFTU0VSVChp bmxpbmVTaXplID49IDApOworICAgICAgICAgICAgcmV0dXJuIGlubGluZVNpemU7CisgICAgICAg IH0KIAogICAgICAgICBHUFJSZWcgYmFzZUdQUjsKICAgICAgICAgR1BSUmVnIHZhbHVlR1BSOwpA QCAtMjA2LDkgKzIxNCwxMCBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBwYXRjaC5iYXNlR1BS OwogICAgIH0KIAotICAgIENvZGVMb2NhdGlvbkNhbGw8SlNJbnRlcm5hbFB0clRhZz4gc2xvd1Bh dGhDYWxsTG9jYXRpb24oKSB7IHJldHVybiBwYXRjaC5zdGFydC5jYWxsQXRPZmZzZXQ8SlNJbnRl cm5hbFB0clRhZz4ocGF0Y2guZGVsdGFGcm9tU3RhcnRUb1Nsb3dQYXRoQ2FsbExvY2F0aW9uKTsg fQotICAgIENvZGVMb2NhdGlvbkxhYmVsPEpTSW50ZXJuYWxQdHJUYWc+IGRvbmVMb2NhdGlvbigp IHsgcmV0dXJuIHBhdGNoLnN0YXJ0LmxhYmVsQXRPZmZzZXQ8SlNJbnRlcm5hbFB0clRhZz4ocGF0 Y2guaW5saW5lU2l6ZSk7IH0KLSAgICBDb2RlTG9jYXRpb25MYWJlbDxKSVRTdHViUm91dGluZVB0 clRhZz4gc2xvd1BhdGhTdGFydExvY2F0aW9uKCkgeyByZXR1cm4gcGF0Y2guc3RhcnQubGFiZWxB dE9mZnNldChwYXRjaC5kZWx0YUZyb21TdGFydFRvU2xvd1BhdGhTdGFydCk7IH0KKyAgICBDb2Rl TG9jYXRpb25DYWxsPEpTSW50ZXJuYWxQdHJUYWc+IHNsb3dQYXRoQ2FsbExvY2F0aW9uKCkgeyBy ZXR1cm4gcGF0Y2guc2xvd1BhdGhDYWxsTG9jYXRpb247IH0KKyAgICBDb2RlTG9jYXRpb25MYWJl bDxKU0ludGVybmFsUHRyVGFnPiBkb25lTG9jYXRpb24oKSB7IHJldHVybiBwYXRjaC5kb25lTG9j YXRpb247IH0KKyAgICBDb2RlTG9jYXRpb25MYWJlbDxKSVRTdHViUm91dGluZVB0clRhZz4gc2xv d1BhdGhTdGFydExvY2F0aW9uKCkgeyByZXR1cm4gcGF0Y2guc2xvd1BhdGhTdGFydExvY2F0aW9u OyB9CisKICAgICBDb2RlTG9jYXRpb25KdW1wPEpTSW50ZXJuYWxQdHJUYWc+IHBhdGNoYWJsZUp1 bXAoKQogICAgIHsgCiAgICAgICAgIEFTU0VSVChhY2Nlc3NUeXBlID09IEFjY2Vzc1R5cGU6Oklu c3RhbmNlT2YpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRJbmxpbmVDYWNo ZUdlbmVyYXRvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9K SVRJbmxpbmVDYWNoZUdlbmVyYXRvci5jcHAJKHJldmlzaW9uIDIzNjU3OCkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9qaXQvSklUSW5saW5lQ2FjaGVHZW5lcmF0b3IuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC01OSwxNCArNTksMTAgQEAgdm9pZCBKSVRJbmxpbmVDYWNoZUdlbmVyYXRvcjo6Zmlu YWxpemUoCiB7CiAgICAgbV9zdHViSW5mby0+cGF0Y2guc3RhcnQgPSBzdGFydDsKIAotICAgIGlu dDMyX3QgaW5saW5lU2l6ZSA9IE1hY3JvQXNzZW1ibGVyOjpkaWZmZXJlbmNlQmV0d2VlbkNvZGVQ dHIoCi0gICAgICAgIHN0YXJ0LCBmYXN0UGF0aC5sb2NhdGlvbk9mPE5vUHRyVGFnPihtX2RvbmUp KTsKLSAgICBtX3N0dWJJbmZvLT5wYXRjaC5pbmxpbmVTaXplID0gaW5saW5lU2l6ZTsKLQotICAg IG1fc3R1YkluZm8tPnBhdGNoLmRlbHRhRnJvbVN0YXJ0VG9TbG93UGF0aENhbGxMb2NhdGlvbiA9 IE1hY3JvQXNzZW1ibGVyOjpkaWZmZXJlbmNlQmV0d2VlbkNvZGVQdHIoCi0gICAgICAgIHN0YXJ0 LCBzbG93UGF0aC5sb2NhdGlvbk9mPE5vUHRyVGFnPihtX3Nsb3dQYXRoQ2FsbCkpOwotICAgIG1f c3R1YkluZm8tPnBhdGNoLmRlbHRhRnJvbVN0YXJ0VG9TbG93UGF0aFN0YXJ0ID0gTWFjcm9Bc3Nl bWJsZXI6OmRpZmZlcmVuY2VCZXR3ZWVuQ29kZVB0cigKLSAgICAgICAgc3RhcnQsIHNsb3dQYXRo LmxvY2F0aW9uT2Y8Tm9QdHJUYWc+KG1fc2xvd1BhdGhCZWdpbikpOworICAgIG1fc3R1YkluZm8t PnBhdGNoLmRvbmVMb2NhdGlvbiA9IGZhc3RQYXRoLmxvY2F0aW9uT2Y8SlNJbnRlcm5hbFB0clRh Zz4obV9kb25lKTsKKworICAgIG1fc3R1YkluZm8tPnBhdGNoLnNsb3dQYXRoQ2FsbExvY2F0aW9u ID0gc2xvd1BhdGgubG9jYXRpb25PZjxKU0ludGVybmFsUHRyVGFnPihtX3Nsb3dQYXRoQ2FsbCk7 CisgICAgbV9zdHViSW5mby0+cGF0Y2guc2xvd1BhdGhTdGFydExvY2F0aW9uID0gc2xvd1BhdGgu bG9jYXRpb25PZjxKSVRTdHViUm91dGluZVB0clRhZz4obV9zbG93UGF0aEJlZ2luKTsKIH0KIAog SklUQnlJZEdlbmVyYXRvcjo6SklUQnlJZEdlbmVyYXRvcigK