190063 2018-09-27 17:17:44 -0700 JSC test stress/jsc-read.js doesn't support CRLF 2018-09-28 11:00:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ross.kirsling ross.kirsling ap commit-queue jfbastien keith_miller webkit-bug-importer ysuzuki oldest_to_newest 1464230 0 ross.kirsling 2018-09-27 17:17:44 -0700 JSC test stress/jsc-read.js doesn't support CRLF 1464231 1 351028 ross.kirsling 2018-09-27 17:20:29 -0700 Created attachment 351028 Patch 1464246 2 351032 ross.kirsling 2018-09-27 18:00:48 -0700 Created attachment 351032 Patch 1464355 3 351032 ysuzuki 2018-09-28 04:17:41 -0700 Comment on attachment 351032 Patch r=me 1464380 4 351032 commit-queue 2018-09-28 08:31:54 -0700 Comment on attachment 351032 Patch Clearing flags on attachment: 351032 Committed r236597: <https://trac.webkit.org/changeset/236597> 1464381 5 commit-queue 2018-09-28 08:31:55 -0700 All reviewed patches have been landed. Closing bug. 1464383 6 webkit-bug-importer 2018-09-28 08:32:40 -0700 <rdar://problem/44864316> 1464437 7 ap 2018-09-28 11:00:19 -0700 I've seen a couple CRLF bugs recently. Is it really the best solution to add special cases all over the place? While I'm not an expert on git or svn clients from Windows, I expect that configuring them to use proper line endings would be a better approach. 351028 2018-09-27 17:20:29 -0700 2018-09-27 18:00:46 -0700 Patch bug-190063-20180927172028.patch text/plain 1421 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NTc3CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGVjYTQ3OTdiYmE0MzEyYzRjNzNhYjM3MDkyZjcz OWE5YWQwYTE5MzguLjM5MjVmNDg0ZjgwODcwOWQxOWY5ZWQyNDQ5YjZkMTA3NWQ4NDEyMjcgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTgtMDktMjcgIFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNv bnkuY29tPgorCisgICAgICAgIEpTQyB0ZXN0IHN0cmVzcy9qc2MtcmVhZC5qcyBkb2Vzbid0IHN1 cHBvcnQgQ1JMRgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTkwMDYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgSW4gb3JkZXIgdG8gcnVuIHRoaXMgdGVzdCB2aWEgV2luZG93cyBjb21tYW5kIHByb21wdCwg d2UgY2FuJ3QgYXNzdW1lIHRoYXQgdGhlIGZpbmFsIG5ld2xpbmUgd2lsbCBiZSBMRi4KKworICAg ICAgICAqIHN0cmVzcy9qc2MtcmVhZC5qczoKKyAgICAgICAgKHRlc3QpOgorCiAyMDE4LTA5LTI3 ICBEb21pbmlrIEluZnVlaHIgIDxkaW5mdWVockBpZ2FsaWEuY29tPgogCiAgICAgICAgIERpc2Fi bGUgdGVzdCB3aXRob3V0IExMSW50IG9uIEFSTXY3CmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVz cy9qc2MtcmVhZC5qcyBiL0pTVGVzdHMvc3RyZXNzL2pzYy1yZWFkLmpzCmluZGV4IDFiMzIwNGUw ZTgxYWQ0MDYzZGJiNGNlNzUzYzY2N2M1YzRiNTk3ODYuLjc0MzVkNDY4OWVhYjBmZjBhZTgwYTlm YjVhYTFlZDhmYTc1NTFkNDEgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvc3RyZXNzL2pzYy1yZWFkLmpz CisrKyBiL0pTVGVzdHMvc3RyZXNzL2pzYy1yZWFkLmpzCkBAIC0zLDcgKzMsOSBAQAogICAgIGNv bnN0IGluX2ZpbGUgPSAnanNjLXJlYWQuanMnOwogCiAgICAgY29uc3QgY2hlY2sgPSBjb250ZW50 X3JlYWQgPT4gewotICAgICAgICBsZXQgZXhwZWN0ID0gJygnICsgdGVzdC50b1N0cmluZygpICsg JykoKTtcbic7CisgICAgICAgIGxldCB0ZXN0Q29udGVudCA9IHRlc3QudG9TdHJpbmcoKTsKKyAg ICAgICAgbGV0IGxpbmVFbmRpbmcgPSB0ZXN0Q29udGVudC5tYXRjaCgvXHJcbj8vKVswXTsKKyAg ICAgICAgbGV0IGV4cGVjdCA9IGAoJHt0ZXN0Q29udGVudH0pKCk7JHtsaW5lRW5kaW5nfWA7CiAg ICAgICAgIGlmIChjb250ZW50X3JlYWQgIT09IGV4cGVjdCkKICAgICAgICAgICAgIHRocm93IEVy cm9yKCdFeHBlY3RlZCB0byByZWFkIHRoaXMgZmlsZSBhcy1pcywgaW5zdGVhZCByZWFkOlxuPT09 PT09PT09PVxuJyArIGNvbnRlbnRfcmVhZCArICdcbj09PT09PT09PT0nKTsKICAgICB9Owo= 351032 2018-09-27 18:00:48 -0700 2018-09-28 08:31:54 -0700 Patch bug-190063-20180927180047.patch text/plain 1421 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NTc3CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGVjYTQ3OTdiYmE0MzEyYzRjNzNhYjM3MDkyZjcz OWE5YWQwYTE5MzguLjM5MjVmNDg0ZjgwODcwOWQxOWY5ZWQyNDQ5YjZkMTA3NWQ4NDEyMjcgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTgtMDktMjcgIFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNv bnkuY29tPgorCisgICAgICAgIEpTQyB0ZXN0IHN0cmVzcy9qc2MtcmVhZC5qcyBkb2Vzbid0IHN1 cHBvcnQgQ1JMRgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTkwMDYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgSW4gb3JkZXIgdG8gcnVuIHRoaXMgdGVzdCB2aWEgV2luZG93cyBjb21tYW5kIHByb21wdCwg d2UgY2FuJ3QgYXNzdW1lIHRoYXQgdGhlIGZpbmFsIG5ld2xpbmUgd2lsbCBiZSBMRi4KKworICAg ICAgICAqIHN0cmVzcy9qc2MtcmVhZC5qczoKKyAgICAgICAgKHRlc3QpOgorCiAyMDE4LTA5LTI3 ICBEb21pbmlrIEluZnVlaHIgIDxkaW5mdWVockBpZ2FsaWEuY29tPgogCiAgICAgICAgIERpc2Fi bGUgdGVzdCB3aXRob3V0IExMSW50IG9uIEFSTXY3CmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVz cy9qc2MtcmVhZC5qcyBiL0pTVGVzdHMvc3RyZXNzL2pzYy1yZWFkLmpzCmluZGV4IDFiMzIwNGUw ZTgxYWQ0MDYzZGJiNGNlNzUzYzY2N2M1YzRiNTk3ODYuLjg1ZDQ3NmFiMGNhNDY0NTI4ZTVlOGYz ZTFkMzgyMmUxOTk5ZmRjNWQgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvc3RyZXNzL2pzYy1yZWFkLmpz CisrKyBiL0pTVGVzdHMvc3RyZXNzL2pzYy1yZWFkLmpzCkBAIC0zLDcgKzMsOSBAQAogICAgIGNv bnN0IGluX2ZpbGUgPSAnanNjLXJlYWQuanMnOwogCiAgICAgY29uc3QgY2hlY2sgPSBjb250ZW50 X3JlYWQgPT4gewotICAgICAgICBsZXQgZXhwZWN0ID0gJygnICsgdGVzdC50b1N0cmluZygpICsg JykoKTtcbic7CisgICAgICAgIGxldCB0ZXN0Q29udGVudCA9IHRlc3QudG9TdHJpbmcoKTsKKyAg ICAgICAgbGV0IGxpbmVFbmRpbmcgPSB0ZXN0Q29udGVudC5tYXRjaCgvXHI/XG4vKVswXTsKKyAg ICAgICAgbGV0IGV4cGVjdCA9IGAoJHt0ZXN0Q29udGVudH0pKCk7JHtsaW5lRW5kaW5nfWA7CiAg ICAgICAgIGlmIChjb250ZW50X3JlYWQgIT09IGV4cGVjdCkKICAgICAgICAgICAgIHRocm93IEVy cm9yKCdFeHBlY3RlZCB0byByZWFkIHRoaXMgZmlsZSBhcy1pcywgaW5zdGVhZCByZWFkOlxuPT09 PT09PT09PVxuJyArIGNvbnRlbnRfcmVhZCArICdcbj09PT09PT09PT0nKTsKICAgICB9Owo=