190059 2018-09-27 15:42:11 -0700 Increase the timeout for iOS Simulator data migration 2018-09-27 17:51:29 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad ryanhaddad aakash_jain ews-watchlist glenn jbedard lforschler webkit-bug-importer oldest_to_newest 1464196 0 ryanhaddad 2018-09-27 15:42:11 -0700 Increase the timeout for iOS Simulator data migration since 3 minutes isn't always enough time for the data migrator to complete when booting up multiple iOS Simulators 1464206 1 351018 ryanhaddad 2018-09-27 16:17:04 -0700 Created attachment 351018 Patch 1464226 2 351018 jbedard 2018-09-27 17:15:13 -0700 Comment on attachment 351018 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351018&action=review > Tools/Scripts/webkitpy/xcode/simulated_device.py:64 > + DEFAULT_TIMEOUT = 60 I think this should be 600 1464228 3 351027 ryanhaddad 2018-09-27 17:16:18 -0700 Created attachment 351027 Patch 1464229 4 jbedard 2018-09-27 17:16:41 -0700 Unofficial r=me. 1464236 5 351027 aakash_jain 2018-09-27 17:30:23 -0700 Comment on attachment 351027 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351027&action=review > Tools/Scripts/webkitpy/xcode/simulated_device.py:64 > + DEFAULT_TIMEOUT = 600 This variable can be named better, to indicate what kind of timeout it is. 1464237 6 ryanhaddad 2018-09-27 17:41:37 -0700 (In reply to Aakash Jain from comment #5) > Comment on attachment 351027 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=351027&action=review > > > Tools/Scripts/webkitpy/xcode/simulated_device.py:64 > > + DEFAULT_TIMEOUT = 600 > > This variable can be named better, to indicate what kind of timeout it is. Perhaps SIMULATOR_BOOT_TIMEOUT is more appropriate. 1464241 7 ryanhaddad 2018-09-27 17:50:55 -0700 Landed in https://trac.webkit.org/r236579 1464242 8 webkit-bug-importer 2018-09-27 17:51:29 -0700 <rdar://problem/44850684> 351018 2018-09-27 16:17:04 -0700 2018-09-27 17:16:16 -0700 Patch bug-190059-20180927161703.patch text/plain 3460 ryanhaddad U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NTc2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjZlZjFlY2M3ODE0NTFhNjhiNGUzZDg4NjA0NDcyOGU2 NmQ0MjVlNi4uYzNlYTVkMjhjNzZlZDVkNzBmZDJlYTExZTRkMzJlZTBiYzU4YTRhMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE4LTA5LTI3ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgorCisg ICAgICAgIEluY3JlYXNlIHRoZSB0aW1lb3V0IGZvciBpT1MgU2ltdWxhdG9yIGRhdGEgbWlncmF0 aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTAw NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAzIG1p bnV0ZXMgaXNuJ3QgYWx3YXlzIGVub3VnaCB0aW1lIGZvciB0aGUgZGF0YSBtaWdyYXRvciB0byBj b21wbGV0ZQorICAgICAgICB3aGVuIGJvb3RpbmcgdXAgbXVsdGlwbGUgaU9TIFNpbXVsYXRvcnMu IENoYW5nZSB0aGUgdGltZW91dCB0byAxMCBtaW51dGVzLgorCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5OgorICAgICAgICAoU2ltdWxhdGVkRGV2 aWNlTWFuYWdlcik6IENyZWF0ZSBhIGNvbnN0YW50IGZvciB0aGUgZGVmYXVsdCB0aW1lb3V0Lgor ICAgICAgICAoU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5pbml0aWFsaXplX2RldmljZXMpOiBVc2Ug bmV3IGNvbnN0YW50LgorICAgICAgICAoU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5zd2FwKTogRGl0 dG8uCisgICAgICAgIChTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLndhaXRfdW50aWxfZGF0YV9taWdy YXRpb25faXNfZG9uZSk6IERpdHRvLgorCiAyMDE4LTA5LTI3ICBBbGV4IENocmlzdGVuc2VuICA8 YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVVJMUGFyc2VyIHNob3VsZCB1c2Ug VGV4dEVuY29kaW5nIHRocm91Z2ggYW4gYWJzdHJhY3QgY2xhc3MKZGlmZiAtLWdpdCBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5weQppbmRleCA3MzE0MzMwOTcwMzIx MGJjNTUzMzA5MjBhYjU0ZDg5NThjY2I3OGQ4Li5jNGNmMThhZjExZjEyOGZkYmEyYmVmMjI4ZDlj M2I3Y2UwNGYzMGY1IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3Np bXVsYXRlZF9kZXZpY2UucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11 bGF0ZWRfZGV2aWNlLnB5CkBAIC02MSw2ICs2MSw4IEBAIGNsYXNzIFNpbXVsYXRlZERldmljZU1h bmFnZXIob2JqZWN0KToKICAgICBBVkFJTEFCTEVfREVWSUNFUyA9IFtdCiAgICAgSU5JVElBTEla RURfREVWSUNFUyA9IE5vbmUKIAorICAgIERFRkFVTFRfVElNRU9VVCA9IDYwCisKICAgICAjIEZJ WE1FOiBTaW11bGF0b3JzIHNob3VsZCBvbmx5IHRha2UgdXAgMkdCLCBidXQgYmVjYXVzZSBvZiA8 cmRhcjovL3Byb2JsZW0vMzkzOTM1OTA+IHNvbWV0aGluZyBpbiB0aGUgT1MgdGhpbmtzIHRoZXkn cmUgdGFraW5nIGNsb3NlciB0byA2R0IKICAgICBNRU1PUllfRVNUSU1BVEVfUEVSX1NJTVVMQVRP Ul9JTlNUQU5DRSA9IDYgKiAoMTAyNCAqKiAzKSAgIyA2R0IgYSBzaW11bGF0b3IuCiAgICAgUFJP Q0VTU19DT1VOVF9FU1RJTUFURV9QRVJfU0lNVUxBVE9SX0lOU1RBTkNFID0gMTI1CkBAIC0zMTQs NyArMzE2LDcgQEAgY2xhc3MgU2ltdWxhdGVkRGV2aWNlTWFuYWdlcihvYmplY3QpOgogICAgICAg ICBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLklOSVRJQUxJWkVEX0RFVklDRVMuYXBwZW5kKGRldmlj ZSkKIAogICAgIEBzdGF0aWNtZXRob2QKLSAgICBkZWYgaW5pdGlhbGl6ZV9kZXZpY2VzKHJlcXVl c3RzLCBob3N0PVN5c3RlbUhvc3QoKSwgbmFtZV9iYXNlPSdNYW5hZ2VkJywgc2ltdWxhdG9yX3Vp PVRydWUsIHRpbWVvdXQ9MTgwLCAqKmt3YXJncyk6CisgICAgZGVmIGluaXRpYWxpemVfZGV2aWNl cyhyZXF1ZXN0cywgaG9zdD1TeXN0ZW1Ib3N0KCksIG5hbWVfYmFzZT0nTWFuYWdlZCcsIHNpbXVs YXRvcl91aT1UcnVlLCB0aW1lb3V0PURFRkFVTFRfVElNRU9VVCwgKiprd2FyZ3MpOgogICAgICAg ICBpZiBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLklOSVRJQUxJWkVEX0RFVklDRVMgaXMgbm90IE5v bmU6CiAgICAgICAgICAgICByZXR1cm4gU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5JTklUSUFMSVpF RF9ERVZJQ0VTCiAKQEAgLTM5NSw3ICszOTcsNyBAQCBjbGFzcyBTaW11bGF0ZWREZXZpY2VNYW5h Z2VyKG9iamVjdCk6CiAgICAgICAgIHJldHVybiBtaW4obWF4X3N1cHBvcnRlZF9zaW11bGF0b3Jz X2xvY2FsbHksIG1heF9zdXBwb3J0ZWRfc2ltdWxhdG9yc19mb3JfaGFyZHdhcmUpCiAKICAgICBA c3RhdGljbWV0aG9kCi0gICAgZGVmIHN3YXAoZGV2aWNlLCByZXF1ZXN0LCBob3N0PVN5c3RlbUhv c3QoKSwgbmFtZV9iYXNlPSdNYW5hZ2VkJywgdGltZW91dD0xODApOgorICAgIGRlZiBzd2FwKGRl dmljZSwgcmVxdWVzdCwgaG9zdD1TeXN0ZW1Ib3N0KCksIG5hbWVfYmFzZT0nTWFuYWdlZCcsIHRp bWVvdXQ9REVGQVVMVF9USU1FT1VUKToKICAgICAgICAgaWYgU2ltdWxhdGVkRGV2aWNlTWFuYWdl ci5JTklUSUFMSVpFRF9ERVZJQ0VTIGlzIE5vbmU6CiAgICAgICAgICAgICByYWlzZSBSdW50aW1l RXJyb3IoJ0Nhbm5vdCBzd2FwIHdoZW4gdGhlcmUgYXJlIG5vIGluaXRpYWxpemVkIGRldmljZXMn KQogICAgICAgICBpZiBkZXZpY2Ugbm90IGluIFNpbXVsYXRlZERldmljZU1hbmFnZXIuSU5JVElB TElaRURfREVWSUNFUzoKQEAgLTQxOSw3ICs0MjEsNyBAQCBjbGFzcyBTaW11bGF0ZWREZXZpY2VN YW5hZ2VyKG9iamVjdCk6CiAgICAgICAgIFNpbXVsYXRlZERldmljZU1hbmFnZXIud2FpdF91bnRp bF9kYXRhX21pZ3JhdGlvbl9pc19kb25lKGhvc3QsIG1heCgwLCBkZWFkbGluZSAtIHRpbWUudGlt ZSgpKSkKIAogICAgIEBzdGF0aWNtZXRob2QKLSAgICBkZWYgd2FpdF91bnRpbF9kYXRhX21pZ3Jh dGlvbl9pc19kb25lKGhvc3QsIHRpbWVvdXQ9MTgwKToKKyAgICBkZWYgd2FpdF91bnRpbF9kYXRh X21pZ3JhdGlvbl9pc19kb25lKGhvc3QsIHRpbWVvdXQ9REVGQVVMVF9USU1FT1VUKToKICAgICAg ICAgIyBUaGUgZXhpc3RlbmNlIG9mIGEgZGF0YW1pZ3JhdG9yIHByb2Nlc3MgbWVhbnMgdGhhdCBz aW11bGF0b3JzIGFyZSBzdGlsbCBib290aW5nLgogICAgICAgICBkZWFkbGluZSA9IHRpbWUudGlt ZSgpICsgdGltZW91dAogICAgICAgICBfbG9nLmRlYnVnKCdXYWl0aW5nIHVudGlsIG5vIGNvbS5h cHBsZS5kYXRhbWlncmF0b3IgcHJvY2Vzc2VzIGFyZSBmb3VuZCcpCg== 351027 2018-09-27 17:16:18 -0700 2018-09-27 17:30:23 -0700 Patch bug-190059-20180927171618.patch text/plain 3461 ryanhaddad U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NTc2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjZlZjFlY2M3ODE0NTFhNjhiNGUzZDg4NjA0NDcyOGU2 NmQ0MjVlNi4uYzNlYTVkMjhjNzZlZDVkNzBmZDJlYTExZTRkMzJlZTBiYzU4YTRhMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE4LTA5LTI3ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgorCisg ICAgICAgIEluY3JlYXNlIHRoZSB0aW1lb3V0IGZvciBpT1MgU2ltdWxhdG9yIGRhdGEgbWlncmF0 aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTAw NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAzIG1p bnV0ZXMgaXNuJ3QgYWx3YXlzIGVub3VnaCB0aW1lIGZvciB0aGUgZGF0YSBtaWdyYXRvciB0byBj b21wbGV0ZQorICAgICAgICB3aGVuIGJvb3RpbmcgdXAgbXVsdGlwbGUgaU9TIFNpbXVsYXRvcnMu IENoYW5nZSB0aGUgdGltZW91dCB0byAxMCBtaW51dGVzLgorCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5OgorICAgICAgICAoU2ltdWxhdGVkRGV2 aWNlTWFuYWdlcik6IENyZWF0ZSBhIGNvbnN0YW50IGZvciB0aGUgZGVmYXVsdCB0aW1lb3V0Lgor ICAgICAgICAoU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5pbml0aWFsaXplX2RldmljZXMpOiBVc2Ug bmV3IGNvbnN0YW50LgorICAgICAgICAoU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5zd2FwKTogRGl0 dG8uCisgICAgICAgIChTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLndhaXRfdW50aWxfZGF0YV9taWdy YXRpb25faXNfZG9uZSk6IERpdHRvLgorCiAyMDE4LTA5LTI3ICBBbGV4IENocmlzdGVuc2VuICA8 YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVVJMUGFyc2VyIHNob3VsZCB1c2Ug VGV4dEVuY29kaW5nIHRocm91Z2ggYW4gYWJzdHJhY3QgY2xhc3MKZGlmZiAtLWdpdCBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5weQppbmRleCA3MzE0MzMwOTcwMzIx MGJjNTUzMzA5MjBhYjU0ZDg5NThjY2I3OGQ4Li4xYjg1M2MzMWQ5MDNiZTI4MWMxYjg4ZTNlZGNm ODVlNmZkNDA4ZGM5IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3Np bXVsYXRlZF9kZXZpY2UucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11 bGF0ZWRfZGV2aWNlLnB5CkBAIC02MSw2ICs2MSw4IEBAIGNsYXNzIFNpbXVsYXRlZERldmljZU1h bmFnZXIob2JqZWN0KToKICAgICBBVkFJTEFCTEVfREVWSUNFUyA9IFtdCiAgICAgSU5JVElBTEla RURfREVWSUNFUyA9IE5vbmUKIAorICAgIERFRkFVTFRfVElNRU9VVCA9IDYwMAorCiAgICAgIyBG SVhNRTogU2ltdWxhdG9ycyBzaG91bGQgb25seSB0YWtlIHVwIDJHQiwgYnV0IGJlY2F1c2Ugb2Yg PHJkYXI6Ly9wcm9ibGVtLzM5MzkzNTkwPiBzb21ldGhpbmcgaW4gdGhlIE9TIHRoaW5rcyB0aGV5 J3JlIHRha2luZyBjbG9zZXIgdG8gNkdCCiAgICAgTUVNT1JZX0VTVElNQVRFX1BFUl9TSU1VTEFU T1JfSU5TVEFOQ0UgPSA2ICogKDEwMjQgKiogMykgICMgNkdCIGEgc2ltdWxhdG9yLgogICAgIFBS T0NFU1NfQ09VTlRfRVNUSU1BVEVfUEVSX1NJTVVMQVRPUl9JTlNUQU5DRSA9IDEyNQpAQCAtMzE0 LDcgKzMxNiw3IEBAIGNsYXNzIFNpbXVsYXRlZERldmljZU1hbmFnZXIob2JqZWN0KToKICAgICAg ICAgU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5JTklUSUFMSVpFRF9ERVZJQ0VTLmFwcGVuZChkZXZp Y2UpCiAKICAgICBAc3RhdGljbWV0aG9kCi0gICAgZGVmIGluaXRpYWxpemVfZGV2aWNlcyhyZXF1 ZXN0cywgaG9zdD1TeXN0ZW1Ib3N0KCksIG5hbWVfYmFzZT0nTWFuYWdlZCcsIHNpbXVsYXRvcl91 aT1UcnVlLCB0aW1lb3V0PTE4MCwgKiprd2FyZ3MpOgorICAgIGRlZiBpbml0aWFsaXplX2Rldmlj ZXMocmVxdWVzdHMsIGhvc3Q9U3lzdGVtSG9zdCgpLCBuYW1lX2Jhc2U9J01hbmFnZWQnLCBzaW11 bGF0b3JfdWk9VHJ1ZSwgdGltZW91dD1ERUZBVUxUX1RJTUVPVVQsICoqa3dhcmdzKToKICAgICAg ICAgaWYgU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5JTklUSUFMSVpFRF9ERVZJQ0VTIGlzIG5vdCBO b25lOgogICAgICAgICAgICAgcmV0dXJuIFNpbXVsYXRlZERldmljZU1hbmFnZXIuSU5JVElBTEla RURfREVWSUNFUwogCkBAIC0zOTUsNyArMzk3LDcgQEAgY2xhc3MgU2ltdWxhdGVkRGV2aWNlTWFu YWdlcihvYmplY3QpOgogICAgICAgICByZXR1cm4gbWluKG1heF9zdXBwb3J0ZWRfc2ltdWxhdG9y c19sb2NhbGx5LCBtYXhfc3VwcG9ydGVkX3NpbXVsYXRvcnNfZm9yX2hhcmR3YXJlKQogCiAgICAg QHN0YXRpY21ldGhvZAotICAgIGRlZiBzd2FwKGRldmljZSwgcmVxdWVzdCwgaG9zdD1TeXN0ZW1I b3N0KCksIG5hbWVfYmFzZT0nTWFuYWdlZCcsIHRpbWVvdXQ9MTgwKToKKyAgICBkZWYgc3dhcChk ZXZpY2UsIHJlcXVlc3QsIGhvc3Q9U3lzdGVtSG9zdCgpLCBuYW1lX2Jhc2U9J01hbmFnZWQnLCB0 aW1lb3V0PURFRkFVTFRfVElNRU9VVCk6CiAgICAgICAgIGlmIFNpbXVsYXRlZERldmljZU1hbmFn ZXIuSU5JVElBTElaRURfREVWSUNFUyBpcyBOb25lOgogICAgICAgICAgICAgcmFpc2UgUnVudGlt ZUVycm9yKCdDYW5ub3Qgc3dhcCB3aGVuIHRoZXJlIGFyZSBubyBpbml0aWFsaXplZCBkZXZpY2Vz JykKICAgICAgICAgaWYgZGV2aWNlIG5vdCBpbiBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLklOSVRJ QUxJWkVEX0RFVklDRVM6CkBAIC00MTksNyArNDIxLDcgQEAgY2xhc3MgU2ltdWxhdGVkRGV2aWNl TWFuYWdlcihvYmplY3QpOgogICAgICAgICBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLndhaXRfdW50 aWxfZGF0YV9taWdyYXRpb25faXNfZG9uZShob3N0LCBtYXgoMCwgZGVhZGxpbmUgLSB0aW1lLnRp bWUoKSkpCiAKICAgICBAc3RhdGljbWV0aG9kCi0gICAgZGVmIHdhaXRfdW50aWxfZGF0YV9taWdy YXRpb25faXNfZG9uZShob3N0LCB0aW1lb3V0PTE4MCk6CisgICAgZGVmIHdhaXRfdW50aWxfZGF0 YV9taWdyYXRpb25faXNfZG9uZShob3N0LCB0aW1lb3V0PURFRkFVTFRfVElNRU9VVCk6CiAgICAg ICAgICMgVGhlIGV4aXN0ZW5jZSBvZiBhIGRhdGFtaWdyYXRvciBwcm9jZXNzIG1lYW5zIHRoYXQg c2ltdWxhdG9ycyBhcmUgc3RpbGwgYm9vdGluZy4KICAgICAgICAgZGVhZGxpbmUgPSB0aW1lLnRp bWUoKSArIHRpbWVvdXQKICAgICAgICAgX2xvZy5kZWJ1ZygnV2FpdGluZyB1bnRpbCBubyBjb20u YXBwbGUuZGF0YW1pZ3JhdG9yIHByb2Nlc3NlcyBhcmUgZm91bmQnKQo=