190054 2018-09-27 14:12:18 -0700 DFG::OSREntry::m_machineCodeOffset should be a CodeLocation. 2018-09-27 15:33:33 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue fpizlo keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer oldest_to_newest 1464143 0 mark.lam 2018-09-27 14:12:18 -0700 <rdar://problem/44803543> 1464145 1 351001 mark.lam 2018-09-27 14:17:09 -0700 Created attachment 351001 proposed patch. 1464178 2 351001 mark.lam 2018-09-27 15:05:56 -0700 Comment on attachment 351001 proposed patch. Thanks for the review. Landing now. 1464190 3 351001 commit-queue 2018-09-27 15:33:31 -0700 Comment on attachment 351001 proposed patch. Clearing flags on attachment: 351001 Committed r236576: <https://trac.webkit.org/changeset/236576> 1464191 4 commit-queue 2018-09-27 15:33:33 -0700 All reviewed patches have been landed. Closing bug. 351001 2018-09-27 14:17:09 -0700 2018-09-27 15:33:31 -0700 proposed patch. bug-190054.patch text/plain 5306 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjM2NTcwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE4LTA5LTI3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBE Rkc6Ok9TUkVudHJ5OjptX21hY2hpbmVDb2RlT2Zmc2V0IHNob3VsZCBiZSBhIENvZGVMb2NhdGlv bi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDA1 NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDQ4MDM1NDM+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkZmcvREZHSklUQ29kZS5oOgorICAgICAg ICAoSlNDOjpERkc6OkpJVENvZGU6OmFwcGVuZE9TUkVudHJ5RGF0YSk6CisgICAgICAgICogZGZn L0RGR0pJVENvbXBpbGVyLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpKSVRDb21waWxlcjo6bm90 aWNlT1NSRW50cnkpOgorICAgICAgICAqIGRmZy9ERkdPU1JFbnRyeS5jcHA6CisgICAgICAgIChK U0M6OkRGRzo6T1NSRW50cnlEYXRhOjpkdW1wSW5Db250ZXh0IGNvbnN0KToKKyAgICAgICAgKEpT Qzo6REZHOjpwcmVwYXJlT1NSRW50cnkpOgorICAgICAgICAqIGRmZy9ERkdPU1JFbnRyeS5oOgor ICAgICAgICAqIHJ1bnRpbWUvSlNDUHRyVGFnLmg6CisKIDIwMTgtMDktMjcgIE1hcmsgTGFtICA8 bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEpJVE1hdGhJQyBzaG91bGQgbm90IHVzZSBp bnRlZ2VyIG9mZnNldHMgaW50byBtYWNoaW5lIGNvZGUuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR0pJVENvZGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR0pJVENvZGUuaAkocmV2aXNpb24gMjM2NTQwKQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdKSVRDb2RlLmgJKHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAv KgotICogQ29weXJpZ2h0IChDKSAyMDEzLTIwMTcgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2Vy dmVkLgorICogQ29weXJpZ2h0IChDKSAyMDEzLTIwMTggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJl c2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5h cnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVk IHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC01NCwxMSArNTQsMTEg QEAgcHVibGljOgogICAgIENvbW1vbkRhdGEqIGRmZ0NvbW1vbigpIG92ZXJyaWRlOwogICAgIEpJ VENvZGUqIGRmZygpIG92ZXJyaWRlOwogICAgIAotICAgIE9TUkVudHJ5RGF0YSogYXBwZW5kT1NS RW50cnlEYXRhKHVuc2lnbmVkIGJ5dGVjb2RlSW5kZXgsIHVuc2lnbmVkIG1hY2hpbmVDb2RlT2Zm c2V0KQorICAgIE9TUkVudHJ5RGF0YSogYXBwZW5kT1NSRW50cnlEYXRhKHVuc2lnbmVkIGJ5dGVj b2RlSW5kZXgsIENvZGVMb2NhdGlvbkxhYmVsPE9TUkVudHJ5UHRyVGFnPiBtYWNoaW5lQ29kZSkK ICAgICB7CiAgICAgICAgIERGRzo6T1NSRW50cnlEYXRhIGVudHJ5OwogICAgICAgICBlbnRyeS5t X2J5dGVjb2RlSW5kZXggPSBieXRlY29kZUluZGV4OwotICAgICAgICBlbnRyeS5tX21hY2hpbmVD b2RlT2Zmc2V0ID0gbWFjaGluZUNvZGVPZmZzZXQ7CisgICAgICAgIGVudHJ5Lm1fbWFjaGluZUNv ZGUgPSBtYWNoaW5lQ29kZTsKICAgICAgICAgb3NyRW50cnkuYXBwZW5kKGVudHJ5KTsKICAgICAg ICAgcmV0dXJuICZvc3JFbnRyeS5sYXN0KCk7CiAgICAgfQpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdKSVRDb21waWxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdKSVRDb21waWxlci5jcHAJKHJldmlzaW9uIDIzNjU0MCkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29tcGlsZXIuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC01NzYsNyArNTc2LDcgQEAgdm9pZCBKSVRDb21waWxlcjo6bm90aWNlT1NSRW50cnkoQmFz aWNCbAogICAgIGlmICghYmFzaWNCbG9jay5pbnRlcnNlY3Rpb25PZkNGQUhhc1Zpc2l0ZWQpCiAg ICAgICAgIHJldHVybjsKIAotICAgIE9TUkVudHJ5RGF0YSogZW50cnkgPSBtX2ppdENvZGUtPmFw cGVuZE9TUkVudHJ5RGF0YShiYXNpY0Jsb2NrLmJ5dGVjb2RlQmVnaW4sIGxpbmtCdWZmZXIub2Zm c2V0T2YoYmxvY2tIZWFkKSk7CisgICAgT1NSRW50cnlEYXRhKiBlbnRyeSA9IG1faml0Q29kZS0+ YXBwZW5kT1NSRW50cnlEYXRhKGJhc2ljQmxvY2suYnl0ZWNvZGVCZWdpbiwgbGlua0J1ZmZlci5s b2NhdGlvbk9mPE9TUkVudHJ5UHRyVGFnPihibG9ja0hlYWQpKTsKIAogICAgIGVudHJ5LT5tX2V4 cGVjdGVkVmFsdWVzID0gYmFzaWNCbG9jay5pbnRlcnNlY3Rpb25PZlBhc3RWYWx1ZXNBdEhlYWQ7 CiAgICAgICAgIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPU1JFbnRyeS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPU1JFbnRyeS5j cHAJKHJldmlzaW9uIDIzNjU0MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NS RW50cnkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Miw3ICs0Miw3IEBAIG5hbWVzcGFjZSBKU0Mg eyBuYW1lc3BhY2UgREZHIHsKIAogdm9pZCBPU1JFbnRyeURhdGE6OmR1bXBJbkNvbnRleHQoUHJp bnRTdHJlYW0mIG91dCwgRHVtcENvbnRleHQqIGNvbnRleHQpIGNvbnN0CiB7Ci0gICAgb3V0LnBy aW50KCJiYyMiLCBtX2J5dGVjb2RlSW5kZXgsICIsIG1hY2hpbmUgY29kZSBvZmZzZXQgPSAiLCBt X21hY2hpbmVDb2RlT2Zmc2V0KTsKKyAgICBvdXQucHJpbnQoImJjIyIsIG1fYnl0ZWNvZGVJbmRl eCwgIiwgbWFjaGluZSBjb2RlID0gIiwgUmF3UG9pbnRlcihtX21hY2hpbmVDb2RlLmV4ZWN1dGFi bGVBZGRyZXNzKCkpKTsKICAgICBvdXQucHJpbnQoIiwgc3RhY2sgcnVsZXMgPSBbIik7CiAgICAg CiAgICAgYXV0byBwcmludE9wZXJhbmQgPSBbJl0gKFZpcnR1YWxSZWdpc3RlciByZWcpIHsKQEAg LTI2OSwxMSArMjY5LDEyIEBAIHZvaWQqIHByZXBhcmVPU1JFbnRyeShFeGVjU3RhdGUqIGV4ZWMs IEMKICAgICAKICAgICAqYml0d2lzZV9jYXN0PHNpemVfdCo+KHNjcmF0Y2ggKyAwKSA9IGZyYW1l U2l6ZTsKICAgICAKLSAgICB2b2lkKiB0YXJnZXRQQyA9IGNvZGVCbG9jay0+aml0Q29kZSgpLT5l eGVjdXRhYmxlQWRkcmVzc0F0T2Zmc2V0KGVudHJ5LT5tX21hY2hpbmVDb2RlT2Zmc2V0KTsKKyAg ICB2b2lkKiB0YXJnZXRQQyA9IGVudHJ5LT5tX21hY2hpbmVDb2RlLmV4ZWN1dGFibGVBZGRyZXNz KCk7CisgICAgUkVMRUFTRV9BU1NFUlQoY29kZUJsb2NrLT5qaXRDb2RlKCktPmNvbnRhaW5zKGVu dHJ5LT5tX21hY2hpbmVDb2RlLnVudGFnZ2VkRXhlY3V0YWJsZUFkZHJlc3MoKSkpOwogICAgIGlm IChPcHRpb25zOjp2ZXJib3NlT1NSKCkpCiAgICAgICAgIGRhdGFMb2dGKCIgICAgT1NSIHVzaW5n IHRhcmdldCBQQyAlcC5cbiIsIHRhcmdldFBDKTsKICAgICBSRUxFQVNFX0FTU0VSVCh0YXJnZXRQ Qyk7Ci0gICAgKmJpdHdpc2VfY2FzdDx2b2lkKio+KHNjcmF0Y2ggKyAxKSA9IHJldGFnQ29kZVB0 cih0YXJnZXRQQywgSlNFbnRyeVB0clRhZywgYml0d2lzZV9jYXN0PFB0clRhZz4oZXhlYykpOwor ICAgICpiaXR3aXNlX2Nhc3Q8dm9pZCoqPihzY3JhdGNoICsgMSkgPSByZXRhZ0NvZGVQdHIodGFy Z2V0UEMsIE9TUkVudHJ5UHRyVGFnLCBiaXR3aXNlX2Nhc3Q8UHRyVGFnPihleGVjKSk7CiAKICAg ICBSZWdpc3RlciogcGl2b3QgPSBzY3JhdGNoICsgMiArIENhbGxGcmFtZTo6aGVhZGVyU2l6ZUlu UmVnaXN0ZXJzOwogICAgIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPU1JF bnRyeS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRW50 cnkuaAkocmV2aXNpb24gMjM2NTQwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdP U1JFbnRyeS5oCSh3b3JraW5nIGNvcHkpCkBAIC01NCw3ICs1NCw3IEBAIHN0cnVjdCBPU1JFbnRy eVJlc2h1ZmZsaW5nIHsKIAogc3RydWN0IE9TUkVudHJ5RGF0YSB7CiAgICAgdW5zaWduZWQgbV9i eXRlY29kZUluZGV4OwotICAgIHVuc2lnbmVkIG1fbWFjaGluZUNvZGVPZmZzZXQ7CisgICAgQ29k ZUxvY2F0aW9uTGFiZWw8T1NSRW50cnlQdHJUYWc+IG1fbWFjaGluZUNvZGU7CiAgICAgT3BlcmFu ZHM8QWJzdHJhY3RWYWx1ZT4gbV9leHBlY3RlZFZhbHVlczsKICAgICAvLyBVc2UgYml0dmVjdG9y cyBoZXJlIGJlY2F1c2UgdGhleSB0ZW5kIHRvIG9ubHkgcmVxdWlyZSBvbmUgd29yZC4KICAgICBC aXRWZWN0b3IgbV9sb2NhbHNGb3JjZWREb3VibGU7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9KU0NQdHJUYWcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9KU0NQdHJUYWcuaAkocmV2aXNpb24gMjM2NTQwKQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSlNDUHRyVGFnLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ1LDYgKzQ1 LDcgQEAgdXNpbmcgUHRyVGFnID0gV1RGOjpQdHJUYWc7CiAgICAgdihKU1N3aXRjaFB0clRhZykg XAogICAgIHYoTGlua0J1ZmZlclB0clRhZykgXAogICAgIHYoT3BlcmF0aW9uUHRyVGFnKSBcCisg ICAgdihPU1JFbnRyeVB0clRhZykgXAogICAgIHYoT1NSRXhpdFB0clRhZykgXAogICAgIHYoUGxh dGZvcm1SZWdpc3RlcnNMUlB0clRhZykgXAogICAgIHYoUGxhdGZvcm1SZWdpc3RlcnNQQ1B0clRh ZykgXAo=