190030 2018-09-26 22:55:46 -0700 JITMathIC should not use integer offsets into machine code. 2018-09-27 09:58:35 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue fpizlo keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer oldest_to_newest 1463894 0 mark.lam 2018-09-26 22:55:46 -0700 <rdar://problem/44803307> 1463896 1 350949 mark.lam 2018-09-26 23:01:43 -0700 Created attachment 350949 proposed patch. 1464000 2 350949 mark.lam 2018-09-27 09:30:40 -0700 Comment on attachment 350949 proposed patch. Thanks for the review. Landing now. 1464018 3 350949 commit-queue 2018-09-27 09:58:33 -0700 Comment on attachment 350949 proposed patch. Clearing flags on attachment: 350949 Committed r236554: <https://trac.webkit.org/changeset/236554> 1464019 4 commit-queue 2018-09-27 09:58:35 -0700 All reviewed patches have been landed. Closing bug. 350949 2018-09-26 23:01:43 -0700 2018-09-27 09:58:33 -0700 proposed patch. bug-190030.patch text/plain 4332 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjM2NTM4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE4LTA5LTI2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBK SVRNYXRoSUMgc2hvdWxkIG5vdCB1c2UgaW50ZWdlciBvZmZzZXRzIGludG8gbWFjaGluZSBjb2Rl LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMDMw CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NDgwMzMwNz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSdsbCByZXBsYWNlIHRoZW0gd2l0aCBDb2Rl TG9jYXRpb24gc21hcnQgcG9pbnRlcnMgaW5zdGVhZC4KKworICAgICAgICAqIGppdC9KSVRNYXRo SUMuaDoKKyAgICAgICAgKEpTQzo6aXNQcm9maWxlRW1wdHkpOgorCiAyMDE4LTA5LTI2ICBNYXJr IExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBPcHRpb25zOjp1c2VTZXBhcmF0 ZWRXWEhlYXAoKSBzaG91bGQgYWx3YXlzIGJlIGZhbHNlIHdoZW4gRU5BQkxFKEZBU1RfSklUX1BF Uk1JU1NJT05TKSAmJiBDUFUoQVJNNjRFKS4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9q aXQvSklUTWF0aElDLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9K SVRNYXRoSUMuaAkocmV2aXNpb24gMjM2NTM3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2pp dC9KSVRNYXRoSUMuaAkod29ya2luZyBjb3B5KQpAQCAtNjIsMTAgKzYyLDEwIEBAIHB1YmxpYzoK ICAgICB7CiAgICAgfQogCi0gICAgQ29kZUxvY2F0aW9uTGFiZWw8SlNJbnRlcm5hbFB0clRhZz4g ZG9uZUxvY2F0aW9uKCkgeyByZXR1cm4gbV9pbmxpbmVTdGFydC5sYWJlbEF0T2Zmc2V0KG1faW5s aW5lU2l6ZSk7IH0KLSAgICBDb2RlTG9jYXRpb25MYWJlbDxKU0ludGVybmFsUHRyVGFnPiBzbG93 UGF0aFN0YXJ0TG9jYXRpb24oKSB7IHJldHVybiBtX2lubGluZVN0YXJ0LmxhYmVsQXRPZmZzZXQo bV9kZWx0YUZyb21TdGFydFRvU2xvd1BhdGhTdGFydCk7IH0KLSAgICBDb2RlTG9jYXRpb25DYWxs PEpTSW50ZXJuYWxQdHJUYWc+IHNsb3dQYXRoQ2FsbExvY2F0aW9uKCkgeyByZXR1cm4gbV9pbmxp bmVTdGFydC5jYWxsQXRPZmZzZXQobV9kZWx0YUZyb21TdGFydFRvU2xvd1BhdGhDYWxsTG9jYXRp b24pOyB9Ci0gICAgCisgICAgQ29kZUxvY2F0aW9uTGFiZWw8SlNJbnRlcm5hbFB0clRhZz4gZG9u ZUxvY2F0aW9uKCkgeyByZXR1cm4gbV9pbmxpbmVFbmQ7IH0KKyAgICBDb2RlTG9jYXRpb25DYWxs PEpTSW50ZXJuYWxQdHJUYWc+IHNsb3dQYXRoQ2FsbExvY2F0aW9uKCkgeyByZXR1cm4gbV9zbG93 UGF0aENhbGxMb2NhdGlvbjsgfQorICAgIENvZGVMb2NhdGlvbkxhYmVsPEpTSW50ZXJuYWxQdHJU YWc+IHNsb3dQYXRoU3RhcnRMb2NhdGlvbigpIHsgcmV0dXJuIG1fc2xvd1BhdGhTdGFydExvY2F0 aW9uOyB9CisKICAgICBib29sIGdlbmVyYXRlSW5saW5lKENDYWxsSGVscGVycyYgaml0LCBNYXRo SUNHZW5lcmF0aW9uU3RhdGUmIHN0YXRlLCBib29sIHNob3VsZEVtaXRQcm9maWxpbmcgPSB0cnVl KQogICAgIHsKICNpZiBDUFUoQVJNX1RSQURJVElPTkFMKQpAQCAtMTM2LDcgKzEzNiw3IEBAIHB1 YmxpYzoKICAgICAgICAgICAgIGF1dG8ganVtcCA9IGppdC5qdW1wKCk7CiAgICAgICAgICAgICAv LyBXZSBkb24ndCBuZWVkIGEgbm9wIHNsZWQgaGVyZSBiZWNhdXNlIG5vYm9keSBzaG91bGQgYmUg anVtcGluZyBpbnRvIHRoZSBtaWRkbGUgb2YgYW4gSUMuCiAgICAgICAgICAgICBib29sIG5lZWRz QnJhbmNoQ29tcGFjdGlvbiA9IGZhbHNlOwotICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlQoaml0 Lm1fYXNzZW1ibGVyLmJ1ZmZlcigpLmNvZGVTaXplKCkgPD0gc3RhdGljX2Nhc3Q8c2l6ZV90Piht X2lubGluZVNpemUpKTsKKyAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJUKGppdC5tX2Fzc2VtYmxl ci5idWZmZXIoKS5jb2RlU2l6ZSgpIDw9IHN0YXRpY19jYXN0PHNpemVfdD4oTWFjcm9Bc3NlbWJs ZXI6OmRpZmZlcmVuY2VCZXR3ZWVuQ29kZVB0cihtX2lubGluZVN0YXJ0LCBtX2lubGluZUVuZCkp KTsKICAgICAgICAgICAgIExpbmtCdWZmZXIgbGlua0J1ZmZlcihqaXQsIG1faW5saW5lU3RhcnQs IGppdC5tX2Fzc2VtYmxlci5idWZmZXIoKS5jb2RlU2l6ZSgpLCBKSVRDb21waWxhdGlvbk11c3RT dWNjZWVkLCBuZWVkc0JyYW5jaENvbXBhY3Rpb24pOwogICAgICAgICAgICAgUkVMRUFTRV9BU1NF UlQobGlua0J1ZmZlci5pc1ZhbGlkKCkpOwogICAgICAgICAgICAgbGlua0J1ZmZlci5saW5rKGp1 bXAsIENvZGVMb2NhdGlvbkxhYmVsPEpJVFN0dWJSb3V0aW5lUHRyVGFnPihtX2NvZGUuY29kZSgp KSk7CkBAIC0yMjQsMTQgKzIyNCwxMSBAQCBwdWJsaWM6CiAgICAgICAgIENvZGVMb2NhdGlvbkxh YmVsPEpTSW50ZXJuYWxQdHJUYWc+IHN0YXJ0ID0gbGlua0J1ZmZlci5sb2NhdGlvbk9mPEpTSW50 ZXJuYWxQdHJUYWc+KHN0YXRlLmZhc3RQYXRoU3RhcnQpOwogICAgICAgICBtX2lubGluZVN0YXJ0 ID0gc3RhcnQ7CiAKLSAgICAgICAgbV9pbmxpbmVTaXplID0gTWFjcm9Bc3NlbWJsZXI6OmRpZmZl cmVuY2VCZXR3ZWVuQ29kZVB0cigKLSAgICAgICAgICAgIHN0YXJ0LCBsaW5rQnVmZmVyLmxvY2F0 aW9uT2Y8Tm9QdHJUYWc+KHN0YXRlLmZhc3RQYXRoRW5kKSk7Ci0gICAgICAgIEFTU0VSVChtX2lu bGluZVNpemUgPiAwKTsKLQotICAgICAgICBtX2RlbHRhRnJvbVN0YXJ0VG9TbG93UGF0aENhbGxM b2NhdGlvbiA9IE1hY3JvQXNzZW1ibGVyOjpkaWZmZXJlbmNlQmV0d2VlbkNvZGVQdHIoCi0gICAg ICAgICAgICBzdGFydCwgbGlua0J1ZmZlci5sb2NhdGlvbk9mPE5vUHRyVGFnPihzdGF0ZS5zbG93 UGF0aENhbGwpKTsKLSAgICAgICAgbV9kZWx0YUZyb21TdGFydFRvU2xvd1BhdGhTdGFydCA9IE1h Y3JvQXNzZW1ibGVyOjpkaWZmZXJlbmNlQmV0d2VlbkNvZGVQdHIoCi0gICAgICAgICAgICBzdGFy dCwgbGlua0J1ZmZlci5sb2NhdGlvbk9mPE5vUHRyVGFnPihzdGF0ZS5zbG93UGF0aFN0YXJ0KSk7 CisgICAgICAgIG1faW5saW5lRW5kID0gbGlua0J1ZmZlci5sb2NhdGlvbk9mPEpTSW50ZXJuYWxQ dHJUYWc+KHN0YXRlLmZhc3RQYXRoRW5kKTsKKyAgICAgICAgQVNTRVJUKG1faW5saW5lRW5kLnVu dGFnZ2VkRXhlY3V0YWJsZUFkZHJlc3MoKSA+IG1faW5saW5lU3RhcnQudW50YWdnZWRFeGVjdXRh YmxlQWRkcmVzcygpKTsKKworICAgICAgICBtX3Nsb3dQYXRoQ2FsbExvY2F0aW9uID0gbGlua0J1 ZmZlci5sb2NhdGlvbk9mPEpTSW50ZXJuYWxQdHJUYWc+KHN0YXRlLnNsb3dQYXRoQ2FsbCk7Cisg ICAgICAgIG1fc2xvd1BhdGhTdGFydExvY2F0aW9uID0gbGlua0J1ZmZlci5sb2NhdGlvbk9mPEpT SW50ZXJuYWxQdHJUYWc+KHN0YXRlLnNsb3dQYXRoU3RhcnQpOwogICAgIH0KIAogICAgIEFyaXRo UHJvZmlsZSogYXJpdGhQcm9maWxlKCkgY29uc3QgeyByZXR1cm4gbV9hcml0aFByb2ZpbGU7IH0K QEAgLTI1Miw5ICsyNDksOSBAQCBwdWJsaWM6CiAgICAgSW5zdHJ1Y3Rpb24qIG1faW5zdHJ1Y3Rp b247CiAgICAgTWFjcm9Bc3NlbWJsZXJDb2RlUmVmPEpJVFN0dWJSb3V0aW5lUHRyVGFnPiBtX2Nv ZGU7CiAgICAgQ29kZUxvY2F0aW9uTGFiZWw8SlNJbnRlcm5hbFB0clRhZz4gbV9pbmxpbmVTdGFy dDsKLSAgICBpbnQzMl90IG1faW5saW5lU2l6ZTsKLSAgICBpbnQzMl90IG1fZGVsdGFGcm9tU3Rh cnRUb1Nsb3dQYXRoQ2FsbExvY2F0aW9uOwotICAgIGludDMyX3QgbV9kZWx0YUZyb21TdGFydFRv U2xvd1BhdGhTdGFydDsKKyAgICBDb2RlTG9jYXRpb25MYWJlbDxKU0ludGVybmFsUHRyVGFnPiBt X2lubGluZUVuZDsKKyAgICBDb2RlTG9jYXRpb25MYWJlbDxKU0ludGVybmFsUHRyVGFnPiBtX3Ns b3dQYXRoQ2FsbExvY2F0aW9uOworICAgIENvZGVMb2NhdGlvbkxhYmVsPEpTSW50ZXJuYWxQdHJU YWc+IG1fc2xvd1BhdGhTdGFydExvY2F0aW9uOwogICAgIGJvb2wgbV9nZW5lcmF0ZUZhc3RQYXRo T25SZXBhdGNoIHsgZmFsc2UgfTsKICAgICBHZW5lcmF0b3JUeXBlIG1fZ2VuZXJhdG9yOwogfTsK