190022 2018-09-26 18:12:25 -0700 Options::useSeparatedWXHeap() should always be false when ENABLE(FAST_JIT_PERMISSIONS) && CPU(ARM64E). 2018-09-27 10:14:27 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 190023 1 mark.lam mark.lam fpizlo keith_miller msaboff rmorisset saam sam tzagallo webkit-bug-importer oldest_to_newest 1463850 0 mark.lam 2018-09-26 18:12:25 -0700 <rdar://problem/44800928> 1463855 1 350933 mark.lam 2018-09-26 18:24:40 -0700 Created attachment 350933 proposed patch. 1463872 2 mark.lam 2018-09-26 21:37:09 -0700 Thanks for the review. Landed in r236538: <http://trac.webkit.org/r236538>. 1464025 3 350933 sam 2018-09-27 10:14:27 -0700 Comment on attachment 350933 proposed patch. I think this might be a little more clear if you introduced a new ENABLE macro specifically for SeparatedWXHeap, an ENABLE_ SEPARATED_WXHEAP. 350933 2018-09-26 18:24:40 -0700 2018-09-26 18:28:00 -0700 proposed patch. bug-190022.patch text/plain 5867 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjM2NTM0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE4LTA5LTI2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBP cHRpb25zOjp1c2VTZXBhcmF0ZWRXWEhlYXAoKSBzaG91bGQgYWx3YXlzIGJlIGZhbHNlIHdoZW4g RU5BQkxFKEZBU1RfSklUX1BFUk1JU1NJT05TKSAmJiBDUFUoQVJNNjRFKS4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDAyMgorICAgICAgICA8cmRh cjovL3Byb2JsZW0vNDQ4MDA5Mjg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBqaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5jcHA6CisgICAgICAgIChK U0M6OkZpeGVkVk1Qb29sRXhlY3V0YWJsZUFsbG9jYXRvcjo6Rml4ZWRWTVBvb2xFeGVjdXRhYmxl QWxsb2NhdG9yKToKKyAgICAgICAgKEpTQzo6Rml4ZWRWTVBvb2xFeGVjdXRhYmxlQWxsb2NhdG9y Ojppbml0aWFsaXplU2VwYXJhdGVkV1hIZWFwcyk6CisgICAgICAgICogaml0L0V4ZWN1dGFibGVB bGxvY2F0b3IuaDoKKyAgICAgICAgKEpTQzo6cGVyZm9ybUpJVE1lbWNweSk6CisgICAgICAgICog cnVudGltZS9PcHRpb25zLmNwcDoKKyAgICAgICAgKEpTQzo6cmVjb21wdXRlRGVwZW5kZW50T3B0 aW9ucyk6CisKIDIwMTgtMDktMjYgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAg ICAgICAgIEFzc2VydCB0aGF0IHBlcmZvcm1KSVRNZW1jcHkoKSBpcyBhbHdheXMgY2FsbGVkIHdp dGggaW5zdHJ1Y3Rpb24gc2l6ZSBhbGlnbmVkIGFkZHJlc3NlcyBvbiBBUk02NC4KSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmNwcAko cmV2aXNpb24gMjM2NTM0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxl QWxsb2NhdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA2LDkgKzEwNiwxMSBAQCBzdGF0aWMg Y29uc3QgZG91YmxlIGV4ZWN1dGFibGVQb29sUmVzZXJ2CiAKIEpTX0VYUE9SVF9QUklWQVRFIHZv aWQqIHRhZ2dlZFN0YXJ0T2ZGaXhlZEV4ZWN1dGFibGVNZW1vcnlQb29sOwogSlNfRVhQT1JUX1BS SVZBVEUgdm9pZCogdGFnZ2VkRW5kT2ZGaXhlZEV4ZWN1dGFibGVNZW1vcnlQb29sOwotSlNfRVhQ T1JUX1BSSVZBVEUgYm9vbCB1c2VGYXN0UGVybWlzaW9uc0pJVENvcHkgeyBmYWxzZSB9OwogCisj aWYgIUVOQUJMRShGQVNUX0pJVF9QRVJNSVNTSU9OUykgfHwgIUNQVShBUk02NEUpCitKU19FWFBP UlRfUFJJVkFURSBib29sIHVzZUZhc3RQZXJtaXNpb25zSklUQ29weSB7IGZhbHNlIH07CiBKU19F WFBPUlRfUFJJVkFURSBKSVRXcml0ZVNlcGFyYXRlSGVhcHNGdW5jdGlvbiBqaXRXcml0ZVNlcGFy YXRlSGVhcHNGdW5jdGlvbjsKKyNlbmRpZgogCiAjaWYgIVVTRShFWEVDVVRFX09OTFlfSklUX1dS SVRFX0ZVTkNUSU9OKSAmJiBIQVZFKFJFTUFQX0pJVCkKIHN0YXRpYyB1aW50cHRyX3Qgc3RhcnRP ZkZpeGVkV3JpdGFibGVNZW1vcnlQb29sOwpAQCAtMTQzLDYgKzE0NSwxMSBAQCBwdWJsaWM6CiAg ICAgICAgICAgICBBU1NFUlQobV9yZXNlcnZhdGlvbi5zaXplKCkgPT0gcmVzZXJ2YXRpb25TaXpl KTsKICAgICAgICAgICAgIHZvaWQqIHJlc2VydmF0aW9uQmFzZSA9IG1fcmVzZXJ2YXRpb24uYmFz ZSgpOwogCisjaWYgRU5BQkxFKEZBU1RfSklUX1BFUk1JU1NJT05TKSAmJiBDUFUoQVJNNjRFKQor ICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlQob3NfdGhyZWFkX3NlbGZfcmVzdHJpY3Rfcnd4X2lz X3N1cHBvcnRlZCgpKTsKKyAgICAgICAgICAgIG9zX3RocmVhZF9zZWxmX3Jlc3RyaWN0X3J3eF90 b19yeCgpOworCisjZWxzZSAvLyBub3QgRU5BQkxFKEZBU1RfSklUX1BFUk1JU1NJT05TKSBvciBu b3QgQ1BVKEFSTTY0RSkKICNpZiBFTkFCTEUoRkFTVF9KSVRfUEVSTUlTU0lPTlMpCiAgICAgICAg ICAgICBpZiAob3NfdGhyZWFkX3NlbGZfcmVzdHJpY3Rfcnd4X2lzX3N1cHBvcnRlZCgpKSB7CiAg ICAgICAgICAgICAgICAgdXNlRmFzdFBlcm1pc2lvbnNKSVRDb3B5ID0gdHJ1ZTsKQEAgLTE1Niw2 ICsxNjMsNyBAQCBwdWJsaWM6CiAgICAgICAgICAgICAgICAgcmVzZXJ2YXRpb25TaXplIC09IHBh Z2VTaXplKCk7CiAgICAgICAgICAgICAgICAgaW5pdGlhbGl6ZVNlcGFyYXRlZFdYSGVhcHMobV9y ZXNlcnZhdGlvbi5iYXNlKCksIHBhZ2VTaXplKCksIHJlc2VydmF0aW9uQmFzZSwgcmVzZXJ2YXRp b25TaXplKTsKICAgICAgICAgICAgIH0KKyNlbmRpZiAvLyBub3QgRU5BQkxFKEZBU1RfSklUX1BF Uk1JU1NJT05TKSBvciBub3QgQ1BVKEFSTTY0RSkKIAogICAgICAgICAgICAgYWRkRnJlc2hGcmVl U3BhY2UocmVzZXJ2YXRpb25CYXNlLCByZXNlcnZhdGlvblNpemUpOwogCkBAIC0yNDQsNyArMjUy LDkgQEAgcHJpdmF0ZToKICAgICAgICAgLy8gWmVybyBvdXQgd3JpdGFibGVBZGRyIHRvIGF2b2lk IGxlYWtpbmcgdGhlIGFkZHJlc3Mgb2YgdGhlIHdyaXRhYmxlIG1hcHBpbmcuCiAgICAgICAgIG1l bXNldF9zKCZ3cml0YWJsZUFkZHIsIHNpemVvZih3cml0YWJsZUFkZHIpLCAwLCBzaXplb2Yod3Jp dGFibGVBZGRyKSk7CiAKKyNpZiAhRU5BQkxFKEZBU1RfSklUX1BFUk1JU1NJT05TKSB8fCAhQ1BV KEFSTTY0RSkKICAgICAgICAgaml0V3JpdGVTZXBhcmF0ZUhlYXBzRnVuY3Rpb24gPSByZWludGVy cHJldF9jYXN0PEpJVFdyaXRlU2VwYXJhdGVIZWFwc0Z1bmN0aW9uPih3cml0ZVRodW5rLmNvZGUo KS5leGVjdXRhYmxlQWRkcmVzcygpKTsKKyNlbmRpZgogICAgIH0KIAogI2lmIENQVShBUk02NCkg JiYgVVNFKEVYRUNVVEVfT05MWV9KSVRfV1JJVEVfRlVOQ1RJT04pCkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuaAkocmV2aXNpb24gMjM2 NTM0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmgJ KHdvcmtpbmcgY29weSkKQEAgLTgxLDExICs4MSwxNCBAQCBpbmxpbmUgYm9vbCBpc0pJVFBDKHZv aWQqIHBjKQogICAgIHJldHVybiBzdGFydE9mRml4ZWRFeGVjdXRhYmxlTWVtb3J5UG9vbCgpIDw9 IHBjICYmIHBjIDwgZW5kT2ZGaXhlZEV4ZWN1dGFibGVNZW1vcnlQb29sKCk7CiB9CiAKKyNpZiAh RU5BQkxFKEZBU1RfSklUX1BFUk1JU1NJT05TKSB8fCAhQ1BVKEFSTTY0RSkKKwogdHlwZWRlZiB2 b2lkICgqSklUV3JpdGVTZXBhcmF0ZUhlYXBzRnVuY3Rpb24pKG9mZl90LCBjb25zdCB2b2lkKiwg c2l6ZV90KTsKIGV4dGVybiBKU19FWFBPUlRfUFJJVkFURSBKSVRXcml0ZVNlcGFyYXRlSGVhcHNG dW5jdGlvbiBqaXRXcml0ZVNlcGFyYXRlSGVhcHNGdW5jdGlvbjsKLQogZXh0ZXJuIEpTX0VYUE9S VF9QUklWQVRFIGJvb2wgdXNlRmFzdFBlcm1pc2lvbnNKSVRDb3B5OwogCisjZW5kaWYgLy8gIUVO QUJMRShGQVNUX0pJVF9QRVJNSVNTSU9OUykgfHwgIUNQVShBUk02NEUpCisKIHN0YXRpYyBpbmxp bmUgdm9pZCogcGVyZm9ybUpJVE1lbWNweSh2b2lkICpkc3QsIGNvbnN0IHZvaWQgKnNyYywgc2l6 ZV90IG4pCiB7CiAjaWYgQ1BVKEFSTTY0KQpAQCAtOTYsMTQgKzk5LDE4IEBAIHN0YXRpYyBpbmxp bmUgdm9pZCogcGVyZm9ybUpJVE1lbWNweSh2b2kKICAgICBpZiAoZHN0ID49IHN0YXJ0T2ZGaXhl ZEV4ZWN1dGFibGVNZW1vcnlQb29sKCkgJiYgZHN0IDwgZW5kT2ZGaXhlZEV4ZWN1dGFibGVNZW1v cnlQb29sKCkpIHsKICAgICAgICAgUkVMRUFTRV9BU1NFUlQocmVpbnRlcnByZXRfY2FzdDx1aW50 OF90Kj4oZHN0KSArIG4gPD0gZW5kT2ZGaXhlZEV4ZWN1dGFibGVNZW1vcnlQb29sKCkpOwogI2lm IEVOQUJMRShGQVNUX0pJVF9QRVJNSVNTSU9OUykKLSAgICAgICAgaWYgKHVzZUZhc3RQZXJtaXNp b25zSklUQ29weSkgeworI2lmICFDUFUoQVJNNjRFKQorICAgICAgICBpZiAodXNlRmFzdFBlcm1p c2lvbnNKSVRDb3B5KQorI2VuZGlmCisgICAgICAgIHsKICAgICAgICAgICAgIG9zX3RocmVhZF9z ZWxmX3Jlc3RyaWN0X3J3eF90b19ydygpOwogICAgICAgICAgICAgbWVtY3B5KGRzdCwgc3JjLCBu KTsKICAgICAgICAgICAgIG9zX3RocmVhZF9zZWxmX3Jlc3RyaWN0X3J3eF90b19yeCgpOwogICAg ICAgICAgICAgcmV0dXJuIGRzdDsKICAgICAgICAgfQotI2VuZGlmCisjZW5kaWYgLy8gRU5BQkxF KEZBU1RfSklUX1BFUk1JU1NJT05TKQogCisjaWYgIUVOQUJMRShGQVNUX0pJVF9QRVJNSVNTSU9O UykgfHwgIUNQVShBUk02NEUpCiAgICAgICAgIGlmIChqaXRXcml0ZVNlcGFyYXRlSGVhcHNGdW5j dGlvbikgewogICAgICAgICAgICAgLy8gVXNlIGV4ZWN1dGUtb25seSB3cml0ZSB0aHVuayBmb3Ig d3JpdGVzIGluc2lkZSB0aGUgSklUIHJlZ2lvbi4gVGhpcyBpcyBhIHZhcmlhbnQgb2YKICAgICAg ICAgICAgIC8vIG1lbWNweSB0aGF0IHRha2VzIGFuIG9mZnNldCBpbnRvIHRoZSBKSVQgcmVnaW9u IGFzIGl0cyBkZXN0aW5hdGlvbiAoZmlyc3QpIHBhcmFtZXRlci4KQEAgLTExMSw2ICsxMTgsNyBA QCBzdGF0aWMgaW5saW5lIHZvaWQqIHBlcmZvcm1KSVRNZW1jcHkodm9pCiAgICAgICAgICAgICBy ZXRhZ0NvZGVQdHI8SklUVGh1bmtQdHJUYWcsIENGdW5jdGlvblB0clRhZz4oaml0V3JpdGVTZXBh cmF0ZUhlYXBzRnVuY3Rpb24pKG9mZnNldCwgc3JjLCBuKTsKICAgICAgICAgICAgIHJldHVybiBk c3Q7CiAgICAgICAgIH0KKyNlbmRpZgogICAgIH0KIAogICAgIC8vIFVzZSByZWd1bGFyIG1lbWNw eSBmb3Igd3JpdGVzIG91dHNpZGUgdGhlIEpJVCByZWdpb24uCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9PcHRpb25zLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9PcHRpb25zLmNwcAkocmV2aXNpb24gMjM2NTM0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ1 OSw3ICs0NTksNyBAQCBzdGF0aWMgdm9pZCByZWNvbXB1dGVEZXBlbmRlbnRPcHRpb25zKCkKICAg ICAgICAgT3B0aW9uczo6dXNlT1NSRW50cnlUb0ZUTCgpID0gZmFsc2U7CiAgICAgfQogICAgIAot I2lmIFBMQVRGT1JNKElPUykgJiYgQ1BVKEFSTTY0KQorI2lmIFBMQVRGT1JNKElPUykgJiYgQ1BV KEFSTTY0KSAmJiAhQ1BVKEFSTTY0RSkKICAgICAvLyBPdmVycmlkZSBnbG9iYWxseSBmb3Igbm93 LiBMb25nZXIgdGVybSB3ZSdsbCBqdXN0IG1ha2UgdGhlIGRlZmF1bHQKICAgICAvLyBiZSB0byBo YXZlIHRoaXMgb3B0aW9uIGVuYWJsZWQsIGFuZCBoYXZlIHBsYXRmb3JtcyB0aGF0IGRvbid0IHN1 cHBvcnQKICAgICAvLyBpdCBqdXN0IHNpbGVudGx5IHVzZSBhIHNpbmdsZSBtYXBwaW5nLgo=