190021 2018-09-26 18:03:39 -0700 Fix IOSMAC build 2018-09-27 14:03:30 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu achristensen cdumez commit-queue rniwa ryanhaddad webkit-bug-importer youennf oldest_to_newest 1463848 0 sihui_liu 2018-09-26 18:03:39 -0700 NetworkProcess::parentProcessHasServiceWorkerEntitlement() not exists in PLATFORM(IOSMAC) 1463849 1 350931 sihui_liu 2018-09-26 18:08:25 -0700 Created attachment 350931 Patch 1463883 2 350942 sihui_liu 2018-09-26 22:29:20 -0700 Created attachment 350942 Patch 1463968 3 350942 achristensen 2018-09-27 08:56:05 -0700 Comment on attachment 350942 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350942&action=review Did you verify this fixes the build? If so, is there a way to just include NetworkProcessIOS in that build instead? > Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:275 > +#if !PLATFORM(IOSMAC) With things like this, we usually have the positive form first: #if PLATFORM(IOSMAC) 1463989 4 sihui_liu 2018-09-27 09:19:14 -0700 (In reply to Alex Christensen from comment #3) > Comment on attachment 350942 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=350942&action=review > > Did you verify this fixes the build? If so, is there a way to just include > NetworkProcessIOS in that build instead? > I am trying to build now. This patch would most likely fix the build because we have #if PLATFORM(IOS) && !PLATFORM(IOSMAC) in NetworkProcessIOS.mm. I will also try remove #if PLATFORM(IOS) && !PLATFORM(IOSMAC) from NetworkProcessIOS.mm. > > Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:275 > > +#if !PLATFORM(IOSMAC) > > With things like this, we usually have the positive form first: > #if PLATFORM(IOSMAC) Gotta 1464110 5 350990 sihui_liu 2018-09-27 13:16:22 -0700 Created attachment 350990 Patch 1464131 6 350990 commit-queue 2018-09-27 14:01:28 -0700 Comment on attachment 350990 Patch Clearing flags on attachment: 350990 Committed r236568: <https://trac.webkit.org/changeset/236568> 1464132 7 commit-queue 2018-09-27 14:01:30 -0700 All reviewed patches have been landed. Closing bug. 1464134 8 webkit-bug-importer 2018-09-27 14:03:30 -0700 <rdar://problem/44842952> 350931 2018-09-26 18:08:25 -0700 2018-09-26 22:29:19 -0700 Patch bug-190021-20180926180825.patch text/plain 2363 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NTMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDgzNjdkZjk1NGNkNzA1YTUz ZjA5YTZiYzg3N2RjZTY5OTFlMWNlNGEuLjE4OWZiMjg1ZTljYjg2NGNhODNiNjYwZTkwMzVjNjY1 Y2QyYmNjMTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMDktMjYgIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IElPU01BQyBidWlsZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMDIxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJv Y2Vzcy9jb2NvYS9OZXR3b3JrUHJvY2Vzc0NvY29hLm1tOgorICAgICAgICAoV2ViS2l0OjpOZXR3 b3JrUHJvY2Vzczo6cGFyZW50UHJvY2Vzc0hhc1NlcnZpY2VXb3JrZXJFbnRpdGxlbWVudCBjb25z dCk6CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvaW9zL05ldHdvcmtQcm9jZXNzSU9TLm1tOgor ICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUHJvY2Vzczo6cGFyZW50UHJvY2Vzc0hhc1NlcnZpY2VX b3JrZXJFbnRpdGxlbWVudCBjb25zdCk6IERlbGV0ZWQuCisKIDIwMTgtMDktMjYgIEphbWVzIFNh dmFnZSAgPGphbWVzLnNhdmFnZUBhcHBsZS5jb20+CiAKICAgICAgICAgQWxsb3cgb3ZlcnJpZGUg b2Ygdmlld3BvcnQgY29uZmlndXJhdGlvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0 d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Byb2Nlc3NDb2NvYS5tbSBiL1NvdXJjZS9XZWJLaXQv TmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Byb2Nlc3NDb2NvYS5tbQppbmRleCBiYjM3OWE0 NTMyZTg4ODU3NGJjMzVhOGYwYmM5OWM2NmU4OTA5Y2ZmLi5kY2RlMWZjNzFmYmJhNGYwYjVjYjkx OWVjMDZiZWE4ZDBlYzA2YTBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL2NvY29hL05ldHdvcmtQcm9jZXNzQ29jb2EubW0KKysrIGIvU291cmNlL1dlYktpdC9OZXR3 b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrUHJvY2Vzc0NvY29hLm1tCkBAIC0yNjgsNCArMjY4LDE2 IEBAIHZvaWQgTmV0d29ya1Byb2Nlc3M6OnBsYXRmb3JtUHJvY2Vzc0RpZFRyYW5zaXRpb25Ub0Zv cmVncm91bmQoKQogI2VuZGlmCiB9CiAKKyNpZiBQTEFURk9STShJT1MpCitib29sIE5ldHdvcmtQ cm9jZXNzOjpwYXJlbnRQcm9jZXNzSGFzU2VydmljZVdvcmtlckVudGl0bGVtZW50KCkgY29uc3QK K3sKKyNpZiAhUExBVEZPUk0oSU9TTUFDKQorICAgIHN0YXRpYyBib29sIGhhc0VudGl0bGVtZW50 ID0gV1RGOjpoYXNFbnRpdGxlbWVudChwYXJlbnRQcm9jZXNzQ29ubmVjdGlvbigpLT54cGNDb25u ZWN0aW9uKCksICJjb20uYXBwbGUuZGV2ZWxvcGVyLldlYktpdC5TZXJ2aWNlV29ya2VycyIpOwor ICAgIHJldHVybiBoYXNFbnRpdGxlbWVudDsKKyNlbHNlCisgICAgcmV0dXJuIHRydWU7CisjZW5k aWYKK30KKyNlbmRpZgorCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvaW9zL05ldHdvcmtQcm9jZXNzSU9TLm1tIGIvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9pb3MvTmV0d29ya1Byb2Nlc3NJT1MubW0KaW5kZXggZDM2 ZDYzNmM5YjU5NzFmNWQ5NzA3M2M2ODFhMzgwNzJiZjMxZTc2Yi4uYjc4N2FkODAzZmMyN2QyMjkz Y2QwNTVhYjI2YTRjY2JjZTE2ZDIwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3Jr UHJvY2Vzcy9pb3MvTmV0d29ya1Byb2Nlc3NJT1MubW0KKysrIGIvU291cmNlL1dlYktpdC9OZXR3 b3JrUHJvY2Vzcy9pb3MvTmV0d29ya1Byb2Nlc3NJT1MubW0KQEAgLTk3LDEyICs5Nyw2IEBAIHZv aWQgTmV0d29ya1Byb2Nlc3M6OnBsYXRmb3JtVGVybWluYXRlKCkKICAgICBub3RJbXBsZW1lbnRl ZCgpOwogfQogCi1ib29sIE5ldHdvcmtQcm9jZXNzOjpwYXJlbnRQcm9jZXNzSGFzU2VydmljZVdv cmtlckVudGl0bGVtZW50KCkgY29uc3QKLXsKLSAgICBzdGF0aWMgYm9vbCBoYXNFbnRpdGxlbWVu dCA9IFdURjo6aGFzRW50aXRsZW1lbnQocGFyZW50UHJvY2Vzc0Nvbm5lY3Rpb24oKS0+eHBjQ29u bmVjdGlvbigpLCAiY29tLmFwcGxlLmRldmVsb3Blci5XZWJLaXQuU2VydmljZVdvcmtlcnMiKTsK LSAgICByZXR1cm4gaGFzRW50aXRsZW1lbnQ7Ci19Ci0KIH0gLy8gbmFtZXNwYWNlIFdlYktpdAog CiAjZW5kaWYgLy8gUExBVEZPUk0oSU9TKQo= 350942 2018-09-26 22:29:20 -0700 2018-09-27 13:16:21 -0700 Patch bug-190021-20180926222919.patch text/plain 2538 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDgzNjdkZjk1NGNkNzA1YTUz ZjA5YTZiYzg3N2RjZTY5OTFlMWNlNGEuLjE4OWZiMjg1ZTljYjg2NGNhODNiNjYwZTkwMzVjNjY1 Y2QyYmNjMTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMDktMjYgIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IElPU01BQyBidWlsZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMDIxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJv Y2Vzcy9jb2NvYS9OZXR3b3JrUHJvY2Vzc0NvY29hLm1tOgorICAgICAgICAoV2ViS2l0OjpOZXR3 b3JrUHJvY2Vzczo6cGFyZW50UHJvY2Vzc0hhc1NlcnZpY2VXb3JrZXJFbnRpdGxlbWVudCBjb25z dCk6CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvaW9zL05ldHdvcmtQcm9jZXNzSU9TLm1tOgor ICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUHJvY2Vzczo6cGFyZW50UHJvY2Vzc0hhc1NlcnZpY2VX b3JrZXJFbnRpdGxlbWVudCBjb25zdCk6IERlbGV0ZWQuCisKIDIwMTgtMDktMjYgIEphbWVzIFNh dmFnZSAgPGphbWVzLnNhdmFnZUBhcHBsZS5jb20+CiAKICAgICAgICAgQWxsb3cgb3ZlcnJpZGUg b2Ygdmlld3BvcnQgY29uZmlndXJhdGlvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0 d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Byb2Nlc3NDb2NvYS5tbSBiL1NvdXJjZS9XZWJLaXQv TmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Byb2Nlc3NDb2NvYS5tbQppbmRleCBiYjM3OWE0 NTMyZTg4ODU3NGJjMzVhOGYwYmM5OWM2NmU4OTA5Y2ZmLi43NTNjODEzNzE1N2Q5YzNiYTIzMTRh ODY0NGJkZDJiNWM2NDA5ZGQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL2NvY29hL05ldHdvcmtQcm9jZXNzQ29jb2EubW0KKysrIGIvU291cmNlL1dlYktpdC9OZXR3 b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrUHJvY2Vzc0NvY29hLm1tCkBAIC00Niw2ICs0Niw3IEBA CiAjaW1wb3J0IDx3dGYvQ2FsbGJhY2tBZ2dyZWdhdG9yLmg+CiAjaW1wb3J0IDx3dGYvUHJvY2Vz c1ByaXZpbGVnZS5oPgogI2ltcG9ydCA8d3RmL1JldGFpblB0ci5oPgorI2ltcG9ydCA8d3RmL2Nv Y29hL0VudGl0bGVtZW50cy5oPgogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIApAQCAtMjY4LDQgKzI2 OSwxNiBAQCB2b2lkIE5ldHdvcmtQcm9jZXNzOjpwbGF0Zm9ybVByb2Nlc3NEaWRUcmFuc2l0aW9u VG9Gb3JlZ3JvdW5kKCkKICNlbmRpZgogfQogCisjaWYgUExBVEZPUk0oSU9TKQorYm9vbCBOZXR3 b3JrUHJvY2Vzczo6cGFyZW50UHJvY2Vzc0hhc1NlcnZpY2VXb3JrZXJFbnRpdGxlbWVudCgpIGNv bnN0Cit7CisjaWYgIVBMQVRGT1JNKElPU01BQykKKyAgICBzdGF0aWMgYm9vbCBoYXNFbnRpdGxl bWVudCA9IFdURjo6aGFzRW50aXRsZW1lbnQocGFyZW50UHJvY2Vzc0Nvbm5lY3Rpb24oKS0+eHBj Q29ubmVjdGlvbigpLCAiY29tLmFwcGxlLmRldmVsb3Blci5XZWJLaXQuU2VydmljZVdvcmtlcnMi KTsKKyAgICByZXR1cm4gaGFzRW50aXRsZW1lbnQ7CisjZWxzZQorICAgIHJldHVybiB0cnVlOwor I2VuZGlmCit9CisjZW5kaWYKKwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2lvcy9OZXR3b3JrUHJvY2Vzc0lPUy5tbSBiL1Nv dXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvaW9zL05ldHdvcmtQcm9jZXNzSU9TLm1tCmluZGV4 IGQzNmQ2MzZjOWI1OTcxZjVkOTcwNzNjNjgxYTM4MDcyYmYzMWU3NmIuLmI3ODdhZDgwM2ZjMjdk MjI5M2NkMDU1YWIyNmE0Y2NiY2UxNmQyMDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0 d29ya1Byb2Nlc3MvaW9zL05ldHdvcmtQcm9jZXNzSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQv TmV0d29ya1Byb2Nlc3MvaW9zL05ldHdvcmtQcm9jZXNzSU9TLm1tCkBAIC05NywxMiArOTcsNiBA QCB2b2lkIE5ldHdvcmtQcm9jZXNzOjpwbGF0Zm9ybVRlcm1pbmF0ZSgpCiAgICAgbm90SW1wbGVt ZW50ZWQoKTsKIH0KIAotYm9vbCBOZXR3b3JrUHJvY2Vzczo6cGFyZW50UHJvY2Vzc0hhc1NlcnZp Y2VXb3JrZXJFbnRpdGxlbWVudCgpIGNvbnN0Ci17Ci0gICAgc3RhdGljIGJvb2wgaGFzRW50aXRs ZW1lbnQgPSBXVEY6Omhhc0VudGl0bGVtZW50KHBhcmVudFByb2Nlc3NDb25uZWN0aW9uKCktPnhw Y0Nvbm5lY3Rpb24oKSwgImNvbS5hcHBsZS5kZXZlbG9wZXIuV2ViS2l0LlNlcnZpY2VXb3JrZXJz Iik7Ci0gICAgcmV0dXJuIGhhc0VudGl0bGVtZW50OwotfQotCiB9IC8vIG5hbWVzcGFjZSBXZWJL aXQKIAogI2VuZGlmIC8vIFBMQVRGT1JNKElPUykK 350990 2018-09-27 13:16:22 -0700 2018-09-27 14:01:28 -0700 Patch bug-190021-20180927131621.patch text/plain 1255 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDE1MzkwMjVjM2FlYmY4ZTUz MjRkYWQ4OWY4MjcyNmYzOGJlYTkwMjIuLjc2ZmRlNDZhZDE5ZDY3OWNlMjYzMDhmNTFlMzg0ODJi OWM0ODkyZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDktMjcgIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IElPU01BQyBidWlsZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMDIxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJv Y2Vzcy9tYWMvTmV0d29ya1Byb2Nlc3NNYWMubW06CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtQ cm9jZXNzOjpwYXJlbnRQcm9jZXNzSGFzU2VydmljZVdvcmtlckVudGl0bGVtZW50IGNvbnN0KToK KwogMjAxOC0wOS0yNyAgUnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4KIAogICAg ICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjM2NTU3LgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9tYWMvTmV0d29ya1Byb2Nlc3NNYWMubW0gYi9Tb3VyY2Uv V2ViS2l0L05ldHdvcmtQcm9jZXNzL21hYy9OZXR3b3JrUHJvY2Vzc01hYy5tbQppbmRleCBiZDdh MjRlOGFiZTdhNmZmNGNkZTlhOTljYjUzMzliODdmYzczZDQ2Li44YjBlNmZkZWE0Njg2MzE5NjRl NzJiYjdjM2NiOWZiMGIyM2ViOTY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQ cm9jZXNzL21hYy9OZXR3b3JrUHJvY2Vzc01hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdv cmtQcm9jZXNzL21hYy9OZXR3b3JrUHJvY2Vzc01hYy5tbQpAQCAtMTUwLDYgKzE1MCwxMyBAQCB2 b2lkIE5ldHdvcmtQcm9jZXNzOjpwbGF0Zm9ybVRlcm1pbmF0ZSgpCiAgICAgfQogfQogCisjaWYg UExBVEZPUk0oSU9TTUFDKQorYm9vbCBOZXR3b3JrUHJvY2Vzczo6cGFyZW50UHJvY2Vzc0hhc1Nl cnZpY2VXb3JrZXJFbnRpdGxlbWVudCgpIGNvbnN0Cit7CisgICAgcmV0dXJuIHRydWU7Cit9Cisj ZW5kaWYKKwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CiAKICNlbmRpZiAvLyBQTEFURk9STShNQUMp Cg==