190019 2018-09-26 17:15:38 -0700 [iOS] Allow access to VoiceServices features needed for accessibility 2018-09-27 14:28:02 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 181619 1 bfulgham bfulgham achristensen bfulgham cfleizach commit-queue jcraig pvollan webkit-bug-importer oldest_to_newest 1463839 0 bfulgham 2018-09-26 17:15:38 -0700 I tightened the sandbox too far in Bug 181619, causing some non-US English voice WebSpeech features to stop working. This patch expands the sandbox to allow those features to work properly in iOS 12. 1463840 1 bfulgham 2018-09-26 17:17:58 -0700 <rdar://problem/43621111> 1463841 2 350928 bfulgham 2018-09-26 17:19:53 -0700 Created attachment 350928 Patch 1463845 3 350928 cfleizach 2018-09-26 17:26:37 -0700 Comment on attachment 350928 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350928&action=review > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:99 > + (global-name "com.apple.voiceservices.keepalive") ; Needed for non-US english language synthesis suspect these are not technically needed. 1464079 4 pvollan 2018-09-27 11:57:23 -0700 (In reply to chris fleizach from comment #3) > Comment on attachment 350928 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=350928&action=review > > > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:99 > > + (global-name "com.apple.voiceservices.keepalive") ; Needed for non-US english language synthesis > > suspect these are not technically needed. I will remove these. 1464083 5 350984 pvollan 2018-09-27 12:10:54 -0700 Created attachment 350984 Patch 1464127 6 350984 pvollan 2018-09-27 13:45:09 -0700 Comment on attachment 350984 Patch Thanks for reviewing! 1464154 7 350984 commit-queue 2018-09-27 14:28:00 -0700 Comment on attachment 350984 Patch Clearing flags on attachment: 350984 Committed r236571: <https://trac.webkit.org/changeset/236571> 1464155 8 commit-queue 2018-09-27 14:28:02 -0700 All reviewed patches have been landed. Closing bug. 350928 2018-09-26 17:19:53 -0700 2018-09-27 12:10:52 -0700 Patch bug-190019-20180926171952.patch text/plain 2114 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDE5Y2EyNzZiMTFkMTViMzcz NWVhMDk0NmE3OTlmNWM5ZmUxZWE2OTkuLjk1YTI5N2Y0OGI5ZmRlMTdlMGU5NDRmZWE1NzhmNjJj NDViYmI2ZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMDktMjYgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gQWxsb3cgYWNjZXNz IHRvIFZvaWNlU2VydmljZXMgZmVhdHVyZXMgbmVlZGVkIGZvciBhY2Nlc3NpYmlsaXR5CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTAwMTkKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzQzNjIxMTExPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJldmlzZSB0aGUgc2FuZGJveCB0byBhbGxvdyBhY2Nlc3Mg dG8gcmVsZXZhbnQgV2ViU3BlZWNoIGZlYXR1cmVzLgorCisgICAgICAgICogUmVzb3VyY2VzL1Nh bmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiOgorCiAyMDE4 LTA5LTIxICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBXaGl0 ZWxpc3QgdHdvIGFkZGl0aW9uYWwgcGx1Z2lucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9S ZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQu c2IgYi9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBs ZS5XZWJLaXQuV2ViQ29udGVudC5zYgppbmRleCBmNDkzMmMzNzhjY2FjODAwZmE3Y2U3ZjU1NWUw OGMyZjExNTA5OTE1Li4wZDVjN2MyNjdmZWIyZDQzMWFkNDg1NDBhOTYyZjlkMTc5NDEyZGJmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2Nv bS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgorKysgYi9Tb3VyY2UvV2ViS2l0L1Jlc291cmNl cy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgpAQCAt ODgsMTIgKzg4LDE3IEBACiA7OyA8cmRhcjovL3Byb2JsZW0vMTIwMzA1MzA+IEFYOiBTYW5kYm94 IHZpb2xhdGlvbiB3aXRoIGNoYW5naW5nIExhbmd1YWdlIHdoaWxlIFZPIGlzIG9uCiA7OyBhbmQg PHJkYXI6Ly9wcm9ibGVtLzEzMDcxNzQ3PgogKG1vYmlsZS1wcmVmZXJlbmNlcy1yZWFkCi0gICAg ImNvbS5hcHBsZS5TcGVha1NlbGVjdGlvbiIpIDsgTmVlZGVkIGZvciBXZWJTcGVlY2gKKyAgICAi Y29tLmFwcGxlLlNwZWFrU2VsZWN0aW9uIiA7IE5lZWRlZCBmb3IgV2ViU3BlZWNoCisgICAgImNv bS5hcHBsZS5Wb2ljZU92ZXJUb3VjaCIgOyBOZWVkZWQgZm9yIG5vbi1VUyBlbmdsaXNoIGxhbmd1 YWdlIHN5bnRoZXNpcworICAgICJjb20uYXBwbGUudm9pY2VzZXJ2aWNlcyIpIDsgRGl0dG8KIAog KGFsbG93IG1hY2gtbG9va3VwCiAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuYXVkaW8uQXVk aW9Db21wb25lbnRQcmVmcyIpCiAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuYXVkaW8uQXVk aW9Db21wb25lbnRSZWdpc3RyYXIiKQotICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmF1ZGlv LkF1ZGlvUXVldWVTZXJ2ZXIiKSkKKyAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5hdWRpby5B dWRpb1F1ZXVlU2VydmVyIikKKyAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS52b2ljZXNlcnZp Y2VzLmtlZXBhbGl2ZSIpIDsgTmVlZGVkIGZvciBub24tVVMgZW5nbGlzaCBsYW5ndWFnZSBzeW50 aGVzaXMKKyAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS52b2ljZXNlcnZpY2VzLnR0cyIpIDsg RGl0dG8KKykKIAogKGFsbG93IG1hY2gtcmVnaXN0ZXIKICAgICAobG9jYWwtbmFtZSAiY29tLmFw cGxlLmlwaG9uZS5heHNlcnZlciIpKSA7IE5lZWRlZCBmb3IgQXBwbGljYXRpb24gQWNjZXNzaWJp bGl0eQo= 350984 2018-09-27 12:10:54 -0700 2018-09-27 14:28:00 -0700 Patch bug-190019-20180927121054.patch text/plain 1531 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzY1NjIpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA5LTI3ICBCcmVudCBGdWxn aGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIEFsbG93IGFjY2VzcyB0 byBWb2ljZVNlcnZpY2VzIGZlYXR1cmVzIG5lZWRlZCBmb3IgYWNjZXNzaWJpbGl0eQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMDE5CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS80MzYyMTExMT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSZXZpc2UgdGhlIHNhbmRib3ggdG8gYWxsb3cgYWNjZXNzIHRv IHJlbGV2YW50IFdlYlNwZWVjaCBmZWF0dXJlcy4KKworICAgICAgICAqIFJlc291cmNlcy9TYW5k Ym94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYjoKKwogMjAxOC0w OS0yNyAgUnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJl dmlld2VkLCByb2xsaW5nIG91dCByMjM2NTU3LgpJbmRleDogU291cmNlL1dlYktpdC9SZXNvdXJj ZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9j b20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IJKHJldmlzaW9uIDIzNjU2MikKKysrIFNvdXJj ZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5X ZWJDb250ZW50LnNiCSh3b3JraW5nIGNvcHkpCkBAIC04OCw3ICs4OCw5IEBACiA7OyA8cmRhcjov L3Byb2JsZW0vMTIwMzA1MzA+IEFYOiBTYW5kYm94IHZpb2xhdGlvbiB3aXRoIGNoYW5naW5nIExh bmd1YWdlIHdoaWxlIFZPIGlzIG9uCiA7OyBhbmQgPHJkYXI6Ly9wcm9ibGVtLzEzMDcxNzQ3Pgog KG1vYmlsZS1wcmVmZXJlbmNlcy1yZWFkCi0gICAgImNvbS5hcHBsZS5TcGVha1NlbGVjdGlvbiIp IDsgTmVlZGVkIGZvciBXZWJTcGVlY2gKKyAgICAiY29tLmFwcGxlLlNwZWFrU2VsZWN0aW9uIiA7 IE5lZWRlZCBmb3IgV2ViU3BlZWNoCisgICAgImNvbS5hcHBsZS5Wb2ljZU92ZXJUb3VjaCIgOyBO ZWVkZWQgZm9yIG5vbi1VUyBlbmdsaXNoIGxhbmd1YWdlIHN5bnRoZXNpcworICAgICJjb20uYXBw bGUudm9pY2VzZXJ2aWNlcyIpIDsgRGl0dG8KIAogKGFsbG93IG1hY2gtbG9va3VwCiAgICAgKGds b2JhbC1uYW1lICJjb20uYXBwbGUuYXVkaW8uQXVkaW9Db21wb25lbnRQcmVmcyIpCg==