190006 2018-09-26 13:04:14 -0700 uidna_nameToASCII only needs a buffer capacity of 64 2018-09-30 20:17:28 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen cdumez darin webkit-bug-importer oldest_to_newest 1463707 0 achristensen 2018-09-26 13:04:14 -0700 uidna_nameToASCII only needs a buffer capacity of 64 1463710 1 350887 achristensen 2018-09-26 13:06:24 -0700 Created attachment 350887 Patch 1463770 2 achristensen 2018-09-26 14:56:44 -0700 http://trac.webkit.org/r236527 1463771 3 webkit-bug-importer 2018-09-26 14:57:29 -0700 <rdar://problem/44809346> 1464897 4 350887 darin 2018-09-30 20:17:28 -0700 Comment on attachment 350887 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350887&action=review > Source/WebCore/platform/URLParser.cpp:2571 > + const size_t maxDomainLength = 64; Since this constant comes from the Unicode Technical Report and is not an arbitrary choice we made for WebKit, it would be good to mention that in a brief comment. 350887 2018-09-26 13:06:24 -0700 2018-09-26 14:19:25 -0700 Patch bug-190006-20180926130623.patch text/plain 4465 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNjUxOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA5LTI2ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgdWlkbmFfbmFt ZVRvQVNDSUkgb25seSBuZWVkcyBhIGJ1ZmZlciBjYXBhY2l0eSBvZiA2NAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMDA2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBzcGVjaWZpZWQgaW4g aHR0cHM6Ly93d3cudW5pY29kZS5vcmcvcmVwb3J0cy90cjQ2LyNUb0FTQ0lJCisgICAgICAgIFRo aXMgaXMgaG93IENocm9tZSBhbmQgRmlyZWZveCBhbHNvIGJlaGF2ZSB3aXRoIGxvbmcgdW5pY29k ZSBob3N0cy4KKworICAgICAgICAqIHBsYXRmb3JtL1VSTFBhcnNlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpVUkxQYXJzZXI6OmRvbWFpblRvQVNDSUkpOgorCiAyMDE4LTA5LTI2ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFNlbGVjdGlvbiBzaG91bGQgd29y ayBhY3Jvc3Mgc2hhZG93IGJvdW5kYXJ5IHdoZW4gaW5pdGlhdGVkIGJ5IGEgbW91c2UgZHJhZwpJ bmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVVJMUGFyc2VyLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9VUkxQYXJzZXIuY3BwCShyZXZpc2lvbiAyMzY0ODgp CisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9VUkxQYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yNTY4LDExICsyNTY4LDEyIEBAIHRlbXBsYXRlPHR5cGVuYW1lIENoYXJhY3RlclR5cGU+ IHN0ZDo6b3AKICAgICAgICAgcmV0dXJuIGFzY2lpOwogICAgIH0KICAgICAKLSAgICBVQ2hhciBo b3N0bmFtZUJ1ZmZlcltkZWZhdWx0SW5saW5lQnVmZmVyU2l6ZV07CisgICAgY29uc3Qgc2l6ZV90 IG1heERvbWFpbkxlbmd0aCA9IDY0OworICAgIFVDaGFyIGhvc3RuYW1lQnVmZmVyW21heERvbWFp bkxlbmd0aF07CiAgICAgVUVycm9yQ29kZSBlcnJvciA9IFVfWkVST19FUlJPUjsKICAgICBVSURO QUluZm8gcHJvY2Vzc2luZ0RldGFpbHMgPSBVSUROQV9JTkZPX0lOSVRJQUxJWkVSOwotICAgIGlu dDMyX3QgbnVtQ2hhcmFjdGVyc0NvbnZlcnRlZCA9IHVpZG5hX25hbWVUb0FTQ0lJKCZpbnRlcm5h dGlvbmFsRG9tYWluTmFtZVRyYW5zY29kZXIoKSwgU3RyaW5nVmlldyhkb21haW4pLnVwY29udmVy dGVkQ2hhcmFjdGVycygpLCBkb21haW4ubGVuZ3RoKCksIGhvc3RuYW1lQnVmZmVyLCBkZWZhdWx0 SW5saW5lQnVmZmVyU2l6ZSwgJnByb2Nlc3NpbmdEZXRhaWxzLCAmZXJyb3IpOwotICAgIEFTU0VS VChudW1DaGFyYWN0ZXJzQ29udmVydGVkIDw9IHN0YXRpY19jYXN0PGludDMyX3Q+KGRlZmF1bHRJ bmxpbmVCdWZmZXJTaXplKSk7CisgICAgaW50MzJfdCBudW1DaGFyYWN0ZXJzQ29udmVydGVkID0g dWlkbmFfbmFtZVRvQVNDSUkoJmludGVybmF0aW9uYWxEb21haW5OYW1lVHJhbnNjb2RlcigpLCBT dHJpbmdWaWV3KGRvbWFpbikudXBjb252ZXJ0ZWRDaGFyYWN0ZXJzKCksIGRvbWFpbi5sZW5ndGgo KSwgaG9zdG5hbWVCdWZmZXIsIG1heERvbWFpbkxlbmd0aCwgJnByb2Nlc3NpbmdEZXRhaWxzLCAm ZXJyb3IpOworICAgIEFTU0VSVChudW1DaGFyYWN0ZXJzQ29udmVydGVkIDw9IHN0YXRpY19jYXN0 PGludDMyX3Q+KG1heERvbWFpbkxlbmd0aCkpOwogCiAgICAgaWYgKFVfU1VDQ0VTUyhlcnJvcikg JiYgIXByb2Nlc3NpbmdEZXRhaWxzLmVycm9ycykgewogICAgICAgICBmb3IgKGludDMyX3QgaSA9 IDA7IGkgPCBudW1DaGFyYWN0ZXJzQ29udmVydGVkOyArK2kpIHsKQEAgLTI1ODQsOCArMjU4NSw2 IEBAIHRlbXBsYXRlPHR5cGVuYW1lIENoYXJhY3RlclR5cGU+IHN0ZDo6b3AKICAgICAgICAgICAg IHN5bnRheFZpb2xhdGlvbihpdGVyYXRvckZvclN5bnRheFZpb2xhdGlvblBvc2l0aW9uKTsKICAg ICAgICAgcmV0dXJuIGFzY2lpOwogICAgIH0KLQotICAgIC8vIEZJWE1FOiBDaGVjayBmb3IgVV9C VUZGRVJfT1ZFUkZMT1dfRVJST1IgYW5kIHJldHJ5IHdpdGggYW4gYWxsb2NhdGVkIGJ1ZmZlci4K ICAgICByZXR1cm4gc3RkOjpudWxsb3B0OwogfQogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzY0ODgp CisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBA QAorMjAxOC0wOS0yNiAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3Jn PgorCisgICAgICAgIHVpZG5hX25hbWVUb0FTQ0lJIG9ubHkgbmVlZHMgYSBidWZmZXIgY2FwYWNp dHkgb2YgNjQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5MDAwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogZmFzdC9kb20vRE9NVVJML3BhcnNpbmcuaHRtbDoKKwogMjAxOC0wOS0yNSAgQ2hyaXMgRHVt ZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0 IHIyMzY0MjAgYW5kIHIyMzY0NTguCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9ET01VUkwv cGFyc2luZy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20v RE9NVVJML3BhcnNpbmctZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAyMzY0ODgpCisrKyBMYXlvdXRU ZXN0cy9mYXN0L2RvbS9ET01VUkwvcGFyc2luZy1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkK QEAgLTE0LDYgKzE0LDcgQEAgUEFTUyBicmVha0Rvd25VUkwoJ2RhdGE6dGV4dC9odG1sLDxiPmZv bwogUEFTUyBicmVha0Rvd25VUkwoJ2h0dHA6Ly9hOmJAYzoxL2UvZj9nJWgnKSBpcyAncHJvdG9j b2w9aHR0cDosIHVzZXJuYW1lPWEsIHBhc3N3b3JkPWIsIGhvc3RuYW1lPWMsIGhvc3Q9YzoxLCBw b3J0PTEsIHBhdGhuYW1lPS9lL2YsIHNlYXJjaD0/ZyVoLCBvcmlnaW49aHR0cDovL2M6MScKIFBB U1MgYnJlYWtEb3duVVJMKCdodHRwOi8vZXglNjFtcGxlLmNvbS8nKSBpcyAncHJvdG9jb2w9aHR0 cDosIGhvc3Q9ZXhhbXBsZS5jb20sIHBhdGhuYW1lPS8sIG9yaWdpbj1odHRwOi8vZXhhbXBsZS5j b20sIHRvU3RyaW5nPWh0dHA6Ly9leGFtcGxlLmNvbS8nCiBQQVNTIGJyZWFrRG93blVSTCgnaHR0 cDovL2V4JTJmbXBsZS5jb20vJykgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogVHlwZSBlcnJv ci4KK1BBU1MgaSBpcyA1NAogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNU IENPTVBMRVRFCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9ET01VUkwvcGFyc2luZy5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL0RPTVVSTC9wYXJzaW5nLmh0bWwJ KHJldmlzaW9uIDIzNjQ4OCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL0RPTVVSTC9wYXJzaW5n Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTU3LDQgKzU3LDE0IEBAIHNob3VsZEJlKCJicmVha0Rv d25VUkwoJ2h0dHA6Ly9hOmJAYzoxL2UKIHNob3VsZEJlKCJicmVha0Rvd25VUkwoJ2h0dHA6Ly9l eCU2MW1wbGUuY29tLycpIiwgIidwcm90b2NvbD1odHRwOiwgaG9zdD1leGFtcGxlLmNvbSwgcGF0 aG5hbWU9Lywgb3JpZ2luPWh0dHA6Ly9leGFtcGxlLmNvbSwgdG9TdHJpbmc9aHR0cDovL2V4YW1w bGUuY29tLyciKTsKIHNob3VsZFRocm93KCJicmVha0Rvd25VUkwoJ2h0dHA6Ly9leCUyZm1wbGUu Y29tLycpIik7CiAKK3ZhciBsb25nVW5pY29kZURvbWFpbiA9ICJcdTEyMzQiOwordmFyIGkgPSAw OwordHJ5IHsKKyAgICBmb3IgKGkgPSAwOyBpIDwgMTAwOyArK2kpIHsKKyAgICAgICAgbG9uZ1Vu aWNvZGVEb21haW4gKz0gImEiCisgICAgICAgIG5ldyBVUkwoImh0dHA6Ly8iICsgbG9uZ1VuaWNv ZGVEb21haW4gKyAiLyIpOworICAgIH0KK30gY2F0Y2ggKGUpIHsgfQorc2hvdWxkQmUoImkiLCAi NTQiKTsKKwogPC9zY3JpcHQ+Cg==