189993 2018-09-26 07:35:24 -0700 REGRESSION(r236365): [GTK] Many form-related tests are failing 2018-11-09 08:15:13 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya webkit-unassigned achristensen berto bugs-noreply cdumez cgarcia ews-watchlist gustavo mcatanzaro Ms2ger oldest_to_newest 1463581 0 aboya 2018-09-26 07:35:24 -0700 The following tests are failing on GTK since r236365-236372: http/tests/fileapi/xhr-send-form-data-filename-escaping.html http/tests/fileapi/xhr-send-form-data-mimetype-normalization.html http/tests/local/formdata/send-form-data-constructed-from-form-using-open-panel.html http/tests/misc/form-blob-challenge.html 1463587 1 Ms2ger 2018-09-26 07:45:03 -0700 Bug 189777 / r236365 looks highly suspicious. 1463595 2 aboya 2018-09-26 08:38:18 -0700 I git bisect'ed the failures to r236365. https://bugs.webkit.org/show_bug.cgi?id=189777 1476868 3 354334 cgarcia 2018-11-09 06:24:29 -0800 Created attachment 354334 Patch 1476870 4 cgarcia 2018-11-09 06:24:59 -0800 *** Bug 191361 has been marked as a duplicate of this bug. *** 1476884 5 354334 mcatanzaro 2018-11-09 07:04:25 -0800 Comment on attachment 354334 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354334&action=review > Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:77 > - return switchOn(element.data, > + switchOn(element.data, It's a shame the compiler didn't warn about this, actually. I guess because switchOn returns void, it figures the return type of the function matches... but still, nobody would write this intentionally. :( 1476909 6 cgarcia 2018-11-09 08:15:13 -0800 Committed r238030: <https://trac.webkit.org/changeset/238030> 354334 2018-11-09 06:24:29 -0800 2018-11-09 07:03:03 -0800 Patch wk-form-upload.diff text/plain 3354 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyMGFmNWViYWFjZS4uODZiNzVjYzU1YmEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAxOC0xMS0wOSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisK KyAgICAgICAgUkVHUkVTU0lPTihyMjM2MzY1KTogW0dUS10gTWFueSBmb3JtLXJlbGF0ZWQgdGVz dHMgYXJlIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE4OTk5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJlbW92ZSBleHBlY3RhdGlvbnMgZm9yIHRlc3RzIHRoYXQgYXJlIHBhc3Npbmcgbm93 LgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTgtMTEt MDggIE1lZ2FuIEdhcmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBB ZG9wdCBSZXZlYWwgRnJhbWV3b3JrIHRvIHJlcGxhY2UgTG9va3VwCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRm b3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDQxNDQ3MTM2YmI4Li4yNjZhNGQ4YTFiNiAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKKysr IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTM1MzEsMTEg KzM1MzEsNiBAQCB3ZWJraXQub3JnL2IvMTg5NzM5IHN2Zy9ncmFkaWVudHMvc3ByZWFkTWV0aG9k Q2xvc2UyLnN2ZyBbIEltYWdlT25seUZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzE4OTczOSBzdmcv Z3JhZGllbnRzL3NwcmVhZE1ldGhvZERpYWdvbmFsMy5zdmcgWyBJbWFnZU9ubHlGYWlsdXJlIF0K IHdlYmtpdC5vcmcvYi8xODk3Mzkgc3ZnL2dyYWRpZW50cy9zcHJlYWRNZXRob2REaWFnb25hbDQu c3ZnIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiAKLXdlYmtpdC5vcmcvYi8xODk5OTMgaHR0cC90ZXN0 cy9maWxlYXBpL3hoci1zZW5kLWZvcm0tZGF0YS1maWxlbmFtZS1lc2NhcGluZy5odG1sIFsgRmFp bHVyZSBdCi13ZWJraXQub3JnL2IvMTg5OTkzIGh0dHAvdGVzdHMvZmlsZWFwaS94aHItc2VuZC1m b3JtLWRhdGEtbWltZXR5cGUtbm9ybWFsaXphdGlvbi5odG1sIFsgRmFpbHVyZSBdCi13ZWJraXQu b3JnL2IvMTg5OTkzIGh0dHAvdGVzdHMvbG9jYWwvZm9ybWRhdGEvc2VuZC1mb3JtLWRhdGEtY29u c3RydWN0ZWQtZnJvbS1mb3JtLXVzaW5nLW9wZW4tcGFuZWwuaHRtbCBbIEZhaWx1cmUgXQotd2Vi a2l0Lm9yZy9iLzE4OTk5MyBodHRwL3Rlc3RzL21pc2MvZm9ybS1ibG9iLWNoYWxsZW5nZS5odG1s IFsgRmFpbHVyZSBdCi0KIHdlYmtpdC5vcmcvYi8xODk5OTQgZmFzdC9maWxlcy94aHItcmVzcG9u c2UtYmxvYi5odG1sIFsgRmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8xODk5OTUgaW1wb3J0ZWQv dzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9tZWRpYWNhcHR1cmUtc3RyZWFtcy9NZWRpYVN0cmVhbS1N ZWRpYUVsZW1lbnQtc3JjT2JqZWN0Lmh0dHBzLmh0bWwgWyBGYWlsdXJlIF0KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCAxNTA2Y2MzZWQxMi4uYmRhMmI4NTgxNmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor MjAxOC0xMS0wOSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisK KyAgICAgICAgUkVHUkVTU0lPTihyMjM2MzY1KTogW0dUS10gTWFueSBmb3JtLXJlbGF0ZWQgdGVz dHMgYXJlIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE4OTk5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE9ubHkgdGhlIGZpcnN0IGZvcm0gZGF0YSBlbGVtZW50IGlzIGFkZGVkIHRvIHRoZSBt ZXNzYWdlIGJvZHkgZHVlIHRvIGEgcmV0dXJuIGFkZGVkIGJ5IG1pc3Rha2UgaW4gcjIzNjM2NS4K KworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlcXVlc3RTb3VwLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdDo6dXBkYXRlU291cE1lc3NhZ2VC b2R5IGNvbnN0KTogUmVtb3ZlIHJldHVybi4KKwogMjAxOC0xMS0wOCAgU2FpZCBBYm91LUhhbGxh d2EgIDxzYWJvdWhhbGxhd2FAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhbiBTUEkgdG8gYWxs b3cgV2ViVmlldyBjbGllbnRzIHRvIGFkZCBhZGRpdGlvbmFsIHN1cHBvcnRlZCBpbWFnZSBmb3Jt YXRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVz b3VyY2VSZXF1ZXN0U291cC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3Nv dXAvUmVzb3VyY2VSZXF1ZXN0U291cC5jcHAKaW5kZXggNThjZmE3NzYxNDQuLjA5MGRjN2ZkOGU3 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3Vy Y2VSZXF1ZXN0U291cC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9z b3VwL1Jlc291cmNlUmVxdWVzdFNvdXAuY3BwCkBAIC03NCw3ICs3NCw3IEBAIHZvaWQgUmVzb3Vy Y2VSZXF1ZXN0Ojp1cGRhdGVTb3VwTWVzc2FnZUJvZHkoU291cE1lc3NhZ2UqIHNvdXBNZXNzYWdl KSBjb25zdAogICAgIHNvdXBfbWVzc2FnZV9ib2R5X3NldF9hY2N1bXVsYXRlKHNvdXBNZXNzYWdl LT5yZXF1ZXN0X2JvZHksIEZBTFNFKTsKICAgICB1aW50NjRfdCBib2R5U2l6ZSA9IDA7CiAgICAg Zm9yIChjb25zdCBhdXRvJiBlbGVtZW50IDogZm9ybURhdGEtPmVsZW1lbnRzKCkpIHsKLSAgICAg ICAgcmV0dXJuIHN3aXRjaE9uKGVsZW1lbnQuZGF0YSwKKyAgICAgICAgc3dpdGNoT24oZWxlbWVu dC5kYXRhLAogICAgICAgICAgICAgWyZdIChjb25zdCBWZWN0b3I8Y2hhcj4mIGJ5dGVzKSB7CiAg ICAgICAgICAgICAgICAgYm9keVNpemUgKz0gYnl0ZXMuc2l6ZSgpOwogICAgICAgICAgICAgICAg IHNvdXBfbWVzc2FnZV9ib2R5X2FwcGVuZChzb3VwTWVzc2FnZS0+cmVxdWVzdF9ib2R5LCBTT1VQ X01FTU9SWV9URU1QT1JBUlksIGJ5dGVzLmRhdGEoKSwgYnl0ZXMuc2l6ZSgpKTsK