189992 2018-09-26 06:55:42 -0700 [iOS] Wrong key event may be sent to UIKit 2018-10-14 22:02:16 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build iPhone / iPad iOS 11 RESOLVED FIXED InRadar P2 Normal --- 190571 1 dbates dbates enrica eric.carlson joepeck megan_gardner mitz simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1463574 0 dbates 2018-09-26 06:55:42 -0700 Currently the UIProcess retains the UIEvent associated with a keyboard event so as to defer notifying the UIKit keyboard code (via -_handleKeyUIEvent) about a received keyboard event until after the WebProcess has processed the raw key event. The UIProcess may invoke -_handleKeyUIEvent with the wrong UIEvent if new hardware keyboard events come in before the UIProcess has received notification that that the WebProcess has processed the last sent raw key event. Additional remarks: UIKit uses a singleton for all hardware-keyboard events. Currently WKWebView.uiEvent retains the UIEvent assigned to it. If this UIEvent is for a hardware keyboard event then it is not sufficient to retain (since we are retaining a singleton) and its value will be clobbered as new hardware keyboard events are received. 1463578 1 350860 dbates 2018-09-26 07:18:04 -0700 Created attachment 350860 Patch I found this issue by code inspection. I am unclear how to test this change given that it effects UIProcess/UIKit behavior. Does anyone have any ideas how to test this? 1463663 2 350860 dbates 2018-09-26 11:45:56 -0700 Comment on attachment 350860 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350860&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3755 > + webEvent.uiEvent = event._hidEvent ? [(UIPhysicalKeyboardEvent *)event _cloneEvent] : event; Oops! This leaks the cloned event. Will update this line to call -autorelease before landing. 1463800 3 350918 dbates 2018-09-26 15:40:37 -0700 Created attachment 350918 Patch 1463801 4 350918 simon.fraser 2018-09-26 15:42:19 -0700 Comment on attachment 350918 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350918&action=review > Source/WebKit/ChangeLog:3 > + [iOS] Wrong key event may be told to UIKit "told to UIKit" sounds weird. Maybe "sent"? > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3755 > + webEvent.uiEvent = event._hidEvent ? [[(UIPhysicalKeyboardEvent *)event _cloneEvent] autorelease] : event; Does _cloneEvent not return an autoreleased object? 1463816 5 dbates 2018-09-26 16:32:45 -0700 (In reply to Simon Fraser (smfr) from comment #4) > Comment on attachment 350918 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=350918&action=review > > > Source/WebKit/ChangeLog:3 > > + [iOS] Wrong key event may be told to UIKit > > "told to UIKit" sounds weird. Maybe "sent"? > Will update ChangeLog to reflect updated bug title before landing. > > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3755 > > + webEvent.uiEvent = event._hidEvent ? [[(UIPhysicalKeyboardEvent *)event _cloneEvent] autorelease] : event; > > Does _cloneEvent not return an autoreleased object? Correct. It does not return an autoreleased object. 1464677 6 350918 joepeck 2018-09-28 19:00:58 -0700 Comment on attachment 350918 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350918&action=review >>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3755 >>> + webEvent.uiEvent = event._hidEvent ? [[(UIPhysicalKeyboardEvent *)event _cloneEvent] autorelease] : event; >> >> Does _cloneEvent not return an autoreleased object? > > Correct. It does not return an autoreleased object. If it does not return an autoreleased object it should probably be annotated with NS_RETURNS_RETAINED. Otherwise if we switched to ARC, our tools would look at this and think it is overreleasing. 1464846 7 350918 eric.carlson 2018-09-30 01:14:28 -0700 Comment on attachment 350918 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350918&action=review > Source/WebKit/ChangeLog:8 > + Retain a clone of a received UIEvent if its for a hardware key event so as to ensure that we Grammar nit: "it's" or "it is" 1465066 8 351257 dbates 2018-10-01 10:18:44 -0700 Created attachment 351257 Patch Updated patch that addresses review feedback. 1465091 9 351264 dbates 2018-10-01 10:40:36 -0700 Created attachment 351264 To Land Patch for landing. I extracted the check for whether the event is a hardware keyboard from two places in -handleKeyEvent: into one conditional at the top of the function. 1465094 10 dbates 2018-10-01 10:41:39 -0700 Committed r236669: <https://trac.webkit.org/changeset/236669> 1465095 11 webkit-bug-importer 2018-10-01 10:42:25 -0700 <rdar://problem/44913099> 350860 2018-09-26 07:18:04 -0700 2018-09-26 15:40:35 -0700 Patch bug-189992-20180926071804.patch text/plain 3136 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MzAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ5ZjJmODYyNmRhNjliMzM5 MzQ0NTJmYzZjMjQ5MDBkZDMzZTNmNzUuLmM2MGE3MTc3ODg3MmRjZGYyNmEwZmNjNmRjYmQzNjA5 NTZjM2QwYjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTgtMDktMjYgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFdyb25nIGtleSBldmVu dCBtYXkgYmUgdG9sZCB0byBVSUtpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTg5OTkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUmV0YWluIGEgY2xvbmUgb2YgYSByZWNlaXZlZCBVSUV2ZW50IGlmIGl0 cyBmb3IgYSBoYXJkd2FyZSBrZXkgZXZlbnQgc28gYXMgdG8gZW5zdXJlIHRoYXQgd2UKKyAgICAg ICAgbm90aWZ5IHRoZSBVSUtpdCBrZXlib2FyZCBjb2RlIG9mIHRoZSBjb3JyZWN0IGtleWJvYXJk IGV2ZW50LgorCisgICAgICAgIEN1cnJlbnRseSB0aGUgVUlQcm9jZXNzIHJldGFpbnMgdGhlIFVJ RXZlbnQgYXNzb2NpYXRlZCB3aXRoIGEga2V5Ym9hcmQgZXZlbnQgc28gYXMgdG8gZGVmZXIKKyAg ICAgICAgbm90aWZ5aW5nIHRoZSBVSUtpdCBrZXlib2FyZCBjb2RlICh2aWEgLV9oYW5kbGVLZXlV SUV2ZW50KSBhYm91dCBhIHJlY2VpdmVkIGtleWJvYXJkIGV2ZW50IHVudGlsCisgICAgICAgIGFm dGVyIHRoZSBXZWJQcm9jZXNzIGhhcyBwcm9jZXNzZWQgdGhlIHJhdyBrZXkgZXZlbnQuIElmIHRo aXMgVUlFdmVudCBpcyBmb3IgYSBoYXJkd2FyZSBrZXlib2FyZAorICAgICAgICBldmVudCB0aGVu IGl0IGlzIG5vdCBzdWZmaWNpZW50IHRvIHJldGFpbiBpdCB0byBwcmVzZXJ2ZSBpdHMgdmFsdWUg YmVjYXVzZSBVSUtpdCB1c2VzIGEgc2luZ2xldG9uCisgICAgICAgIFVJRXZlbnQgZm9yIGFsbCBo YXJkd2FyZSBrZXlib2FyZCBldmVudHMgOz0+IGl0cyB2YWx1ZSB3aWxsIGJlIGNsb2JiZXJlZCBh cyBlYWNoIGhhcmR3YXJlIGtleWJvYXJkCisgICAgICAgIGV2ZW50IGlzIHJlY2VpdmVkLiBJbnN0 ZWFkIHdlIG5lZWQgdG8gZXhwbGljaXRseSBjbG9uZSBhIFVJRXZlbnQgZm9yIGEgaGFyZHdhcmUg a2V5IGV2ZW50IGJlZm9yZQorICAgICAgICByZXRhaW5pbmcgaXQuCisKKyAgICAgICAgKiBQbGF0 Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmg6IEZvcndhcmQgZGVjbGFyZSBTUEkuCisgICAgICAgICog VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dL Q29udGVudFZpZXcgaGFuZGxlS2V5RXZlbnQ6XSk6IENsb25lIHRoZSBVSUV2ZW50IGlmIGl0cyBm b3IgYSBoYXJkd2FyZSBrZXkgZXZlbnQuCisKIDIwMTgtMDktMjAgIERhbmllbCBCYXRlcyAgPGRh YmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIEtleSBjb2RlIGlzIDAgZm9yIG1hbnkg aGFyZHdhcmUga2V5Ym9hcmQga2V5cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9y bS9zcGkvaW9zL1VJS2l0U1BJLmggYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlL aXRTUEkuaAppbmRleCA0NDY5OGQyNWI5OTRhMDZjMzY2MGNmM2U0ZjI5ZGYzMTBjN2EyN2I0Li5h N2NkMTczOGQ4OTFlNDViOWU1ZmEzY2Q0NjE0NTE1ZGQ1ODY1MjYyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaAorKysgYi9Tb3VyY2UvV2ViS2l0 L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaApAQCAtMTAwMiw2ICsxMDAyLDcgQEAgdHlwZWRl ZiBOU0ludGVnZXIgVUlDb21wb3NpdGluZ01vZGU7CiBAZW5kCiAKIEBpbnRlcmZhY2UgVUlQaHlz aWNhbEtleWJvYXJkRXZlbnQgKCkKKy0gKFVJUGh5c2ljYWxLZXlib2FyZEV2ZW50ICopX2Nsb25l RXZlbnQ7CiBAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHkpIENGSW5kZXggX2tleUNvZGU7 CiBAZW5kCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRl bnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250 ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IDI3ZDk3OTI1OTA4MzZiOTRhYTM3ODFhYjI0YjU0 MWRkZWI5NzZjMGEuLmFlM2I5NDIyYmFhOTQyYjQ5NzBkOWVlY2NhNDcwYWRkNDExMzk0OGYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJh Y3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJ bnRlcmFjdGlvbi5tbQpAQCAtMzc1MSw3ICszNzUxLDggQEAgLSAodm9pZCloYW5kbGVLZXlFdmVu dDooOjpVSUV2ZW50ICopZXZlbnQKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBrZXlDb2RlOmV2ZW50Ll9oaWRFdmVudCA/ICgoVUlQ aHlzaWNhbEtleWJvYXJkRXZlbnQgKilldmVudCkuX2tleUNvZGUgOiAwCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpc1RhYktleTpb ZXZlbnQuX21vZGlmaWVkSW5wdXQgaXNFcXVhbFRvU3RyaW5nOkAiXHQiXQogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjaGFyYWN0ZXJTZXQ6 V2ViRXZlbnRDaGFyYWN0ZXJTZXRVbmljb2RlXSBhdXRvcmVsZWFzZV07Ci0gICAgd2ViRXZlbnQu dWlFdmVudCA9IGV2ZW50OworICAgIC8vIFVJS2l0IHVzZXMgYSBzaW5nbGV0b24gZm9yIGhhcmR3 YXJlIGtleWJvYXJkIGV2ZW50cy4KKyAgICB3ZWJFdmVudC51aUV2ZW50ID0gZXZlbnQuX2hpZEV2 ZW50ID8gWyhVSVBoeXNpY2FsS2V5Ym9hcmRFdmVudCAqKWV2ZW50IF9jbG9uZUV2ZW50XSA6IGV2 ZW50OwogICAgIAogICAgIFtzZWxmIGhhbmRsZUtleVdlYkV2ZW50OndlYkV2ZW50XTsgICAgCiB9 Cg== 350918 2018-09-26 15:40:37 -0700 2018-10-01 10:18:43 -0700 Patch bug-189992-20180926154036.patch text/plain 3150 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MzAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ5ZjJmODYyNmRhNjliMzM5 MzQ0NTJmYzZjMjQ5MDBkZDMzZTNmNzUuLmM2MGE3MTc3ODg3MmRjZGYyNmEwZmNjNmRjYmQzNjA5 NTZjM2QwYjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTgtMDktMjYgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFdyb25nIGtleSBldmVu dCBtYXkgYmUgdG9sZCB0byBVSUtpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTg5OTkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUmV0YWluIGEgY2xvbmUgb2YgYSByZWNlaXZlZCBVSUV2ZW50IGlmIGl0 cyBmb3IgYSBoYXJkd2FyZSBrZXkgZXZlbnQgc28gYXMgdG8gZW5zdXJlIHRoYXQgd2UKKyAgICAg ICAgbm90aWZ5IHRoZSBVSUtpdCBrZXlib2FyZCBjb2RlIG9mIHRoZSBjb3JyZWN0IGtleWJvYXJk IGV2ZW50LgorCisgICAgICAgIEN1cnJlbnRseSB0aGUgVUlQcm9jZXNzIHJldGFpbnMgdGhlIFVJ RXZlbnQgYXNzb2NpYXRlZCB3aXRoIGEga2V5Ym9hcmQgZXZlbnQgc28gYXMgdG8gZGVmZXIKKyAg ICAgICAgbm90aWZ5aW5nIHRoZSBVSUtpdCBrZXlib2FyZCBjb2RlICh2aWEgLV9oYW5kbGVLZXlV SUV2ZW50KSBhYm91dCBhIHJlY2VpdmVkIGtleWJvYXJkIGV2ZW50IHVudGlsCisgICAgICAgIGFm dGVyIHRoZSBXZWJQcm9jZXNzIGhhcyBwcm9jZXNzZWQgdGhlIHJhdyBrZXkgZXZlbnQuIElmIHRo aXMgVUlFdmVudCBpcyBmb3IgYSBoYXJkd2FyZSBrZXlib2FyZAorICAgICAgICBldmVudCB0aGVu IGl0IGlzIG5vdCBzdWZmaWNpZW50IHRvIHJldGFpbiBpdCB0byBwcmVzZXJ2ZSBpdHMgdmFsdWUg YmVjYXVzZSBVSUtpdCB1c2VzIGEgc2luZ2xldG9uCisgICAgICAgIFVJRXZlbnQgZm9yIGFsbCBo YXJkd2FyZSBrZXlib2FyZCBldmVudHMgOz0+IGl0cyB2YWx1ZSB3aWxsIGJlIGNsb2JiZXJlZCBh cyBlYWNoIGhhcmR3YXJlIGtleWJvYXJkCisgICAgICAgIGV2ZW50IGlzIHJlY2VpdmVkLiBJbnN0 ZWFkIHdlIG5lZWQgdG8gZXhwbGljaXRseSBjbG9uZSBhIFVJRXZlbnQgZm9yIGEgaGFyZHdhcmUg a2V5IGV2ZW50IGJlZm9yZQorICAgICAgICByZXRhaW5pbmcgaXQuCisKKyAgICAgICAgKiBQbGF0 Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmg6IEZvcndhcmQgZGVjbGFyZSBTUEkuCisgICAgICAgICog VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dL Q29udGVudFZpZXcgaGFuZGxlS2V5RXZlbnQ6XSk6IENsb25lIHRoZSBVSUV2ZW50IGlmIGl0cyBm b3IgYSBoYXJkd2FyZSBrZXkgZXZlbnQuCisKIDIwMTgtMDktMjAgIERhbmllbCBCYXRlcyAgPGRh YmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIEtleSBjb2RlIGlzIDAgZm9yIG1hbnkg aGFyZHdhcmUga2V5Ym9hcmQga2V5cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9y bS9zcGkvaW9zL1VJS2l0U1BJLmggYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlL aXRTUEkuaAppbmRleCA0NDY5OGQyNWI5OTRhMDZjMzY2MGNmM2U0ZjI5ZGYzMTBjN2EyN2I0Li5h N2NkMTczOGQ4OTFlNDViOWU1ZmEzY2Q0NjE0NTE1ZGQ1ODY1MjYyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaAorKysgYi9Tb3VyY2UvV2ViS2l0 L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaApAQCAtMTAwMiw2ICsxMDAyLDcgQEAgdHlwZWRl ZiBOU0ludGVnZXIgVUlDb21wb3NpdGluZ01vZGU7CiBAZW5kCiAKIEBpbnRlcmZhY2UgVUlQaHlz aWNhbEtleWJvYXJkRXZlbnQgKCkKKy0gKFVJUGh5c2ljYWxLZXlib2FyZEV2ZW50ICopX2Nsb25l RXZlbnQ7CiBAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHkpIENGSW5kZXggX2tleUNvZGU7 CiBAZW5kCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRl bnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250 ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IDI3ZDk3OTI1OTA4MzZiOTRhYTM3ODFhYjI0YjU0 MWRkZWI5NzZjMGEuLjI2MmNlZjk0NGRmZTQxYTliOGZiN2QxNDgxYzYzNWIzNjBlNmZiYjkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJh Y3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJ bnRlcmFjdGlvbi5tbQpAQCAtMzc1MSw3ICszNzUxLDggQEAgLSAodm9pZCloYW5kbGVLZXlFdmVu dDooOjpVSUV2ZW50ICopZXZlbnQKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBrZXlDb2RlOmV2ZW50Ll9oaWRFdmVudCA/ICgoVUlQ aHlzaWNhbEtleWJvYXJkRXZlbnQgKilldmVudCkuX2tleUNvZGUgOiAwCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpc1RhYktleTpb ZXZlbnQuX21vZGlmaWVkSW5wdXQgaXNFcXVhbFRvU3RyaW5nOkAiXHQiXQogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjaGFyYWN0ZXJTZXQ6 V2ViRXZlbnRDaGFyYWN0ZXJTZXRVbmljb2RlXSBhdXRvcmVsZWFzZV07Ci0gICAgd2ViRXZlbnQu dWlFdmVudCA9IGV2ZW50OworICAgIC8vIFVJS2l0IHVzZXMgYSBzaW5nbGV0b24gZm9yIGhhcmR3 YXJlIGtleWJvYXJkIGV2ZW50cy4KKyAgICB3ZWJFdmVudC51aUV2ZW50ID0gZXZlbnQuX2hpZEV2 ZW50ID8gW1soVUlQaHlzaWNhbEtleWJvYXJkRXZlbnQgKilldmVudCBfY2xvbmVFdmVudF0gYXV0 b3JlbGVhc2VdIDogZXZlbnQ7CiAgICAgCiAgICAgW3NlbGYgaGFuZGxlS2V5V2ViRXZlbnQ6d2Vi RXZlbnRdOyAgICAKIH0K 351257 2018-10-01 10:18:44 -0700 2018-10-01 10:40:34 -0700 Patch bug-189992-20181001101844.patch text/plain 3182 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM5N2EyOTZhZTM1Njg0Nzc0 ZTlmNTUyMmRlMDI5NDA4MTc0OWIyNjEuLjdjOWIzZTQzMTRlZGU1Y2U3M2NlZTkwMGU1YzhlMWU5 MjM4ZDZmY2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTgtMTAtMDEgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFdyb25nIGtleSBldmVu dCBtYXkgYmUgc2VudCB0byBVSUtpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTg5OTkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUmV0YWluIGEgY2xvbmUgb2YgYSByZWNlaXZlZCBVSUV2ZW50IGlmIGl0 IGlzIGZvciBhIGhhcmR3YXJlIGtleSBldmVudCBzbyBhcyB0byBlbnN1cmUgdGhhdCB3ZQorICAg ICAgICBub3RpZnkgdGhlIFVJS2l0IGtleWJvYXJkIGNvZGUgb2YgdGhlIGNvcnJlY3Qga2V5Ym9h cmQgZXZlbnQuCisKKyAgICAgICAgQ3VycmVudGx5IHRoZSBVSVByb2Nlc3MgcmV0YWlucyB0aGUg VUlFdmVudCBhc3NvY2lhdGVkIHdpdGggYSBrZXlib2FyZCBldmVudCBzbyBhcyB0byBkZWZlcgor ICAgICAgICBub3RpZnlpbmcgdGhlIFVJS2l0IGtleWJvYXJkIGNvZGUgKHZpYSAtX2hhbmRsZUtl eVVJRXZlbnQpIGFib3V0IGEgcmVjZWl2ZWQga2V5Ym9hcmQgZXZlbnQgdW50aWwKKyAgICAgICAg YWZ0ZXIgdGhlIFdlYlByb2Nlc3MgaGFzIHByb2Nlc3NlZCB0aGUgcmF3IGtleSBldmVudC4gSWYg dGhpcyBVSUV2ZW50IGlzIGZvciBhIGhhcmR3YXJlIGtleWJvYXJkCisgICAgICAgIGV2ZW50IHRo ZW4gaXQgaXMgbm90IHN1ZmZpY2llbnQgdG8gcmV0YWluIGl0IHRvIHByZXNlcnZlIGl0cyB2YWx1 ZSBiZWNhdXNlIFVJS2l0IHVzZXMgYSBzaW5nbGV0b24KKyAgICAgICAgVUlFdmVudCBmb3IgYWxs IGhhcmR3YXJlIGtleWJvYXJkIGV2ZW50cyA7PT4gaXRzIHZhbHVlIHdpbGwgYmUgY2xvYmJlcmVk IGFzIGVhY2ggaGFyZHdhcmUga2V5Ym9hcmQKKyAgICAgICAgZXZlbnQgaXMgcmVjZWl2ZWQuIElu c3RlYWQgd2UgbmVlZCB0byBleHBsaWNpdGx5IGNsb25lIGEgVUlFdmVudCBmb3IgYSBoYXJkd2Fy ZSBrZXkgZXZlbnQgYmVmb3JlCisgICAgICAgIHJldGFpbmluZyBpdC4KKworICAgICAgICAqIFBs YXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaDogRm9yd2FyZCBkZWNsYXJlIFNQSS4KKyAgICAgICAg KiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1b V0tDb250ZW50VmlldyBoYW5kbGVLZXlFdmVudDpdKTogQ2xvbmUgdGhlIFVJRXZlbnQgaWYgaXQg aXMgZm9yIGEgaGFyZHdhcmUga2V5IGV2ZW50LgorCiAyMDE4LTA5LTI1ICBEYW5pZWwgQmF0ZXMg IDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBTcGVjaWFsIGtleXMgYXJlIG1p c2lkZW50aWZpZWQgaW4gRE9NIGtleWJvYXJkIGV2ZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmggYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3Jt L3NwaS9pb3MvVUlLaXRTUEkuaAppbmRleCBhYWVjYTBlZmNiNTM4NDM5OGY4MTljY2ZlYWQ1ODY3 YjE3MjM3NDEwLi4wMGNhYTE4YmNhOGNkYjExNWUxYzIwOGRjZDU0NDcxMjU4Y2E3MGNkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaAorKysgYi9T b3VyY2UvV2ViS2l0L1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaApAQCAtMTAwMyw2ICsxMDAz LDcgQEAgdHlwZWRlZiBOU0ludGVnZXIgVUlDb21wb3NpdGluZ01vZGU7CiBAZW5kCiAKIEBpbnRl cmZhY2UgVUlQaHlzaWNhbEtleWJvYXJkRXZlbnQgKCkKKy0gKFVJUGh5c2ljYWxLZXlib2FyZEV2 ZW50ICopX2Nsb25lRXZlbnQgTlNfUkVUVVJOU19SRVRBSU5FRDsKIEBwcm9wZXJ0eSAobm9uYXRv bWljLCByZWFkb25seSkgQ0ZJbmRleCBfa2V5Q29kZTsKIEBlbmQKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5k ZXggN2U2NGE1ZWUyY2YxYmI4ZGJkNzk5YmM4NDZmNzNhNDEzNWEwYTc2ZC4uMWIyNzczYzhhN2Qy YzNkODZjZjQ5N2I4NjljNDhmOTZiYmE3MmRjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC0zNzU1LDcg KzM3NTUsOCBAQCAtICh2b2lkKWhhbmRsZUtleUV2ZW50Oig6OlVJRXZlbnQgKilldmVudAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGtleUNvZGU6ZXZlbnQuX2hpZEV2ZW50ID8gKChVSVBoeXNpY2FsS2V5Ym9hcmRFdmVudCAqKWV2 ZW50KS5fa2V5Q29kZSA6IDAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGlzVGFiS2V5OltldmVudC5fbW9kaWZpZWRJbnB1dCBpc0Vx dWFsVG9TdHJpbmc6QCJcdCJdCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGNoYXJhY3RlclNldDpXZWJFdmVudENoYXJhY3RlclNldFVuaWNv ZGVdIGF1dG9yZWxlYXNlXTsKLSAgICB3ZWJFdmVudC51aUV2ZW50ID0gZXZlbnQ7CisgICAgLy8g VUlLaXQgdXNlcyBhIHNpbmdsZXRvbiBmb3IgaGFyZHdhcmUga2V5Ym9hcmQgZXZlbnRzLgorICAg IHdlYkV2ZW50LnVpRXZlbnQgPSBldmVudC5faGlkRXZlbnQgPyBbWyhVSVBoeXNpY2FsS2V5Ym9h cmRFdmVudCAqKWV2ZW50IF9jbG9uZUV2ZW50XSBhdXRvcmVsZWFzZV0gOiBldmVudDsKICAgICAK ICAgICBbc2VsZiBoYW5kbGVLZXlXZWJFdmVudDp3ZWJFdmVudF07ICAgIAogfQo= 351264 2018-10-01 10:40:36 -0700 2018-10-01 10:40:36 -0700 To Land bug-189992-20181001104035.patch text/plain 4126 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NjY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGUzODc2MjE4MmQ0NDljOTJh Y2VlN2RiMWQ3NmI3ZmNkNTliMTM1OTguLjcyODBjNmVlNWJjNzkyYjQyYmViNDhjMjM5MmU1M2Nl NjM1ZTk1MzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTgtMTAtMDEgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFdyb25nIGtleSBldmVu dCBtYXkgYmUgc2VudCB0byBVSUtpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTg5OTkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2Vy LgorCisgICAgICAgIFJldGFpbiBhIGNsb25lIG9mIGEgcmVjZWl2ZWQgVUlFdmVudCBpZiBpdCBp cyBmb3IgYSBoYXJkd2FyZSBrZXkgZXZlbnQgc28gYXMgdG8gZW5zdXJlIHRoYXQgd2UKKyAgICAg ICAgbm90aWZ5IHRoZSBVSUtpdCBrZXlib2FyZCBjb2RlIG9mIHRoZSBjb3JyZWN0IGtleWJvYXJk IGV2ZW50LgorCisgICAgICAgIEN1cnJlbnRseSB0aGUgVUlQcm9jZXNzIHJldGFpbnMgdGhlIFVJ RXZlbnQgYXNzb2NpYXRlZCB3aXRoIGEga2V5Ym9hcmQgZXZlbnQgc28gYXMgdG8gZGVmZXIKKyAg ICAgICAgbm90aWZ5aW5nIHRoZSBVSUtpdCBrZXlib2FyZCBjb2RlICh2aWEgLV9oYW5kbGVLZXlV SUV2ZW50KSBhYm91dCBhIHJlY2VpdmVkIGtleWJvYXJkIGV2ZW50IHVudGlsCisgICAgICAgIGFm dGVyIHRoZSBXZWJQcm9jZXNzIGhhcyBwcm9jZXNzZWQgdGhlIHJhdyBrZXkgZXZlbnQuIElmIHRo aXMgVUlFdmVudCBpcyBmb3IgYSBoYXJkd2FyZSBrZXlib2FyZAorICAgICAgICBldmVudCB0aGVu IGl0IGlzIG5vdCBzdWZmaWNpZW50IHRvIHJldGFpbiBpdCB0byBwcmVzZXJ2ZSBpdHMgdmFsdWUg YmVjYXVzZSBVSUtpdCB1c2VzIGEgc2luZ2xldG9uCisgICAgICAgIFVJRXZlbnQgZm9yIGFsbCBo YXJkd2FyZSBrZXlib2FyZCBldmVudHMgOz0+IGl0cyB2YWx1ZSB3aWxsIGJlIGNsb2JiZXJlZCBh cyBlYWNoIGhhcmR3YXJlIGtleWJvYXJkCisgICAgICAgIGV2ZW50IGlzIHJlY2VpdmVkLiBJbnN0 ZWFkIHdlIG5lZWQgdG8gZXhwbGljaXRseSBjbG9uZSBhIFVJRXZlbnQgZm9yIGEgaGFyZHdhcmUg a2V5IGV2ZW50IGJlZm9yZQorICAgICAgICByZXRhaW5pbmcgaXQuCisKKyAgICAgICAgKiBQbGF0 Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmg6IEZvcndhcmQgZGVjbGFyZSBTUEkuCisgICAgICAgICog VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dL Q29udGVudFZpZXcgaGFuZGxlS2V5RXZlbnQ6XSk6IENsb25lIHRoZSBVSUV2ZW50IGlmIGl0IGlz IGZvciBhIGhhcmR3YXJlIGtleSBldmVudC4KKwogMjAxOC0xMC0wMSAgQWxleCBDaHJpc3RlbnNl biAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIERlcHJlY2F0ZSBPYmpDIFNQ SSBpbiBEZXByZWNhdGVkIFhjb2RlIGdyb3VwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1Bs YXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaCBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lv cy9VSUtpdFNQSS5oCmluZGV4IGFhZWNhMGVmY2I1Mzg0Mzk4ZjgxOWNjZmVhZDU4NjdiMTcyMzc0 MTAuLjAwY2FhMThiY2E4Y2RiMTE1ZTFjMjA4ZGNkNTQ0NzEyNThjYTcwY2QgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCisrKyBiL1NvdXJjZS9X ZWJLaXQvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQSS5oCkBAIC0xMDAzLDYgKzEwMDMsNyBAQCB0 eXBlZGVmIE5TSW50ZWdlciBVSUNvbXBvc2l0aW5nTW9kZTsKIEBlbmQKIAogQGludGVyZmFjZSBV SVBoeXNpY2FsS2V5Ym9hcmRFdmVudCAoKQorLSAoVUlQaHlzaWNhbEtleWJvYXJkRXZlbnQgKilf Y2xvbmVFdmVudCBOU19SRVRVUk5TX1JFVEFJTkVEOwogQHByb3BlcnR5IChub25hdG9taWMsIHJl YWRvbmx5KSBDRkluZGV4IF9rZXlDb2RlOwogQGVuZAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQppbmRleCA3ZTY0 YTVlZTJjZjFiYjhkYmQ3OTliYzg0NmY3M2E0MTM1YTBhNzZkLi5hNGI2MGI2NmFjZmQwYTU0YTk3 ZDNhZjM0ZDMzNmU3YmUxYjNhZDk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KQEAgLTM3NDUsNiArMzc0NSwx NSBAQCAtICh2b2lkKWhhbmRsZUtleUV2ZW50Oig6OlVJRXZlbnQgKilldmVudAogICAgIGlmIChl dmVudCA9PSBfdWlFdmVudEJlaW5nUmVzZW50KQogICAgICAgICByZXR1cm47CiAKKyAgICB1aW50 MTZfdCBrZXlDb2RlOworICAgIEJPT0wgaXNIYXJkd2FyZUtleWJvYXJkRXZlbnQgPSAhIWV2ZW50 Ll9oaWRFdmVudDsKKyAgICBpZiAoIWlzSGFyZHdhcmVLZXlib2FyZEV2ZW50KQorICAgICAgICBr ZXlDb2RlID0gMDsKKyAgICBlbHNlIHsKKyAgICAgICAgVUlQaHlzaWNhbEtleWJvYXJkRXZlbnQg KmtleUV2ZW50ID0gKFVJUGh5c2ljYWxLZXlib2FyZEV2ZW50ICopZXZlbnQ7CisgICAgICAgIGtl eUNvZGUgPSBrZXlFdmVudC5fa2V5Q29kZTsKKyAgICAgICAgZXZlbnQgPSBbW2tleUV2ZW50IF9j bG9uZUV2ZW50XSBhdXRvcmVsZWFzZV07IC8vIFVJS2l0IHVzZXMgYSBzaW5nbGV0b24gZm9yIGhh cmR3YXJlIGtleWJvYXJkIGV2ZW50cy4KKyAgICB9CiAgICAgV0tXZWJFdmVudCAqd2ViRXZlbnQg PSBbW1tXS1dlYkV2ZW50IGFsbG9jXSBpbml0V2l0aEtleUV2ZW50VHlwZTooZXZlbnQuX2lzS2V5 RG93bikgPyBXZWJFdmVudEtleURvd24gOiBXZWJFdmVudEtleVVwCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRpbWVTdGFtcDpldmVu dC50aW1lc3RhbXAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBjaGFyYWN0ZXJzOmV2ZW50Ll9tb2RpZmllZElucHV0CkBAIC0zNzUyLDcg KzM3NjEsNyBAQCAtICh2b2lkKWhhbmRsZUtleUV2ZW50Oig6OlVJRXZlbnQgKilldmVudAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBt b2RpZmllcnM6ZXZlbnQuX21vZGlmaWVyRmxhZ3MKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlzUmVwZWF0aW5nOihldmVudC5faW5wdXRG bGFncyAmIGtVSUtleWJvYXJkSW5wdXRSZXBlYXQpCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHdpdGhGbGFnczpldmVudC5faW5wdXRG bGFncwotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGtleUNvZGU6ZXZlbnQuX2hpZEV2ZW50ID8gKChVSVBoeXNpY2FsS2V5Ym9hcmRF dmVudCAqKWV2ZW50KS5fa2V5Q29kZSA6IDAKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBrZXlDb2RlOmtleUNvZGUKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlzVGFi S2V5OltldmVudC5fbW9kaWZpZWRJbnB1dCBpc0VxdWFsVG9TdHJpbmc6QCJcdCJdCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNoYXJhY3Rl clNldDpXZWJFdmVudENoYXJhY3RlclNldFVuaWNvZGVdIGF1dG9yZWxlYXNlXTsKICAgICB3ZWJF dmVudC51aUV2ZW50ID0gZXZlbnQ7Cg==