189989 2018-09-25 22:04:20 -0700 MiniBrowser doesn't respect default enabled-ness of experimental and internal debug features 2018-09-26 12:48:26 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa andersca dino lforschler simon.fraser webkit-bug-importer wenson_hsieh youennf oldest_to_newest 1463516 0 rniwa 2018-09-25 22:04:20 -0700 All experimental and internal debug features are disabled by default in MiniBrowser. We should match the default values of the features instead. 1463517 1 350846 rniwa 2018-09-25 22:06:44 -0700 Created attachment 350846 Fixes the bug 1463576 2 350846 andersca 2018-09-26 07:03:49 -0700 Comment on attachment 350846 Fixes the bug I think you can use objectForKey + boolValue on the returned object to avoid two lookups. 1463690 3 rniwa 2018-09-26 12:43:10 -0700 (In reply to Anders Carlsson from comment #2) > Comment on attachment 350846 [details] > Fixes the bug > > I think you can use objectForKey + boolValue on the returned object to avoid > two lookups. Per IRC conversation, it looks like boolValue on NSString behaves differently from boolForValue on NSUserDefaults. https://developer.apple.com/documentation/foundation/nsstring/1409420-boolvalue?language=objc https://developer.apple.com/documentation/foundation/nsuserdefaults/1416388-boolforkey?language=objc I'm gonna stick with boolForKey for now. 1463693 4 350846 rniwa 2018-09-26 12:47:49 -0700 Comment on attachment 350846 Fixes the bug Clearing flags on attachment: 350846 Committed r236518: <https://trac.webkit.org/changeset/236518> 1463694 5 rniwa 2018-09-26 12:47:52 -0700 All reviewed patches have been landed. Closing bug. 1463695 6 webkit-bug-importer 2018-09-26 12:48:26 -0700 <rdar://problem/44804642> 350846 2018-09-25 22:06:44 -0700 2018-09-26 12:47:49 -0700 Fixes the bug bug-189989-20180925220643.patch text/plain 2328 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzNjQ5NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE4LTA5LTI1ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIE1pbmlCcm93c2VyIGRvZXNuJ3QgcmVzcGVjdCBkZWZhdWx0IGVuYWJsZWQtbmVz cyBvZiBleHBlcmltZW50YWwgYW5kIGludGVybmFsIGRlYnVnIGZlYXR1cmVzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODk5ODkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHRoZSBwcmVmZXJlbmNl IGlzbid0IGZvdW5kIGluIHVzZXIgZGVmYXVsdHMsIHVzZSB0aGUgZGVmYXVsdCB2YWx1ZSBvZiBl YWNoIGZlYXR1cmUncyBlbmFibGVkbmVzcy4KKworICAgICAgICAqIE1pbmlCcm93c2VyL21hYy9B cHBEZWxlZ2F0ZS5tOgorICAgICAgICAoZGVmYXVsdENvbmZpZ3VyYXRpb24pOgorCiAyMDE4LTA5 LTI1ICBKaWV3ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYkF1 dGhOXSBNYWtlIEF1dGhlbnRpY2F0b3JNYW5hZ2VyCkluZGV4OiBUb29scy9NaW5pQnJvd3Nlci9t YWMvQXBwRGVsZWdhdGUubQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9NaW5pQnJvd3Nlci9tYWMvQXBw RGVsZWdhdGUubQkocmV2aXNpb24gMjM2NDk1KQorKysgVG9vbHMvTWluaUJyb3dzZXIvbWFjL0Fw cERlbGVnYXRlLm0JKHdvcmtpbmcgY29weSkKQEAgLTEwOSwxMyArMTA5LDIxIEBAIHN0YXRpYyBX S1dlYlZpZXdDb25maWd1cmF0aW9uICpkZWZhdWx0Q28KICNpZiBXS19BUElfRU5BQkxFRAogICAg ICAgICBOU0FycmF5PF9XS0V4cGVyaW1lbnRhbEZlYXR1cmUgKj4gKmV4cGVyaW1lbnRhbEZlYXR1 cmVzID0gW1dLUHJlZmVyZW5jZXMgX2V4cGVyaW1lbnRhbEZlYXR1cmVzXTsKICAgICAgICAgZm9y IChfV0tFeHBlcmltZW50YWxGZWF0dXJlICpmZWF0dXJlIGluIGV4cGVyaW1lbnRhbEZlYXR1cmVz KSB7Ci0gICAgICAgICAgICBCT09MIGVuYWJsZWQgPSBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJk VXNlckRlZmF1bHRzXSBib29sRm9yS2V5OmZlYXR1cmUua2V5XTsKKyAgICAgICAgICAgIEJPT0wg ZW5hYmxlZDsKKyAgICAgICAgICAgIGlmIChbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRl ZmF1bHRzXSBvYmplY3RGb3JLZXk6ZmVhdHVyZS5rZXldKQorICAgICAgICAgICAgICAgIGVuYWJs ZWQgPSBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1bHRzXSBib29sRm9yS2V5OmZl YXR1cmUua2V5XTsKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBlbmFibGVkID0g W2ZlYXR1cmUgZGVmYXVsdFZhbHVlXTsKICAgICAgICAgICAgIFtjb25maWd1cmF0aW9uLnByZWZl cmVuY2VzIF9zZXRFbmFibGVkOmVuYWJsZWQgZm9yRXhwZXJpbWVudGFsRmVhdHVyZTpmZWF0dXJl XTsKICAgICAgICAgfQogCiAgICAgICAgIE5TQXJyYXk8X1dLSW50ZXJuYWxEZWJ1Z0ZlYXR1cmUg Kj4gKmludGVybmFsRGVidWdGZWF0dXJlcyA9IFtXS1ByZWZlcmVuY2VzIF9pbnRlcm5hbERlYnVn RmVhdHVyZXNdOwogICAgICAgICBmb3IgKF9XS0ludGVybmFsRGVidWdGZWF0dXJlICpmZWF0dXJl IGluIGludGVybmFsRGVidWdGZWF0dXJlcykgewotICAgICAgICAgICAgQk9PTCBlbmFibGVkID0g W1tOU1VzZXJEZWZhdWx0cyBzdGFuZGFyZFVzZXJEZWZhdWx0c10gYm9vbEZvcktleTpmZWF0dXJl LmtleV07CisgICAgICAgICAgICBCT09MIGVuYWJsZWQ7CisgICAgICAgICAgICBpZiAoW1tOU1Vz ZXJEZWZhdWx0cyBzdGFuZGFyZFVzZXJEZWZhdWx0c10gb2JqZWN0Rm9yS2V5OmZlYXR1cmUua2V5 XSkKKyAgICAgICAgICAgICAgICBlbmFibGVkID0gW1tOU1VzZXJEZWZhdWx0cyBzdGFuZGFyZFVz ZXJEZWZhdWx0c10gYm9vbEZvcktleTpmZWF0dXJlLmtleV07CisgICAgICAgICAgICBlbHNlCisg ICAgICAgICAgICAgICAgZW5hYmxlZCA9IFtmZWF0dXJlIGRlZmF1bHRWYWx1ZV07CiAgICAgICAg ICAgICBbY29uZmlndXJhdGlvbi5wcmVmZXJlbmNlcyBfc2V0RW5hYmxlZDplbmFibGVkIGZvcklu dGVybmFsRGVidWdGZWF0dXJlOmZlYXR1cmVdOwogICAgICAgICB9CiAjZW5kaWYK