189972 2018-09-25 13:43:29 -0700 Allow for suffixes to com.apple.WebKit.WebContent 2018-09-26 17:43:12 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen aestes ap cdumez darin thorton webkit-bug-importer oldest_to_newest 1463314 0 achristensen 2018-09-25 13:43:29 -0700 Allow for suffixes to com.apple.WebKit.WebContent 1463316 1 350783 achristensen 2018-09-25 13:45:22 -0700 Created attachment 350783 Patch 1463331 2 achristensen 2018-09-25 14:06:56 -0700 http://trac.webkit.org/r236474 1463334 3 webkit-bug-importer 2018-09-25 14:07:31 -0700 <rdar://problem/44773386> 1463486 4 ap 2018-09-25 20:01:32 -0700 This will be tricky to start using, because many system frameworks hardcore existing WebContent names. We’ll need to work with them if we want to add more names. 1463632 5 350783 darin 2018-09-26 09:41:32 -0700 Comment on attachment 350783 Patch Gets rid of the "com.apple.WebProcess" bundle ID. Was that being used anywhere? 1463648 6 achristensen 2018-09-26 10:59:56 -0700 (In reply to Alexey Proskuryakov from comment #4) > This will be tricky to start using, because many system frameworks hardcode > existing WebContent names. We’ll need to work with them if we want to add > more names. Tricky but possible. I intend to do just that. (In reply to Darin Adler from comment #5) > Comment on attachment 350783 [details] > Patch > > Gets rid of the "com.apple.WebProcess" bundle ID. Was that being used > anywhere? I believe it's historical. 1463832 7 350783 aestes 2018-09-26 17:07:50 -0700 Comment on attachment 350783 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350783&action=review > Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm:89 > + static bool mainBundleIsWebProcess = [[[NSBundle mainBundle] bundleIdentifier] hasPrefix:@"com.apple.WebKit.WebContent"]; I don’t know what suffixes you have in mind, but I’m a little surprised that the prefix string doesn’t end in a period. Will a suffix ever not be separated from the prefix by a period? 1463833 8 achristensen 2018-09-26 17:08:54 -0700 com.apple.WebKit.WebContent is valid com.apple.WebKit.WebContent.something is valid It can't have a period. There might be no suffix. 1463835 9 aestes 2018-09-26 17:13:03 -0700 (In reply to Alex Christensen from comment #8) > com.apple.WebKit.WebContent is valid > com.apple.WebKit.WebContent.something is valid > It can't have a period. There might be no suffix. com.apple.WebKit.WebContentdevelopment is also valid. Is that what you intend? 1463838 10 achristensen 2018-09-26 17:15:16 -0700 Are you suggesting we check for exact equality with "com.apple.WebKit.WebContent" or beginning with "com.apple.WebKit.WebContent."? I think that's overkill, especially since the right solution is to remove these bundle checks entirely. 1463847 11 aestes 2018-09-26 17:43:12 -0700 (In reply to Alex Christensen from comment #10) > Are you suggesting we check for exact equality with > "com.apple.WebKit.WebContent" or beginning with > "com.apple.WebKit.WebContent."? I think that's overkill, especially since > the right solution is to remove these bundle checks entirely You could also check if the string begins with com.apple.WebKit.WebContent and is equal in length to the prefix or has a period as the first character in the suffix. That wouldn’t require two comparisons. 350783 2018-09-25 13:45:22 -0700 2018-09-25 14:03:17 -0700 Patch bug-189972-20180925134521.patch text/plain 2912 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNjQ2MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE4LTA5LTI1ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWxsb3cgZm9y IHN1ZmZpeGVzIHRvIGNvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5OTcyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jb2NvYS9SdW50aW1l QXBwbGljYXRpb25DaGVja3NDb2NvYS5tbToKKyAgICAgICAgKFdlYkNvcmU6OmlzSW5XZWJQcm9j ZXNzKToKKwogMjAxOC0wOS0yNSAgWGFiaWVyIFJvZHJpZ3VleiBDYWx2YXIgIDxjYWx2YXJpc0Bp Z2FsaWEuY29tPgogCiAgICAgICAgIFtFTUVdIEZpeCB2YXJpYWJsZSBuYW1lIHRoYXQgc2hvdWxk IGhhdmUgZ29uZSBpbiByMjM2MzE3CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jb2Nv YS9SdW50aW1lQXBwbGljYXRpb25DaGVja3NDb2NvYS5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9jb2NvYS9SdW50aW1lQXBwbGljYXRpb25DaGVja3NDb2NvYS5tbQko cmV2aXNpb24gMjM2NDYyKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvUnVudGlt ZUFwcGxpY2F0aW9uQ2hlY2tzQ29jb2EubW0JKHdvcmtpbmcgY29weSkKQEAgLTg2LDkgKzg2LDcg QEAgdWludDMyX3QgYXBwbGljYXRpb25TREtWZXJzaW9uKCkKIAogYm9vbCBpc0luV2ViUHJvY2Vz cygpCiB7Ci0gICAgc3RhdGljIGJvb2wgbWFpbkJ1bmRsZUlzV2ViUHJvY2VzcyA9IFtbW05TQnVu ZGxlIG1haW5CdW5kbGVdIGJ1bmRsZUlkZW50aWZpZXJdIGlzRXF1YWxUb1N0cmluZzpAImNvbS5h cHBsZS5XZWJLaXQuV2ViQ29udGVudC5EZXZlbG9wbWVudCJdCi0gICAgICAgIHx8IFtbW05TQnVu ZGxlIG1haW5CdW5kbGVdIGJ1bmRsZUlkZW50aWZpZXJdIGlzRXF1YWxUb1N0cmluZzpAImNvbS5h cHBsZS5XZWJLaXQuV2ViQ29udGVudCJdCi0gICAgICAgIHx8IFtbW05TQnVuZGxlIG1haW5CdW5k bGVdIGJ1bmRsZUlkZW50aWZpZXJdIGlzRXF1YWxUb1N0cmluZzpAImNvbS5hcHBsZS5XZWJQcm9j ZXNzIl07CisgICAgc3RhdGljIGJvb2wgbWFpbkJ1bmRsZUlzV2ViUHJvY2VzcyA9IFtbW05TQnVu ZGxlIG1haW5CdW5kbGVdIGJ1bmRsZUlkZW50aWZpZXJdIGhhc1ByZWZpeDpAImNvbS5hcHBsZS5X ZWJLaXQuV2ViQ29udGVudCJdOwogICAgIHJldHVybiBtYWluQnVuZGxlSXNXZWJQcm9jZXNzOwog fQogCkluZGV4OiBTb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L2JtYWxsb2MvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzY0NzEpCisrKyBTb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxOC0wOS0yNSAgQWxl eCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgorCisgICAgICAgIEFsbG93 IGZvciBzdWZmaXhlcyB0byBjb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTk3MgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYm1hbGxvYy9Qcm9jZXNzQ2hl Y2subW06CisgICAgICAgIChibWFsbG9jOjpnaWdhY2FnZUVuYWJsZWRGb3JQcm9jZXNzKToKKwog MjAxOC0wOS0yNCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNvbT4KIAog ICAgICAgICBSZW5hbWUgV1RGX0NPTVBJTEVSX0dDQ19PUl9DTEFORyB0byBXVEZfQ09NUElMRVJf R0NDX0NPTVBBVElCTEUKSW5kZXg6IFNvdXJjZS9ibWFsbG9jL2JtYWxsb2MvUHJvY2Vzc0NoZWNr Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9ibWFsbG9jL2JtYWxsb2MvUHJvY2Vzc0NoZWNrLm1t CShyZXZpc2lvbiAyMzY0NjIpCisrKyBTb3VyY2UvYm1hbGxvYy9ibWFsbG9jL1Byb2Nlc3NDaGVj ay5tbQkod29ya2luZyBjb3B5KQpAQCAtMzgsOSArMzgsNyBAQCBib29sIGdpZ2FjYWdlRW5hYmxl ZEZvclByb2Nlc3MoKQogCiAgICAgTlNTdHJpbmcgKmFwcE5hbWUgPSBbW05TQnVuZGxlIG1haW5C dW5kbGVdIGJ1bmRsZUlkZW50aWZpZXJdOwogICAgIGlmIChhcHBOYW1lKSB7Ci0gICAgICAgIGJv b2wgaXNXZWJQcm9jZXNzID0gW2FwcE5hbWUgaXNFcXVhbFRvU3RyaW5nOkAiY29tLmFwcGxlLldl YktpdC5XZWJDb250ZW50LkRldmVsb3BtZW50Il0KLSAgICAgICAgICAgIHx8IFthcHBOYW1lIGlz RXF1YWxUb1N0cmluZzpAImNvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudCJdCi0gICAgICAgICAg ICB8fCBbYXBwTmFtZSBpc0VxdWFsVG9TdHJpbmc6QCJjb20uYXBwbGUuV2ViUHJvY2VzcyJdOwor ICAgICAgICBib29sIGlzV2ViUHJvY2VzcyA9IFthcHBOYW1lIGhhc1ByZWZpeDpAImNvbS5hcHBs ZS5XZWJLaXQuV2ViQ29udGVudCJdOwogICAgICAgICByZXR1cm4gaXNXZWJQcm9jZXNzOwogICAg IH0KIAo=