189949 2018-09-25 08:44:12 -0700 [JSC] offlineasm parser should handle CRLF in asm files 2018-09-26 04:06:33 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 189947 1 koby.b webkit-unassigned commit-queue fpizlo keith_miller mark.lam msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1463144 0 koby.b 2018-09-25 08:44:12 -0700 When working on Windows, LLInt's asm files might contain CRLFs, which currently fail the offlineasm parser. This patch removes '\r's from the input file. 1463150 1 350752 koby.b 2018-09-25 09:10:16 -0700 Created attachment 350752 Patch 1463152 2 350752 mark.lam 2018-09-25 09:37:56 -0700 Comment on attachment 350752 Patch r=me 1463378 3 mark.lam 2018-09-25 15:31:13 -0700 @Koby, in case you are new to WebKit development, since you don't have commit privileges yet, if you want a patch to be landed once a reviewer has granted a r+, you should set the cq flag to cq?. That will tell the reviewer or other committers that you're done with the patch and that it's ready to land. 1463533 4 koby.b 2018-09-26 01:33:43 -0700 @Mark thanks, I am new and this is actually the first patch I'm trying to upload. To set the cq flag, should I use webkit-patch land-safely? 1463537 5 ysuzuki 2018-09-26 01:41:01 -0700 (In reply to Koby from comment #4) > @Mark thanks, I am new and this is actually the first patch I'm trying to > upload. To set the cq flag, should I use webkit-patch land-safely? You can set `cq?` flag for already uploaded patches in this web page. Or passing `--request-commit` flag to `webkit-patch upload` when uploading the patch. In this case, your patch is already marked as `r+`. So just setting `cq=?` to the uploaded patch works fine :) 1463551 6 koby.b 2018-09-26 03:20:44 -0700 Done :) The "Reviewed by NOBODY (OOPS!)." will updated automatically? 1463552 7 350752 commit-queue 2018-09-26 03:45:45 -0700 Comment on attachment 350752 Patch Clearing flags on attachment: 350752 Committed r236499: <https://trac.webkit.org/changeset/236499> 1463553 8 commit-queue 2018-09-26 03:45:46 -0700 All reviewed patches have been landed. Closing bug. 1463554 9 webkit-bug-importer 2018-09-26 03:46:34 -0700 <rdar://problem/44791913> 1463556 10 ysuzuki 2018-09-26 04:06:33 -0700 (In reply to Koby from comment #6) > Done :) The "Reviewed by NOBODY (OOPS!)." will updated automatically? Yes! 350752 2018-09-25 09:10:16 -0700 2018-09-26 03:45:45 -0700 Patch bug-189949-20180925191013.patch text/plain 2167 koby.b U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh YTQzOGJlMWUwYmMzY2IxOTJiY2Y3MTA1NzgwZDkzN2ZmOWVjMjEzLi5mZmJjN2ZlYjE2ZWRiYjcz MDFiNjYwOTg4NjU2ZTA4NjQ3MjBjZmU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxOC0wOS0yNSAgS29ieSBCb3lhbmdvICA8a29ieS5iQG1jZS5zeXN0ZW1z PgorCisgICAgICAgIFtKU0NdIG9mZmxpbmVhc20gcGFyc2VyIHNob3VsZCBoYW5kbGUgQ1JMRiBp biBhc20gZmlsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4OTk0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogb2ZmbGluZWFzbS9wYXJzZXIucmI6CisKIDIwMTgtMDktMjQgIEpvc2VwaCBQZWNvcmFy byAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgQVVUSE9SUyBhbmQgVEhB TktTIGZpbGVzIHdoaWNoIGFyZSBzdGFsZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL29mZmxpbmVhc20vcGFyc2VyLnJiIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVh c20vcGFyc2VyLnJiCmluZGV4IDM4NjllNmMzZmUxZWQzYzBhN2RlYjBkNjJhYTI3NzM2ZGM4Yjhh ZGYuLmNmOGExMDdmNTMxNzg0MDQxYTY2MzkzMDJkYzg0YTcyYzczN2ZiMTIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3BhcnNlci5yYgorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9wYXJzZXIucmIKQEAgLTg0MCwxNyArODQwLDI4IEBA IGNsYXNzIFBhcnNlcgogICAgIGVuZAogZW5kCiAKK2RlZiByZWFkVGV4dEZpbGUoZmlsZU5hbWUp CisgICAgZGF0YSA9IElPOjpyZWFkKGZpbGVOYW1lKQorCisgICAgIyBPbiBXaW5kb3dzLCBmaWxl cyBtYXkgY29udGFpbiBDUkxGIGxpbmUgZW5kaW5ncyAoZm9yIGV4YW1wbGUsIGdpdCBjbGllbnQg bWlnaHQKKyAgICAjIGF1dG9tYXRpY2FsbHkgcmVwbGFjZSBcbiB3aXRoIFxyXG4gb24gV2luZG93 cykgd2hpY2ggd2lsbCBmYWlsIG91ciBwYXJzaW5nLgorICAgICMgVGh1cywgd2UnbGwganVzdCBy ZW1vdmUgYWxsIFxyIGZyb20gdGhlIGRhdGEgKGtlZXBpbmcganVzdCB0aGUgXG4gY2hhcmFjdGVy cykKKyAgICBkYXRhLmRlbGV0ZSEoIlxyIikKKworICAgIHJldHVybiBkYXRhCitlbmQKKwogZGVm IHBhcnNlRGF0YShkYXRhLCBmaWxlTmFtZSkKICAgICBwYXJzZXIgPSBQYXJzZXIubmV3KGRhdGEs IFNvdXJjZUZpbGUubmV3KGZpbGVOYW1lKSkKICAgICBwYXJzZXIucGFyc2VTZXF1ZW5jZShuaWws ICIiKQogZW5kCiAKIGRlZiBwYXJzZShmaWxlTmFtZSkKLSAgICBwYXJzZURhdGEoSU86OnJlYWQo ZmlsZU5hbWUpLCBmaWxlTmFtZSkKKyAgICBwYXJzZURhdGEocmVhZFRleHRGaWxlKGZpbGVOYW1l KSwgZmlsZU5hbWUpCiBlbmQKIAogZGVmIHBhcnNlSGFzaChmaWxlTmFtZSkKLSAgICBwYXJzZXIg PSBQYXJzZXIubmV3KElPOjpyZWFkKGZpbGVOYW1lKSwgU291cmNlRmlsZS5uZXcoZmlsZU5hbWUp KQorICAgIHBhcnNlciA9IFBhcnNlci5uZXcocmVhZFRleHRGaWxlKGZpbGVOYW1lKSwgU291cmNl RmlsZS5uZXcoZmlsZU5hbWUpKQogICAgIGZpbGVMaXN0ID0gcGFyc2VyLnBhcnNlSW5jbHVkZXMo bmlsLCAiIikKICAgICBmaWxlTGlzdEhhc2goZmlsZUxpc3QpCiBlbmQKd2FybmluZzogTEYgd2ls bCBiZSByZXBsYWNlZCBieSBDUkxGIGluIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cu ClRoZSBmaWxlIHdpbGwgaGF2ZSBpdHMgb3JpZ2luYWwgbGluZSBlbmRpbmdzIGluIHlvdXIgd29y a2luZyBkaXJlY3RvcnkuCndhcm5pbmc6IExGIHdpbGwgYmUgcmVwbGFjZWQgYnkgQ1JMRiBpbiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9wYXJzZXIucmIuClRoZSBmaWxlIHdpbGwg aGF2ZSBpdHMgb3JpZ2luYWwgbGluZSBlbmRpbmdzIGluIHlvdXIgd29ya2luZyBkaXJlY3Rvcnku Cg==