189937 2018-09-24 17:06:27 -0700 Don't cause a crash even when some IDL attribute is missing CEReactions 2018-09-24 17:28:44 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 154907 1 rniwa rniwa cdumez dbates esprehn+autocc ews-watchlist ggaren kangil.han koivisto simon.fraser webkit-bug-importer oldest_to_newest 1463021 0 rniwa 2018-09-24 17:06:27 -0700 It's not a good trade-off to cause a release assertion hit when there is an IDL attribute missing CEReactions. Turn this into a debug-only assertion. 1463026 1 350715 rniwa 2018-09-24 17:12:13 -0700 Created attachment 350715 Don't release-assert even when CEReactions is missing 1463030 2 webkit-bug-importer 2018-09-24 17:17:46 -0700 <rdar://problem/44746785> 1463032 3 rniwa 2018-09-24 17:28:44 -0700 Committed r236446: <https://trac.webkit.org/changeset/236446> 350715 2018-09-24 17:12:13 -0700 2018-09-24 17:14:10 -0700 Don't release-assert even when CEReactions is missing bug-189937-20180924171212.patch text/plain 2699 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNjQ0NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE4LTA5LTI0ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIERvbid0IGNhdXNlIGEgY3Jhc2gg ZXZlbiB3aGVuIHNvbWUgSURMIGF0dHJpYnV0ZSBpcyBtaXNzaW5nIENFUmVhY3Rpb25zCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODk5MzcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXBsYWNlZCByZWxl YXNlIGFzc2VydGlvbnMgaW4gRWxlbWVudFF1ZXVlOjphZGQgYW5kIEVsZW1lbnRRdWV1ZTo6aW52 b2tlQWxsIGJ5IGRlYnVnIGFzc2VydGlvbnMKKyAgICAgICAgc2luY2UgYSBtaXNzaW5nIENFUmVh Y3Rpb25zIHJlc3VsdGluZyBpbiBhIGNyYXNoIGlzIGEgdGVycmlibGUgdXNlciBleHBlcmllbmNl LgorCisgICAgICAgIEFsc28gbWFkZSB0aGUgaXRlcmF0aW9uIGluIGludm9rZUFsbCBzYWZlIHdo ZW4gbW9yZSBlbGVtZW50cyB3ZXJlIGFkZGVkIHRvIG1fZWxlbWVudHMuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzIHNpbmNlIHdlIHdvdWxkIHN0aWxsIGhpdCBkZWJ1ZyBhc3NlcnRpb25zLCBhbmQg dGhpcyBiZWhhdmlvciBzaG91bGQgb25seSBjb21lIHVwCisgICAgICAgIHdoZW4gc29tZSBJREwg YXR0cmlidXRlIGlzIGVycm9uZW91c2x5IG1pc3NpbmcgQ0VSZWFjdGlvbnMuCisKKyAgICAgICAg KiBkb20vQ3VzdG9tRWxlbWVudFJlYWN0aW9uUXVldWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Q3VzdG9tRWxlbWVudFJlYWN0aW9uUXVldWU6OkVsZW1lbnRRdWV1ZTo6YWRkKToKKyAgICAgICAg KFdlYkNvcmU6OkN1c3RvbUVsZW1lbnRSZWFjdGlvblF1ZXVlOjpFbGVtZW50UXVldWU6Omludm9r ZUFsbCk6CisKIDIwMTgtMDktMjQgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAK ICAgICAgICAgU2hhcmVkQnVmZmVyIHNob3VsZCBoYXZlIGFuIGVxdWFsaXR5IHRlc3QKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL2RvbS9DdXN0b21FbGVtZW50UmVhY3Rpb25RdWV1ZS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL0N1c3RvbUVsZW1lbnRSZWFjdGlvblF1ZXVlLmNw cAkocmV2aXNpb24gMjM2NDQxKQorKysgU291cmNlL1dlYkNvcmUvZG9tL0N1c3RvbUVsZW1lbnRS ZWFjdGlvblF1ZXVlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjI1LDcgKzIyNSw3IEBAIHZvaWQg Q3VzdG9tRWxlbWVudFJlYWN0aW9uUXVldWU6Omludm9rZUEKIAogaW5saW5lIHZvaWQgQ3VzdG9t RWxlbWVudFJlYWN0aW9uUXVldWU6OkVsZW1lbnRRdWV1ZTo6YWRkKEVsZW1lbnQmIGVsZW1lbnQp CiB7Ci0gICAgUkVMRUFTRV9BU1NFUlQoIW1faW52b2tpbmcpOworICAgIEFTU0VSVCghbV9pbnZv a2luZyk7CiAgICAgLy8gRklYTUU6IEF2b2lkIGluc2VydGluZyB0aGUgc2FtZSBlbGVtZW50IG11 bHRpcGxlIHRpbWVzLgogICAgIG1fZWxlbWVudHMuYXBwZW5kKGVsZW1lbnQpOwogfQpAQCAtMjM0 LDEzICsyMzQsMTYgQEAgaW5saW5lIHZvaWQgQ3VzdG9tRWxlbWVudFJlYWN0aW9uUXVldWU6Ogog ewogICAgIFJFTEVBU0VfQVNTRVJUKCFtX2ludm9raW5nKTsKICAgICBTZXRGb3JTY29wZTxib29s PiBpbnZva2luZyhtX2ludm9raW5nLCB0cnVlKTsKLSAgICBhdXRvIG9yaWdpbmFsU2l6ZSA9IG1f ZWxlbWVudHMuc2l6ZSgpOwotICAgIGZvciAoYXV0byYgZWxlbWVudCA6IG1fZWxlbWVudHMpIHsK LSAgICAgICAgYXV0byogcXVldWUgPSBlbGVtZW50LT5yZWFjdGlvblF1ZXVlKCk7CisgICAgdW5z aWduZWQgb3JpZ2luYWxTaXplID0gbV9lbGVtZW50cy5zaXplKCk7CisgICAgLy8gSXQncyBwb3Nz aWJsZSBmb3IgbW9yZSBlbGVtZW50cyB0byBiZSBlbnF1ZXVlZCBpZiBzb21lIElETCBhdHRyaWJ1 dGVzIHdlcmUgbWlzc2luZyBDRVJlYWN0aW9ucy4KKyAgICAvLyBJbnZva2UgY2FsbGJhY2tzIHNs aWdodGx5IGxhdGVyIGhlcmUgaW5zdGVhZCBvZiBjcmFzaGluZyAvIGlnbm9yaW5nIHRob3NlIGNh c2VzLgorICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBtX2VsZW1lbnRzLnNpemUoKTsgKytp KSB7CisgICAgICAgIGF1dG8mIGVsZW1lbnQgPSBtX2VsZW1lbnRzW2ldLmdldCgpOworICAgICAg ICBhdXRvKiBxdWV1ZSA9IGVsZW1lbnQucmVhY3Rpb25RdWV1ZSgpOwogICAgICAgICBBU1NFUlQo cXVldWUpOwotICAgICAgICBxdWV1ZS0+aW52b2tlQWxsKGVsZW1lbnQuZ2V0KCkpOworICAgICAg ICBxdWV1ZS0+aW52b2tlQWxsKGVsZW1lbnQpOwogICAgIH0KLSAgICBSRUxFQVNFX0FTU0VSVCht X2VsZW1lbnRzLnNpemUoKSA9PSBvcmlnaW5hbFNpemUpOworICAgIEFTU0VSVF9VTlVTRUQobV9l bGVtZW50cy5zaXplKCkgPT0gb3JpZ2luYWxTaXplLCBvcmlnaW5hbFNpemUpOwogICAgIG1fZWxl bWVudHMuY2xlYXIoKTsKIH0KIAo=