18993 2008-05-11 01:34:57 -0700 Update of buttons in toolbar lags behind 2008-06-23 14:17:37 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) All All RESOLVED FIXED P3 Enhancement --- 1 digulla webkit-unassigned webkit oldest_to_newest 80110 0 digulla 2008-05-11 01:34:57 -0700 Select a piece of text and make it bold. Now use the cursor keys to move in and out of the bold text. You'll see that the button in the toolbar lags behind by one keystroke. The source of the problem is that the cursor is in a new position when the key is released. To fix this, add an event listener for "keyup" in FancyToolbar.prototype.show() (just copy the line with "keypress"). Don't forget to remove the event listener in FancyToolbar.prototype.hidden(). Also, the call to loadFancyToolbars() in index.html is no longer necessary. 80111 1 21065 digulla 2008-05-11 01:36:09 -0700 Created attachment 21065 Patch for the two issues 83241 2 21065 webkit 2008-06-13 12:33:02 -0700 Comment on attachment 21065 Patch for the two issues I suppose you have asked for review ;) 83245 3 21065 darin 2008-06-13 14:02:01 -0700 Comment on attachment 21065 Patch for the two issues r=me 84079 4 digulla 2008-06-22 13:32:26 -0700 Just apply the code to the project. It's just three lines that are changed! 84101 5 mrowe 2008-06-22 18:27:19 -0700 Landed in r34736. 84192 6 digulla 2008-06-23 14:17:37 -0700 Verified in r34746. Should I mark this bug as verified or who does that? 21065 2008-05-11 01:36:09 -0700 2008-06-13 14:02:01 -0700 Patch for the two issues editingToolbar-lag.patch text/plain 1892 digulla SW5kZXg6IFdlYktpdFNpdGUvZGVtb3MvZWRpdGluZ1Rvb2xiYXIvRmFuY3lUb29sYmFyLmpzCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYktpdFNpdGUvZGVtb3MvZWRpdGluZ1Rvb2xiYXIvRmFuY3lUb29sYmFy LmpzCShyZXZpc2lvbiAzMzAyOCkKKysrIFdlYktpdFNpdGUvZGVtb3MvZWRpdGluZ1Rvb2xiYXIv RmFuY3lUb29sYmFyLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0yODksNiArMjg5LDcgQEAgRmFuY3lU b29sYmFyLnByb3RvdHlwZS5zaG93ID0gZnVuY3Rpb24oKQogICAgIHRoaXMuZWRpdEFyZWEuY29u dGVudERvY3VtZW50LmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNldXAiLCB0aGlzLnVwZGF0ZVRvb2xi YXJMaXN0ZW5lciwgZmFsc2UpOwogICAgIHRoaXMuZWRpdEFyZWEuY29udGVudERvY3VtZW50LmFk ZEV2ZW50TGlzdGVuZXIoIm1vdXNlbW92ZSIsIHRoaXMudXBkYXRlVG9vbGJhckxpc3RlbmVyLCBm YWxzZSk7CiAgICAgdGhpcy5lZGl0QXJlYS5jb250ZW50RG9jdW1lbnQuYWRkRXZlbnRMaXN0ZW5l cigia2V5cHJlc3MiLCB0aGlzLnVwZGF0ZVRvb2xiYXJMaXN0ZW5lciwgZmFsc2UpOworICAgIHRo aXMuZWRpdEFyZWEuY29udGVudERvY3VtZW50LmFkZEV2ZW50TGlzdGVuZXIoImtleXVwIiwgdGhp cy51cGRhdGVUb29sYmFyTGlzdGVuZXIsIGZhbHNlKTsKIAogICAgIHdpbmRvdy5hZGRFdmVudExp c3RlbmVyKCJyZXNpemUiLCB0aGlzLndpbmRvd1Jlc2l6ZUxpc3RlbmVyLCBmYWxzZSk7CiAKQEAg LTMxNyw2ICszMTgsNyBAQCBGYW5jeVRvb2xiYXIucHJvdG90eXBlLmhpZGRlbiA9IGZ1bmN0aW9u CiAgICAgdGhpcy5lZGl0QXJlYS5jb250ZW50RG9jdW1lbnQucmVtb3ZlRXZlbnRMaXN0ZW5lcigi bW91c2V1cCIsIHRoaXMudXBkYXRlVG9vbGJhckxpc3RlbmVyLCBmYWxzZSk7CiAgICAgdGhpcy5l ZGl0QXJlYS5jb250ZW50RG9jdW1lbnQucmVtb3ZlRXZlbnRMaXN0ZW5lcigibW91c2Vtb3ZlIiwg dGhpcy51cGRhdGVUb29sYmFyTGlzdGVuZXIsIGZhbHNlKTsKICAgICB0aGlzLmVkaXRBcmVhLmNv bnRlbnREb2N1bWVudC5yZW1vdmVFdmVudExpc3RlbmVyKCJrZXlwcmVzcyIsIHRoaXMudXBkYXRl VG9vbGJhckxpc3RlbmVyLCBmYWxzZSk7CisgICAgdGhpcy5lZGl0QXJlYS5jb250ZW50RG9jdW1l bnQucmVtb3ZlRXZlbnRMaXN0ZW5lcigia2V5dXAiLCB0aGlzLnVwZGF0ZVRvb2xiYXJMaXN0ZW5l ciwgZmFsc2UpOwogICAgIHdpbmRvdy5yZW1vdmVFdmVudExpc3RlbmVyKCJyZXNpemUiLCB0aGlz LndpbmRvd1Jlc2l6ZUxpc3RlbmVyLCBmYWxzZSk7CiAKICAgICAvLyByZW1vdmUgdGhlIHRvb2xi YXIgZWxlbWVudApJbmRleDogV2ViS2l0U2l0ZS9kZW1vcy9lZGl0aW5nVG9vbGJhci9pbmRleC5o dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYktpdFNpdGUvZGVtb3MvZWRpdGluZ1Rvb2xiYXIvaW5kZXgu aHRtbAkocmV2aXNpb24gMzMwMjgpCisrKyBXZWJLaXRTaXRlL2RlbW9zL2VkaXRpbmdUb29sYmFy L2luZGV4Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTY1LDcgKzY1LDcgQEAgaWZyYW1lLmVkaXRh YmxlIHsKIDxsaW5rIHJlbD0ic3R5bGVzaGVldCIgdHlwZT0idGV4dC9jc3MiIGhyZWY9IkZhbmN5 VG9vbGJhci5jc3MiPgogPHNjcmlwdCBzcmM9IkZhbmN5VG9vbGJhci5qcyI+PC9zY3JpcHQ+CiA8 L2hlYWQ+Ci08Ym9keSBvbmxvYWQ9ImxvYWRGYW5jeVRvb2xiYXJzKCkiPgorPGJvZHk+CiA8aWZy YW1lIGNsYXNzPSJlZGl0YWJsZSIgc3JjPSJjb250ZW50Lmh0bWwiPjwvaWZyYW1lPgogPC9ib2R5 PgogPC9odG1sPgo=