189928 2018-09-24 14:09:35 -0700 Include more headers in IOSurface.mm, PixelBufferResizer.{h, mm} 2018-09-24 15:48:35 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates aestes andersca eric.carlson pvollan webkit-bug-importer oldest_to_newest 1462870 0 dbates 2018-09-24 14:09:35 -0700 When shuffling around some files I caused my Mac build to fail to build IOSurface.mm and PixelBufferResizer.mm because of some missing #includes. This issue will only manifest itself if IOSurface.mm or PixelBufferResizer.mm are not unified with other translation units that have the missing #includes that they need. We should make building IOSurface.mm and PixelBufferResizer.mm deterministic and have them include the appropriate headers. 1462874 1 350682 dbates 2018-09-24 14:14:13 -0700 Created attachment 350682 Patch 1462946 2 dbates 2018-09-24 15:47:43 -0700 Committed r236432: <https://trac.webkit.org/changeset/236432> 1462947 3 webkit-bug-importer 2018-09-24 15:48:35 -0700 <rdar://problem/44743458> 350682 2018-09-24 14:14:13 -0700 2018-09-24 14:17:29 -0700 Patch bug-189928-20180924141412.patch text/plain 3299 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NDI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjBkZTU4ZGIyNjI0NjJl OTg4N2Q4MzI0MWI0NjllMjE1YTEwZDY3MS4uNjMwMTQyNmIyODczOTIxMDM5ZmQxZmZiODNjY2Vm MjQ1MDljNWI5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTA5LTI0ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBJbmNsdWRlIG1vcmUgaGVh ZGVycyBpbiBJT1N1cmZhY2UubW0sIFBpeGVsQnVmZmVyUmVzaXplci57aCwgbW19CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODk5MjgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIGJ1aWxkaW5nIElP U3VyZmFjZS5tbSBhbmQgUGl4ZWxCdWZmZXJSZXNpemVyLm1tIGRldGVybWluaXN0aWMgcmVnYXJk bGVzcyBvZgorICAgICAgICB3aGljaCBidW5kbGUgb2YgdW5pZmllZCBzb3VyY2VzIHRoZXkgYXJl IGJ1aWx0IGluLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvSU9TdXJmYWNl Lm1tOiBJbmNsdWRlIGhlYWRlcnMgSG9zdFdpbmRvdy5oIGFuZCBQbGF0Zm9ybVNjcmVlbi5oCisg ICAgICAgIHNpbmNlIHdlIG1ha2UgdXNlIG9mIGZ1bmN0aW9uYWxpdHkgZnJvbSB0aGVzZSBoZWFk ZXJzLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2N2L1BpeGVsQnVmZmVyUmVzaXplci5o OiBJbmNsdWRlIGhlYWRlciBJbnRTaXplLmggc2luY2UKKyAgICAgICAgd2UgbmVlZCB0aGUgc2l6 ZSBvZiBhbiBJbnRTaXplIGZvciBtX3NpemUuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv Y3YvUGl4ZWxCdWZmZXJSZXNpemVyLm1tOiBJbmNsdWRlIGhlYWRlciBMb2dnaW5nLmggc2luY2UK KyAgICAgICAgdGhpcyBmaWxlIG1ha2VzIHVzZSBvZiBsb2dnaW5nIGZhY2lsaXRpZXMuIEFsc28g c3Vic3RpdHV0ZSAjaW1wb3J0IGZvciAjaW5jbHVkZQorICAgICAgICB3aGlsZSBJIGFtIGhlcmUg c2luY2UgdGhpcyBmaWxlIGlzIGFuIE9iamVjdGl2ZS1DKysgZmlsZS4KKwogMjAxOC0wOS0yNCAg RGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgU2VwYXJhdGUgTWFj IGFuZCBpT1MgaW1wbGVtZW50YXRpb24gb2Ygd2luZG93c0tleUNvZGVGb3JDaGFyQ29kZSgpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9JT1N1cmZh Y2UubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9JT1N1cmZhY2Uu bW0KaW5kZXggZjgyMWVlMDcxZmE3OWY2OTczZmQyNDkxZDFjNWVjYTBhZTkwY2ZkNi4uMTA0MGRi ZTg3YmM4MGZjYzcyNGIzNDRkOTRkM2E0Yzc4NmUxYjEyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvSU9TdXJmYWNlLm1tCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0lPU3VyZmFjZS5tbQpAQCAtMzAsMTAgKzMw LDEyIEBACiAKICNpbXBvcnQgIkdyYXBoaWNzQ29udGV4dDNELmgiCiAjaW1wb3J0ICJHcmFwaGlj c0NvbnRleHRDRy5oIgorI2ltcG9ydCAiSG9zdFdpbmRvdy5oIgogI2ltcG9ydCAiSU9TdXJmYWNl UG9vbC5oIgogI2ltcG9ydCAiSW1hZ2VCdWZmZXIuaCIKICNpbXBvcnQgIkltYWdlQnVmZmVyRGF0 YUNHLmgiCiAjaW1wb3J0ICJMb2dnaW5nLmgiCisjaW1wb3J0ICJQbGF0Zm9ybVNjcmVlbi5oIgog I2ltcG9ydCA8cGFsL3NwaS9jZy9Db3JlR3JhcGhpY3NTUEkuaD4KICNpbXBvcnQgPHBhbC9zcGkv Y29jb2EvSU9TdXJmYWNlU1BJLmg+CiAjaW1wb3J0IDx3dGYvQXNzZXJ0aW9ucy5oPgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY3YvUGl4ZWxCdWZmZXJSZXNp emVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jdi9QaXhlbEJ1ZmZlclJl c2l6ZXIuaAppbmRleCBkYjE5NTM2MzM4NDQxZGRlMjY3MTdmZjE0NTNjNzkzZThlOGM3NTk3Li4z ZGNkNGFiMjI0MDUwZTQ3ZmI1NzNjNWE5M2UzNzVmODgyOTE1ZjVkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jdi9QaXhlbEJ1ZmZlclJlc2l6ZXIuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jdi9QaXhlbEJ1ZmZlclJlc2l6ZXIu aApAQCAtMjcsNiArMjcsNyBAQAogCiAjaWYgVVNFKFZJREVPVE9PTEJPWCkKIAorI2luY2x1ZGUg IkludFNpemUuaCIKICNpbmNsdWRlIDx3dGYvUmV0YWluUHRyLmg+CiAKIHR5cGVkZWYgc3RydWN0 IE9wYXF1ZVZUUGl4ZWxUcmFuc2ZlclNlc3Npb24qIFZUUGl4ZWxUcmFuc2ZlclNlc3Npb25SZWY7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jdi9QaXhlbEJ1 ZmZlclJlc2l6ZXIubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jdi9QaXhl bEJ1ZmZlclJlc2l6ZXIubW0KaW5kZXggOTQwMTg0NGE4ODc3MTFjMzQ1Njc1YWUzZGViZjIwMmY2 YjBiYzQyYS4uNmJhMDk0ODhhMWFhYzMxMTI2ZDA3MGFjOGMyMjNlYzU0ZjU4NzVhNCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY3YvUGl4ZWxCdWZmZXJSZXNp emVyLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2N2L1BpeGVsQnVm ZmVyUmVzaXplci5tbQpAQCAtMjMsMTUgKzIzLDE2IEBACiAgKiBUSEUgUE9TU0lCSUxJVFkgT0Yg U1VDSCBEQU1BR0UuCiAgKi8KIAotI2luY2x1ZGUgImNvbmZpZy5oIgotI2luY2x1ZGUgIlBpeGVs QnVmZmVyUmVzaXplci5oIgorI2ltcG9ydCAiY29uZmlnLmgiCisjaW1wb3J0ICJQaXhlbEJ1ZmZl clJlc2l6ZXIuaCIKIAogI2lmIFVTRShWSURFT1RPT0xCT1gpCiAKLSNpbmNsdWRlIDx3dGYvU29m dExpbmtpbmcuaD4KKyNpbXBvcnQgIkxvZ2dpbmcuaCIKKyNpbXBvcnQgPHd0Zi9Tb2Z0TGlua2lu Zy5oPgogCi0jaW5jbHVkZSAiQ29yZVZpZGVvU29mdExpbmsuaCIKLSNpbmNsdWRlICJWaWRlb1Rv b2xib3hTb2Z0TGluay5oIgorI2ltcG9ydCAiQ29yZVZpZGVvU29mdExpbmsuaCIKKyNpbXBvcnQg IlZpZGVvVG9vbGJveFNvZnRMaW5rLmgiCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAo=