189909 2018-09-23 23:37:55 -0700 Remove duplicate CSS Properties and Values feature on status page 2018-09-27 15:30:31 -0700 1 1 1 Unclassified WebKit WebKit Website Other Unspecified Unspecified RESOLVED FIXED FromImplementor, InRadar P2 Trivial --- 189692 1 andruud justin_michaud commit-queue ews-watchlist joepeck jond justin_michaud lforschler simon.fraser webkit-bug-importer oldest_to_newest 1462624 0 andruud 2018-09-23 23:37:55 -0700 How great that you are implementing this spec! :) If [1] could be updated with status "In Development", and [2] could be deleted, that would be great. It already caused some minor confusion. [1] https://webkit.org/status/#specification-css-properties-and-values-api-level-1 [2] https://webkit.org/status/#specification-css-custom-properties-and-values 1464156 1 351003 justin_michaud 2018-09-27 14:29:48 -0700 Created attachment 351003 Patch 1464157 2 351003 simon.fraser 2018-09-27 14:33:55 -0700 Comment on attachment 351003 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351003&action=review > Source/WebCore/features.json:137 > "keywords": ["css", "houdini"], Would be nice to have description and webkit-url here and the better keywords. 1464161 3 351004 justin_michaud 2018-09-27 14:38:43 -0700 Created attachment 351004 Patch 1464169 4 ews-watchlist 2018-09-27 14:50:12 -0700 Attachment 351004 did not pass style-queue: ERROR: Source/WebCore/features.json:0: The feature "Pointer Events" has a specification field but no specification of that name exists. [json/syntax] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1464176 5 justin_michaud 2018-09-27 14:57:43 -0700 I think the style error is a false positive. I didn't change Pointer Events, and the spec does exist 1464187 6 351004 commit-queue 2018-09-27 15:29:34 -0700 Comment on attachment 351004 Patch Clearing flags on attachment: 351004 Committed r236575: <https://trac.webkit.org/changeset/236575> 1464188 7 commit-queue 2018-09-27 15:29:35 -0700 All reviewed patches have been landed. Closing bug. 1464189 8 webkit-bug-importer 2018-09-27 15:30:31 -0700 <rdar://problem/44846052> 351003 2018-09-27 14:29:48 -0700 2018-09-27 14:38:41 -0700 Patch bug-189909-20180927142946.patch text/plain 2074 justin_michaud U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NTcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjBlNThiYmM3ZmEyYzdh OWU0YjljZjkyODBiOTNlNDBmNGM5YzFlOC4uYWY0NDAwMDZiNWE1MDBlYWEwMmMwZGE3ZTExM2Y3 Y2JlZjllZDI5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA5LTI3ICBKdXN0 aW4gTWljaGF1ZCAgPGp1c3Rpbl9taWNoYXVkQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUg ZHVwbGljYXRlIENTUyBQcm9wZXJ0aWVzIGFuZCBWYWx1ZXMgZmVhdHVyZSBvbiBzdGF0dXMgcGFn ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5OTA5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRl IENTUyBwcm9wZXJ0aWVzIGFuZCB2YWx1ZXMgYXBpIGZlYXR1cmUgaW4gZmVhdHVyZXMuanNvbgor CisgICAgICAgICogZmVhdHVyZXMuanNvbjoKKwogMjAxOC0wOS0yNyAgQWxpY2lhIEJveWEgR2Fy Y8OtYSAgPGFib3lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW01TRV0gRml4IHVud2FudGVkIHNh bXBsZSBlcmFzZSBmcm9tIHRoZSBkZWNvZGUgcXVldWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2ZlYXR1cmVzLmpzb24gYi9Tb3VyY2UvV2ViQ29yZS9mZWF0dXJlcy5qc29uCmluZGV4IGI2 NDMwZmFhZWVjOTk0NDE4ZWNlNWY4MzgyNGI3ZmM1MDVmYzZiYTUuLjgwZGU4MjEyMDA4M2VjODU3 ZDI1M2U1MTJjNjYxNWE3NDI4MjNkYjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2ZlYXR1 cmVzLmpzb24KKysrIGIvU291cmNlL1dlYkNvcmUvZmVhdHVyZXMuanNvbgpAQCAtNDksMTYgKzQ5 LDYgQEAKICAgICAgICAgImNhdGVnb3J5IjogImNzcyIsCiAgICAgICAgICJkZXNjcmlwdGlvbiI6 ICJBbGxvd3MgY29udGVudCB0byBzcGVjaWZ5IGNvbG9ycyBvdXRzaWRlIG9mIHRoZSBzUkdCIENv bG9yIFNwYWNlLiIKICAgICB9LAotICAgIHsKLSAgICAgICAgIm5hbWUiOiAiQ1NTIEN1c3RvbSBQ cm9wZXJ0aWVzIEFuZCBWYWx1ZXMiLAotICAgICAgICAic3RhdHVzIjogewotICAgICAgICAgICAg InN0YXR1cyI6ICJVbmRlciBEZXZlbG9wbWVudCIKLSAgICAgICAgfSwKLSAgICAgICAgInVybCI6 ICJodHRwczovL2RyYWZ0cy5jc3MtaG91ZGluaS5vcmcvY3NzLXByb3BlcnRpZXMtdmFsdWVzLWFw aS8iLAotICAgICAgICAid2Via2l0LXVybCI6ICJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTg5NjkyIiwKLSAgICAgICAgImtleXdvcmRzIjogWyJDU1NDdXN0b21Qcm9w ZXJ0aWVzQW5kVmFsdWVzIiwgImN1c3RvbSBwcm9wZXJ0aWVzIiwgImNzcyJdLAotICAgICAgICAi ZGVzY3JpcHRpb24iOiAiQW4gQVBJIGZvciByZWdpc3RlcmluZyBuZXcgQ1NTIHByb3BlcnRpZXMu IFByb3BlcnRpZXMgcmVnaXN0ZXJlZCB1c2luZyB0aGlzIEFQSSBhcmUgcHJvdmlkZWQgd2l0aCBh IHBhcnNlIHN5bnRheCB0aGF0IGRlZmluZXMgYSB0eXBlLCBpbmhlcml0YW5jZSBiZWhhdmlvdXIs IGFuZCBhbiBpbml0aWFsIHZhbHVlLiIKLSAgICB9LAogICAgIHsKICAgICAgICAgIm5hbWUiOiAi Q1NTIEZvbnQgRGlzcGxheSIsCiAgICAgICAgICJzdGF0dXMiOiB7CkBAIC0xNDEsNyArMTMxLDcg QEAKICAgICB7CiAgICAgICAgICJuYW1lIjogIkNTUyBQcm9wZXJ0aWVzIGFuZCBWYWx1ZXMgQVBJ IExldmVsIDEiLAogICAgICAgICAic3RhdHVzIjogewotICAgICAgICAgICAgInN0YXR1cyI6ICJV bmRlciBDb25zaWRlcmF0aW9uIgorICAgICAgICAgICAgInN0YXR1cyI6ICJVbmRlciBEZXZlbG9w bWVudCIKICAgICAgICAgfSwKICAgICAgICAgInVybCI6ICJodHRwczovL2RyYWZ0cy5jc3MtaG91 ZGluaS5vcmcvY3NzLXByb3BlcnRpZXMtdmFsdWVzLWFwaS8iLAogICAgICAgICAia2V5d29yZHMi OiBbImNzcyIsICJob3VkaW5pIl0sCg== 351004 2018-09-27 14:38:43 -0700 2018-09-27 15:29:34 -0700 Patch bug-189909-20180927143840.patch text/plain 2459 justin_michaud U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NTcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjBlNThiYmM3ZmEyYzdh OWU0YjljZjkyODBiOTNlNDBmNGM5YzFlOC4uYWY0NDAwMDZiNWE1MDBlYWEwMmMwZGE3ZTExM2Y3 Y2JlZjllZDI5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA5LTI3ICBKdXN0 aW4gTWljaGF1ZCAgPGp1c3Rpbl9taWNoYXVkQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUg ZHVwbGljYXRlIENTUyBQcm9wZXJ0aWVzIGFuZCBWYWx1ZXMgZmVhdHVyZSBvbiBzdGF0dXMgcGFn ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5OTA5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRl IENTUyBwcm9wZXJ0aWVzIGFuZCB2YWx1ZXMgYXBpIGZlYXR1cmUgaW4gZmVhdHVyZXMuanNvbgor CisgICAgICAgICogZmVhdHVyZXMuanNvbjoKKwogMjAxOC0wOS0yNyAgQWxpY2lhIEJveWEgR2Fy Y8OtYSAgPGFib3lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW01TRV0gRml4IHVud2FudGVkIHNh bXBsZSBlcmFzZSBmcm9tIHRoZSBkZWNvZGUgcXVldWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2ZlYXR1cmVzLmpzb24gYi9Tb3VyY2UvV2ViQ29yZS9mZWF0dXJlcy5qc29uCmluZGV4IGI2 NDMwZmFhZWVjOTk0NDE4ZWNlNWY4MzgyNGI3ZmM1MDVmYzZiYTUuLmUyNDc3NDhjODUwNDRjZWU5 OTlhN2JiYmI2OTQ1Y2E1YjNlNWIxMzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2ZlYXR1 cmVzLmpzb24KKysrIGIvU291cmNlL1dlYkNvcmUvZmVhdHVyZXMuanNvbgpAQCAtNDksMTYgKzQ5 LDYgQEAKICAgICAgICAgImNhdGVnb3J5IjogImNzcyIsCiAgICAgICAgICJkZXNjcmlwdGlvbiI6 ICJBbGxvd3MgY29udGVudCB0byBzcGVjaWZ5IGNvbG9ycyBvdXRzaWRlIG9mIHRoZSBzUkdCIENv bG9yIFNwYWNlLiIKICAgICB9LAotICAgIHsKLSAgICAgICAgIm5hbWUiOiAiQ1NTIEN1c3RvbSBQ cm9wZXJ0aWVzIEFuZCBWYWx1ZXMiLAotICAgICAgICAic3RhdHVzIjogewotICAgICAgICAgICAg InN0YXR1cyI6ICJVbmRlciBEZXZlbG9wbWVudCIKLSAgICAgICAgfSwKLSAgICAgICAgInVybCI6 ICJodHRwczovL2RyYWZ0cy5jc3MtaG91ZGluaS5vcmcvY3NzLXByb3BlcnRpZXMtdmFsdWVzLWFw aS8iLAotICAgICAgICAid2Via2l0LXVybCI6ICJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTg5NjkyIiwKLSAgICAgICAgImtleXdvcmRzIjogWyJDU1NDdXN0b21Qcm9w ZXJ0aWVzQW5kVmFsdWVzIiwgImN1c3RvbSBwcm9wZXJ0aWVzIiwgImNzcyJdLAotICAgICAgICAi ZGVzY3JpcHRpb24iOiAiQW4gQVBJIGZvciByZWdpc3RlcmluZyBuZXcgQ1NTIHByb3BlcnRpZXMu IFByb3BlcnRpZXMgcmVnaXN0ZXJlZCB1c2luZyB0aGlzIEFQSSBhcmUgcHJvdmlkZWQgd2l0aCBh IHBhcnNlIHN5bnRheCB0aGF0IGRlZmluZXMgYSB0eXBlLCBpbmhlcml0YW5jZSBiZWhhdmlvdXIs IGFuZCBhbiBpbml0aWFsIHZhbHVlLiIKLSAgICB9LAogICAgIHsKICAgICAgICAgIm5hbWUiOiAi Q1NTIEZvbnQgRGlzcGxheSIsCiAgICAgICAgICJzdGF0dXMiOiB7CkBAIC0xNDEsMTAgKzEzMSwx MiBAQAogICAgIHsKICAgICAgICAgIm5hbWUiOiAiQ1NTIFByb3BlcnRpZXMgYW5kIFZhbHVlcyBB UEkgTGV2ZWwgMSIsCiAgICAgICAgICJzdGF0dXMiOiB7Ci0gICAgICAgICAgICAic3RhdHVzIjog IlVuZGVyIENvbnNpZGVyYXRpb24iCisgICAgICAgICAgICAic3RhdHVzIjogIlVuZGVyIERldmVs b3BtZW50IgogICAgICAgICB9LAogICAgICAgICAidXJsIjogImh0dHBzOi8vZHJhZnRzLmNzcy1o b3VkaW5pLm9yZy9jc3MtcHJvcGVydGllcy12YWx1ZXMtYXBpLyIsCi0gICAgICAgICJrZXl3b3Jk cyI6IFsiY3NzIiwgImhvdWRpbmkiXSwKKyAgICAgICAgIndlYmtpdC11cmwiOiAiaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTY5MiIsCisgICAgICAgICJrZXl3b3Jk cyI6IFsiY3NzIiwgImhvdWRpbmkiLCAiY3VzdG9tIHByb3BlcnRpZXMiXSwKKyAgICAgICAgImRl c2NyaXB0aW9uIjogIkFuIEFQSSBmb3IgcmVnaXN0ZXJpbmcgbmV3IENTUyBwcm9wZXJ0aWVzLiBQ cm9wZXJ0aWVzIHJlZ2lzdGVyZWQgdXNpbmcgdGhpcyBBUEkgYXJlIHByb3ZpZGVkIHdpdGggYSBw YXJzZSBzeW50YXggdGhhdCBkZWZpbmVzIGEgdHlwZSwgaW5oZXJpdGFuY2UgYmVoYXZpb3VyLCBh bmQgYW4gaW5pdGlhbCB2YWx1ZS4iLAogICAgICAgICAiY2F0ZWdvcnkiOiAiY3NzIgogICAgIH0s CiAgICAgewo=