189890 2018-09-22 15:58:17 -0700 [ARM] Building FELightingNEON.cpp fails due to missing lightVector member 2018-09-22 21:23:18 -0700 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez commit-queue darin mark.lam simon.fraser webkit-bug-importer ysuzuki zan oldest_to_newest 1462432 0 aperez 2018-09-22 15:58:17 -0700 SSIA. Compiler output (GCC 7) follows. --- [ 53%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource319.cpp.o In file included from /home/aperez/buildroot/output-wkgtk-rpi/build/webkitgtk-2.22.2/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.cpp:28:0, from /home/aperez/buildroot/output-wkgtk-rpi/build/webkitgtk-2.22.2/DerivedSources/WebCore/unified-sources/UnifiedSource319.cpp:5: /home/aperez/buildroot/output-wkgtk-rpi/build/webkitgtk-2.22.2/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h: In member function ‘void WebCore::FELighting::platformApplyNeon(const WebCore::FELighting::LightingData&, const WebCore::LightSource::PaintingData&)’: /home/aperez/buildroot/output-wkgtk-rpi/build/webkitgtk-2.22.2/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h:147:46: error: ‘const struct WebCore::LightSource::PaintingData’ has no member named ‘lightVector’; did you mean ‘directionVector’? floatArguments.lightX = paintingData.lightVector.x(); ^~~~~~~~~~~ directionVector /home/aperez/buildroot/output-wkgtk-rpi/build/webkitgtk-2.22.2/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h:148:46: error: ‘const struct WebCore::LightSource::PaintingData’ has no member named ‘lightVector’; did you mean ‘directionVector’? floatArguments.lightY = paintingData.lightVector.y(); ^~~~~~~~~~~ directionVector /home/aperez/buildroot/output-wkgtk-rpi/build/webkitgtk-2.22.2/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h:149:46: error: ‘const struct WebCore::LightSource::PaintingData’ has no member named ‘lightVector’; did you mean ‘directionVector’? floatArguments.lightZ = paintingData.lightVector.z(); ^~~~~~~~~~~ directionVector 1462433 1 aperez 2018-09-22 16:00:23 -0700 For the record, this was trying to build WebKitGTK+ 2.22.2, but I am quite certain that the issue affects also WPE and is definitely not fixed in “trunk”. 1462435 2 aperez 2018-09-22 16:21:50 -0700 This seems to have been broken by r225122 (bug #179933), which changed the layout of struct PaintaingData. 1462437 3 350537 aperez 2018-09-22 16:25:02 -0700 Created attachment 350537 Patch 1462438 4 aperez 2018-09-22 16:30:02 -0700 I would appreciate if Simon Fraser (who wrote the patch in bug #179933) and/or Darin Adler (who reviewed it) could take a look at my patch before landing it (thanks in advance!) 1462472 5 350537 commit-queue 2018-09-22 21:22:56 -0700 Comment on attachment 350537 Patch Clearing flags on attachment: 350537 Committed r236391: <https://trac.webkit.org/changeset/236391> 1462473 6 commit-queue 2018-09-22 21:22:58 -0700 All reviewed patches have been landed. Closing bug. 1462474 7 webkit-bug-importer 2018-09-22 21:23:18 -0700 <rdar://problem/44710038> 350537 2018-09-22 16:25:02 -0700 2018-09-22 21:22:56 -0700 Patch bug-189890-20180923022500.patch text/plain 1925 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2Mzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzI2NDU1OWJiYTg5ZmI0 ZDkwNzM5NDhmNDM5ZjVmMDU4YjZhNWEyYS4uMzlmMTYxYWUwY2ViMjQxZjNjZjAwYmZkM2FkN2Rm ZWVjYTA4ODZjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA5LTIyICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0FSTV0g QnVpbGRpbmcgRkVMaWdodGluZ05FT04uY3BwIGZhaWxzIGR1ZSB0byBtaXNzaW5nIGxpZ2h0VmVj dG9yIG1lbWJlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTg5ODkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nw dS9hcm0vZmlsdGVycy9GRUxpZ2h0aW5nTkVPTi5oOgorICAgICAgICAoV2ViQ29yZTo6RkVMaWdo dGluZzo6cGxhdGZvcm1BcHBseU5lb24pOiBBZGFwdCB0byBuZXcgbGF5b3V0IG9mICJzdHJ1Y3Qg UGFpbnRpbmdEYXRhIiBhZnRlciByMjI1MTIyLgorCiAyMDE4LTA5LTIyICBaYW4gRG9iZXJzZWsg IDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBbQ2Fpcm9dIE51bGwtY2hlY2sgY2Fp cm9fcGF0dGVybl90IGdyYWRpZW50IG9iamVjdHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NwdS9hcm0vZmlsdGVycy9GRUxpZ2h0aW5nTkVPTi5oIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY3B1L2FybS9maWx0ZXJzL0ZFTGlnaHRpbmdO RU9OLmgKaW5kZXggNDJhZjkyMjM3NGJkNjhhNDc0Y2U4YTZlMmZkNjZkYTdmYTVmM2VjMy4uYjU0 MmE0YzgxYWEzYjExNzc3YjU4ZTYyZDhlYTc1ZGI0NzNlNzMxOCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY3B1L2FybS9maWx0ZXJzL0ZFTGlnaHRpbmdORU9O LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY3B1L2FybS9maWx0ZXJz L0ZFTGlnaHRpbmdORU9OLmgKQEAgLTE0NCw5ICsxNDQsOSBAQCBpbmxpbmUgdm9pZCBGRUxpZ2h0 aW5nOjpwbGF0Zm9ybUFwcGx5TmVvbihjb25zdCBMaWdodGluZ0RhdGEmIGRhdGEsIGNvbnN0IExp Z2h0UwogICAgICAgICAgICAgbmVvbkRhdGEuZmxhZ3MgfD0gRkxBR19DT05FX0VYUE9ORU5UX0lT XzE7CiAgICAgfSBlbHNlIHsKICAgICAgICAgQVNTRVJUKG1fbGlnaHRTb3VyY2UtPnR5cGUoKSA9 PSBMU19ESVNUQU5UKTsKLSAgICAgICAgZmxvYXRBcmd1bWVudHMubGlnaHRYID0gcGFpbnRpbmdE YXRhLmxpZ2h0VmVjdG9yLngoKTsKLSAgICAgICAgZmxvYXRBcmd1bWVudHMubGlnaHRZID0gcGFp bnRpbmdEYXRhLmxpZ2h0VmVjdG9yLnkoKTsKLSAgICAgICAgZmxvYXRBcmd1bWVudHMubGlnaHRa ID0gcGFpbnRpbmdEYXRhLmxpZ2h0VmVjdG9yLnooKTsKKyAgICAgICAgZmxvYXRBcmd1bWVudHMu bGlnaHRYID0gcGFpbnRpbmdEYXRhLmluaXRpYWxMaWdodGluZ0RhdGEubGlnaHRWZWN0b3IueCgp OworICAgICAgICBmbG9hdEFyZ3VtZW50cy5saWdodFkgPSBwYWludGluZ0RhdGEuaW5pdGlhbExp Z2h0aW5nRGF0YS5saWdodFZlY3Rvci55KCk7CisgICAgICAgIGZsb2F0QXJndW1lbnRzLmxpZ2h0 WiA9IHBhaW50aW5nRGF0YS5pbml0aWFsTGlnaHRpbmdEYXRhLmxpZ2h0VmVjdG9yLnooKTsKICAg ICAgICAgZmxvYXRBcmd1bWVudHMucGFkZGluZzIgPSAxOwogICAgIH0KIAo=