<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>18989</bug_id>
          
          <creation_ts>2008-05-10 15:57:04 -0700</creation_ts>
          <short_desc>sunspider regexp-dna is inaccurate on firefox</short_desc>
          <delta_ts>2008-10-07 14:22:15 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Felix">felix.1</reporter>
          <assigned_to name="Dave Hyatt">hyatt</assigned_to>
          <cc>ap</cc>
    
    <cc>barraclough</cc>
    
    <cc>dmandelin</cc>
    
    <cc>ggaren</cc>
    
    <cc>mjs</cc>
    
    <cc>oliver</cc>
    
    <cc>sam</cc>
    
    <cc>sayrer</cc>
    
    <cc>sdwilsh</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>80089</commentid>
    <comment_count>0</comment_count>
    <who name="Felix">felix.1</who>
    <bug_when>2008-05-10 15:57:04 -0700</bug_when>
    <thetext>dnaInput = dnaInput.replace(k, subs[k], &quot;g&quot;)

the 3rd arg to String.replace is a js extension in firefox/spidermonkey.  it&apos;s not supported by safari/webkit, opera, and IE.  those browsers ignore the &apos;g&apos; flag, so they only replace the first match.   firefox is doing a lot more work on this test than other browsers.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>80090</commentid>
    <comment_count>1</comment_count>
    <who name="Felix">felix.1</who>
    <bug_when>2008-05-10 15:59:10 -0700</bug_when>
    <thetext>forgot to mention.  an easy way to confirm this is to add to the end of the test
alert(dnaInput.length);
and load it on different browsers.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>94426</commentid>
    <comment_count>2</comment_count>
      <attachid>24156</attachid>
    <who name="Dave Hyatt">hyatt</who>
    <bug_when>2008-10-07 13:24:13 -0700</bug_when>
    <thetext>Created attachment 24156
Patch to update test</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>94435</commentid>
    <comment_count>3</comment_count>
      <attachid>24156</attachid>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2008-10-07 13:47:56 -0700</bug_when>
    <thetext>Comment on attachment 24156
Patch to update test

r=me

Can you add a FIXME above this line indicating that it should really be doing a global substitution, not just a single one? We&apos;ll want to do that in a future SunSpider version.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>94447</commentid>
    <comment_count>4</comment_count>
    <who name="Dave Hyatt">hyatt</who>
    <bug_when>2008-10-07 14:22:15 -0700</bug_when>
    <thetext>Fixed in r37390.

</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>24156</attachid>
            <date>2008-10-07 13:24:13 -0700</date>
            <delta_ts>2008-10-07 13:47:56 -0700</delta_ts>
            <desc>Patch to update test</desc>
            <filename>patch.txt</filename>
            <type>text/plain</type>
            <size>426</size>
            <attacher name="Dave Hyatt">hyatt</attacher>
            
              <data encoding="base64">SW5kZXg6IHRlc3RzL3JlZ2V4cC1kbmEuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gdGVzdHMvcmVnZXhwLWRu
YS5qcwkocmV2aXNpb24gMzczNzApCisrKyB0ZXN0cy9yZWdleHAtZG5hLmpzCSh3b3JraW5nIGNv
cHkpCkBAIC0xNzA4LDUgKzE3MDgsNSBAQCBmb3IoaSBpbiBzZXFzKQogIC8vIG1hdGNoIHJldHVy
bnMgbnVsbCBpZiBubyBtYXRjaGVzLCBzbyByZXBsYWNlIHdpdGggZW1wdHkKIAogZm9yKGsgaW4g
c3VicykKLSBkbmFJbnB1dCA9IGRuYUlucHV0LnJlcGxhY2Uoaywgc3Vic1trXSwgImciKQorIGRu
YUlucHV0ID0gZG5hSW5wdXQucmVwbGFjZShrLCBzdWJzW2tdKQogIC8vIHNlYXJjaCBzdHJpbmcs
IHJlcGxhY2VtZW50IHN0cmluZywgZmxhZ3MK
</data>
<flag name="review"
          id="10970"
          type_id="1"
          status="+"
          setter="mjs"
    />
          </attachment>
      

    </bug>

</bugzilla>