189869 2018-09-21 17:19:58 -0700 [MSE][GStreamer] Don't update duration when it was not previously NaN 2018-09-24 03:16:18 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya aboya bugs-noreply calvaris commit-queue eocanha oldest_to_newest 1462190 0 aboya 2018-09-21 17:19:58 -0700 This is what the spec mandates. The spec doesn't say anything about updating duration when it had been previously set, even if the new init segment says that the duration is growing. This fixes MSE YTTV 2018 69.MediaSourceDurationVP9. Original patch by Enrique Ocaña González. 1462192 1 350462 aboya 2018-09-21 17:22:08 -0700 Created attachment 350462 Patch 1462193 2 aboya 2018-09-21 17:22:17 -0700 Link to the spec: https://www.w3.org/TR/media-source/#sourcebuffer-init-segment-received 1462661 3 350462 commit-queue 2018-09-24 03:16:16 -0700 Comment on attachment 350462 Patch Clearing flags on attachment: 350462 Committed r236395: <https://trac.webkit.org/changeset/236395> 1462662 4 commit-queue 2018-09-24 03:16:18 -0700 All reviewed patches have been landed. Closing bug. 350462 2018-09-21 17:22:08 -0700 2018-09-24 03:16:16 -0700 Patch bug-189869-20180922022206.patch text/plain 1941 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2Mjg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGYwZGJkY2NlYjFmM2Y3 YjA2YTc1MTg5ODEzNTdjZjhhODZiODk1My4uMTM1ODE0MDdmMjAwZDYwMDk2ZmEzMWU0MzNkZDEz YjkzOTUzNDU0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA5LTIxICBFbnJp cXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW01T RV1bR1N0cmVhbWVyXSBEb24ndCB1cGRhdGUgZHVyYXRpb24gd2hlbiBpdCB3YXMgbm90IHByZXZp b3VzbHkgTmFOCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xODk4NjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIGlzIHdoYXQgdGhlIHNwZWMgbWFuZGF0ZXMuIFRoZSBzcGVjIGRvZXNuJ3Qgc2F5IGFu eXRoaW5nIGFib3V0CisgICAgICAgIHVwZGF0aW5nIGR1cmF0aW9uIHdoZW4gaXQgaGFkIGJlZW4g cHJldmlvdXNseSBzZXQsIGV2ZW4gaWYgdGhlIG5ldworICAgICAgICBpbml0IHNlZ21lbnQgc2F5 cyB0aGF0IHRoZSBkdXJhdGlvbiBpcyBncm93aW5nLgorCisgICAgICAgIFRoaXMgZml4ZXMgTVNF IFlUVFYgMjAxOCA2OS5NZWRpYVNvdXJjZUR1cmF0aW9uVlA5LgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9BcHBlbmRQaXBlbGluZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpBcHBlbmRQaXBlbGluZTo6Y29ubmVjdERlbXV4ZXJTcmNQYWRUb0FwcHNpbmspOgor CiAyMDE4LTA5LTIxICBBbGljaWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbTVNFXVtHU3RyZWFtZXJdIFVzZSBuby1tb3JlLXBhZHMgZXZlbnQgZm9yIG5vdGlj aW5nIGluaXRpYWxpemF0aW9uIHNlZ21lbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL0FwcGVuZFBpcGVsaW5lLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUu Y3BwCmluZGV4IGUzNzE5M2MxMmM3ZGQ0Y2MyNmRiMzVjMDk2N2RmYzNmYzFjNmEzOWUuLjhlZTk1 YzNlZDc5NmYzOWNmYmJkNjQ4NWVkMThkOGM5YTFhZmM0N2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBw ZW5kUGlwZWxpbmUuY3BwCkBAIC0xMDE5LDggKzEwMTksNyBAQCB2b2lkIEFwcGVuZFBpcGVsaW5l Ojpjb25uZWN0RGVtdXhlclNyY1BhZFRvQXBwc2luayhHc3RQYWQqIGRlbXV4ZXJTcmNQYWQpCiAg ICAgfQogI2VuZGlmCiAKLSAgICBpZiAobV9pbml0aWFsRHVyYXRpb24gPiBtX21lZGlhU291cmNl Q2xpZW50LT5kdXJhdGlvbigpCi0gICAgICAgIHx8IChtX21lZGlhU291cmNlQ2xpZW50LT5kdXJh dGlvbigpLmlzSW52YWxpZCgpICYmIG1faW5pdGlhbER1cmF0aW9uID4gTWVkaWFUaW1lOjp6ZXJv VGltZSgpKSkKKyAgICBpZiAobV9tZWRpYVNvdXJjZUNsaWVudC0+ZHVyYXRpb24oKS5pc0ludmFs aWQoKSAmJiBtX2luaXRpYWxEdXJhdGlvbiA+IE1lZGlhVGltZTo6emVyb1RpbWUoKSkKICAgICAg ICAgbV9tZWRpYVNvdXJjZUNsaWVudC0+ZHVyYXRpb25DaGFuZ2VkKG1faW5pdGlhbER1cmF0aW9u KTsKIAogICAgIHBhcnNlRGVtdXhlclNyY1BhZENhcHMoZ3N0X2NhcHNfcmVmKGNhcHMuZ2V0KCkp KTsK