189864 2018-09-21 15:44:41 -0700 Web Inspector: REGRESSION(r236336): computed CSSProperty doesn't have a value for _text 2018-09-21 19:04:22 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 189808 1 hi hi commit-queue inspector-bugzilla-changes joepeck ryanhaddad tsavell webkit-bug-importer oldest_to_newest 1462130 0 hi 2018-09-21 15:44:41 -0700 `CSS.types.CSSComputedStyleProperty` doesn't include a `text` value, which was used by "inspector/css/pseudo-element-matches-for-pseudo-element-node.html" for printing the property's text. Modify the test to generate it's own text result via `name` and `value`. 1462132 1 350447 hi 2018-09-21 15:47:16 -0700 Created attachment 350447 Patch 1462182 2 350447 joepeck 2018-09-21 17:02:35 -0700 Comment on attachment 350447 Patch r=me 1462232 3 350447 commit-queue 2018-09-21 19:03:59 -0700 Comment on attachment 350447 Patch Clearing flags on attachment: 350447 Committed r236380: <https://trac.webkit.org/changeset/236380> 1462233 4 commit-queue 2018-09-21 19:04:01 -0700 All reviewed patches have been landed. Closing bug. 1462234 5 webkit-bug-importer 2018-09-21 19:04:22 -0700 <rdar://problem/44699783> 350447 2018-09-21 15:47:16 -0700 2018-09-21 19:03:59 -0700 Patch 189864.diff text/plain 2088 hi ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkZTU1ZTE0ZDkyMi4uNmNmZDNlZDgzYTYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor MjAxOC0wOS0yMSAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisKKyAgICAgICAg V2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTihyMjM2MzM2KTogY29tcHV0ZWQgQ1NTUHJvcGVydHkg ZG9lc24ndCBoYXZlIGEgdmFsdWUgZm9yIF90ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODk4NjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9jc3MvcHNldWRvLWVsZW1lbnQtbWF0 Y2hlcy1mb3ItcHNldWRvLWVsZW1lbnQtbm9kZS5odG1sOgorCisgICAgICAgIGBDU1MudHlwZXMu Q1NTQ29tcHV0ZWRTdHlsZVByb3BlcnR5YCBkb2Vzbid0IGluY2x1ZGUgYSBgdGV4dGAgdmFsdWUs IHdoaWNoIHdhcyB1c2VkIHRvIHByaW50CisgICAgICAgICBlYWNoIHByb3BlcnR5J3MgdGV4dC4g TW9kaWZ5IHRoZSB0ZXN0IHRvIGdlbmVyYXRlIGl0J3Mgb3duIHRleHQgdmlhIGBuYW1lYCBhbmQg YHZhbHVlYC4KKwogMjAxOC0wOS0yMCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxl LmNvbT4KIAogICAgICAgICBNYWtlICJvdmVyZmxvdzogb3ZlcmxheSIgYSBzeW5vbnltIGZvciAi b3ZlcmZsb3c6IGF1dG8iCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY3NzL3Bz ZXVkby1lbGVtZW50LW1hdGNoZXMtZm9yLXBzZXVkby1lbGVtZW50LW5vZGUuaHRtbCBiL0xheW91 dFRlc3RzL2luc3BlY3Rvci9jc3MvcHNldWRvLWVsZW1lbnQtbWF0Y2hlcy1mb3ItcHNldWRvLWVs ZW1lbnQtbm9kZS5odG1sCmluZGV4IDFhZDYzNmJkN2JiLi40ZjQxNWUwNTI0NCAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2Nzcy9wc2V1ZG8tZWxlbWVudC1tYXRjaGVzLWZvci1w c2V1ZG8tZWxlbWVudC1ub2RlLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2Nzcy9w c2V1ZG8tZWxlbWVudC1tYXRjaGVzLWZvci1wc2V1ZG8tZWxlbWVudC1ub2RlLmh0bWwKQEAgLTE1 LDggKzE1LDE1IEBAIGZ1bmN0aW9uIHRlc3QoKSB7CiAgICAgICAgIEluc3BlY3RvclRlc3QuZXhw ZWN0VGhhdCghT2JqZWN0LmtleXMobm9kZVN0eWxlcy5wc2V1ZG9FbGVtZW50cykubGVuZ3RoLCAi Tm8gUHNldWRvIEVsZW1lbnQgU3R5bGVzIik7CiAKICAgICAgICAgSW5zcGVjdG9yVGVzdC5leHBl Y3RUaGF0KG5vZGVTdHlsZXMuY29tcHV0ZWRTdHlsZSwgIkhhcyBDb21wdXRlZCBTdHlsZXMiKTsK LSAgICAgICAgSW5zcGVjdG9yVGVzdC5sb2coIlBST1BFUlRZOiAiICsgbm9kZVN0eWxlcy5jb21w dXRlZFN0eWxlLnByb3BlcnR5Rm9yTmFtZSgiY29udGVudCIpLnRleHQpOwotICAgICAgICBJbnNw ZWN0b3JUZXN0LmxvZygiUFJPUEVSVFk6ICIgKyBub2RlU3R5bGVzLmNvbXB1dGVkU3R5bGUucHJv cGVydHlGb3JOYW1lKCJjb2xvciIpLnRleHQpOworCisgICAgICAgIGZ1bmN0aW9uIGxvZ1Byb3Bl cnR5KHByb3BlcnR5TmFtZSkgeworICAgICAgICAgICAgY29uc3QgZG9udENyZWF0ZUlmTWlzc2lu ZyA9IHRydWU7CisgICAgICAgICAgICBsZXQgcHJvcGVydHkgPSBub2RlU3R5bGVzLmNvbXB1dGVk U3R5bGUucHJvcGVydHlGb3JOYW1lKHByb3BlcnR5TmFtZSwgZG9udENyZWF0ZUlmTWlzc2luZyk7 CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmxvZyhgUFJPUEVSVFk6ICR7cHJvcGVydHkubmFt ZX06ICR7cHJvcGVydHkudmFsdWV9O2ApOworICAgICAgICB9CisKKyAgICAgICAgbG9nUHJvcGVy dHkoImNvbnRlbnQiKTsKKyAgICAgICAgbG9nUHJvcGVydHkoImNvbG9yIik7CiAKICAgICAgICAg Zm9yICh2YXIgcnVsZSBvZiBub2RlU3R5bGVzLm1hdGNoZWRSdWxlcykgewogICAgICAgICAgICAg SW5zcGVjdG9yVGVzdC5sb2coIk1BVENIRUQgUlVMRToiKTsK