189861 2018-09-21 15:02:27 -0700 FontDataCache should use Ref<Font> instead of a RefPtr<Font> 2018-09-28 12:13:38 -0700 1 1 1 Unclassified WebKit Text WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=189722 InRadar P2 Normal --- 1 cdumez cdumez achristensen commit-queue ggaren koivisto mmaxfield webkit-bug-importer youennf oldest_to_newest 1462113 0 cdumez 2018-09-21 15:02:27 -0700 FontDataCache should use Ref<Font> instead of a RefPtr<Font>. 1462114 1 350435 cdumez 2018-09-21 15:03:14 -0700 Created attachment 350435 Patch 1462312 2 350435 commit-queue 2018-09-22 00:56:28 -0700 Comment on attachment 350435 Patch Clearing flags on attachment: 350435 Committed r236383: <https://trac.webkit.org/changeset/236383> 1462313 3 commit-queue 2018-09-22 00:56:30 -0700 All reviewed patches have been landed. Closing bug. 1462315 4 webkit-bug-importer 2018-09-22 00:57:23 -0700 <rdar://problem/44702531> 350435 2018-09-21 15:03:14 -0700 2018-09-22 00:56:28 -0700 Patch bug-189861-20180921150313.patch text/plain 2768 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MzYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTMxNzBhNjViZDYxMzVj Njg3YmI1NzFjYTNlMGM5MTA3MjUwOTZlNy4uNjRjNmNkMjk1YjZhZWFhYWRmZjBkNzk3Y2Y4NjVk YWExMWJkNDRkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA5LTIxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRm9udERhdGFDYWNoZSBzaG91 bGQgdXNlIFJlZjxGb250PiBpbnN0ZWFkIG9mIGEgUmVmUHRyPEZvbnQ+CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODk4NjEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0Zv bnRDYWNoZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb250Q2FjaGU6OmZvbnRGb3JQbGF0Zm9y bURhdGEpOgorICAgICAgICAoV2ViQ29yZTo6Rm9udENhY2hlOjpwdXJnZUluYWN0aXZlRm9udERh dGEpOgorCiAyMDE4LTA5LTIwICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29t PgogCiAgICAgICAgIFNpbXBsaWZ5IHRoZSBsb2dpYyBhcm91bmQgaGFzKlNjcm9sbGJhcldpdGhB dXRvQmVoYXZpb3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L0ZvbnRDYWNoZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250Q2Fj aGUuY3BwCmluZGV4IDRiYmFkZmIyODMwMGU0Y2YxMmViMmU4MmI2ZTllYTYyYjZiMTg4NWYuLjRi N2MxZWVjYmQ0ZmE3OWI3YmJlMzZiMzg0MDQwOTIyNDgyNzdiODggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRDYWNoZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udENhY2hlLmNwcApAQCAtMjgzLDcgKzI4Myw3IEBA IHN0cnVjdCBGb250RGF0YUNhY2hlS2V5VHJhaXRzIDogV1RGOjpHZW5lcmljSGFzaFRyYWl0czxG b250UGxhdGZvcm1EYXRhPiB7CiAgICAgfQogfTsKIAotdHlwZWRlZiBIYXNoTWFwPEZvbnRQbGF0 Zm9ybURhdGEsIFJlZlB0cjxGb250PiwgRm9udERhdGFDYWNoZUtleUhhc2gsIEZvbnREYXRhQ2Fj aGVLZXlUcmFpdHM+IEZvbnREYXRhQ2FjaGU7Cit0eXBlZGVmIEhhc2hNYXA8Rm9udFBsYXRmb3Jt RGF0YSwgUmVmPEZvbnQ+LCBGb250RGF0YUNhY2hlS2V5SGFzaCwgRm9udERhdGFDYWNoZUtleVRy YWl0cz4gRm9udERhdGFDYWNoZTsKIAogc3RhdGljIEZvbnREYXRhQ2FjaGUmIGNhY2hlZEZvbnRz KCkKIHsKQEAgLTMzNywxMyArMzM3LDEzIEBAIFJlZjxGb250PiBGb250Q2FjaGU6OmZvbnRGb3JQ bGF0Zm9ybURhdGEoY29uc3QgRm9udFBsYXRmb3JtRGF0YSYgcGxhdGZvcm1EYXRhKQogICAgIGF1 dG8gbG9ja2VyID0gaG9sZExvY2soZm9udExvY2spOwogI2VuZGlmCiAgICAgCi0gICAgYXV0byBh ZGRSZXN1bHQgPSBjYWNoZWRGb250cygpLmFkZChwbGF0Zm9ybURhdGEsIG51bGxwdHIpOwotICAg IGlmIChhZGRSZXN1bHQuaXNOZXdFbnRyeSkKLSAgICAgICAgYWRkUmVzdWx0Lml0ZXJhdG9yLT52 YWx1ZSA9IEZvbnQ6OmNyZWF0ZShwbGF0Zm9ybURhdGEpOworICAgIGF1dG8gYWRkUmVzdWx0ID0g Y2FjaGVkRm9udHMoKS5lbnN1cmUocGxhdGZvcm1EYXRhLCBbJl0geworICAgICAgICByZXR1cm4g Rm9udDo6Y3JlYXRlKHBsYXRmb3JtRGF0YSk7CisgICAgfSk7CiAKICAgICBBU1NFUlQoYWRkUmVz dWx0Lml0ZXJhdG9yLT52YWx1ZS0+cGxhdGZvcm1EYXRhKCkgPT0gcGxhdGZvcm1EYXRhKTsKIAot ICAgIHJldHVybiAqYWRkUmVzdWx0Lml0ZXJhdG9yLT52YWx1ZTsKKyAgICByZXR1cm4gYWRkUmVz dWx0Lml0ZXJhdG9yLT52YWx1ZS5jb3B5UmVmKCk7CiB9CiAKIHZvaWQgRm9udENhY2hlOjpwdXJn ZUluYWN0aXZlRm9udERhdGFJZk5lZWRlZCgpCkBAIC0zNzUsMTIgKzM3NSwxMiBAQCB2b2lkIEZv bnRDYWNoZTo6cHVyZ2VJbmFjdGl2ZUZvbnREYXRhKHVuc2lnbmVkIHB1cmdlQ291bnQpCiAjZW5k aWYKIAogICAgIHdoaWxlIChwdXJnZUNvdW50KSB7Ci0gICAgICAgIFZlY3RvcjxSZWZQdHI8Rm9u dD4sIDIwPiBmb250c1RvRGVsZXRlOwotICAgICAgICBmb3IgKGF1dG8gZm9udCA6IGNhY2hlZEZv bnRzKCkudmFsdWVzKCkpIHsKKyAgICAgICAgVmVjdG9yPFJlZjxGb250PiwgMjA+IGZvbnRzVG9E ZWxldGU7CisgICAgICAgIGZvciAoYXV0byYgZm9udCA6IGNhY2hlZEZvbnRzKCkudmFsdWVzKCkp IHsKICAgICAgICAgICAgIExPRyhGb250cywgIiB0cnlpbmcgdG8gcHVyZ2UgZm9udCAlcyAoaGFz IG9uZSByZWYgJWQpIiwgZm9udC0+cGxhdGZvcm1EYXRhKCkuZGVzY3JpcHRpb24oKS51dGY4KCku ZGF0YSgpLCBmb250LT5oYXNPbmVSZWYoKSk7CiAgICAgICAgICAgICBpZiAoIWZvbnQtPmhhc09u ZVJlZigpKQogICAgICAgICAgICAgICAgIGNvbnRpbnVlOwotICAgICAgICAgICAgZm9udHNUb0Rl bGV0ZS5hcHBlbmQoV1RGTW92ZShmb250KSk7CisgICAgICAgICAgICBmb250c1RvRGVsZXRlLmFw cGVuZChmb250LmNvcHlSZWYoKSk7CiAgICAgICAgICAgICBpZiAoIS0tcHVyZ2VDb3VudCkKICAg ICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQo=