189845 2018-09-21 11:58:52 -0700 Web Inspector: remove unnecessary WI.Platform.version checks 2018-09-21 13:33:41 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg commit-queue inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1461980 0 bburg 2018-09-21 11:58:52 -0700 We don't ship on 10.10 or 10.11 any more, we can remove some conditional code. 1462009 1 350405 bburg 2018-09-21 12:46:34 -0700 Created attachment 350405 Patch 1462034 2 350405 mattbaker 2018-09-21 13:06:42 -0700 Comment on attachment 350405 Patch rs=me 1462051 3 350405 commit-queue 2018-09-21 13:32:15 -0700 Comment on attachment 350405 Patch Clearing flags on attachment: 350405 Committed r236357: <https://trac.webkit.org/changeset/236357> 1462052 4 commit-queue 2018-09-21 13:32:16 -0700 All reviewed patches have been landed. Closing bug. 1462054 5 webkit-bug-importer 2018-09-21 13:33:41 -0700 <rdar://problem/44690570> 350405 2018-09-21 12:46:34 -0700 2018-09-21 13:32:15 -0700 Patch bug-189845-20180921124633.patch text/plain 4135 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAw MzI4ZDgxMThiZjhiN2Q3ZmYxMTY4ODMwYzdiZmE5YWM5NTU1MGFjLi5jMzJmZjQyY2E3MjdmNTNm NzAxMzViOTc0NmUwMmViNGQ3ODM5N2RkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOC0wOS0yMSAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiByZW1vdmUgdW5uZWNlc3NhcnkgV0kuUGxhdGZvcm0udmVy c2lvbiBjaGVja3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4OTg0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVXNlckludGVyZmFjZS9CYXNlL1BsYXRmb3JtLmpzOgorICAgICAgICAob3NWZXJzaW9u TWF0Y2gpOiBBZGQgbmFtZSBmb3IgbWFjT1MgTW9qYXZlLgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9CYXNlL01haW4uanM6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Qb3BvdmVy LmpzOgorICAgICAgICBSZW1vdmUgb2xkIGxvZ2ljIHRoYXQncyBubyBsb25nZXIgbmVlZGVkLgor CiAyMDE4LTA5LTE3ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBnZW5lcmF0ZSBDU1NLZXl3b3JkQ29tcGxldGlvbnMgZnJvbSBiYWNr ZW5kIHZhbHVlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvQmFzZS9NYWluLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFz ZS9NYWluLmpzCmluZGV4IGJjODFkOWQ5MGJmNGE1ZjFkNmNjMGUxZDE0NDg2NjNhNDRlNTEzMDUu LjUzNmI2NDU5YzdlMDZmMWY1NGE2NmI2NWQ1NzBlMzdlMWVhN2E1ZWMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcworKysgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKQEAgLTE3NjYsMjEg KzE3NjYsOSBAQCBXSS5fbW92ZVdpbmRvd01vdXNlRG93biA9IGZ1bmN0aW9uKGV2ZW50KQogICAg IGV2ZW50W1dJLlBvcG92ZXIuRXZlbnRQcmV2ZW50RGlzbWlzc1N5bWJvbF0gPSB0cnVlOwogCiAg ICAgaWYgKFdJLlBsYXRmb3JtLm5hbWUgPT09ICJtYWMiKSB7Ci0gICAgICAgIC8vIE5ldyBNYWMg cmVsZWFzZXMgY2FuIHN0YXJ0IGEgd2luZG93IGRyYWcuCi0gICAgICAgIGlmIChXSS5QbGF0Zm9y bS52ZXJzaW9uLnJlbGVhc2UgPj0gMTEpIHsKLSAgICAgICAgICAgIEluc3BlY3RvckZyb250ZW5k SG9zdC5zdGFydFdpbmRvd0RyYWcoKTsKLSAgICAgICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0 KCk7Ci0gICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIH0KLQotICAgICAgICAvLyBJZ25vcmUg ZHJhZ2dpbmcgb24gdGhlIHRvcCBvZiB0aGUgdG9vbGJhciBvbiBNYWMgaWYgdGhlIHN5c3RlbSBo YW5kbGVzIGl0LgotICAgICAgICBpZiAoV0kuUGxhdGZvcm0udmVyc2lvbi5yZWxlYXNlID09PSAx MCkgewotICAgICAgICAgICAgY29uc3Qgd2luZG93RHJhZ0hhbmRsZWRUaXRsZUJhckhlaWdodCA9 IDIyOwotICAgICAgICAgICAgaWYgKGV2ZW50LnBhZ2VZIDwgd2luZG93RHJhZ0hhbmRsZWRUaXRs ZUJhckhlaWdodCkgewotICAgICAgICAgICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7Ci0g ICAgICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICAgICAgfQotICAgICAgICB9CisgICAgICAg IEluc3BlY3RvckZyb250ZW5kSG9zdC5zdGFydFdpbmRvd0RyYWcoKTsKKyAgICAgICAgZXZlbnQu cHJldmVudERlZmF1bHQoKTsKKyAgICAgICAgcmV0dXJuOwogICAgIH0KIAogICAgIHZhciBsYXN0 U2NyZWVuWCA9IGV2ZW50LnNjcmVlblg7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9CYXNlL1BsYXRmb3JtLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvQmFzZS9QbGF0Zm9ybS5qcwppbmRleCA0ZjJlMWU3YzA5M2E1YjExZjQy ZDI1MjExNWU0ZDFmNzc1ZGI2MTlkLi5mZmI1YTc3ZTJjM2FkYzc0Y2YyYmJlOTg2MDk2Y2E3MGFm YTBiNjk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9C YXNlL1BsYXRmb3JtLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0Jhc2UvUGxhdGZvcm0uanMKQEAgLTQ5LDE4ICs0OSwxNSBAQCBXSS5QbGF0Zm9ybSA9IHsKICAg ICAgICAgV0kuUGxhdGZvcm0udmVyc2lvbi5iYXNlID0gMTA7CiAgICAgICAgIFdJLlBsYXRmb3Jt LnZlcnNpb24ucmVsZWFzZSA9IHBhcnNlSW50KG9zVmVyc2lvbk1hdGNoWzJdKTsKICAgICAgICAg c3dpdGNoIChvc1ZlcnNpb25NYXRjaFsyXSkgeworICAgICAgICBjYXNlICIxNCI6CisgICAgICAg ICAgICBXSS5QbGF0Zm9ybS52ZXJzaW9uLm5hbWUgPSAibW9qYXZlIjsKKyAgICAgICAgICAgIGJy ZWFrOwogICAgICAgICBjYXNlICIxMyI6CiAgICAgICAgICAgICBXSS5QbGF0Zm9ybS52ZXJzaW9u Lm5hbWUgPSAiaGlnaC1zaWVycmEiOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2Ug IjEyIjoKICAgICAgICAgICAgIFdJLlBsYXRmb3JtLnZlcnNpb24ubmFtZSA9ICJzaWVycmEiOwog ICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgIjExIjoKLSAgICAgICAgICAgIFdJLlBs YXRmb3JtLnZlcnNpb24ubmFtZSA9ICJlbC1jYXBpdGFuIjsKLSAgICAgICAgICAgIGJyZWFrOwot ICAgICAgICBjYXNlICIxMCI6Ci0gICAgICAgICAgICBXSS5QbGF0Zm9ybS52ZXJzaW9uLm5hbWUg PSAieW9zZW1pdGUiOwotICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGRlZmF1bHQ6CiAgICAg ICAgICAgICBXSS5QbGF0Zm9ybS52ZXJzaW9uLm5hbWUgPSAidW5rbm93bi1tYWMiOwogICAgICAg ICAgICAgYnJlYWs7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9Qb3BvdmVyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvUG9wb3Zlci5qcwppbmRleCA3NjM5NjEwMDEzNjU0Yzc4M2ViMjhhNjIwNGIxMTg1 MTNhMDdhNDQ3Li5mMDBhNmU3NDc3OWE5NDJkZjdjMWVkNTI5YzAyM2Q4NmUzNzFkNTU3IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Qb3BvdmVy LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1BvcG92 ZXIuanMKQEAgLTIyNiw3ICsyMjYsNyBAQCBXSS5Qb3BvdmVyID0gY2xhc3MgUG9wb3ZlciBleHRl bmRzIFdJLk9iamVjdAogICAgICAgICAgICAgdGhpcy5fcHJlZmVycmVkU2l6ZSA9IG5ldyBXSS5T aXplKE1hdGguY2VpbChwb3BvdmVyQm91bmRzLndpZHRoKSwgTWF0aC5jZWlsKHBvcG92ZXJCb3Vu ZHMuaGVpZ2h0KSk7CiAgICAgICAgIH0KIAotICAgICAgICB2YXIgdGl0bGVCYXJPZmZzZXQgPSBX SS5QbGF0Zm9ybS5uYW1lID09PSAibWFjIiAmJiBXSS5QbGF0Zm9ybS52ZXJzaW9uLnJlbGVhc2Ug Pj0gMTAgPyAyMiA6IDA7CisgICAgICAgIHZhciB0aXRsZUJhck9mZnNldCA9IFdJLlBsYXRmb3Jt Lm5hbWUgPT09ICJtYWMiID8gMjIgOiAwOwogICAgICAgICB2YXIgY29udGFpbmVyRnJhbWUgPSBu ZXcgV0kuUmVjdCgwLCB0aXRsZUJhck9mZnNldCwgd2luZG93LmlubmVyV2lkdGgsIHdpbmRvdy5p bm5lckhlaWdodCAtIHRpdGxlQmFyT2Zmc2V0KTsKICAgICAgICAgLy8gVGhlIGZyYW1lIG9mIHRo ZSB3aW5kb3cgd2l0aCBhIGxpdHRsZSBpbnNldCB0byBtYWtlIHN1cmUgd2UgaGF2ZSByb29tIGZv ciBzaGFkb3dzLgogICAgICAgICBjb250YWluZXJGcmFtZSA9IGNvbnRhaW5lckZyYW1lLmluc2V0 KFdJLlBvcG92ZXIuU2hhZG93RWRnZUluc2V0cyk7Cg==